t; Petersen ; linux-scsi@vger.kernel.org
> Cc: Stanislav Nijnikov ; Avi Shchislowski
> ; Alex Lemberg ;
> Subhash Jadavani ; Vinayak Holikatti
>
> Subject: Re: [PATCH v5 3/6] scsi: ufs: Add ufs-bsg module
>
> On 9/17/18 9:08 AM, Avri Altman wrote:
> > +*Caveat emptor*: The
Bart,
> On Sep 15, 2018, at 9:57 PM, Bart Van Assche wrote:
>
> External Email
>
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> @@ -686,7 +686,7 @@ static void qla_nvmet_send_resp_ctio(struct qla_qpair
>> *qpair,
>> ctio->u.nvme_status_mode1.transfer_len =
>>
On 2018/9/19 0:42, Mike Christie wrote:
On 09/18/2018 05:32 AM, xiu...@redhat.com wrote:
From: Xiubo Li
Currently there has one cmd timeout timer for each udev, and whenever
there has any new coming cmd it will update the timer. And for some
corner case the timer is always working only for
On 9/17/18 9:08 AM, Avri Altman wrote:
+*Caveat emptor*: The driver makes no further input validations and sends the
+UPIU to the device as it is. Open the bsg device in /dev/ufs-bsg-%0:0 and
+send SG_IO with the applicable sg_io_v4:
It's not clear to me what %0:0 stands for. Otherwise this
On 09/18/2018 05:32 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> Currently there has one cmd timeout timer for each udev, and whenever
> there has any new coming cmd it will update the timer. And for some
> corner case the timer is always working only for the ringbuffer's
> newest cmd.
> On Sep 17, 2018, at 1:03 PM, Bart Van Assche wrote:
>
> External Email
>
> On 9/17/18 12:07 PM, Madhani, Himanshu wrote:
>>
>>> On Sep 15, 2018, at 9:53 PM, Bart Van Assche wrote:
>>>
>>> External Email
>>>
>>> On 09/14/18 14:28, Himanshu Madhani wrote:
diff --git
On 9/17/18 12:07 PM, Madhani, Himanshu wrote:
On Sep 15, 2018, at 9:53 PM, Bart Van Assche wrote:
External Email
On 09/14/18 14:28, Himanshu Madhani wrote:
diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
index 036cc3f217b1..f1539d8b68ef 100644
---
> On Sep 16, 2018, at 6:42 AM, Bart Van Assche wrote:
>
> External Email
>
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> From: Anil Gurumurthy
>>
>> This patch adds LS handling into driver
>
> Please make the patch description more clear. What does "LS" stand for?
> What is the
> On Sep 15, 2018, at 9:53 PM, Bart Van Assche wrote:
>
> External Email
>
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
>> index 036cc3f217b1..f1539d8b68ef 100644
>> --- a/drivers/scsi/qla2xxx/Kconfig
>> +++
Hi Bart,
> On Sep 15, 2018, at 9:50 PM, Bart Van Assche wrote:
>
> External Email
>
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> diff --git a/drivers/scsi/qla2xxx/qla_nvmet.c
>> b/drivers/scsi/qla2xxx/qla_nvmet.c
>> new file mode 100644
>> [ ... ]
>> +#if
>
> > @@ -5,6 +5,9 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) += tc-
> dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
> > obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
> > obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
> > ufshcd-core-objs := ufshcd.o ufs-sysfs.o
> > +ifeq ($(CONFIG_SCSI_UFS_BSG),y)
> >
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla24xx_els_dcmd2_iocb':
> drivers/scsi/qla2xxx/qla_iocb.c:2644:13: warning:
> variable 'ptr_dma' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue. Thanks!
--
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/lpfc/lpfc_nvme.c: In function 'lpfc_new_nvme_buf':
> drivers/scsi/lpfc/lpfc_nvme.c:2238:24: warning:
> variable 'sgl_size' set but not used [-Wunused-but-set-variable]
> int bcnt, num_posted, sgl_size;
>
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function 'bnx2fc_rcv':
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c:435:17: warning:
> variable 'oxid' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue, thanks!
--
Martin K.
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/aic7xxx/aic79xx_pci.c: In function 'ahd_pci_config':
> drivers/scsi/aic7xxx/aic79xx_pci.c:291:19: warning:
> variable 'shared_scb_data' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue, thank
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/pm8001/pm80xx_hwi.c: In function 'pm8001_set_phy_profile':
> drivers/scsi/pm8001/pm80xx_hwi.c:4679:6: warning:
> variable 'page_code' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue, thanks!
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/pm8001/pm8001_sas.c: In function
> 'pm8001_I_T_nexus_event_handler':
> drivers/scsi/pm8001/pm8001_sas.c:1052:6: warning:
> variable 'device_id' set but not used [-Wunused-but-set-variable]
>
>
>
> On 09/15/18 23:41, Avri Altman wrote:
> >> Since this patch series does not touch any include/uapi header and since no
> >> uapi UFS header files already exist, how is user space software expected to
> >> know which message format it should use for communicating over the UFS
> BSG
> >>
On 09/15/18 23:41, Avri Altman wrote:
Since this patch series does not touch any include/uapi header and since no
uapi UFS header files already exist, how is user space software expected to
know which message format it should use for communicating over the UFS BSG
endpoint? I don't think that
On 09/14/18 14:28, Himanshu Madhani wrote:
From: Anil Gurumurthy
This patch adds SysFS node for NVMe Target configuration
Please elaborate the description of this patch. Are NVMe initiator and
target mode mutually exclusive or can both be enabled at the same time?
What is the impact of
On 09/14/18 14:28, Himanshu Madhani wrote:
From: Anil Gurumurthy
This patch adds LS handling into driver
Please make the patch description more clear. What does "LS" stand for?
What is the relationship between LS and NVMe target support?
Thanks,
Bart.
Hi Bart,
> Since this patch series does not touch any include/uapi header and since no
> uapi UFS header files already exist, how is user space software expected to
> know which message format it should use for communicating over the UFS BSG
> endpoint? I don't think that "read the source" is an
On 09/14/18 14:28, Himanshu Madhani wrote:
@@ -686,7 +686,7 @@ static void qla_nvmet_send_resp_ctio(struct qla_qpair
*qpair,
ctio->u.nvme_status_mode1.transfer_len =
cpu_to_be32(ersp->xfrd_len);
- ql_log(ql_log_info,
On 09/14/18 14:28, Himanshu Madhani wrote:
diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
index 036cc3f217b1..f1539d8b68ef 100644
--- a/drivers/scsi/qla2xxx/Kconfig
+++ b/drivers/scsi/qla2xxx/Kconfig
@@ -3,6 +3,7 @@ config SCSI_QLA_FC
depends on PCI && SCSI
On 09/14/18 14:28, Himanshu Madhani wrote:
diff --git a/drivers/scsi/qla2xxx/qla_nvmet.c b/drivers/scsi/qla2xxx/qla_nvmet.c
new file mode 100644
[ ... ]
+#ifIS_ENABLED(CONFIG_NVME_TARGET_FC)
[ ... ]
+#endif
This style of using #if / #endif is not acceptable. Instead,
Hi Anil,
I love your patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on next-20180913]
[cannot apply to v4.19-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
On Fri, Sep 14, 2018 at 3:29 AM YueHaibing wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/pm8001/pm80xx_hwi.c: In function 'pm8001_set_phy_profile':
> drivers/scsi/pm8001/pm80xx_hwi.c:4679:6: warning:
> variable 'page_code' set but not used [-Wunused-but-set-variable]
On 09/04/2018 12:19 PM, Greg Edwards wrote:
> When T10 PI is enabled on a backing device for the iblock backstore, the
> PI SGL for the entire command is attached to the first bio only. This
> works fine if the command is covered by a single bio, but can result in
> ref tag errors in the client
On 9/12/2018 4:28 PM, James Smart wrote:
The driver currently uses the ndlp to get the local rport which is
then used to get the nvme transport remoteport pointer. There can
be cases where a stale remoteport pointer is obtained as
synchronization isn't done through the different dereferences.
On Wed, Sep 12, 2018 at 03:31:07PM +0530, Sreekanth Reddy wrote:
> On Wed, Sep 5, 2018 at 1:08 PM, Lukas Wunner wrote:
> > On Wed, Sep 05, 2018 at 11:45:45AM +0530, Sreekanth Reddy wrote:
> > > I have one more instance where still we need this poll kthread, i.e
> > > during the device probe time
On Thu, Sep 13, 2018 at 3:44 AM YueHaibing wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/pm8001/pm8001_sas.c: In function
> 'pm8001_I_T_nexus_event_handler':
> drivers/scsi/pm8001/pm8001_sas.c:1052:6: warning:
> variable 'device_id' set but not used
> On Sep 12, 2018, at 7:40 PM, YueHaibing wrote:
>
> External Email
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla24xx_els_dcmd2_iocb':
> drivers/scsi/qla2xxx/qla_iocb.c:2644:13: warning:
> variable 'ptr_dma' set but not used
On Wed, Sep 5, 2018 at 1:08 PM, Lukas Wunner wrote:
> On Wed, Sep 05, 2018 at 11:45:45AM +0530, Sreekanth Reddy wrote:
>> On Tue, Sep 4, 2018 at 3:12 PM, Lukas Wunner wrote:
>> > Many scsi drivers call pci_channel_offline() to detect inaccessibility
>> > of the device due to a PCI error:
>> >
Viswas,
> This patch set include some bug fixes for pm80xx driver.
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> We should first do the le16_to_cpu endian conversion and then apply
> the FCP_CMD_LENGTH_MASK mask.
Applied to 4.19/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
> drivers/scsi/libfc/fc_fcp.c:1875:30: warning:
> variable 'rpriv' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue. Thank you!
--
Martin K.
James,
> This patch contains lpfc bug fixes, a couple of performance mods, and
> a new diagnostic ability
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This patch series fixes issues found during our testing for qla2xxx.
Also applied. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This series updates driver for ABTS handling and rport management.
>
> Please queue this patches to 4.20/scsi-misc at your earliest convenience.
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This series contains support for ZIO interrupt threashold and
> cleanups.
Applied!
--
Martin K. Petersen Oracle Linux Engineering
On Tue, Sep 11, 2018 at 10:48 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> Added proper mask for phy id in mpi_phy_stop_resp().
>
> V2:
> -Initialized the PM8001F_RUN_TIME flag in
> pm8001_pci_probe().
> -Differentiated PHY_LINK_UP state
> On Sep 8, 2018, at 1:42 AM, Dan Carpenter wrote:
>
> External Email
>
> We should first do the le16_to_cpu endian conversion and then apply
> the FCP_CMD_LENGTH_MASK mask.
>
> Fixes: 5f35509db179 ("qla2xxx: Terminate exchange if corrupted")
> Signed-off-by: Dan Carpenter
> ---
> I just
Dan,
It looks good. Thanks.
Regards,
Quinn Tran
-Original Message-
From: Dan Carpenter
Date: Saturday, September 8, 2018 at 1:42 AM
To: Dept-Eng QLA2xxx Upstream , "Tran, Quinn"
Cc: "James E.J. Bottomley" , "Martin K. Petersen"
, "linux-scsi@vger.kernel.org"
, "Madhani, Himanshu"
> @@ -5,6 +5,9 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) +=
> tc-dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
> obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
> obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
> ufshcd-core-objs := ufshcd.o ufs-sysfs.o
> +ifeq ($(CONFIG_SCSI_UFS_BSG),y)
> +ufshcd-core-objs +=
On Fri, Sep 07, 2018 at 12:49:39PM +0300, Avri Altman wrote:
> Do that in order to re-use its code if the task request and response
> UPIUs are given externally.
This should not be needed. Instead any pass-though style caller
should use the new lower-level __ufshcd_issue_tm_cmd function I added.
; Bart Van Assche
> ; James E.J. Bottomley
> ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; Stanislav Nijnikov
> ; Avi Shchislowski
> ; Alex Lemberg ;
> Subhash Jadavani ; Vinayak Holikatti
>
> Subject: Re: [PATCH v3 3/7] scsi: ufs: Add fill task management request
>
On Thu, 2018-09-06 at 09:03 +0200, Hannes Reinecke wrote:
> On 09/05/2018 04:09 PM, Martin Wilck wrote:
> > On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote:
> > > test_bit() is atomic, test_bit() || test_bit() is not.
> > > So protect consecutive bit tests with a lock to avoid races.
> >
On 09/05/2018 04:09 PM, Martin Wilck wrote:
> On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote:
>> test_bit() is atomic, test_bit() || test_bit() is not.
>> So protect consecutive bit tests with a lock to avoid races.
>>
>> Signed-off-by: Hannes Reinecke
>> ---
>>
On Wed, Sep 05, 2018 at 07:08:50PM +0200, Christoph Hellwig wrote:
> On Wed, Sep 05, 2018 at 03:53:41PM +, Avri Altman wrote:
> > But on the other hand, task management request and response UPIUs
> > are honorable members of the ufs spec (JEDEC 220C paragraphs 10.7.6 &
> > 10.7.7).
> > and
On Wed, Sep 05, 2018 at 03:53:41PM +, Avri Altman wrote:
> But on the other hand, task management request and response UPIUs
> are honorable members of the ufs spec (JEDEC 220C paragraphs 10.7.6 & 10.7.7).
> and indeed they lives in ufs.h, where they should.
There is no other use anywhere.
> On Wed, Sep 05, 2018 at 07:30:03AM +, Avri Altman wrote:
> > Looking into the UFSHCI spec (JESD223C March 2016) paragraph 6.2,
> > It doesn't specify any inner structure of the task management
> > request or response, just a bunch of 8 DW each.
> > I guess this is why it is defined as a
On Wed, Sep 05, 2018 at 09:38:16AM +0200, Lukas Wunner wrote:
> On Wed, Sep 05, 2018 at 11:45:45AM +0530, Sreekanth Reddy wrote:
> > On Tue, Sep 4, 2018 at 3:12 PM, Lukas Wunner wrote:
> > > Many scsi drivers call pci_channel_offline() to detect inaccessibility
> > > of the device due to a PCI
On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote:
> test_bit() is atomic, test_bit() || test_bit() is not.
> So protect consecutive bit tests with a lock to avoid races.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/qedf/qedf_els.c | 9 +++--
>
On Wed, Sep 05, 2018 at 07:30:03AM +, Avri Altman wrote:
> Looking into the UFSHCI spec (JESD223C March 2016) paragraph 6.2,
> It doesn't specify any inner structure of the task management
> request or response, just a bunch of 8 DW each.
> I guess this is why it is defined as a __le32 array.
On Wed, Sep 5, 2018 at 7:47 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> Updated the driver version from 0.1.38 to 0.1.39.
>
> Signed-off-by: Deepak Ukey
> Signed-off-by: Viswas G
> ---
> drivers/scsi/pm8001/pm8001_sas.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Wed, Sep 5, 2018 at 7:47 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> When the firmware is not responding, execution of kexec boot
> causes a system hang. When firmware assertion happened, driver
> get notified with interrupt vector updated in MPI configuration
> table. Then, the driver will
> > ---
> > drivers/scsi/ufs/ufshcd.c | 35 ++-
> > 1 file changed, 26 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index d18832a..15be103 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++
On Wed, Sep 5, 2018 at 7:47 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> For the function dma_unmap_sg(), the parameter should be
> number of elements in the scatter list prior to the mapping, not
> after the mapping.
>
> Signed-off-by: Deepak Ukey
> Signed-off-by: Viswas G
> ---
>
On Wed, Sep 5, 2018 at 7:47 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> Added proper mask for phy id in mpi_phy_stop_resp().
>
> Signed-off-by: Deepak Ukey
> Signed-off-by: Viswas G
> ---
> drivers/scsi/pm8001/pm8001_defs.h | 7 +++
> drivers/scsi/pm8001/pm8001_hwi.c | 4 ++--
>
On Wed, Sep 05, 2018 at 11:45:45AM +0530, Sreekanth Reddy wrote:
> On Tue, Sep 4, 2018 at 3:12 PM, Lukas Wunner wrote:
> > Many scsi drivers call pci_channel_offline() to detect inaccessibility
> > of the device due to a PCI error:
> >
. Bottomley
> ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; Stanislav Nijnikov
> ; Avi Shchislowski
> ; Alex Lemberg ;
> Subhash Jadavani ; Vinayak Holikatti
>
> Subject: Re: [PATCH v3 3/7] scsi: ufs: Add fill task management request
>
> In general this looks good,
> > + */
> > +#ifndef SCSI_BSG_UFS_H
> > +#define SCSI_BSG_UFS_H
> > +
> > +/*
> > + * This file intended to be included by both kernel and user space
> > + */
> > +
> > +
> > +/**
> > + * struct ufs_bsg_upiu - upiu transaction structure
> > + *
> > + * @header: upiu header
> > + * @tsf:
l
On Tue, Sep 4, 2018 at 3:12 PM, Lukas Wunner wrote:
> On Tue, Sep 04, 2018 at 11:19:04AM +0530, Sreekanth Reddy wrote:
>> On Fri, Aug 31, 2018 at 2:25 PM, Lukas Wunner wrote:
>> > * Just reading the vendor ID may not be sufficient to detect unplug,
>> > it may also read as "all ones" if
@vger.kernel.org; Stanislav Nijnikov
> ; Avi Shchislowski
> ; Alex Lemberg ;
> Subhash Jadavani ; Vinayak Holikatti
>
> Subject: Re: [PATCH v3 1/7] scsi: ufs: Add ufs-bsg module
>
> > +config SCSI_UFS_BSG
> > + bool "Universal Flash Storage BSG device node"
&
@vger.kernel.org; Stanislav Nijnikov
> ; Avi Shchislowski
> ; Alex Lemberg ;
> Subhash Jadavani ; Vinayak Holikatti
>
> Subject: Re: [PATCH v3 2/7] scsi: ufs: Instantiate a ufs bsg if its available
>
> On Mon, Sep 03, 2018 at 01:33:11PM +0300, Avri Altman wrote:
&
On Mon, 2018-09-03 at 13:33 +0300, Avri Altman wrote:
> [ ... ]
> +++ b/include/uapi/scsi/scsi_bsg_ufs.h
> @@ -0,0 +1,56 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * UFS Transport SGIO v4 BSG Message Support
> + *
> + * Copyright (C) 2018 Western Digital Corporation
> + */
> +#ifndef
> +config SCSI_UFS_BSG
> + bool "Universal Flash Storage BSG device node"
So this a bool,
> obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
> obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
> obj-$(CONFIG_SCSI_UFS_HISI) += ufs-hisi.o
> +obj-$(CONFIG_SCSI_UFS_BSG) += ufs_bsg.o
But
On Mon, Sep 03, 2018 at 01:33:13PM +0300, Avri Altman wrote:
> Do that in order to re-use its code if the task request and response
> UPIUs are given externally.
>
> Signed-off-by: Avri Altman
> ---
> drivers/scsi/ufs/ufshcd.c | 35 ++-
>
In general this looks good, but a question below:
> index ed37914..d18832a 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -5598,6 +5598,32 @@ static int ufshcd_clear_tm_cmd(struct ufs_hba *hba,
> int tag)
> return err;
> }
>
> +static void
On 09/04/2018 11:21 AM, Greg Edwards wrote:
> static int
> -iblock_alloc_bip(struct se_cmd *cmd, struct bio *bio)
> +iblock_alloc_bip(struct se_cmd *cmd, struct bio *bio,
> + struct sg_mapping_iter *miter)
> {
> struct se_device *dev = cmd->se_dev;
> struct blk_integrity
On Sat, Sep 01, 2018 at 08:42:16AM +0800, kbuild test robot wrote:
> Hi Greg,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on target/for-next]
> [also build test WARNING on v4.19-rc1 next-20180831]
> [if your patch is applied to the wrong git tree, please
On Tue, Sep 04, 2018 at 11:19:04AM +0530, Sreekanth Reddy wrote:
> On Fri, Aug 31, 2018 at 2:25 PM, Lukas Wunner wrote:
> > * Just reading the vendor ID may not be sufficient to detect unplug,
> > it may also read as "all ones" if the link is down due to error
> > recovery by DPC.
>
> So, is
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key
On Fri, Aug 31, 2018 at 2:25 PM, Lukas Wunner wrote:
> [cc += linux-pci, benh]
>
> On Fri, Aug 31, 2018 at 7:37 AM Suganath Prabu S
> wrote:
>> Posting below set of patches to support PCIe Hot Plug surprise removal,
>> and few defect fixes.
>
> Please cross-post to linux-pci in the future.
>
>
Hi Greg,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on target/for-next]
[also build test WARNING on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Hi Quinn,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
[cc += linux-pci, benh]
On Fri, Aug 31, 2018 at 7:37 AM Suganath Prabu S
wrote:
> Posting below set of patches to support PCIe Hot Plug surprise removal,
> and few defect fixes.
Please cross-post to linux-pci in the future.
Regarding [PATCH 1/7] mpt3sas: Introduce
+Cc: Lukas (I think he might be interested to look at this)
On Fri, Aug 31, 2018 at 7:37 AM Suganath Prabu S
wrote:
>
> Posting below set of patches to support PCIe Hot Plug surprise removal,
> and few defect fixes.
>
> This is NOT the normal PCIe Hot Plug support, whereby the user informs the
>
On 08/30/2018 12:25 PM, Greg Edwards wrote:
> When T10 PI is enabled on a backing device for the iblock backstore, the
> PI SGL for the entire command is attached to the first bio only. This
> works fine if the command is covered by a single bio, but can result in
> ref tag errors in the client
Hello,
The complaint is actually about line 6956. Has the mutex been released
there?
julia
-- Forwarded message --
Date: Fri, 31 Aug 2018 00:37:52 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH 1/7] mpt3sas: Introduce
On Wed, Aug 29, 2018 at 06:23:52PM -0500, Mike Christie wrote:
>
> Can you still hit the issue where t_prot_nents > BIO_MAX_PAGES so
> bio_integrity_alloc fails or is t_prot_nents always going to be smaller.
> Was wondering why you dropped that from the last patch.
There was a vhost bug that was
Chengguang,
> kmem_cache_destroy() can handle NULL pointer correctly, so there is
> no need to check NULL pointer before calling kmem_cache_destroy()
Applied to 4.20/scsi-queue, thank you.
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> Smatch complains about this code:
>
> drivers/scsi/lpfc/lpfc_scsi.c:1053 lpfc_get_scsi_buf_s4()
> warn: variable dereferenced before check 'lpfc_cmd' (see line 1039)
>
> Fortunately the NULL check isn't required so I have removed it.
Applied to 4.20/scsi-queue, thank you!
--
Faisal,
> 'NEGOTIATION' was misspelled as 'NEGOTATION'. Fixed it. It is a coding
> style change which should have no impact on runtime execution of code.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Nilesh,
> The QED driver commit, 1ac4329 qed: Add configuration information to
> register dump and debug data, removes the CRC length validation
> causing nvm_get_image failure while loading qedi driver,
>
> [qed_mcp_get_nvm_image:2700(host_10-0)]Image [0] is too big - 6008
> bytes where
Mike,
> The following patches are login fixes from the list. The set has been
> rebased against Linus's current tree so they apply over the idr/ida
> patches that have been merged.
Applied to 4.19/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
On 08/29/2018 03:36 PM, Greg Edwards wrote:
> When T10 PI is enabled on a backing device for the iblock backstore, the
> PI SGL for the entire command is attached to the first bio only. This
> works fine if the command is covered by a single bio, but can result in
> ref tag errors in the client
On Wed, Aug 29, 2018 at 10:04:04PM +0800, Chengguang Xu wrote:
> kmem_cache_destroy()/mempool_destroy() can handle NULL pointer
> correctly, so there is no need to check NULL pointer before calling
> kmem_cache_destroy()/mempool_destroy(). Meanwhile, because this
> is in the error case of init
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key
On Mon, Aug 27, 2018 at 02:45:15PM -0500, Mike Christie wrote:
> Signed-off-by: Vincent Pelletier
> [rebased against idr/ida changes and to handle ret review comments from
> Matthew]
> Signed-off-by: Mike Christie
> Cc: Matthew Wilcox
Reviewed-by: Matthew Wilcox
Dan,
> The problem is that ->reset_state is a u8 but it can be set to -1 or
> -2 in aac_tmf_callback() and the error handling in
> aac_eh_target_reset() relies on it to be signed.
Applied to 4.19/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Mike,
> I will remake and resend the last 2 patches against the current Linus
> tree, because the second patch does not cleanly apply against the
> idr/ida changes.
Sounds good. Just getting the new SCSI trees ready...
--
Martin K. Petersen Oracle Linux Engineering
On 08/27/2018 12:03 AM, Matthew Wilcox wrote:
> On Fri, Aug 24, 2018 at 01:37:10PM -0500, Mike Christie wrote:
>> The following patchset is a round up of login fixes that have been
>> on the list and in Mathew's tree. They fix a couple of bugs in the
>> iscsi login failure handling path.
>>
>> The
On Fri, Aug 24, 2018 at 01:37:10PM -0500, Mike Christie wrote:
> The following patchset is a round up of login fixes that have been
> on the list and in Mathew's tree. They fix a couple of bugs in the
> iscsi login failure handling path.
>
> The patches were made against Martin's 4.19/scsi-queue
On Fri, Aug 24, 2018 at 06:33:29PM -0600, Jens Axboe wrote:
> On 8/24/18 6:21 PM, Jens Axboe wrote:
> > On 8/24/18 5:16 PM, Ming Lei wrote:
> >> Hi,
> >>
> >> On Fri, Aug 24, 2018 at 04:20:41PM -0600, Jens Axboe wrote:
> >>> Hi,
> >>>
> >>> Was testing other things today, but ended up with this:
>
On 8/24/18 6:21 PM, Jens Axboe wrote:
> On 8/24/18 5:16 PM, Ming Lei wrote:
>> Hi,
>>
>> On Fri, Aug 24, 2018 at 04:20:41PM -0600, Jens Axboe wrote:
>>> Hi,
>>>
>>> Was testing other things today, but ended up with this:
>>>
>>> # echo "write through" >
On 8/24/18 5:16 PM, Ming Lei wrote:
> Hi,
>
> On Fri, Aug 24, 2018 at 04:20:41PM -0600, Jens Axboe wrote:
>> Hi,
>>
>> Was testing other things today, but ended up with this:
>>
>> # echo "write through" > /sys/block/sde/device/scsi_disk/4:0:0:0/cache_type
>>
>> hanging. Looking closer, the
Hi,
On Fri, Aug 24, 2018 at 04:20:41PM -0600, Jens Axboe wrote:
> Hi,
>
> Was testing other things today, but ended up with this:
>
> # echo "write through" > /sys/block/sde/device/scsi_disk/4:0:0:0/cache_type
>
> hanging. Looking closer, the request is successfully queued and the
> caller is
On Fri, Aug 24, 2018 at 01:37:12PM -0500, Mike Christie wrote:
> Also, let idr_alloc return value through instead of replacing it with -ENOMEM,
> as it is already a negative value and caller checks sign, not exact value.
I bet it's less code to just return -ENOMEM in all situations instead of
On Fri, Aug 24, 2018 at 01:37:10PM -0500, Mike Christie wrote:
> The following patchset is a round up of login fixes that have been
> on the list and in Mathew's tree. They fix a couple of bugs in the
> iscsi login failure handling path.
>
> The patches were made against Martin's 4.19/scsi-queue
601 - 700 of 39577 matches
Mail list logo
