On Fri, 2018-07-20 at 15:21 -0400, Douglas Gilbert wrote:
> /* Complete the processing of the thread that queued a SCSI command to this
> @@ -4459,6 +4462,11 @@ static int schedule_resp(struct scsi_cmnd *cmnd,
> struct sdebug_dev_info *devip,
> sd_dp->issuing_cpu =
On Fri, 2018-07-20 at 16:08 -0500, Mike Christie wrote:
> Hey Bart and Christoph,
>
> Bart, I noticed we basically had what you are requesting but Christoph
> had moved the id code from the fabric drivers to lio core in this commit:
>
> commit 2650d71e244fb3637b5f58a0080682a8bf9c7091
> Author:
On 07/20/2018 04:08 PM, Mike Christie wrote:
> On 07/19/2018 11:13 AM, Mike Christie wrote:
>> > On 07/19/2018 10:15 AM, Bart Van Assche wrote:
>>> >> On Wed, 2018-07-18 at 20:02 -0500, Mike Christie wrote:
>>> On 07/18/2018 07:03 PM, Mike Christie wrote:
> On 07/18/2018 05:09 PM,
On 07/19/2018 11:13 AM, Mike Christie wrote:
> On 07/19/2018 10:15 AM, Bart Van Assche wrote:
>> On Wed, 2018-07-18 at 20:02 -0500, Mike Christie wrote:
>>> On 07/18/2018 07:03 PM, Mike Christie wrote:
On 07/18/2018 05:09 PM, Bart Van Assche wrote:
> [ ... ]
> is that these involve a
>
>
> []
> system_call_fastpath+0x1c/0x21
>
>
>
> And with IOs going on, when killing the tcmu-runner process, the
Are you just doing a test to kill runner at
On Thu, Jul 19, 2018 at 04:30:36PM -0500, Mike Christie wrote:
> Just to clarify. We can create a dir from the kernel already. It is no
> problem. I am doing that in this patchset with configfs_register_group.
>
> What Bart was requesting originally and what is missing is being able to
> add a
Himanshu,
> This patch series fixes issues with load/unload of the driver in a
> loop.
>
> Please apply this series for 4.18/scsi-fixes at your earliest convenience
> to be included in 4.18.0-rc6.
Applied to 4.18/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Varun,
> T5/T6 can have different pack and pad boundary value. This patch sets
> packing boundary based on cache line size and PCI-E maximum payload
> size and sets smallest padding boundary value.
Applied to 4.19/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
On 07/19/2018 03:47 PM, Christoph Hellwig wrote:
> On Thu, Jul 19, 2018 at 05:07:59PM +, Bart Van Assche wrote:
>> Initially configfs did not support creation of a directory from the kernel
>> side. Last time I brought this up with Christoph he replied that this
>> functionality has been added
On Sun, Jul 15, 2018 at 06:16:31PM -0500, Mike Christie wrote:
> Just have iscsit_start_nopin_timer grab the lock and
> call __iscsit_start_nopin_timer.
It doesn't really merge them but makes one call the other. Except for
that this looks fine:
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
On Thu, Jul 19, 2018 at 05:07:59PM +, Bart Van Assche wrote:
> Initially configfs did not support creation of a directory from the kernel
> side. Last time I brought this up with Christoph he replied that this
> functionality has been added to configfs (if I understood Christoph
> correctly).
On Sun, Jul 15, 2018 at 06:16:24PM -0500, Mike Christie wrote:
> For tcm_fc, it should be ok to call
> transport_deregister_session_configfs later like in the new
> remove function because the transport_deregister_session_configfs call
> was not affecting the target_sess_cmd_list_set_waiting/
>
On Sun, Jul 15, 2018 at 06:16:23PM -0500, Mike Christie wrote:
> Rename target_alloc_session to target_setup_session to avoid
> confusion with the other transport session allocation
> function that only allocates the session and because
> the target_alloc_session does so more. It allocates the
>
On Sun, Jul 15, 2018 at 06:16:22PM -0500, Mike Christie wrote:
> transport_init_session_tags is only called from target_core_transport.c
> so make it static.
>
> Signed-off-by: Mike Christie
Looks fine by itself:
Reviewed-by: Christoph Hellwig
Although folding it into the only caller would
On Sun, Jul 15, 2018 at 06:16:21PM -0500, Mike Christie wrote:
> sess_get_index is meaninless for most drivers. For iscsi, it
> is the same as the se_session->sid now and for fcoe it was just
> the port id which would not work if multiple initiators
> connected to the same target port. So just use
On Sun, Jul 15, 2018 at 06:16:19PM -0500, Mike Christie wrote:
> When __transport_register_session is called from
> transport_register_session irqs will already have been disabled,
> so we do not want the unlock irq call to enable them until
> the higher level has done the final
>
On Thu, 2018-07-19 at 11:38 -0500, Mike Christie wrote:
> On 07/19/2018 10:37 AM, Bart Van Assche wrote:
> > The general recommendation for configfs is that each attribute contains a
> > single value, just like for sysfs. Patch 11/15 exports two values through
> > a single attribute. Have you
On 07/19/2018 10:37 AM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> +if (se_sess->se_tpg->se_tpg_tfo->sess_get_initiator_sid) {
>> +len = snprintf(page, PAGE_SIZE, "%s 0x%6phN\n",
>> +
On 07/19/2018 10:15 AM, Bart Van Assche wrote:
> On Wed, 2018-07-18 at 20:02 -0500, Mike Christie wrote:
>> On 07/18/2018 07:03 PM, Mike Christie wrote:
>>> On 07/18/2018 05:09 PM, Bart Van Assche wrote:
[ ... ]
is that these involve a transport ID and that that transport ID can be up
On 07/19/2018 09:30 AM, xiu...@redhat.com wrote:
> From: Xiubo Li
>
> The logs are:
>
> BUG: unable to handle kernel NULL pointer dereference at 0040
> IP: [] tcmu_reset_ring_store+0x149/0x240 [target_core_user]
> PGD 8e254067 PUD e255067 PMD 0
> Oops: 0002 [#1] SMP
> [...]
On Wed, 2018-07-18 at 21:15 -0500, Mike Christie wrote:
> Oh wait, I think I know what you mean.
I should have written "se_node_acl" instead of "se_portal_group".
Bart.
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> + if (se_sess->se_tpg->se_tpg_tfo->sess_get_initiator_sid) {
> + len = snprintf(page, PAGE_SIZE, "%s 0x%6phN\n",
> +se_sess->se_node_acl->initiatorname,
> +
On Wed, 2018-07-18 at 22:47 -0500, Mike Christie wrote:
> Hey Bart, I looked into this some more and this value is also being used
> as the scsiAttIntrPortIndex. For that use, does it need to be unique
> across a target when the target has multiple ports?
>
> So I think it needs to be on the
On Wed, 2018-07-18 at 20:02 -0500, Mike Christie wrote:
> On 07/18/2018 07:03 PM, Mike Christie wrote:
> > On 07/18/2018 05:09 PM, Bart Van Assche wrote:
> > > [ ... ]
> > > is that these involve a transport ID and that that transport ID can be up
> > > to 228
> > > bytes long for iSCSI.
> >
> >
On Wed, Jul 18, 2018 at 7:38 PM, Bart Van Assche wrote:
> On Wed, 2018-07-18 at 01:22 -0400, Sreekanth Reddy wrote:
>> In mpt3sas_base_clear_st() function smid value is reseted in wrong line,
>> i.e. driver should reset smid value to zero after decrementing chain_offset
>> counter in chain_lookup
On 07/18/2018 07:15 PM, Mike Christie wrote:
> On 07/18/2018 05:19 PM, Bart Van Assche wrote:
>> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>>> diff --git a/drivers/target/target_core_transport.c
>>> b/drivers/target/target_core_transport.c
>>> index 75ddbbb..97a1ee5 100644
>>> ---
On 07/18/2018 06:04 PM, Mike Christie wrote:
> On 07/18/2018 05:41 PM, Bart Van Assche wrote:
>> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>>> Export the initiator port info in configfs
>>
>> Does configfs support soft links? Can this information be exported as a
>> soft link from
On 07/18/2018 07:03 PM, Mike Christie wrote:
> On 07/18/2018 05:09 PM, Bart Van Assche wrote:
>> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>>> The isid is 48 bits, and in hex string format it's 12 bytes.
>>> We are currently copying the 12 byte hex string to a u64
>>> so we can
On 07/18/2018 05:46 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> + int (*test_session)(struct se_session *, u8 timeout);
>
> Does any of the patches in this series define a test_session callback
> function?
Patch 14 does.
>
> What is the unit of
On 07/18/2018 05:19 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> diff --git a/drivers/target/target_core_transport.c
>> b/drivers/target/target_core_transport.c
>> index 75ddbbb..97a1ee5 100644
>> --- a/drivers/target/target_core_transport.c
>> +++
On 07/18/2018 05:09 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> The isid is 48 bits, and in hex string format it's 12 bytes.
>> We are currently copying the 12 byte hex string to a u64
>> so we can easily compare it, but this has the problem that
>> only
On 07/18/2018 05:41 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> Export the initiator port info in configfs
>
> Does configfs support soft links? Can this information be exported as a
> soft link from the session directory to the struct se_portal_group
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> + int (*test_session)(struct se_session *, u8 timeout);
Does any of the patches in this series define a test_session callback
function?
What is the unit of the timeout parameter? 1/HZ, ms or s?
Thanks,
Bart.
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> Export the initiator port info in configfs
Does configfs support soft links? Can this information be exported as a
soft link from the session directory to the struct se_portal_group configfs
object?
Thanks,
Bart.
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> +static void target_fabric_session_release(struct config_item *item)
> +{
> + struct se_session *se_sess = container_of(to_config_group(item),
> + struct se_session, group);
> +
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> This adds a function to remove a session which should be used by
> drivers that use target_setup_session.
>
> All the drivers but iscsi and tcm_fc were doing calling
> transport_deregister_session_configfs and then immediately calling
>
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> Rename target_alloc_session to target_setup_session to avoid
> confusion with the other transport session allocation
> function that only allocates the session and because
> the target_alloc_session does so more. It allocates the
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> transport_init_session_tags is only called from target_core_transport.c
> so make it static.
Reviewed-by: Bart Van Assche
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> sess_get_index is meaninless for most drivers. For iscsi, it
^^
meaningless?
> is the same as the se_session->sid now and for fcoe it was just
> the port id which would not work if multiple
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> diff --git a/drivers/target/target_core_transport.c
> b/drivers/target/target_core_transport.c
> index 75ddbbb..97a1ee5 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -55,6 +55,8
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> When __transport_register_session is called from
> transport_register_session irqs will already have been disabled,
> so we do not want the unlock irq call to enable them until
> the higher level has done the final
>
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> The isid is 48 bits, and in hex string format it's 12 bytes.
> We are currently copying the 12 byte hex string to a u64
> so we can easily compare it, but this has the problem that
> only 8 bytes of the 12 bytes are copied.
>
> The next
omic_set(>loop_down_timer,
LOOP_DOWN_TIME);
- qla2x00_mark_all_devices_lost(vha, 1);
+ if (!N2N_TOPO(ha))
+ qla2x00_mark_all_devices_lost(vha, 1);
}
if (vha->vp_id
Le Fri, 15 Jan 2016 12:48:09 +0100
Emmanuel Florac écrivait:
> Le Thu, 14 Jan 2016 15:12:53 -0500 (EST)
> Laurence Oberman écrivait:
>
> > All attempts to get my drive and changer firmware updated have
> > failed. So I wont be able to add another "tested by" to this thread
> > unless I can
On Wed, 2018-07-18 at 01:22 -0400, Sreekanth Reddy wrote:
> In mpt3sas_base_clear_st() function smid value is reseted in wrong line,
> i.e. driver should reset smid value to zero after decrementing chain_offset
> counter in chain_lookup table but in current code, driver is resetting smid
> value
On 07/18/2018 07:22 AM, Sreekanth Reddy wrote:
> In mpt3sas_base_clear_st() function smid value is reseted in wrong line,
> i.e. driver should reset smid value to zero after decrementing chain_offset
> counter in chain_lookup table but in current code, driver is resetting smid
> value before
Thanks, applied to the configfs tree.
On 07/15/2018 06:16 PM, Mike Christie wrote:
> TODO:
> 1. handle target_fabric_register_session failure in iscsi target.
>
I fixed this in the updated attached patch. So Bodo and reviewers please
use that instead.
>From 895edd5d20df208c3dfae8d826a3c3fcbd68 Mon Sep 17 00:00:00 2001
From: Mike
Sreekanth,
> Below kernel BUG was observed while running IOs with host reset
> (issued from application),
Applied to 4.18/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
Varun,
> In iscsi_check_tmf_restrictions() task->hdr is dereferenced to print
> the opcode, it is possible that task->hdr is NULL.
Applied to 4.18/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tony,
> Fix a minor memory leak when there is an error opening a /dev/sg
> device.
Applied to 4.18/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tony,
> The calling convention of blk_get_request() has changed in lk 4.18;
> update the comment in sg.c to match.
Applied to 4.18/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Doug,
> A test program's runtime became impractically long since any non zero
> ndelay (e.g. 1 nanosec) caused Start Stop Unit to delay over 8
> magnitudes greater than other commands. This patch skips long delays
> (on Start Stop Unit and Synchronize Cache) if ndelay is less than or
> equal to
Hannes,
> it turned out that my original patch for fixing up disc_mutex handling
> wasn't quite perfect, as it was causing 'scheduling while atomie'
> warnings. Upon inspection it turns out that we can't use RCU list
> traversal in most cases, as these list iterations would be calling
>
On 2018-07-12 06:09 PM, Tony Battersby wrote:
The calling convention of blk_get_request() has changed in lk 4.18;
update the comment in sg.c to match.
Fixes: ff005a066240 ("block: sanitize blk_get_request calling conventions")
Signed-off-by: Tony Battersby
Acked-by: Douglas Gilbert
---
I
On 2018-07-12 02:46 PM, Tony Battersby wrote:
Fix a minor memory leak when there is an error opening a /dev/sg device.
Signed-off-by: Tony Battersby
Acked-by: Douglas Gilbert
Thanks.
---
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index cd2fdac..2962a38 100644
---
On 07/12/18 13:30, Tony Battersby wrote:
Fix a minor memory leak when there is an error opening a /dev/sg device.
Reviewed-by: Bart Van Assche
Fix a minor memory leak when there is an error opening a /dev/sg device.
Fixes: cc833acbee9d ("sg: O_EXCL and other lock handling")
Cc:
Reviewed-by: Ewan D. Milne
Signed-off-by: Tony Battersby
---
Resending to include the requested fixes: / cc: stable tags.
diff --git a/drivers/scsi/sg.c
On Thu, 2018-07-12 at 14:46 -0400, Tony Battersby wrote:
> Fix a minor memory leak when there is an error opening a /dev/sg device.
Please Cc: stable for patches like this and please also add a Fixes: tag.
Thanks,
Bart.
On Thu, 2018-07-12 at 14:46 -0400, Tony Battersby wrote:
> Fix a minor memory leak when there is an error opening a /dev/sg device.
>
> Signed-off-by: Tony Battersby
> ---
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index cd2fdac..2962a38 100644
> --- a/drivers/scsi/sg.c
> +++
On Tue, Jul 10, 2018 at 10:58 PM, Sreekanth Reddy
wrote:
> On Mon, Jul 9, 2018 at 5:14 PM, Sreekanth Reddy
> wrote:
>> On Thu, Jun 28, 2018 at 10:56 AM, Sreekanth Reddy
>> wrote:
>>> On Thu, Jun 28, 2018 at 3:48 AM, Bart Van Assche
>>> wrote:
On 06/24/18 23:10, Sreekanth Reddy wrote:
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Wed, 2018-07-11 at 10:09 +0200, Hannes Reinecke wrote:
> Hi all,
>
> it turned out that my original patch for fixing up disc_mutex
> handling
> wasn't quite perfect, as it was causing 'scheduling while atomie'
> warnings.
> Upon inspection it turns out that we can't use RCU list traversal in
>
.
>
> I obviously missed the first email of this thread. Sigh.
Whether I need to re-send this same patch?
>
> --
> Martin K. Petersen Oracle Linux Engineering
> Since this commit is buried a bit deep in the pile, please submit an
> incremental patch that addresses Dave's problem.
I obviously missed the first email of this thread. Sigh.
--
Martin K. Petersen Oracle Linux Engineering
James,
> This patch contains lpfc bug fixes and some minor functional additions.
Applied to 4.19/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Chad,
> Need to notify firmware when driver is loaded and unloaded.
Applied to 4.18/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Cédric,
> commit cd43c221bb5e ("scsi: cxlflash: Isolate external module
> dependencies") introduced the use of ifdefs to avoid compilation
> errors when one of the possible backend driver, CXL or OCXL, is not
> compiled.
>
> Unfortunately, the wrong defines are used and the backend ops are
>
Hannes,
> Convert the free text locking notes into proper lockdep annotations.
Applied to 4.19/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Hannes,
> fc_rport_login() will be calling mutex_lock() while running inside
> an RCU-protected section, triggering the warning 'sleeping function
> called from invalid context'.
> To fix this we can drop the rcu functions here altogether as the
> disc mutex protecting the list itself is
Don,
> The original complaint was the lsscsi -t showed the same SAS address
> of the two enclosures (SEP devices). In fact the SAS address was being
> set to the Enclosure Logical Identifier (ELI).
Applied to 4.18/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Manish,
> In case of iSCSI offload BFS environment, mfw requires to mark
> virtual link based upon qedi load status.
Applied to 4.18/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Damien,
> Fix the description of sd_zbc_check_zone_size() to correctly explain
> that the returned value is a number of device blocks, not bytes.
> Additionally, the 32 bits "ret" variable used in this function may
> truncate the 64 bits zone_blocks variable value upon return. To fix
> this,
Sreekanth,
> I am trying to revert patch commit cf6bf9710c (scsi: mpt3sas: Bug fix
> for big endian systems) but revert operation is not happening
> smoothly, it may be due to dependency with some other patch changes.
>
> Anyway in this patch we have reverted those hunks of cf6bf9710c patch
>
On Mon, Jul 9, 2018 at 5:14 PM, Sreekanth Reddy
wrote:
> On Thu, Jun 28, 2018 at 10:56 AM, Sreekanth Reddy
> wrote:
>> On Thu, Jun 28, 2018 at 3:48 AM, Bart Van Assche
>> wrote:
>>> On 06/24/18 23:10, Sreekanth Reddy wrote:
Before calling scsi_internal_device_block_nowait() API;
On Tue, Jul 10, 2018 at 2:38 AM, David Miller wrote:
> From: Sreekanth Reddy
> Date: Mon, 9 Jul 2018 17:12:51 +0530
>
>> This is a shared structure between the host drivers and HBA device.
>> HBA Firmware sends the information though this structures which are
>> defined in the MPI headers. Now
From: Sreekanth Reddy
Date: Mon, 9 Jul 2018 17:12:51 +0530
> This is a shared structure between the host drivers and HBA device.
> HBA Firmware sends the information though this structures which are
> defined in the MPI headers. Now we can't change the order of these u8
> objects.
>
> typedef
On Thu, Jun 28, 2018 at 10:56 AM, Sreekanth Reddy
wrote:
> On Thu, Jun 28, 2018 at 3:48 AM, Bart Van Assche
> wrote:
>> On 06/24/18 23:10, Sreekanth Reddy wrote:
>>>
>>> Before calling scsi_internal_device_block_nowait() API; driver sets
>>> sas_device_priv_data->block flag as one. And in the
On Wed, Jul 4, 2018 at 5:52 PM, David Miller wrote:
> From: Sreekanth Reddy
> Date: Wed, 4 Jul 2018 16:54:05 +0530
>
>>
>> Also I tried replacing readl() API with readw()API (as HBA FW will
>> send 16 bit data at a time) as shown below and still I see same issue,
>>
>> MPI2DefaultReply_t
problem)?
Huacai
-- Original --
From: "James Smart";
Date: Mon, Mar 5, 2018 11:37 PM
To: "陈华才"; "Dick Kennedy";
Cc: "James E . J . Bottomley"; "Martin K .
Petersen"; "Fuxin Zhang";
"linux-scsi&q
On Thu, Jul 05, 2018 at 07:26:23AM +0200, Cédric Le Goater wrote:
> commit cd43c221bb5e ("scsi: cxlflash: Isolate external module
> dependencies") introduced the use of ifdefs to avoid compilation
> errors when one of the possible backend driver, CXL or OCXL, is not
> compiled.
>
> Unfortunately,
On 07/02/18 23:23, Damien Le Moal wrote:
Fix the description of sd_zbc_check_zone_size() to correctly explain
that the returned value is a number of device blocks, not bytes.
Additionally, the 32 bits "ret" variable used in this function may
truncate the 64 bits zone_blocks variable value upon
From: Sreekanth Reddy
Date: Wed, 4 Jul 2018 16:54:05 +0530
>
> Also I tried replacing readl() API with readw()API (as HBA FW will
> send 16 bit data at a time) as shown below and still I see same issue,
>
> MPI2DefaultReply_t *default_reply = (MPI2DefaultReply_t *)reply;
> u16
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key
On Tue, Jul 3, 2018 at 8:53 PM, James Bottomley
wrote:
> On Tue, 2018-07-03 at 22:49 +0900, David Miller wrote:
>> From: Sreekanth Reddy
>> Date: Tue, 3 Jul 2018 17:48:49 +0530
>>
>> > Any suggestion/update over my previous mail. I am using 4.13
>> kernel.
>>
>> I think the issue is that if you
Le Tue, 3 Jul 2018 17:37:56 +
Dave Carroll écrivait:
> > [ 61.076949] SME is active and system is using DMA bounce buffers
> > [ 61.076954] aacraid: Comm Interface type2 enabled
> >
>
> Both controllers are capable of 64-bit DMA, however the communication
> area should be 32-bit. Is
> I have already set up many drives of this size previously, using
> ASR8xx5 controllers, without any problem.
>
> On another machine with a simple 8x1TB array, it doesn't work any better,
> while
> an older kernel works perfectly fine too:
>
> 4.14.48 :
>
> [ 61.069190] Adaptec aacraid
Le Tue, 3 Jul 2018 16:59:41 +
Dave Carroll écrivait:
> Hi Emmanuel,
>
> It is curious that the FW is having outstanding commands ... I've
> created a ticket to iderntify the differences. I suspect that the
> large drive size may be related, but all options are open.
>
I have already set
> After a very long time, it finally boots up and sees the disks, but
> here's the output from dmesg | grep aacraid:
>
> [1.357760] Adaptec aacraid driver 1.2.1[50877]-custom
> [1.388119] aacraid: Comm Interface type2 enabled
> [3.405113] scsi host0: aacraid
> [ 50.156024]
Le Wed, 27 Jun 2018 18:48:56 +
Dave Carroll écrivait:
> > Is this size consistent with the 4.13 kernel? That size is greater
> > than the 64-bit LBA addressing (0x93 539F B000).
>
> Sorry, that comment was incorrect, but I would like to see if the
> size is consistent between the kernels.
Le Wed, 27 Jun 2018 18:48:56 +
Dave Carroll écrivait:
> Sorry, that comment was incorrect, but I would like to see if the
> size is consistent between the kernels.
>
I just booted the 4.16 from Debian testing, same problem, so this is
not an artefact of my custom compilation:
aacraid:
On Tue, 2018-07-03 at 22:49 +0900, David Miller wrote:
> From: Sreekanth Reddy
> Date: Tue, 3 Jul 2018 17:48:49 +0530
>
> > Any suggestion/update over my previous mail. I am using 4.13
> kernel.
>
> I think the issue is that if you are reading a 32-bit word and then
> interpreting it as a
From: Sreekanth Reddy
Date: Tue, 3 Jul 2018 17:48:49 +0530
> Any suggestion/update over my previous mail. I am using 4.13 kernel.
I think the issue is that if you are reading a 32-bit word and then
interpreting it as a struct full of individual bytes, you have to
order the bytes in the
Hi,
Any suggestion/update over my previous mail. I am using 4.13 kernel.
Thanks,
Sreekanth
On Sat, Jun 30, 2018 at 12:34 AM, Sreekanth Reddy
wrote:
> Hi All,
>
> Here is the issue which we are observing when driver don't use
> le16_to_cpu() in below code snippet on Sparc64 machine when driver
On 07/03/2018 08:23 AM, Damien Le Moal wrote:
> Fix the description of sd_zbc_check_zone_size() to correctly explain
> that the returned value is a number of device blocks, not bytes.
> Additionally, the 32 bits "ret" variable used in this function may
> truncate the 64 bits zone_blocks variable
901 - 1000 of 39577 matches
Mail list logo
