On Thu, Jul 17, 2014 at 11:53:33PM +, KY Srinivasan wrote:
I still see this problem. There was talk of fixing it elsewhere.
Well, what we have right not is entirely broken, given that the
block layer doesn't initialize -timeout on TYPE_FS requeuests.
We either need to revert that initial
On Fri, Jul 18, 2014 at 12:51:06AM +, Elliott, Robert (Server Storage)
wrote:
SYNCHRONIZE CACHE (16) should be favored over SYNCHRONIZE
CACHE (10) unless SYNCHRONIZE CACHE (10) is not supported.
I gues you mean (16) for the last occurance? What's the benefit of
using SYNCHRONIZE CACHE
On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage)
wrote:
In sd_sync_cache:
rq-timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER;
Regardless of the baseline for the multiplication, a magic
number of 2 is too arbitrary. That might work for an
individual drive, but could be far
-Original Message-
From: Christoph Hellwig (h...@infradead.org) [mailto:h...@infradead.org]
Sent: Friday, July 18, 2014 8:11 AM
To: KY Srinivasan
Cc: Jens Axboe; James Bottomley; micha...@cs.wisc.edu; Christoph Hellwig
(h...@infradead.org); linux-scsi@vger.kernel.org;
On Fri, 2014-07-18 at 16:44 +, KY Srinivasan wrote:
-Original Message-
From: Christoph Hellwig (h...@infradead.org) [mailto:h...@infradead.org]
Sent: Friday, July 18, 2014 8:11 AM
To: KY Srinivasan
Cc: Jens Axboe; James Bottomley; micha...@cs.wisc.edu; Christoph Hellwig
On Wed, Jun 04, 2014 at 09:33:43AM -0700, K. Y. Srinivasan wrote:
Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the
FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use the
basic I/O timeout of the device. Fix this bug.
Signed-off-by: K. Y.
On Fri, Jul 18, 2014 at 04:57:13PM +, James Bottomley wrote:
Actually, no you didn't. The difference is in the derivation of the
timeout. Christoph's patch is absolute in terms of SD_TIMEOUT; yours is
relative to the queue timeout setting ... I thought there was a reason
for preferring
On Fri, 2014-07-18 at 10:00 -0700, Christoph Hellwig wrote:
On Wed, Jun 04, 2014 at 09:33:43AM -0700, K. Y. Srinivasan wrote:
Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the
FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use
the
basic
-Original Message-
From: James Bottomley [mailto:jbottom...@parallels.com]
Sent: Friday, July 18, 2014 9:57 AM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; h...@infradead.org; a...@canonical.com;
de...@linuxdriverproject.org; micha...@cs.wisc.edu; ax...@kernel.dk;
This is what I plan to put in after it passes basic testing:
---
From bb617c9465b839d70ecbbc69002a20ccf5f935bd Mon Sep 17 00:00:00 2001
From: K. Y. Srinivasan k...@microsoft.com
Date: Fri, 18 Jul 2014 19:12:58 +0200
Subject: sd: fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O
timeout
On Fri, Jul 18, 2014 at 10:12:38AM -0700, h...@infradead.org wrote:
This is what I plan to put in after it passes basic testing:
And that one was on top of my previous version. One that applies
against core-for-3.17 below:
---
From 8a79783e5f72ec034a724e16c1f46604bd97bf68 Mon Sep 17 00:00:00
From: James Bottomley [mailto:jbottom...@parallels.com]
On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage)
wrote:
...
Also, in both sd_setup_flush_cmnd and sd_sync_cache:
cmd-cmnd[0] = SYNCHRONIZE_CACHE;
cmd-cmd_len = 10;
SYNCHRONIZE CACHE (16)
On Fri, 2014-07-18 at 17:17 +, Elliott, Robert (Server Storage)
wrote:
From: James Bottomley [mailto:jbottom...@parallels.com]
On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage)
wrote:
...
Also, in both sd_setup_flush_cmnd and sd_sync_cache:
On 14-07-18 07:41 AM, James Bottomley wrote:
On Fri, 2014-07-18 at 17:17 +, Elliott, Robert (Server Storage)
wrote:
From: James Bottomley [mailto:jbottom...@parallels.com]
On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage)
wrote:
...
Also, in both sd_setup_flush_cmnd
-Original Message-
From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev-
devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan
Sent: Friday, June 20, 2014 2:37 PM
To: Jens Axboe; James Bottomley; micha...@cs.wisc.edu
Cc: linux-scsi@vger.kernel.org;
In sd_sync_cache:
rq-timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER;
Regardless of the baseline for the multiplication, a magic
number of 2 is too arbitrary. That might work for an
individual drive, but could be far too short for a RAID
controller that runs into worst case error handling for
-Original Message-
From: Jens Axboe [mailto:ax...@kernel.dk]
Sent: Friday, June 6, 2014 11:23 AM
To: James Bottomley; micha...@cs.wisc.edu
Cc: linux-ker...@vger.kernel.org; h...@infradead.org;
de...@linuxdriverproject.org; a...@canonical.com; KY Srinivasan; linux-
On 6/5/14, 9:53 PM, KY Srinivasan wrote:
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Thursday, June 5, 2014 6:33 PM
To: KY Srinivasan
Cc: James Bottomley; linux-ker...@vger.kernel.org; a...@canonical.com;
de...@linuxdriverproject.org; h...@infradead.org;
On Fri, 2014-06-06 at 12:18 -0500, Mike Christie wrote:
On 6/5/14, 9:53 PM, KY Srinivasan wrote:
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Thursday, June 5, 2014 6:33 PM
To: KY Srinivasan
Cc: James Bottomley; linux-ker...@vger.kernel.org;
On 2014-06-06 11:52, James Bottomley wrote:
On Fri, 2014-06-06 at 12:18 -0500, Mike Christie wrote:
On 6/5/14, 9:53 PM, KY Srinivasan wrote:
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Thursday, June 5, 2014 6:33 PM
To: KY Srinivasan
Cc: James
On 06/04/2014 12:15 PM, KY Srinivasan wrote:
-Original Message-
From: James Bottomley [mailto:jbottom...@parallels.com]
Sent: Wednesday, June 4, 2014 10:02 AM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; a...@canonical.com;
de...@linuxdriverproject.org; h...@infradead.org;
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Thursday, June 5, 2014 6:33 PM
To: KY Srinivasan
Cc: James Bottomley; linux-ker...@vger.kernel.org; a...@canonical.com;
de...@linuxdriverproject.org; h...@infradead.org; linux-
s...@vger.kernel.org;
On Wed, 2014-06-04 at 09:33 -0700, K. Y. Srinivasan wrote:
Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the
FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use the
basic I/O timeout of the device. Fix this bug.
Signed-off-by: K. Y. Srinivasan
-Original Message-
From: James Bottomley [mailto:jbottom...@parallels.com]
Sent: Wednesday, June 4, 2014 10:02 AM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; a...@canonical.com;
de...@linuxdriverproject.org; h...@infradead.org; linux-
s...@vger.kernel.org;
24 matches
Mail list logo
