Re: [PATCH 3/4] Complain if scsi_target_block() fails

2019-07-26 Thread Bart Van Assche
On 7/26/19 11:03 AM, James Bottomley wrote: I don't disagree, but nothing in this patch set actually uses it ... is there a plan for something to use the scsi_target_block return value to perform some action other than issue a warning? If not, it likely makes better sense simply to add the warn

Re: [PATCH 3/4] Complain if scsi_target_block() fails

2019-07-26 Thread James Bottomley
On Fri, 2019-07-26 at 11:00 -0700, Bart Van Assche wrote: > On 7/26/19 10:00 AM, James Bottomley wrote: > > On Fri, 2019-07-26 at 09:48 -0700, Bart Van Assche wrote: > > > If scsi_target_block() fails that can break the code that calls > > > this > > > function. Hence complain loudly if scsi_target

Re: [PATCH 3/4] Complain if scsi_target_block() fails

2019-07-26 Thread Bart Van Assche
On 7/26/19 10:00 AM, James Bottomley wrote: On Fri, 2019-07-26 at 09:48 -0700, Bart Van Assche wrote: If scsi_target_block() fails that can break the code that calls this function. Hence complain loudly if scsi_target_block() fails. Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Johannes Thums

Re: [PATCH 3/4] Complain if scsi_target_block() fails

2019-07-26 Thread James Bottomley
On Fri, 2019-07-26 at 09:48 -0700, Bart Van Assche wrote: > If scsi_target_block() fails that can break the code that calls this > function. Hence complain loudly if scsi_target_block() fails. > > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > Cc: Ming Lei > Signed-off-