Re: [PATCH v2 08/12] qla2xxx: Add framework for Async fabric discovery.

2017-01-17 Thread Bart Van Assche
On Mon, 2017-01-16 at 12:35 -0800, Himanshu Madhani wrote: > + /* > + * return FC_CTELS_STATUS_OK and leave the decoding of the ELS/CT > + * fc payload to the caller > + */ > + > + bsg_reply->reply_data.ctels_reply.status = FC_CTELS_STATUS_OK; > +

Re: [PATCH v2 08/12] qla2xxx: Add framework for Async fabric discovery.

2017-01-17 Thread Madhani, Himanshu
On 1/17/17, 2:27 PM, "Bart Van Assche" wrote: >%phC Yes. It looks like typo in the message. Will update this patch with other sparse warnings fixes. Thanks, Himanshu >

Re: [PATCH v2 08/12] qla2xxx: Add framework for Async fabric discovery.

2017-01-17 Thread Bart Van Assche
On Mon, 2017-01-16 at 12:35 -0800, Himanshu Madhani wrote: > -   kref_get(>sess_kref); > +   if (!kref_get_unless_zero(>sess_kref)) { > +   ql_dbg(ql_dbg_tgt_tmr, vha, 0x, > +   "%s: kref_get fail %8pHC \n", > +

Re: [PATCH v2 08/12] qla2xxx: Add framework for Async fabric discovery.

2017-01-17 Thread Bart Van Assche
On Mon, 2017-01-16 at 12:35 -0800, Himanshu Madhani wrote: > /* > * Adds an extra ref to allow to drop hw lock after adding sess to the list. > * Caller must put it. > @@ -839,93 +1103,65 @@ static struct fc_port *qlt_create_sess( > bool local) > { > struct qla_hw_data *ha =

Re: [PATCH v2 08/12] qla2xxx: Add framework for Async fabric discovery.

2017-01-17 Thread Bart Van Assche
On Mon, 2017-01-16 at 12:35 -0800, Himanshu Madhani wrote: > -static void > +void > qla2x00_async_iocb_timeout(void *data) > { > srb_t *sp = (srb_t *)data; > fc_port_t *fcport = sp->fcport; > + struct srb_iocb *lio = >u.iocb_cmd; > + struct event_arg ea; > >