Re: [patch] sg: clean up gfp_mask in sg_build_indirect

2018-06-18 Thread Martin K. Petersen
Jeff, > And there's only one user of the gfp_mask. Just or in the __GFP_ZERO > flag at the top of the function and be done with it. Applied to 4.19/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [patch] sg: clean up gfp_mask in sg_build_indirect

2018-06-18 Thread Douglas Gilbert
On 2018-06-18 09:57 AM, Jeff Moyer wrote: commit a45b599ad808c ("scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()") changed the call to alloc_pages to always use __GFP_ZERO. Just above that, though, there was this: if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO))