[PATCH V6 3/5] virtio-scsi: push vq lock/unlock into virtscsi_vq_done

2013-03-20 Thread Wanlong Gao
From: Paolo Bonzini pbonz...@redhat.com Avoid duplicated code in all of the callers. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 22

[PATCH V6 4/5] virtio-scsi: introduce multiqueue support

2013-03-20 Thread Wanlong Gao
From: Paolo Bonzini pbonz...@redhat.com This patch adds queue steering to virtio-scsi. When a target is sent multiple requests, we always drive them to the same queue so that FIFO processing order is kept. However, if a target was idle, we can choose a queue arbitrarily. In this case the queue

[PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-20 Thread Wanlong Gao
Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 29

[PATCH V6 0/5] virtio-scsi multiqueue

2013-03-20 Thread Wanlong Gao
This series implements virtio-scsi queue steering, which gives performance improvements of up to 50% (measured both with QEMU and tcm_vhost backends). This version rebased on Rusty's virtio ring rework patches, which has already gone into virtio-next today. We hope this can go into virtio-next

[PATCH V6 1/5] virtio-scsi: redo allocation of target data

2013-03-20 Thread Wanlong Gao
virtio_scsi_target_state is now empty. We will find new uses for it in the next few patches, so this patch does not drop it completely. And as James suggested, we use entries target_alloc and target_destroy in the host template to allocate and destroy the virtio_scsi_target_state of each target,

[PATCH V6 2/5] virtio-scsi: pass struct virtio_scsi to virtqueue completion function

2013-03-20 Thread Wanlong Gao
From: Paolo Bonzini pbonz...@redhat.com This will be needed soon in order to retrieve the per-target struct. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Asias He as...@redhat.com ---

Re: [PATCH V5 4/5] virtio-scsi: introduce multiqueue support

2013-03-20 Thread Wanlong Gao
On 03/20/2013 09:46 AM, Venkatesh Srinivas wrote: This looks pretty good! I rather like the (lack of) locking in I/O completion (around the req count vs. target/queue binding). It is unfortunate that you need to hold the per-target lock in virtscsi_pick_vq() though; have any idea how much

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-20 Thread Asias He
On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote: Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-20 Thread Wanlong Gao
On 03/20/2013 03:24 PM, Asias He wrote: On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote: Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong

Re: [PATCH V6 1/5] virtio-scsi: redo allocation of target data

2013-03-20 Thread Asias He
On Wed, Mar 20, 2013 at 03:01:20PM +0800, Wanlong Gao wrote: virtio_scsi_target_state is now empty. We will find new uses for it in the next few patches, so this patch does not drop it completely. And as James suggested, we use entries target_alloc and target_destroy in the host template to

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-20 Thread Wanlong Gao
On 03/20/2013 03:24 PM, Asias He wrote: On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote: Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong

Re: [PATCH V5 4/5] virtio-scsi: introduce multiqueue support

2013-03-20 Thread Paolo Bonzini
Il 20/03/2013 02:46, Venkatesh Srinivas ha scritto: This looks pretty good! I rather like the (lack of) locking in I/O completion (around the req count vs. target/queue binding). It is unfortunate that you need to hold the per-target lock in virtscsi_pick_vq() though; have any idea how much

Re: Kernel oops on st module cycling

2013-03-20 Thread Jean Delvare
Le jeudi 07 mars 2013 à 13:48 +0100, Jean Delvare a écrit : Hi Joe, Thanks for your fast answer. Le vendredi 22 février 2013 à 10:30 -0500, Joe Lawrence a écrit : I remember finding an st module load/unload kref accounting bug a while ago: http://thread.gmane.org/gmane.linux.scsi/77539

[PATCH V3 00/12] Support for PMC 8081/8088/8089 controllers

2013-03-20 Thread Anand
From ffe82b1efc42510239046909a7ac0aff10bb4162 Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Tue, 19 Mar 2013 18:32:55 +0530 Subject: [PATCH V3 00/12] Support for PMC 8081/8088/8089 controllers V3 Resubmission of patchset addressing Hannes comment on usage

[PATCH V3 01/12] pm80xx: fix for memory region free

2013-03-20 Thread Anand
From 700bfe79294e9f9e1a5def178af52b13928902a9 Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Mon, 4 Feb 2013 12:10:02 +0530 Subject: [PATCH V3 01/12] pm80xx: fix for memory region free All memory regions are allocated based on variables total_len and

[PATCH V3 02/12] pm80xx: Added SPCv/ve specific ids, variables and modify for SPC

2013-03-20 Thread Anand
From ef678e2188866af926f2a089719c24ec99e4e88c Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Wed, 27 Feb 2013 20:22:50 +0530 Subject: [PATCH V3 02/12] pm80xx: Added SPCv/ve specific ids, variables and modify for SPC Updated pci id table with device,

[PATCH V3 03/12] pm80xx: Multiple inbound/outbound queue configuration

2013-03-20 Thread Anand
From f0b469f372f1c1faa393123f4a3a5e93e05b8387 Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Wed, 27 Feb 2013 20:25:25 +0530 Subject: [PATCH V3 03/12] pm80xx: Multiple inbound/outbound queue configuration Memory allocation and configuration of multiple

[PATCH V3 07/12] pm80xx: SPC new firmware changes for device id 0x8081 alone

2013-03-20 Thread Anand
From 2ce3ecb52358fcd358e1ea93a02522084fc7f968 Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Tue, 19 Mar 2013 18:05:55 +0530 Subject: [PATCH V3 07/12] pm80xx: SPC new firmware changes for device id 0x8081 alone Additional bar shift for new SPC firmware,

[PATCH V3 08/12] pm80xx: Firmware flash memory free fix, with addition of new memory region for it

2013-03-20 Thread Anand
From 4043d1eb8813a2fc0656815fe2e6d21d4df0da66 Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Tue, 19 Mar 2013 18:06:40 +0530 Subject: [PATCH V3 08/12] pm80xx: Firmware flash memory free fix, with addition of new memory region for it Performing

[PATCH V3 09/12] pm80xx: Changed module name and debug messages update

2013-03-20 Thread Anand
From 8d5db4d3d00604c8dc3db6e616ed21e0c46bcbaf Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Tue, 19 Mar 2013 18:07:09 +0530 Subject: [PATCH V3 09/12] pm80xx: Changed module name and debug messages update Changed name in driver to pm80xx. Updated debug

[PATCH V3 10/12] pm80xx: WWN Modification for PM8081/88/89 controllers

2013-03-20 Thread Anand
From 6fb08e45a7272daecc4b8bdce643e40fd2062542 Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Tue, 19 Mar 2013 18:07:35 +0530 Subject: [PATCH V3 10/12] pm80xx: WWN Modification for PM8081/88/89 controllers Individual WWN read operations based on controller.

[PATCH V3 11/12] pm80xx: NCQ error handling changes

2013-03-20 Thread Anand
From 2738e0b59fe103a363b0ea600b3eccc687a7fa3c Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Tue, 19 Mar 2013 18:08:08 +0530 Subject: [PATCH V3 11/12] pm80xx: NCQ error handling changes Handled NCQ errors in the low level driver as the FW is not providing

[PATCH V3 12/12] pm80xx: thermal, sas controller config and error handling update

2013-03-20 Thread Anand
From ffe82b1efc42510239046909a7ac0aff10bb4162 Mon Sep 17 00:00:00 2001 From: Sakthivel K sakthivel.saravanankamalr...@pmcs.com Date: Tue, 19 Mar 2013 18:08:40 +0530 Subject: [PATCH V3 12/12] pm80xx: thermal, sas controller config and error handling update Modified thermal configuration to happen

Re: [PATCH V6 4/5] virtio-scsi: introduce multiqueue support

2013-03-20 Thread Venkatesh Srinivas
On Wed, Mar 20, 2013 at 03:01:23PM +0800, Wanlong Gao wrote: From: Paolo Bonzini pbonz...@redhat.com This patch adds queue steering to virtio-scsi. When a target is sent multiple requests, we always drive them to the same queue so that FIFO processing order is kept. However, if a target was

[PATCH 0/3] PCI: Handle device quirks when accessing sysfs resourceN entries

2013-03-20 Thread Myron Stowe
Xiangliang reported that a platform hangs after udevadm info --attribute-walk --path=/sys/devices/pci:00/.../block/sda is ran. He was then able to isolate the failure further to accesses involving a Marvell 9125 device's I/O BARs, or more specifically, accesses to I/O Port space backing the

[PATCH 2/3] PCI: Handle device quirks when accessing sysfs resourceN entries

2013-03-20 Thread Myron Stowe
Sysfs includes entries to memory regions that back a PCI device's BARs. The pci-sysfs entries backing I/O Port BARs can be accessed by userspace, providing direct access to the device's registers. File permissions prevent random users from accessing the device's registers through these files, but

[PATCH 3/3] PCI, scsi, ahci: Unify usages of 0x1b4b vendor ID to use PCI_VENDOR_ID_MARVELL_EXT

2013-03-20 Thread Myron Stowe
With the 0x1b4b vendor ID #define in place, convert hard-coded ID values. Also, unify the previous SCSI specific use of this vendor ID to the new macro. Signed-off-by: Myron Stowe myron.st...@redhat.com --- drivers/ata/ahci.c | 10 +- drivers/scsi/mvsas/mv_init.c |6

[PATCH 1/3] PCI: Define macro for Marvell vendor ID

2013-03-20 Thread Myron Stowe
From: Xiangliang Yu yuxia...@marvell.com Define PCI_VENDOR_ID_MARVELL_EXT macro for 0x1b4b vendor ID Signed-off-by: Xiangliang Yu yuxia...@marvell.com Signed-off-by: Myron Stowe myron.st...@redhat.com --- include/linux/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff