Re: [PATCHv3 0/9] New EH command timeout handler

2013-07-15 Thread Ren Mingxin
Hi, Hannes: On 07/12/2013 06:27 PM, Hannes Reinecke wrote: On 07/12/2013 12:00 PM, Ren Mingxin wrote: On 07/12/2013 02:09 PM, Hannes Reinecke wrote: On 07/12/2013 06:14 AM, Ren Mingxin wrote: On 07/01/2013 10:24 PM, Hannes Reinecke wrote: With the original SCSI EH I got: # time dd

Re: The pm80xx driver hangs in 3.10 with the Adaptec 71605H HBA

2013-07-15 Thread Jack Wang
Hi Hans, On 07/14/2013 10:45 AM, Hans Verkuil wrote: Hi Anand, On 07/12/2013 03:14 PM, Anand Kumar Santhanam wrote: Hans, I reviewed the code changes and I did not see major differences except for the fact that in adaptec driver we have 64 interrupt handlers to handle 64 MSI-X. This was

[PATCH] [SCSI] scsi_debug: silence GCC warning

2013-07-15 Thread Paul Bolle
Building scsi_debug.o triggers a GCC warning: drivers/scsi/scsi_debug.c: In function ‘dif_verify’: drivers/scsi/scsi_debug.c:1755:3: warning: ‘csum’ may be used uninitialized in this function [-Wmaybe-uninitialized] This is a false positive, but if we make scsi_debug_guard a bool, we

Re: [PATCH] pm80xx: fix Adaptec 71605H hang

2013-07-15 Thread Jack Wang
On 07/14/2013 10:25 AM, Hans Verkuil wrote: The IO command size is 128 bytes for these new controllers as opposed to 64 for the old 8001 controller. The Adaptec out-of-tree driver did this correctly. After comparing the two this turned out to be the crucial difference. Thanks Hans for this

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-07-15 Thread Ren Mingxin
Hi, Ewan: On 07/12/2013 09:30 PM, Ewan Milne wrote: On Fri, 2013-07-12 at 13:54 +0800, Ren Mingxin wrote: I'm wondering how do you test, with a special hardware or self-made module?Would you mind pasting your test method() and result? This was tested in a SAN environment with an EMC Symmetrix

[PATCH 3/4] scsi_debug: fix WRITE_SAME with virtual_gb 0

2013-07-15 Thread Akinobu Mita
With module parameter virtual_gb 0, the device accesses may go beyond the actual ramdisk storage (fake_storep). Such requests should be treated as fake_storep is repeatedly mirrored up to virtual size (virtual_gb * 1GB). Unfortunately, WRITE_SAME commands with such requests access out of

[PATCH 0/4] scsi_debug: fix bugs with certain module parameters

2013-07-15 Thread Akinobu Mita
This patch set includes bug fixes with certain module parameters of scsi_debug. First one fixes bug with num_parts 0. Others fix logical block provisioning support with unmap_alignment != 0 and with virtual_gb 0. Akinobu Mita (4): scsi_debug: fix endianness bug in sdebug_build_parts()

[PATCH 1/4] scsi_debug: fix endianness bug in sdebug_build_parts()

2013-07-15 Thread Akinobu Mita
With module parameter num_parts 0, partition table is built on the ramdisk storage when loading the driver. Unfortunately, there is an endianness bug in sdebug_build_parts(). So the partition table is not correctly initialized on big-endian systems. Signed-off-by: Akinobu Mita

[PATCH 4/4] scsi_debug: fix out of range access by Get_LBA_status with virtual_gb 0

2013-07-15 Thread Akinobu Mita
With logical block provisioning support enabled, the provisioning map (map_storep) keeps track of the provisioning status (mapped or unmapped) for actual ramdisk storage range (fake_storep). The provisioning status for out of fake_storep range with module parameter virtual_gb 0 is not tracked,

[PATCH 2/4] scsi_debug: fix logical block provisioning support when unmap_alignment != 0

2013-07-15 Thread Akinobu Mita
Commit b90ebc3d5c41c9164ae04efd2e4f8204c2a186f1 ([SCSI] scsi_debug: fix logical block provisioning support) fixed several issues with logical block provisioning support, but it still doesn't properly fix the cases when unmap_alignment 0. (for example, unmap_alignment=1 and unmap_granularity=3)

[PATCH][SCSI] megaraid_sas: megaraid_sas driver init fails in kdump kernel

2013-07-15 Thread Sumit.Saxena
Problem: When Hardware IOMMU is on, megaraid_sas driver initialization fails in kdump kernel with LSI MegaRAID controller(device id-0x73). This issue was reported to Redhat Bugzilla. Redhat bugzilla ID is 833299. Actually this issue needs fix in firmware, but for firmware running in field,

RE: The pm80xx driver hangs in 3.10 with the Adaptec 71605H HBA

2013-07-15 Thread Anand Kumar Santhanam
Hi Hans, Pls find responses inline. Regards Anand -Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Monday, July 15, 2013 2:24 PM To: Hans Verkuil Cc: Anand Kumar Santhanam; lindar_liu; linux-scsi@vger.kernel.org; jinpu.w...@profitbricks.com Subject: Re: The pm80xx

Re: The pm80xx driver hangs in 3.10 with the Adaptec 71605H HBA

2013-07-15 Thread Jack Wang
Hi Anand, On 07/15/2013 02:37 PM, Anand Kumar Santhanam wrote: Hi Hans, Pls find responses inline. Regards Anand -Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Monday, July 15, 2013 2:24 PM To: Hans Verkuil Cc: Anand Kumar Santhanam; lindar_liu;

Re: The pm80xx driver hangs in 3.10 with the Adaptec 71605H HBA

2013-07-15 Thread Hans Verkuil
Hi Anand! On 07/15/2013 02:37 PM, Anand Kumar Santhanam wrote: Hi Hans, Pls find responses inline. Regards Anand -Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Monday, July 15, 2013 2:24 PM To: Hans Verkuil Cc: Anand Kumar Santhanam; lindar_liu;

[PATCH v2] [SCSI] scsi_debug: silence GCC warning

2013-07-15 Thread Paul Bolle
Building scsi_debug.o triggers a GCC warning: drivers/scsi/scsi_debug.c: In function ‘dif_verify’: drivers/scsi/scsi_debug.c:1755:3: warning: ‘csum’ may be used uninitialized in this function [-Wmaybe-uninitialized] This is a false positive. But if we transform the switch statement in

Re: [PATCH v2 1/1] [SCSI] sg: fix race condition when do exclusive open

2013-07-15 Thread Jörn Engel
On Sun, 7 July 2013 01:24:44 +0800, vaughan wrote: Do you agree that I use a per device spin_lock 'sfd_lock' to protect sfds list and leave sg_index_lock only protect the global sg device lookup? I think it's reasonable for concurrency. That bit looks fine to me. I don't think it matters

Re: Linux Plumbers IO File System Micro-conference

2013-07-15 Thread Ric Wheeler
On 07/12/2013 01:42 PM, faibish, sorin wrote: Can we have a discussion on Lustre client in the kernel? Thanks ./Sorin I am not sure that we have that much to do for Lustre on the client side. Is this a topic that would be of broad enough interest to include people outside of the kernel

Re: [PATCH v3 1/1] [SCSI] sg: fix race condition when do exclusive open

2013-07-15 Thread Jörn Engel
On Mon, 8 July 2013 03:53:49 +0800, vaughan wrote: Use rwsem to aid opens. Exclusive open has to get write lock and non-exclusive open should get read lock. Replace global sg_open_exclusive_lock with a per device lock - sfd_lock. Since sfds list is now protected by the lock owned by the

[PATCH 0/13] lpfc 8.3.41: Update lpfc to revision 8.3.41

2013-07-15 Thread James Smart
This patch set updates the lpfc driver to revision 8.3.41 The patches for 8.3.41 contain: - Fixed freeing of iocb when internal loopback times out - Fix mailbox byteswap issue on PPC - Fixed Receive Queue varied frame size handling - Fixed max value of lpfc_lun_queue_depth - Ensure driver

[PATCH 1/13] lpfc 8.3.41: Fixed freeing of iocb when internal loopback times out

2013-07-15 Thread James Smart
Fixed freeing of iocb when internal loopback times out Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_bsg.c |8 +--- lpfc_scsi.c |2 +- lpfc_sli.c | 51 +-- lpfc_sli.h |5 - 4 files changed, 55

[PATCH 2/13] lpfc 8.3.41: Fix mailbox byteswap issue on PPC

2013-07-15 Thread James Smart
Fix mailbox byteswap issue on PPC Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c |1 - 1 file changed, 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c 2013-07-15 07:15:01.997055473 -0400

[PATCH 3/13] lpfc 8.3.41: Fixed Receive Queue varied frame size handling

2013-07-15 Thread James Smart
Fixed Receive Queue varied frame size handling Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c ---

[PATCH 5/13] lpfc 8.3.41: Ensure driver properly zeros unused fields in SLI4 mailbox commands

2013-07-15 Thread James Smart
Ensure driver properly zeros unused fields in SLI4 mailbox commands Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_mbox.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers/scsi/lpfc/lpfc_mbox.c ---

[PATCH 6/13] lpfc 8.3.41: Fixed support for 128 byte WQEs

2013-07-15 Thread James Smart
Fixed support for 128 byte WQEs Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hw4.h | 13 + lpfc_init.c |1 + lpfc_sli.c | 48 +--- lpfc_sli4.h |6 ++ 4 files changed, 65 insertions(+), 3 deletions(-)

[PATCH 4/13] lpfc 8.3.41: Fixed max value of lpfc_lun_queue_depth

2013-07-15 Thread James Smart
Fixed max value of lpfc_lun_queue_depth Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c |9 ++--- lpfc_init.c | 34 -- lpfc_sli.c | 11 +++ lpfc_vport.c |3 +++ 4 files changed, 44 insertions(+), 13 deletions(-)

[PATCH 8/13] lpfc 8.3.41: Fixed failure in setting SLI3 board mode

2013-07-15 Thread James Smart
Fixed failure in setting SLI3 board mode Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c |3 --- 1 file changed, 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2013-07-15

[PATCH 7/13] lpfc 8.3.41: Fixed SLI3 failing FCP write on check-condition no-sense with residual zero

2013-07-15 Thread James Smart
Fixed SLI3 failing FCP write on check-condition no-sense with residual zero Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c ---

[PATCH 9/13] lpfc 8.3.41: Fixed not able to perform PCI function reset when board was not in online mode

2013-07-15 Thread James Smart
Fixed not able to perform PCI function reset when board was not in online mode Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c

[PATCH 11/13] lpfc 8.3.41: Fixed the format of some log message fields

2013-07-15 Thread James Smart
Fixed the format of some log message fields Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_ct.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c --- a/drivers/scsi/lpfc/lpfc_ct.c 2013-07-15

[PATCH 10/13] lpfc 8.3.41: Add first burst support to driver

2013-07-15 Thread James Smart
Add first burst support to driver Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |1 + lpfc_attr.c | 11 +++ lpfc_disc.h |1 + lpfc_els.c |2 ++ lpfc_nportdisc.c | 12 ++-- lpfc_scsi.c |5 + 6 files changed,

[PATCH 13/13] lpfc 8.3.41: Update lpfc version to driver version 8.3.41

2013-07-15 Thread James Smart
Update lpfc version to driver version 8.3.41 Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h ---

[PATCH 12/13] lpfc 8.3.41: Update copyrights for 8.3.41 modifications

2013-07-15 Thread James Smart
Update copyrights for 8.3.41 modifications Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_disc.h |2 +- lpfc_sli.h |2 +- lpfc_vport.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_disc.h

[PATCH] drivers/scsi/fnic: updated fileoperations structure to use simple_open

2013-07-15 Thread Dragos Foianu
The function has the same implementation as simple_open. I removed it and replaced the reference in the fileoperations struct with simple_open. Found using Coccinelle. Signed-off-by: Dragos Foianu dragos.foi...@gmail.com --- drivers/scsi/fnic/fnic_debugfs.c | 19 +-- 1 file