-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Sudip Mukherjee
Sent: Thursday, October 30, 2014 12:55 AM
To: Fabian Frederick
Cc: linux-ker...@vger.kernel.org; Stephen M. Cameron; James E.J.
Bottomley;
On Thu, Oct 30, 2014 at 06:28:13AM +, Elliott, Robert (Server Storage)
wrote:
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Sudip Mukherjee
Sent: Thursday, October 30, 2014 12:55 AM
To: Fabian Frederick
On 10/27/2014 06:26 AM, Finn Thain wrote:
Static variables from dtc.c and pas16.c should not appear in the core
NCR5380.c driver. Aside from being a layering issue this worsens the
divergence between the three core driver variants (atari_NCR5380.c and
sun3_NCR5380.c don't support PSEUDO_DMA)
On 10/27/2014 06:26 AM, Finn Thain wrote:
The *_RELEASE macros don't tell me anything. In some cases the version in
the macro contradicts the version in the comments. Anyway, the Linux kernel
version is sufficient information. Remove these macros to improve readability.
Signed-off-by: Finn
On 10/27/2014 06:26 AM, Finn Thain wrote:
Convert Scsi_Cmnd to struct scsi_cmnd and drop the #include scsi.h.
The sun3_NCR5380.c core driver already uses struct scsi_cmnd so converting
the other core drivers reduces the diff which makes them easier to unify.
Signed-off-by: Finn Thain
On 10/27/2014 06:26 AM, Finn Thain wrote:
Testing shows that the Domex 3191D card never asserts its IRQ. Hence it is
non-functional with Linux (worse, the EH bugs in the core driver are fatal
but that's a problem for another patch). Perhaps the DT-536 chip needs
special setup? I can't find
On 10/27/2014 06:26 AM, Finn Thain wrote:
The #defines in mac_scsi.h are intended to influence subsequent #includes in
mac_scsi.c. IMHO, that's too convoluted.
Remove mac_scsi.h by moving those macro definitions to mac_scsi.c,
consistent with other NCR5380 drivers.
Signed-off-by: Finn
On 10/27/2014 06:26 AM, Finn Thain wrote:
Allow mac_scsi to be built as a module. Replace the old validation of
__setup options with code that validates both module and __setup options.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/Kconfig|2
On 10/27/2014 06:26 AM, Finn Thain wrote:
Fix whitespace, remove pointless volatile qualifiers and improve code style
by use of INPUT_DATA_REG and OUTPUT_DATA_REG macros.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/mac_scsi.c | 122
On 10/27/2014 06:26 AM, Finn Thain wrote:
Convert mac_scsi to platform device and eliminate scsi_register().
Platform resources for chip registers now follow the documentation. This
should fix issues with the Mac IIci (and possibly other models too).
Signed-off-by: Finn Thain
On 10/27/2014 06:26 AM, Finn Thain wrote:
Don't disable irqs when waiting for the ST DMA lock; its release may
require an interrupt.
Introduce stdma_try_lock() for use in soft irq context. atari_scsi now tells
the SCSI mid-layer to defer queueing a command if the ST DMA lock is not
On 10/27/2014 06:26 AM, Finn Thain wrote:
Convert atari_scsi to platform device and eliminate scsi_register().
Validate __setup options later on so that module options are checked as well.
Remove the comment about the scsi mid-layer disabling the host irq as it
is no longer true (AFAICT).
On Wed, Oct 29, 2014 at 04:16:08PM -0500, Brian King wrote:
I think we can likely drop the first in the series here. I've reverted it
and have been running abort testing for a bit and haven't hit any issues.
Unless I see anything overnight, I'll resend the second patch by itself and
cc stable.
On 10/27/2014 06:26 AM, Finn Thain wrote:
The #defines in atari_scsi.h are intended to influence subsequent #includes
in atari_scsi.c. IMHO, that's too convoluted.
Remove atari_scsi.h by moving those macro definitions to atari_scsi.c,
consistent with other NCR5380 drivers.
Signed-off-by:
On 10/27/2014 06:26 AM, Finn Thain wrote:
Convert sun3_scsi to platform device and eliminate scsi_register().
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries Storage
h...@suse.de
On 10/27/2014 06:26 AM, Finn Thain wrote:
The #defines in sun3_scsi.h are intended to influence subsequent #includes
in sun3_scsi.c. IMHO, that's too convoluted.
Move sun3_scsi.h macro definitions to sun3_scsi.c, consistent with other
NCR5380 drivers.
Omit the unused
On 10/27/2014 06:26 AM, Finn Thain wrote:
atari_NCR5380.c enables its IRQ when it is already enabled. Sun3 doesn't
use the ENABLE_IRQ/DISABLE_IRQ cruft. Remove it.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Cheers,
Hannes
--
Dr. Hannes
On 10/27/2014 06:26 AM, Finn Thain wrote:
Make the atari_NCR5380.c core driver usable by sun3_scsi, mac_scsi and
others by moving some of the Falcon-specific code out of the core driver:
!IS_A_TT, atari_read_overruns and falcon_dont_release. Replace these with
hostdata variables and flags.
On 10/27/2014 06:26 AM, Finn Thain wrote:
Simplify falcon_release_lock_if_possible() by making callers responsible for
disabling local IRQ's, which they must do anyway to correctly synchronize
the ST DMA lock with core driver data structures. Move this
synchronization logic to the core driver
On 10/27/2014 06:26 AM, Finn Thain wrote:
There is very little difference between the sun3_NCR5380.c core driver
and atari_NCR5380.c. The former is a fork of the latter.
Merge the sun3_NCR5380.c core driver into atari_NCR5380.c so that
sun3_scsi.c can adopt the latter and the former can be
On 10/27/2014 06:26 AM, Finn Thain wrote:
Given the preceding changes to atari_NCR5380.c, this patch should not change
behaviour of the sun3_scsi and sun3_scsi_vme modules.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
One down. Good work.
Reviewed-by: Hannes Reinecke h...@suse.de
On 10/27/2014 06:26 AM, Finn Thain wrote:
The NCR5380.c core driver has moved on since atari_NCR5380.c was forked.
Some of those changes are also relevant to atari_NCR5380.c so apply them
there as well.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke
On 10/27/2014 06:26 AM, Finn Thain wrote:
The static variable setup_use_tagged_queuing is declared in mac_scsi.c,
sun3_scsi.c and atari_scsi.c and doesn't belong in the core driver.
None of the other NCR5380 drivers suffer from this layering issue which
makes merging the core drivers more
On 10/27/2014 06:26 AM, Finn Thain wrote:
The atari_NCR5380.c core driver keeps some per-host data in a static
variable which limits the driver to a single instance. Fix this by moving
TagAlloc to the hostdata struct.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Hmm. This really
On 10/27/2014 06:26 AM, Finn Thain wrote:
Unlike NCR5380.c, the atari_NCR5380.c core driver is limited to a single
instance because co-routine state is stored globally.
Fix this by removing the static scsi host pointer. For the co-routine,
obtain this pointer from the work_struct pointer
On 10/30/2014 08:46 AM, Hannes Reinecke wrote:
On 10/27/2014 06:26 AM, Finn Thain wrote:
Fix whitespace, remove pointless volatile qualifiers and improve code style
by use of INPUT_DATA_REG and OUTPUT_DATA_REG macros.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
On Wed, Oct 29, 2014 at 12:34:49PM -0500, Brian King wrote:
Acked-by: Brian King brk...@linux.vnet.ibm.com
Doesn't apply to me.
Brain, can you please resend a rebased version of these two patches with
ipr error handlign patch (and anything else ipr related)?
--
To unsubscribe from this list:
Move all code to set up and tear down sdev-scsi_dh_data to common code.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/device_handler/scsi_dh.c | 29 ++
drivers/scsi/device_handler/scsi_dh_alua.c | 59
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/device_handler/scsi_dh.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh.c
All drivers now do their own matching, so there is no more need to expose
a device list as part of the interface.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/device_handler/scsi_dh_emc.c | 6 --
We need to grab a reference to the module before calling the attach
routines to avoid a small race vs module removal. It also cleans up
the code significantly as a side effect.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
---
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/device_handler/scsi_dh_hp_sw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_hp_sw.c
b/drivers/scsi/device_handler/scsi_dh_hp_sw.c
This series (against the core-for-3.19 branch) deals with various
issues realated to scsi-ioctls, mostly with the SG_SCSI_RESET ioctl.
Changes since V1:
- fix scsi_ioctl_reset return value, pointed out by Bart Van Assche
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/osst.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index b6d63d6..8c38464 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -3327,19 +3327,18
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/st.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 7d2e036..e46e02b2 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -861,17 +861,16 @@ static
No need to verify the passthrough ioctls, the real handler will
take care of that. Also make sure not to block for resets on
O_NONBLOCK fds.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/sd.c | 28
1 file changed, 8 insertions(+), 20 deletions(-)
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/scsi_ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_ioctl.c b/drivers/scsi/scsi_ioctl.c
index 712f159..c4f7b56 100644
--- a/drivers/scsi/scsi_ioctl.c
+++ b/drivers/scsi/scsi_ioctl.c
@@
On 10/30/2014 10:27 AM, Christoph Hellwig wrote:
Pull the common code from the two callers into the function,
and renamed it to scsi_ioctl_reset.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 10/30/2014 10:27 AM, Christoph Hellwig wrote:
No need to verify the passthrough ioctls, the real handler will
take care of that. Also make sure not to block for resets on
O_NONBLOCK fds.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
Cheers,
On Thu, Oct 30, 2014 at 10:39:46AM +0100, Hannes Reinecke wrote:
Enumeration appears to be skewed; two patches with 3/6 but none with
5/6 ...
Everything seems correct in my linux-scsi folder.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to
On Wed, Oct 29, 2014 at 09:08:46AM -0600, Jens Axboe wrote:
Another test server with MPT SCSI RAID has similar problem,
scsi_mode.use_blk_mq=0 cures it but I can not get good trace (no serail
console). 3.18.0-rc2-00043-gf7e87a4 was tested there.
The first issue looks like scsi cdrom
On 10/30/2014 04:11 AM, Christoph Hellwig wrote:
On Wed, Oct 29, 2014 at 12:34:49PM -0500, Brian King wrote:
Acked-by: Brian King brk...@linux.vnet.ibm.com
Doesn't apply to me.
Brain, can you please resend a rebased version of these two patches with
ipr error handlign patch (and anything
Allow a SCSI LLD to declare how many hardware queues it supports
by setting Scsi_Host.nr_hw_queues before calling scsi_add_host().
Signed-off-by: Bart Van Assche bvanass...@acm.org
Reviewed-by: Sagi Grimberg sa...@mellanox.com
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
---
Modify scsi_find_tag() and scsi_host_find_tag() such that these
functions can translate a tag generated by blk_mq_unique_tag().
Signed-off-by: Bart Van Assche bvanass...@acm.org
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Sagi Grimberg
Attempting to connect three times may be insufficient after an
initiator system tries to relogin, especially if the relogin
attempt occurs before the SRP target service ID has been
registered. Since the srp_daemon retries a failed login attempt
anyway, remove the stale connection retry mechanism.
The patch that adds multichannel support into the SRP initiator
driver introduces an additional call to srp_free_ch_ib(). This
patch helps to keep that later patch simple.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Reviewed-by: Sagi Grimberg sa...@mellanox.com
Cc: Sebastian Parschauer
If a cable is pulled during LUN scanning it can happen that the
SRP rport and the SCSI host have been created but no LUNs have been
added to the SCSI host. Since multipathd only sends SCSI commands
to a SCSI target if one or more SCSI devices are present and since
there is no keepalive mechanism
Introduce the srp_target_port member variables 'sgid' and 'pkey'.
Change the type of 'orig_dgid' from __be16[8] into union ib_gid.
This patch does not change any functionality but makes the
Separate target and channel variables patch easier to verify.
Signed-off-by: Bart Van Assche
Changes in this patch:
- Move channel variables into a new structure (struct srp_rdma_ch).
- Add an srp_target_port pointer, 'lock' and 'comp_vector' members
in struct srp_rdma_ch.
- Add code to initialize these three new member variables.
- Many boring target- into ch- changes.
- The cm_id and
Since the block layer already contains functionality to assign
a tag to each request, use that functionality instead of
reimplementing that functionality in the SRP initiator driver.
This change makes the free_reqs list superfluous. Hence remove
that list.
Signed-off-by: Bart Van Assche
Improve performance by using multiple RDMA/RC channels per SCSI
host for communication with an SRP target. About the
implementation:
- Introduce a loop over all channels in the code that uses
target-ch.
- Set the SRP_MULTICHAN_MULTI flag during login for the creation
of the second and
At least LID reassignment can trigger a race condition in the SRP
initiator driver, namely the receive completion handler trying to
post a request on a QP during or after QP destruction and before
the CQ's have been destroyed. Avoid this race by modifying a QP
into the error state and by waiting
Although the SRP protocol supports multichannel operation, although
since considerable time RDMA HCA's are available that support multiple
completion vectors and although multichannel operation yields better
performance than using a single channel, the Linux SRP initiator does
not yet support
On 10/29/2014 12:52 PM, Bart Van Assche wrote:
On 10/28/14 19:32, Sagi Grimberg wrote:
On 10/21/2014 12:10 PM, Sagi Grimberg wrote:
On 10/20/2014 3:56 PM, Bart Van Assche wrote:
On 10/19/14 19:36, Sagi Grimberg wrote:
On 10/7/2014 4:07 PM, Bart Van Assche wrote:
* comp_vector, a
On 10/29/2014 2:36 PM, Bart Van Assche wrote:
On 10/21/14 11:14, Sagi Grimberg wrote:
On 10/7/2014 4:07 PM, Bart Van Assche wrote:
spin_lock_irqsave(ch-lock, flags);
ch-req_lim += be32_to_cpu(rsp-req_lim_delta);
@@ -1906,7 +1970,7 @@ static int
On 10/30/2014 3:50 PM, Bart Van Assche wrote:
At least LID reassignment can trigger a race condition in the SRP
initiator driver, namely the receive completion handler trying to
post a request on a QP during or after QP destruction and before
the CQ's have been destroyed. Avoid this race by
On 10/30/2014 3:47 PM, Bart Van Assche wrote:
If a cable is pulled during LUN scanning it can happen that the
SRP rport and the SCSI host have been created but no LUNs have been
added to the SCSI host. Since multipathd only sends SCSI commands
to a SCSI target if one or more SCSI devices are
On 10/30/2014 3:48 PM, Bart Van Assche wrote:
Since the block layer already contains functionality to assign
a tag to each request, use that functionality instead of
reimplementing that functionality in the SRP initiator driver.
This change makes the free_reqs list superfluous. Hence remove
that
On 10/30/14 15:19, Sagi Grimberg wrote:
My impression here that in the default settings, on a 1 NUMA node with
8 cores, 2 different srp connections (using 4 channels each) will be
associated with comp vectors 0-3. while it could potentially use
vectors 4-7 and reduce possible mutual
On 10/30/14 15:26, Sagi Grimberg wrote:
On 10/30/2014 3:50 PM, Bart Van Assche wrote:
+/* Destroying a QP and reusing ch-done is only safe if not
connected */
+WARN_ON_ONCE(target-connected);
I thought we agreed that cannot happen. I guess I don't mind keeping
it... BTW, were you able
On 10/30/2014 4:36 PM, Bart Van Assche wrote:
On 10/30/14 15:19, Sagi Grimberg wrote:
My impression here that in the default settings, on a 1 NUMA node with
8 cores, 2 different srp connections (using 4 channels each) will be
associated with comp vectors 0-3. while it could potentially use
On 10/30/2014 4:53 PM, Bart Van Assche wrote:
On 10/30/14 15:26, Sagi Grimberg wrote:
On 10/30/2014 3:50 PM, Bart Van Assche wrote:
+/* Destroying a QP and reusing ch-done is only safe if not
connected */
+WARN_ON_ONCE(target-connected);
I thought we agreed that cannot happen. I
On 10/30/14 16:06, Sagi Grimberg wrote:
I'm not aware of any implicit interrupt coalescing effect...
In case it was not clear what I was referring to: if multiple completion
queue handling routines run on the same CPU then the average number of
work completions processed by each completion
Meelis,
can you try the patch below? It's a hack and not a proper fix, but it
addresses what seems to be your culprit, given that it is the only
place allocating a request from the error handler.
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index fa7b5ec..5804ea0 100644
On 10/29/2014 10:15 AM, Fabian Frederick wrote:
Fix -Wunused-but-set-variable warning
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/scsi/hpsa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index
On Thu, Oct 30, 2014 at 10:21:05AM -0500, Don Brace wrote:
I can add this patch to my current set of patches for 3.19 or ack this now,
What would you prefer?
Please queue it up, I'm much more interested in reducing the massive
backlog of real hpsa changes than in litte cleanups at the moment.
On 10/30/2014 5:19 PM, Bart Van Assche wrote:
On 10/30/14 16:06, Sagi Grimberg wrote:
I'm not aware of any implicit interrupt coalescing effect...
In case it was not clear what I was referring to: if multiple completion
queue handling routines run on the same CPU then the average number of
can you try the patch below? It's a hack and not a proper fix, but it
addresses what seems to be your culprit, given that it is the only
place allocating a request from the error handler.
Applied it on top of 3.18-rc2, booted with scsi_mod.use_blk_mq=1 and it
booted up fine.
diff --git
On Thu, Oct 30, 2014 at 07:32:52PM +0200, Meelis Roos wrote:
can you try the patch below? It's a hack and not a proper fix, but it
addresses what seems to be your culprit, given that it is the only
place allocating a request from the error handler.
Applied it on top of 3.18-rc2, booted
From: Anton Blanchard an...@samba.org
Even though the ipr driver is only used on PCI, convert it
to use the generic DMA API.
Signed-off-by: Anton Blanchard an...@samba.org
Signed-off-by: Brian King brk...@linux.vnet.ibm.com
---
drivers/scsi/ipr.c | 103
From: Anton Blanchard an...@samba.org
Use dma_set_mask_and_coherent() to set both the DMA and coherent
DMA mask.
Signed-off-by: Anton Blanchard an...@samba.org
Signed-off-by: Brian King brk...@linux.vnet.ibm.com
---
drivers/scsi/ipr.c | 11 ++-
1 file changed, 6 insertions(+), 5
Fixes a race condition in abort handling that was injected
when multiple interrupt support was added. When only a single
interrupt is present, the adapter guarantees it will send
responses for aborted commands prior to the response for the
abort command itself. With multiple interrupts, these
72 matches
Mail list logo
