Re: [PATCH v4 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

2015-04-09 Thread Hannes Reinecke
On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: Kconfig for kbuild Makefile to build snic module Updated MAINTAINERS file Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes

[PATCH v4 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

2015-04-09 Thread Narsimhulu Musini
Kconfig for kbuild Makefile to build snic module Updated MAINTAINERS file Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- * v3 - Added additional config section (CONFIG_SNIC_DEBUG_FS) for enabling debugging functionality. * v2 - Added

Re: [PATCH v4 6/9] snic:Add low level queuing interfaces

2015-04-09 Thread Hannes Reinecke
Hi Narsimhulu, please find my comment at the bottom. On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: These files contain low level queueing interfaces includes hardware queues, and management of hardware features. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar

Re: [PATCH v4 5/9] snic:add SCSI handling, AEN, and fwreset handling

2015-04-09 Thread Hannes Reinecke
Hi Narsimhulu, please find some comments inline. On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: snic_scsi.c contains scsi handling, includes queuing io, abort, lun reset, and host reset. Also it handles asynchronous event notifications from FW. Signed-off-by: Narsimhulu Musini

Re: [PATCH v4 4/9] snic:Add snic target discovery

2015-04-09 Thread Hannes Reinecke
Hi Narsimhulu, please find some comments inline. On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: snic_disc.h contains snic target structure definition. snic_disc.c contains target discovery, setup, lookup, and cleanup snic_ctl.c contains retrieval of snic capabilities includes max ios,

Re: [PATCH v4 3/9] snic:Add meta request, handling of meta requests.

2015-04-09 Thread Hannes Reinecke
On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: snic_io.h contains meta request structure definition meta request contains high level information about firmware requests. such as request information, size, SGLs. snic_io.c contains interfaces to handle meta request, firmware acknowledgment,

Re: [PATCH v4 2/9] snic:Add interrupt, resource firmware interfaces

2015-04-09 Thread Hannes Reinecke
On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: snic_fwint.h contains firmware interface structures. snic_res.h contains firmware request initialization snic_res.c contains retrieval of resource configuration, and allocation, and initialization of HW Queues. snic_isr.c contains

[PATCH v4 4/9] snic:Add snic target discovery

2015-04-09 Thread Narsimhulu Musini
snic_disc.h contains snic target structure definition. snic_disc.c contains target discovery, setup, lookup, and cleanup snic_ctl.c contains retrieval of snic capabilities includes max ios, size, SGs per request, and max concurrent requests. Signed-off-by: Narsimhulu Musini nmus...@cisco.com

[PATCH v4 1/9] snic: snic module infrastructure

2015-04-09 Thread Narsimhulu Musini
snic_main.c contains module load and unload, global driver context, PCI Registration, PCI probe and remove, SCSI ML registration functionality. snic.h contains snic structure definition, snic global context, and prototypes. snic_attrs.c contains device attributes to list snic state, link state,

[PATCH v4 0/9] snic:initial submission of snic driver for Cisco SCSI HBA

2015-04-09 Thread Narsimhulu Musini
The following patch series adds snic driver for Cisco SCSI HBA Cisco has developed a new PCI HBA interface called sNIC, which stands for SCSI NIC. This is a new storage feature supported on specialized network adapter. The new PCI function provides a uniform host interface and abstracts backend

[PATCH v4 3/9] snic:Add meta request, handling of meta requests.

2015-04-09 Thread Narsimhulu Musini
snic_io.h contains meta request structure definition meta request contains high level information about firmware requests. such as request information, size, SGLs. snic_io.c contains interfaces to handle meta request, firmware acknowledgment, and high level generic queueing interface.

[PATCH v4 6/9] snic:Add low level queuing interfaces

2015-04-09 Thread Narsimhulu Musini
These files contain low level queueing interfaces includes hardware queues, and management of hardware features. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- * v3 - Cleaned up unused functions. * v2 - driver supports x86-64 arch, so

[PATCH v4 5/9] snic:add SCSI handling, AEN, and fwreset handling

2015-04-09 Thread Narsimhulu Musini
snic_scsi.c contains scsi handling, includes queuing io, abort, lun reset, and host reset. Also it handles asynchronous event notifications from FW. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- * v2 - Changed queuecommand to lock-free

[PATCH v4 2/9] snic:Add interrupt, resource firmware interfaces

2015-04-09 Thread Narsimhulu Musini
snic_fwint.h contains firmware interface structures. snic_res.h contains firmware request initialization snic_res.c contains retrieval of resource configuration, and allocation, and initialization of HW Queues. snic_isr.c contains interrupt request, release, and handling Signed-off-by:

[PATCH 11/14] qla2xxx: Prevent multiple firmware dump collection for ISP27XX.

2015-04-09 Thread Himanshu Madhani
For ISP27XX, driver will capture new firmware dump even if there is one already collected. Prevent this from happening by checking fw_dumped flag. Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com ---

[PATCH 06/14] qla2xxx: Add message for sucessful FW dump collected for ISP27XX.

2015-04-09 Thread Himanshu Madhani
o Added message indicating firmware dump was sucessfully collected for ISP27XX. o Improve logging to help debug firmware dump process for ISP27XX. Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com ---

[PATCH 10/14] qla2xxx: Disable Interrupt handshake for ISP27XX.

2015-04-09 Thread Himanshu Madhani
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_def.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h

[PATCH 03/14] qla2xxx: Increase the wait time for firmware to be ready for P3P.

2015-04-09 Thread Himanshu Madhani
From: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_init.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git

re: ufs: add ioctl interface for query request

2015-04-09 Thread Dan Carpenter
Hello Dolev Raviv, The patch 4aca8e8975db: ufs: add ioctl interface for query request from Mar 12, 2015, leads to the following Smatch warning: drivers/scsi/ufs/ufshcd.c:4386 ufshcd_query_ioctl() warn: maybe return -EFAULT instead of the bytes remaining?

Re: [PATCH 15/21] lpfc: Implement support for wire-only DIF devices

2015-04-09 Thread Martin K. Petersen
James == James Smart james.sm...@emulex.com writes: James fyi - in the v3 of the lpfc 10.5.0.0 patches I just posted, I James pulled the patch. We will see what to do with it. We may come James back with a set of generic midlayer patches. We already have a DIF blacklist. We could have an

Re: [PATCH] scsi_transport_fc: Add support for 25Gbit speed

2015-04-09 Thread Hannes Reinecke
On 04/02/2015 09:50 PM, James Smart wrote: Add FC transport support for 25Gbit speed Signed-off-by: James Smart james.sm...@emulex.com Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes ReineckezSeries Storage h...@suse.de

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-09 Thread Wolfram Sang
It doesn't really matter that the error codes are different, it matters that they are meaningful. As much as possible you should pass error codes from the lower layers. parport_claim_or_block() and i2c_bit_add_bus() return proper error codes so you should record and transmit them. Oh,

Re: [PATCH 5/6] ipr: AF DASD raw mode implementation in ipr driver

2015-04-09 Thread James Bottomley
On Thu, 2015-03-26 at 11:23 -0500, Brian King wrote: From: Wen Xiong wenxi...@linux.vnet.ibm.com This patch implements raw mode support for AF DASD in ipr driver which allows for tools to send commands directly to physical devices which are members of RAID arrays when enabled in the

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-09 Thread Jean Delvare
On Thu, 9 Apr 2015 09:13:07 +0200, Wolfram Sang wrote: On Wed, Apr 08, 2015 at 04:50:38PM +0530, Sudip Mukherjee wrote: now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee

[PATCH 08/14] qla2xxx: Add serdes read/write support for ISP27XX

2015-04-09 Thread Himanshu Madhani
From: Andrew Vasquez andrew.vasq...@qlogic.com Signed-off-by: Andrew Vasquez andrew.vasq...@qlogic.com Signed-off-by: Harish Zunjarrao harish.zunjar...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_mbx.c | 15 +++ 1 files

[PATCH 02/14] qla2xxx: Fix crash due to wrong casting of reg for ISP27XX.

2015-04-09 Thread Himanshu Madhani
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_tmpl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c

[PATCH 00/14] qla2xxx: Patches for scsi misc branch.

2015-04-09 Thread Himanshu Madhani
Hi James, Please apply the following patches to the scsi tree at your earliest convenience for inclusion in the next mainline merge window. Thanks, Himanshu Andrew Vasquez (1): qla2xxx: Add serdes read/write support for ISP27XX Chad Dupuis (1): qla2xxx: Increase the wait time for firmware

[PATCH 07/14] qla2xxx: Add udev notification to save fw dump for ISP27XX

2015-04-09 Thread Himanshu Madhani
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_tmpl.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c

[PATCH 04/14] qla2xxx: Fix beacon blink for ISP27XX.

2015-04-09 Thread Himanshu Madhani
From: Nigel Kirkland nigel.kirkl...@qlogic.com Signed-off-by: Nigel Kirkland nigel.kirkl...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_sup.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git

[PATCH 13/14] qla2xxx: Restore physical port WWPN only, when port down detected for FA-WWPN port.

2015-04-09 Thread Himanshu Madhani
From: Sawan Chandak sawan.chan...@qlogic.com For FA-WWPN is enabled port, if NPIV created on that port and, if port link is brought down, then WWPN was restored from flash for both physical and NPIV port. This will result in NPIV port and physical port sharing same WWPN. Any application

[PATCH v4 7/9] snic:Add sysfs entries to list stats and trace data

2015-04-09 Thread Narsimhulu Musini
snic_stats.h contains stats structre definitions for various events in snic driver. snic_debugfs.c contains setup and cleanup of sysfs entries for listing stats, resetting stats, enabling/disabling trace, and listing trace data. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by:

Re: [PATCH v4 7/9] snic:Add sysfs entries to list stats and trace data

2015-04-09 Thread Hannes Reinecke
On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: snic_stats.h contains stats structre definitions for various events in snic driver. snic_debugfs.c contains setup and cleanup of sysfs entries for listing stats, resetting stats, enabling/disabling trace, and listing trace data.

[PATCH 12/14] qla2xxx: Fix virtual port configuration, when switch port is disabled/enabled.

2015-04-09 Thread Himanshu Madhani
From: Sawan Chandak sawan.chan...@qlogic.com On some vendor switches, when switch port is toggled (down /up), then in some condition driver tries to configure virtual port, before FW is actually in ready state to process any commands on wire. At this time, configuring virtual port can fail. Add

[PATCH 14/14] qla2xxx: Update driver version to 8.07.00.18-k

2015-04-09 Thread Himanshu Madhani
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Himanshu Madhani himanshu.madh...@qlogic.com --- drivers/scsi/qla2xxx/qla_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h

Re: [PATCH v2 2/2] target/rd: Don't pass imcomplete scatterlist entries to sbc_dif_verify_*

2015-04-09 Thread Nicholas A. Bellinger
On Wed, 2015-04-08 at 23:25 +0900, Akinobu Mita wrote: 2015-04-08 14:13 GMT+09:00 Nicholas A. Bellinger n...@linux-iscsi.org: On Sun, 2015-04-05 at 23:59 +0900, Akinobu Mita wrote: The scatterlist for protection information which is passed to sbc_dif_verify_read() or sbc_dif_verify_write()

Re: [PATCH] scsi_transport_fc: Add support for 25Gbit speed

2015-04-09 Thread Ewan Milne
On Thu, 2015-04-02 at 15:50 -0400, James Smart wrote: Add FC transport support for 25Gbit speed Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/scsi_transport_fc.c | 1 + include/scsi/scsi_transport_fc.h | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-09 Thread Wolfram Sang
On Wed, Apr 08, 2015 at 04:50:38PM +0530, Sudip Mukherjee wrote: now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- drivers/i2c/busses/i2c-parport.c | 7

Re: [PATCH 15/21] lpfc: Implement support for wire-only DIF devices

2015-04-09 Thread James Smart
fyi - in the v3 of the lpfc 10.5.0.0 patches I just posted, I pulled the patch. We will see what to do with it. We may come back with a set of generic midlayer patches. -- james s On 4/5/2015 12:06 PM, Christoph Hellwig wrote: On Fri, Apr 03, 2015 at 05:13:00PM -0400, James Smart wrote:

Re: [PATCH v4 1/9] snic: snic module infrastructure

2015-04-09 Thread Hannes Reinecke
On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: snic_main.c contains module load and unload, global driver context, PCI Registration, PCI probe and remove, SCSI ML registration functionality. snic.h contains snic structure definition, snic global context, and prototypes. snic_attrs.c

Re: [PATCH v4 8/9] snic:Add event tracing to capture IO events.

2015-04-09 Thread Hannes Reinecke
On 04/09/2015 01:49 PM, Narsimhulu Musini wrote: snic_trc.h contains global trace structure definitions for snic driver snic_trc.c adds tracing functionality to capture various IO events. It maintains global trace buffer to maintain recent history of IO events. It helps to understand the

[PATCH v4 8/9] snic:Add event tracing to capture IO events.

2015-04-09 Thread Narsimhulu Musini
snic_trc.h contains global trace structure definitions for snic driver snic_trc.c adds tracing functionality to capture various IO events. It maintains global trace buffer to maintain recent history of IO events. It helps to understand the sequence of events prior to particular IO event, or hung,