Re: [PATCH] ibmvscsi:Remove no longer required comment for the function send_mad_adapter_info

2015-07-16 Thread Tyrel Datwyler
On 07/09/2015 10:24 AM, Nicholas Krause wrote: This removes the no longer required comment for the function send_mad_adapter_info stating that it always return zero due to this function being declared as void and thus never returning any useful value. Signed-off-by: Nicholas Krause

[PATCH v2 3/4] target: Return descriptor format sense data in case the LU spans 64bit sectors

2015-07-16 Thread Sagi Grimberg
In case a LU spans 64bit sectors, fixed size sense data information field is only 32 bits which means the sector information will be truncated. Thus, if the LU spans 64bit sectors, use descriptor format sense data to correctly report sector information. Reported-by: Christoph Hellwig h...@lst.de

Re: [PATCH] scsi: fix hang in scsi error handling

2015-07-16 Thread Hannes Reinecke
On 07/15/2015 02:47 PM, Kevin Groeneveld wrote: With the following setup/steps I can consistently trigger the scsi host to hang requiring a reboot: 1. iMX6Q processor with built in AHCI compatible SATA host 2. SATA port multiplier in CBS mode connected to iMX6Q 3. HDD connected to port

Re: [PATCH] sd: Fix maximum I/O size for BLOCK_PC requests

2015-07-16 Thread Hannes Reinecke
On 07/16/2015 03:13 AM, Martin K. Petersen wrote: Commit bcdb247c6b6a (sd: Limit transfer length) clamped the maximum size of an I/O request to the MAXIMUM TRANSFER LENGTH field in the BLOCK LIMITS VPD. This had the unfortunate effect of also limiting the maximum size of non-filesystem

Re: [dm-devel] [PATCH] dm-mpath: always return reservation conflict

2015-07-16 Thread Christoph Hellwig
On Thu, Jul 16, 2015 at 05:07:03AM +, Christophe Varoqui wrote: For reference the opensvc crm does use type 5 pr, and aims for all paths registered. It still does not make use of the multipathd pr janitoring features, and uses sg_persist directly for pr status and actions. The type doesn't

Re: [PATCH] csiostor: Use list_for_each_safe instead of re-implementing it

2015-07-16 Thread Johannes Thumshirn
Christophe JAILLET christophe.jail...@wanadoo.fr writes: Use 'list_for_each_safe' instead of 'list_for_each' + own logic to keep safe when a list entry is deleted. Delete the now useless 'csio_list_prev' macro. Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr ---

Re: [PATCH v2] mpt2sas: setpci reset kernel oops fix

2015-07-16 Thread Hannes Reinecke
On 07/14/2015 01:23 PM, Nagarajkumar Narayanan wrote: Patch Description: In mpt2sas driver due to lack of synchronization between ioctl, BRM status access through sysfs, pci resource removal kernel oops happen as ioctl path and BRM status sysfs access path still tries to access the

Re: [PATCH 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-07-16 Thread Sreekanth Reddy
On Sun, Jul 12, 2015 at 9:54 AM, Calvin Owens calvinow...@fb.com wrote: These objects can be referenced concurrently throughout the driver, we need a way to make sure threads can't delete them out from under each other. This patch adds the refcount, and refactors the code to use it.

Re: [dm-devel] [PATCH] dm-mpath: always return reservation conflict

2015-07-16 Thread Hannes Reinecke
On 07/16/2015 09:54 AM, Christoph Hellwig wrote: On Thu, Jul 16, 2015 at 05:07:03AM +, Christophe Varoqui wrote: For reference the opensvc crm does use type 5 pr, and aims for all paths registered. It still does not make use of the multipathd pr janitoring features, and uses sg_persist

[PATCH] scsi: fix memory leak with scsi-mq

2015-07-16 Thread Tony Battersby
Fix a memory leak with scsi-mq triggered by commands with large data transfer length. __sg_alloc_table() sets both table-nents and table-orig_nents to the same value. When the scatterlist is DMA-mapped, table-nents is overwritten with the (possibly smaller) size of the DMA-mapped scatterlist,

RE: [PATCH] scsi: fix hang in scsi error handling

2015-07-16 Thread Kevin Groeneveld
-Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: July-16-15 7:11 AM When the hang occurs shost-host_busy == 2 and shost-host_failed == 1 in the scsi_eh_wakeup function. However this function only wakes the error handler if host_busy == host_failed. Which

Re: [PATCH] ibmvscsi:Remove no longer required comments about return values in the file ibmvfc.c

2015-07-16 Thread Tyrel Datwyler
On 07/09/2015 10:41 AM, Nicholas Krause wrote: This removes the no longer require comments about the return values for the functions ibmvfc_init_host and ibmvfc_reinit_host due to these functions being declared to have a return type of void thus making this comments invalid. Signed-off-by:

Re: [PATCH v2 3/4] target: Return descriptor format sense data in case the LU spans 64bit sectors

2015-07-16 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi In case a LU spans 64bit sectors, fixed size sense data Sagi information field is only 32 bits which means the sector Sagi information will be truncated. Sagi Thus, if the LU spans 64bit sectors, use descriptor format sense Sagi data to

[PATCH] wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE

2015-07-16 Thread Vaishali Thakkar
Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with the goal of getting rid of this macro completely. The Coccinelle semantic patch that performs this transformation is as follows: @@ identifier a; declarer name

Re: [PATCH 1/1] Using the local variable instead of I/O flag to acquire io_req_lock in fnic_queuecommand() to avoid deadloack

2015-07-16 Thread Martin K. Petersen
Hiral == Hiral Shah his...@cisco.com writes: Hiral We added changes in fnic driver patch 1.6.0.16 to acquire Hiral io_req_lock in fnic_queuecommand() before issuing I/O so that io Hiral completion is serialized. But when releasing the lock we check Hiral for the I/O flag and this could be

Re: [PATCH 1/3] [RESEND] ipr: Fix locking for unit attention handling

2015-07-16 Thread Martin K. Petersen
Brian == Brian King brk...@linux.vnet.ibm.com writes: Brian Make sure we have the host lock held when calling Brian scsi_report_bus_reset. Fixes a crash seen as the __devices list Brian in the scsi host was changing as we were iterating through it. Nit: I take it that renaming lock_flags to

Re: [PATCH 2/3] [RESEND] ipr: Fix incorrect trace indexing

2015-07-16 Thread Martin K. Petersen
Brian == Brian King brk...@linux.vnet.ibm.com writes: Brian When ipr's internal driver trace was changed to an atomic, a Brian signed/unsigned bug slipped in which results in us indexing Brian backwards in our memory buffer writing on memory that does not Brian belong to us. This patch fixes

Re: [PATCH 3/3] [RESEND] ipr: Fix invalid array indexing for HRRQ

2015-07-16 Thread Martin K. Petersen
Brian == Brian King brk...@linux.vnet.ibm.com writes: Brian Fixes another signed / unsigned array indexing bug in the ipr Brian driver. Currently, when hrrq_index wraps, it becomes a negative Brian number. We do the modulo, but still have a negative number, so we Brian end up indexing backwards

[PATCH v2 3/3] cxlflash: Virtual LUN support

2015-07-16 Thread Matthew R. Ochs
Add support for physical LUN segmentation (virtual LUNs) to device driver supporting the IBM CXL Flash adapter. This patch allows user space applications to virtually segment a physical LUN into N virtual LUNs, taking advantage of the translation features provided by this adapter. Signed-off-by:

[PATCH v2 2/3] cxlflash: Superpipe support

2015-07-16 Thread Matthew R. Ochs
Add superpipe supporting infrastructure to device driver for the IBM CXL Flash adapter. This patch allows userspace applications to take advantage of the accelerated I/O features that this adapter provides and bypass the traditional filesystem stack. Signed-off-by: Matthew R. Ochs

[PATCH v2 0/3] IBM CXL Flash Error Recovery and Superpipe

2015-07-16 Thread Matthew R. Ochs
This patch set is intended for the 4.3 release and adds support for error recovery and the superpipe features provided by the IBM CXL Flash adapter. The superpipe function was originally presented in an RFC patch set in late April. To aid with the review of the superpipe portion of these

[PATCH v2 1/3] cxlflash: Base error recovery support

2015-07-16 Thread Matthew R. Ochs
Introduce support for enhanced I/O error handling. Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com --- drivers/scsi/cxlflash/common.h | 11 +++- drivers/scsi/cxlflash/main.c | 135 ++--- 2