Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Stefano Stabellini
On Tue, 4 Aug 2015, Boris Ostrovsky wrote: On 08/04/2015 02:12 PM, Julien Grall wrote: /* * We detect special mappings in one of two ways: @@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned long mfn) /* VIRT - MACHINE conversion */ #define

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Stefano Stabellini
On Tue, 4 Aug 2015, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This resulted in some misimplementation of helpers on ARM and confused developers about the expected behavior.

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Julien Grall
Hi Boris, On 05/08/15 00:16, Boris Ostrovsky wrote: On 08/04/2015 02:12 PM, Julien Grall wrote: /* * We detect special mappings in one of two ways: @@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned long mfn) /* VIRT - MACHINE conversion */ #define

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Boris Ostrovsky
On 08/05/2015 08:33 AM, Julien Grall wrote: On 05/08/15 13:19, Boris Ostrovsky wrote: On 08/05/2015 06:51 AM, Julien Grall wrote: diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++

Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-05 Thread Brian King
On 08/02/2015 11:33 PM, Matthew R. Ochs wrote: diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi/cxlflash/common.h index ba070a5..3d6217a 100644 --- a/drivers/scsi/cxlflash/common.h +++ b/drivers/scsi/cxlflash/common.h @@ -76,6 +76,12 @@ enum cxlflash_init_state {

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Dmitry Torokhov
On Wed, Aug 05, 2015 at 11:08:55AM +0100, Stefano Stabellini wrote: On Tue, 4 Aug 2015, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This resulted in some misimplementation

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Wei Liu
On Tue, Aug 04, 2015 at 07:12:48PM +0100, Julien Grall wrote: [...] diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7d50711..3b7b7c3 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -314,7 +314,7 @@ static

Re: [Open-FCoE] [PATCH] libfc: correct function name in comment

2015-08-05 Thread Vasu Dev
On Wed, 2015-08-05 at 00:21 +0200, Sebastian Herbszt wrote: Use the correct function name in kernel-doc comment. Signed-off-by: Sebastian Herbszt herb...@gmx.de --- diff -U 5 -rp a/drivers/scsi/libfc/fc_npiv.c b/drivers/scsi/libfc/fc_npiv.c --- a/drivers/scsi/libfc/fc_npiv.c2014-09-03

Re: [PATCH v3 1/4] cxlflash: Updates to legacy I/O

2015-08-05 Thread Matthew R. Ochs
On Aug 5, 2015, at 10:44 AM, Brian King brk...@linux.vnet.ibm.com wrote: Hi Matt, Can you break this up into separate patches for these separate logical bug fixes / changes? There is too much bundled all into a single patch here from my perspective. Sure, I can do that for v4.

Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-05 Thread Daniel Axtens
On Wed, 2015-08-05 at 17:30 -0500, Matthew R. Ochs wrote: Hi Brian, Thanks for reviewing. Comments inline below. -matt On Aug 5, 2015, at 11:04 AM, Brian King brk...@linux.vnet.ibm.com wrote: On 08/02/2015 11:33 PM, Matthew R. Ochs wrote: diff --git

Re: [PATCH v3 2/4] cxlflash: Base error recovery support

2015-08-05 Thread Matthew R. Ochs
Hi Brian, Thanks for reviewing. Comments inline below. -matt On Aug 5, 2015, at 11:04 AM, Brian King brk...@linux.vnet.ibm.com wrote: On 08/02/2015 11:33 PM, Matthew R. Ochs wrote: diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi/cxlflash/common.h index ba070a5..3d6217a