Re: [PATCH 1 02/25] hpsa: remove unused hpsa_tag_discard_error_bits

On 28.10.2015 23:04, Don Brace wrote: > This function is no longer used. > > Signed-off-by: Don Brace Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH 1 01/25] hpsa: stop zeroing reset_cmds_out and ioaccel_cmds_out during rescan

On 28.10.2015 23:04, Don Brace wrote: > pulling the rug out from under the reset handler > likewise for ioaccel_cmds_out > > Signed-off-by: Don Brace Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [PATCH 1 03/25] hpsa: check for null arguments to dev_printk

On 28.10.2015 23:04, Don Brace wrote: > Check for NULLs. How is the devtype change related to this? Please next time use separated patch for every change. Reviewed-by: Tomas Henzl Cheers, Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH 1 04/25] hpsa: fix null device issues

On 28.10.2015 23:04, Don Brace wrote: > Signed-off-by: Don Brace > --- > drivers/scsi/hpsa.c | 25 - > 1 file changed, 20 insertions(+), 5 deletions(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index 6b6e9bb..3fe8a18 100644 > ---

Re: [PATCH 1 08/25] hpsa: fix hpsa_adjust_hpsa_scsi_table

On 28.10.2015 23:05, Don Brace wrote: > Fix a NULL pointer issue in the driver when devices are removed > during a reset. > > Signed-off-by: Don Brace > --- > drivers/block/cciss.h |1 + > drivers/scsi/hpsa.c | 16 > drivers/scsi/hpsa.h |1 + >

IBM request to allow unprivledged ioctls [Was: Revert "dm mpath: fix stalls when handling invalid ioctls"]

On Thu, Oct 29 2015 at 8:24am -0400, Mauricio Faria de Oliveira wrote: > This reverts commit a1989b330093578ea5470bea0a00f940c444c466. > > That commit introduced a regression at least for the case of the SG_IO ioctl() > running without CAP_SYS_RAWIO capability

Re: [dm-devel] IBM request to allow unprivledged ioctls [Was: Revert "dm mpath: fix stalls when handling invalid ioctls"]

Hi Mike, On 10/29/2015 11:18 AM, Mike Snitzer wrote: Sorry but I fail to see why your request to revert is viable. No problem. Thanks for moving this for a discussion on a proper fix. I'm somewhat new to kernel and SCSI workings and its community process, so that's certainly appreciated.

Re: [PATCH 1 10/25] hpsa: correct check for non-disk devices

On 28.10.2015 23:05, Don Brace wrote: > The driver is using two MACROs which seemingly are looking in > the wrong location for the device_flags returned from > CISS_REPORT_PHYS. Both MACROs, NON_DISK_PHYS_DEV and > PHYS_IOACCEL, are using the pointer returned from figure_lunaddrbytes > which is

Re: [PATCH 1 02/25] hpsa: remove unused hpsa_tag_discard_error_bits

On 10/29/2015 09:37 AM, Manoj Kumar wrote: Don: See comment below. - Manoj Kumar On 10/28/2015 5:04 PM, Don Brace wrote: This function is no longer used. diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c +#define HPSA_PERF_ERROR_BITS ((1 << DIRECT_LOOKUP_SHIFT) - 1)

Re: [PATCH 1 09/25] hpsa: fix physical target reset

On 28.10.2015 23:05, Don Brace wrote: > From: Scott Teel > > Set reset type in device_reset_handler to do either > logical unit reset for logical devices, or physical > target reset, for physical devices. > > Reviewed-by: Scott Teel > Reviewed-by: Justin

Re: [PATCH 1 14/25] hpsa: add function is_logical_device

On 28.10.2015 23:05, Don Brace wrote: > From: Kevin Barnett > > simplify checking for logical/physical devices > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett >

Re: [PATCH 1 15/25] hpsa: enhance hpsa_get_device_id

On 28.10.2015 23:06, Don Brace wrote: > use an index into vpd data for SAS/SATA drives > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett > Signed-off-by: Don Brace

Re: [PATCH 1 02/25] hpsa: remove unused hpsa_tag_discard_error_bits

Don: See comment below. - Manoj Kumar On 10/28/2015 5:04 PM, Don Brace wrote: This function is no longer used. diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c +#define HPSA_PERF_ERROR_BITS ((1 << DIRECT_LOOKUP_SHIFT) - 1) HPSA_PERF_ERROR_BITS seems to be only used in the function

Re: [PATCH 1 09/25] hpsa: fix physical target reset

On 10/29/2015 09:30 AM, Tomas Henzl wrote: On 28.10.2015 23:05, Don Brace wrote: From: Scott Teel Set reset type in device_reset_handler to do either logical unit reset for logical devices, or physical target reset, for physical devices. Reviewed-by: Scott Teel

Re: [PATCH 1 13/25] hpsa: simplify update scsi devices

On 28.10.2015 23:05, Don Brace wrote: > From: Kevin Barnett > > remove repeated calculation that checks for physical > or logical devices. > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett

Re: [PATCH 1 03/25] hpsa: check for null arguments to dev_printk

On 10/28/2015 5:04 PM, Don Brace wrote: Check for NULLs. - int devtype; + unsigned int devtype; Don: Unrelated to the NULL argument check. Would have been preferable in a distinct patch. Reviewed-by: Manoj Kumar --- Manoj Kumar -- To unsubscribe

Re: [PATCH 1 11/25] hpsa: correct ioaccel2 sg chain len

On 28.10.2015 23:05, Don Brace wrote: > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett > Signed-off-by: Don Brace Reviewed-by: Tomas Henzl Tomas

Re: Blk-mq/scsi-mq Tuning

On 10/28/2015 01:11 PM, Chad Dupuis wrote: We¹ve begun to explore blk-mq and scsi-mq and wanted to know if there were any best practices in terms of block layer settings. We¹re looking specifically at the FCoE and iSCSI protocols. A little background on the queues in our hardware first: we

Re: [PATCH 1 15/25] hpsa: enhance hpsa_get_device_id

> On Oct 28, 2015, at 5:06 PM, Don Brace wrote: > > use an index into vpd data for SAS/SATA drives > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett > Signed-off-by:

Re: [PATCH 1 17/25] hpsa: move scsi_add_device and scsi_remove_device calls to new function

On 28.10.2015 23:06, Don Brace wrote: > From: Kevin Barnett > > preparation for adding the sas transport class > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett >

Re: [PATCH 1 16/25] hpsa: refactor hpsa_figure_bus_target_lun

On 28.10.2015 23:06, Don Brace wrote: > From: Kevin Barnett > > setup for sas transport. Need to set the > bus and target accordingly. > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett

Re: [PATCH 1 14/25] hpsa: add function is_logical_device

Reviewed-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1 13/25] hpsa: simplify update scsi devices

> On Oct 28, 2015, at 5:05 PM, Don Brace wrote: > > From: Kevin Barnett > > remove repeated calculation that checks for physical > or logical devices. > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley

Re: [PATCH 1 17/25] hpsa: move scsi_add_device and scsi_remove_device calls to new function

> On Oct 28, 2015, at 5:06 PM, Don Brace wrote: > > From: Kevin Barnett > > preparation for adding the sas transport class > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin

Re: [PATCH 1 13/25] hpsa: simplify update scsi devices

On 10/29/2015 11:43 AM, Matthew R. Ochs wrote: On Oct 28, 2015, at 5:05 PM, Don Brace wrote: From: Kevin Barnett remove repeated calculation that checks for physical or logical devices. Reviewed-by: Scott Teel Reviewed-by:

Re: [PATCH 1 18/25] External array LUNs must use target and lun numbers assigned by the

> On Oct 28, 2015, at 5:06 PM, Don Brace wrote: > > From: Scott Teel > > external array. So the driver must treat these differently from > local LUNs when assigning lun/target. > > LUN's 'model' field has been used to detect Lun types that need >

Re: [PATCH 1 19/25] hpsa: eliminate fake lun0 enclosures

Reviewed-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1 13/25] hpsa: simplify update scsi devices

> On Oct 29, 2015, at 2:01 PM, Don Brace wrote: > > On 10/29/2015 11:43 AM, Matthew R. Ochs wrote: >>> On Oct 28, 2015, at 5:05 PM, Don Brace wrote: >>> >>> From: Kevin Barnett >>> >>> remove repeated calculation that checks

Re: [PATCH 1 20/25] hpsa: add discovery polling for PT RAID devices.

> On Oct 28, 2015, at 5:06 PM, Don Brace wrote: > > From: Scott Teel > > There are problems with getting configuration change notification > in pass-through RAID environments. So, activate flag > h->discovery_polling when one of these devices is

Re: [PATCH 1 20/25] hpsa: add discovery polling for PT RAID devices.

> On Oct 29, 2015, at 3:51 PM, Don Brace wrote: > On 10/29/2015 03:20 PM, Matthew R. Ochs wrote: >>> On Oct 28, 2015, at 5:06 PM, Don Brace >>> wrote: >>> >>> From: Scott Teel >>> >>> >>> >>> There are problems with getting

[Bug 106871] New: Lower log level for "No Caching mode page found" and "Assuming drive cache: write through"

https://bugzilla.kernel.org/show_bug.cgi?id=106871 Bug ID: 106871 Summary: Lower log level for "No Caching mode page found" and "Assuming drive cache: write through" Product: IO/Storage Version: 2.5 Kernel Version: 4.2.4

[Bug 106861] DPOFUA should not be related to WCE / Caching mode page

https://bugzilla.kernel.org/show_bug.cgi?id=106861 --- Comment #1 from Tom Yan --- Example drive: [tom@localhost ~]$ sudo sdparm --long /dev/sdc /dev/sdc: WDMy Passport 083A 1065 Direct access device specific parameters: WP=0 DPOFUA=1 Control [co] mode

[Bug 106861] New: DPOFUA should not be related to WCE / Caching mode page

https://bugzilla.kernel.org/show_bug.cgi?id=106861 Bug ID: 106861 Summary: DPOFUA should not be related to WCE / Caching mode page Product: IO/Storage Version: 2.5 Kernel Version: 4.2.4 Hardware: All