[PATCH, resend] scsi: advansys: fix big-endian builds

Building the advansys driver in a big-endian configuration such as ARM allmodconfig shows a warning: drivers/scsi/advansys.c: In function 'adv_build_req': include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define

Re: [PATCH 3/9] IB: add a helper to safely drain a QP

On 11/15/2015 3:34 AM, Sagi Grimberg wrote: + +struct ib_stop_cqe { +struct ib_cqecqe; +struct completion done; +}; + +static void ib_stop_done(struct ib_cq *cq, struct ib_wc *wc) +{ +struct ib_stop_cqe *stop = +container_of(wc->wr_cqe, struct ib_stop_cqe, cqe); + +

[PATCH v4 05/32] scsi: hisi_sas: scan device tree

Scan the device tree for all properties. Also do this: - do ioremap for SAS registers - allocate memory for interrupt names Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 10 drivers/scsi/hisi_sas/hisi_sas_main.c | 45

[PATCH v4 17/32] scsi: hisi_sas: add v1 hw module init

Add module init code for v1 hw. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/Makefile | 1 + drivers/scsi/hisi_sas/hisi_sas.h | 3 ++ drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 53 ++ 3 files changed, 57 insertions(+)

[PATCH v4 14/32] scsi: hisi_sas: add hisi sas device type

Include initialisation. Signed-off-by: John Garry Conflicts: drivers/scsi/hisi_sas/hisi_sas_main.c --- drivers/scsi/hisi_sas/hisi_sas.h | 12 drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ++ 2 files changed, 18 insertions(+) diff --git

[PATCH v4 03/32] scsi: hisi_sas: add initial bare main driver

This patch adds the initial bare main driver for the HiSilicon SAS HBA. This only introduces the changes to build and load the main driver module. The complete driver consists of the core main module and also a module platform driver for driving the hw. The HBA is a platform device.

[PATCH for-next 05/10] iser: Have initiator and target to share protocol structures and definitions

The iser RDMA_CM negotiation protocol is shared by the initiator and the target, so have a shared header for the defines and structure. Move relevant items from the initiator and target headers. Signed-off-by: Sagi Grimberg Signed-off-by: Jenny Derzhavetz

[PATCH v4 01/32] [SCSI] sas: centralise ssp frame information units

The xfer_rdy, command, and task frame's iu structures are not available in , but only aic94xx driver folder. Add them to include/scsi/sas.h Signed-off-by: John Garry --- drivers/scsi/aic94xx/aic94xx_sas.h | 49 - include/scsi/sas.h

[PATCH v4 21/32] scsi: hisi_sas: add path from phyup irq to SAS framework

Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 49 ++ drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 15 +++ 3 files changed, 66 insertions(+) diff --git

Re: [PATCH v4 02/32] devicetree: bindings: scsi: HiSi SAS

On Mon, Nov 16, 2015 at 09:05:48PM +0800, John Garry wrote: > Add devicetree bindings for HiSilicon SAS driver. > > Signed-off-by: John Garry > Signed-off-by: Zhangfei Gao Acked-by: Rob Herring > --- >

[PATCH v4 22/32] scsi: hisi_sas: add ssp command function

Add path to send ssp command to HW Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 30 + drivers/scsi/hisi_sas/hisi_sas_main.c | 234 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 194 +++ 3

[PATCH v4 19/32] scsi: hisi_sas: add v1 HW initialisation code

Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 4 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 337 + 3 files changed, 342 insertions(+) diff --git

[PATCH v4 20/32] scsi: hisi_sas: add v1 hw interrupt init

Add code to interrupts, so now we can get a phy up interrupt when a disk is connected. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 5 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 161 + 2 files changed, 166

[PATCH v4 13/32] scsi: hisi_sas: add hisi_hba workqueue

Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 8 2 files changed, 9 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index c50384f..62bc6f3 100644

[PATCH v4 06/32] scsi: hisi_sas: add HW DMA structures

Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 131 +++ 1 file changed, 131 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index 87f4b61..19d40b7 100644 ---

[PATCH v4 15/32] scsi: hisi_sas: add phy and port init

Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 15 +++ drivers/scsi/hisi_sas/hisi_sas_main.c | 31 +++ 2 files changed, 46 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h

[PATCH v4 24/32] scsi: hisi_sas: add dev_found and dev_gone

Add functions to deal with lldd_dev_found and lldd_dev_gone. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 13 + drivers/scsi/hisi_sas/hisi_sas_main.c | 88 ++ drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 41

[PATCH v4 31/32] scsi: hisi_sas: add fatal irq handler

Add handlers for fatal interrupts Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 119 + 1 file changed, 119 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

[PATCH v4 32/32] MAINTAINERS: add maintainer for HiSi SAS driver

Add maintainer for HiSilicon SAS driver. Signed-off-by: John Garry --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e9caa4b..c7081bd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5035,6 +5035,13 @@ F:

[PATCH v4 25/32] scsi: hisi_sas: add abnormal irq handler

Add abnormal irq handler. This handler is concerned with phy down event. Also add port formed and port deformed handlers. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 + drivers/scsi/hisi_sas/hisi_sas_main.c | 118

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

On 11/13/2015 10:54 PM, Martin K. Petersen wrote: >> "Lee" == Lee Duncan writes: > >>> Well, I'm a bit worried about the loss of a monotonically increasing >>> host number from the debugging perspective. Right now, if you look >>> at any log, hostX always refers to one and

[PATCH v4 04/32] scsi: hisi_sas: add scsi host registration

Add functionality to register device as a scsi host. The SAS domain transport ops are empty at this point. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 34 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 116 ++

[PATCH v4 16/32] scsi: hisi_sas: add timer and spinlock init

Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index 3a2400e..3749c46 100644 ---

[PATCH v4 10/32] scsi: hisi_sas: add cq structure initialization

Each completion queue has a structure. This is mainly for passing to irq handler so we know which queue the irq occured on. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 7 +++ drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ++ 2 files changed,

[PATCH v4 00/32] HiSilicon SAS driver

This is the driver patchset for the HiSilicon SAS driver. The driver is a platform driver. The driver will support multiple revisions of HW. Currently only "v1" HW is supported. The driver uses libsas framework within the SCSI framework. The v1 HW supports SSP and SMP, but not STP/SATA.

[PATCH v4 02/32] devicetree: bindings: scsi: HiSi SAS

Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry Signed-off-by: Zhangfei Gao --- .../devicetree/bindings/scsi/hisilicon-sas.txt | 69 ++ 1 file changed, 69 insertions(+) create mode 100644

[PATCH v4 11/32] scsi: hisi_sas: add phy SAS ADDR initialization

The SAS address for the HBA comes from the device tree. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 12 2 files changed, 13 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h

[PATCH v4 23/32] scsi: hisi_sas: add cq interrupt handler

Add cq interrupt handler and also slot error handler function. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 9 + drivers/scsi/hisi_sas/hisi_sas_main.c | 35 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 345 +

[PATCH v4 27/32] scsi: hisi_sas: add smp protocol support

Add support for smp function, which allows devices attached by expander to be controlled Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 3 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 9 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 88

[PATCH v4 26/32] scsi: hisi_sas: add bcast interrupt handler

This is for expander broadcast event. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

[PATCH v4 18/32] scsi: hisi_sas: add v1 hardware register definitions

Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 389 + 1 file changed, 389 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c index e9aebce..9fe89bb 100644 ---

[PATCH v4 28/32] scsi: hisi_sas: add scan finished and start

Add functions for scsi host template scan_finished and scan_start methods Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 25 + 2 files changed, 26 insertions(+) diff --git

[PATCH v4 29/32] scsi: hisi_sas: add tmf methods

Add function methods for tmf's. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 309 ++ 1 file changed, 309 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c

[PATCH v4 08/32] scsi: hisi_sas: add hisi_sas_remove

This patch also includes relevant memory/pool free'ing and sas/scsi host removal Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 71 ++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git

[PATCH v4 07/32] scsi: hisi_sas: allocate memories and create pools

Allocate DMA and non-DMA memories for the controller. Also create DMA pools. These include: - Delivery queues - Completion queues - Command status buffer - Command table - ITCT (For device context) - Host slot info - IO status - Breakpoint - host slot indexing - SG data - FIS - interrupts names

[PATCH v4 09/32] scsi: hisi_sas: add slot init code

Add functionality to init slot indexing. Slot indexing is for the host to track which slots (or tags) are free and which are used. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 4 drivers/scsi/hisi_sas/hisi_sas_main.c | 23

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

> -Original Message- > From: Steve Wise [mailto:sw...@opengridcomputing.com] > Sent: Monday, November 16, 2015 10:38 AM > To: Sagi Grimberg; Christoph Hellwig; linux-r...@vger.kernel.org > Cc: bart.vanass...@sandisk.com; ax...@fb.com; linux-scsi@vger.kernel.org; >

Re: [PATCH 2/2] Restart list search after unlock in scsi_remove_target

Bart, can you resend your patch on top of 4.4-rc1? I think we really need it so we should get it into 4.4 and backport it to -stable. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

On Mon, Nov 16, 2015 at 06:20:31PM +, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote: > > It turns out that the commit that introduced this used the cpu_to_le32() > > incorrectly on an 8-bit field, which results in the sense_len to always > > be

RE: [PATCH 3/9] IB: add a helper to safely drain a QP

> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Sagi Grimberg > Sent: Monday, November 16, 2015 12:38 PM > To: Steve Wise; 'Christoph Hellwig'; linux-r...@vger.kernel.org > Cc: bart.vanass...@sandisk.com;

Re: [PATCH] ib_srp: initialize dma_length in srp_map_idb

On 11/15/2015 09:59 AM, Christoph Hellwig wrote: Without this sg_dma_len will return 0 on architectures tha have the dma_length field. Signed-off-by: Christoph Hellwig --- drivers/infiniband/ulp/srp/ib_srp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

> On Nov 15, 2015, at 4:10 AM, Or Gerlitz wrote: > > On Fri, Nov 13, 2015 at 6:51 PM, Mike Christie wrote: >> On 11/13/2015 09:06 AM, Or Gerlitz wrote: The patch has caused multiple regressions, did not even compile when > sent to me, and

Re: [PATCH 3/9] IB: add a helper to safely drain a QP

After looking at the nes driver, I don't see any common way to support drain w/o some serious driver mods. Since SRP is the only user, perhaps we can ignore iWARP for this function... But iser/isert essentially does it too (and I think xprtrdma will have it soon)... the modify_qp is

Re: [PATCH] ib_srp: initialize dma_length in srp_map_idb

On 11/16/2015 09:22 AM, Christoph Hellwig wrote: the code in this area changed enough since 4.3 that it won't easily apply. But a backport would still be very useful! In that case: Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote: > It turns out that the commit that introduced this used the cpu_to_le32() > incorrectly on an 8-bit field, which results in the sense_len to always > be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper > byte of the

Re: [PATCH v4 03/32] scsi: hisi_sas: add initial bare main driver

Hi John, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.4-rc1 next-20151116] url: https://github.com/0day-ci/linux/commits/John-Garry/HiSilicon-SAS-driver/20151116-215304 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: i386

Re: [PATCH] ib_srp: initialize dma_length in srp_map_idb

Hi Bart, the code in this area changed enough since 4.3 that it won't easily apply. But a backport would still be very useful! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

On Mon, Nov 16, 2015 at 7:20 PM, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote: >> It turns out that the commit that introduced this used the cpu_to_le32() >> incorrectly on an 8-bit field, which results in the sense_len to

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

On 11/16/2015 04:10 AM, Hannes Reinecke wrote: > On 11/13/2015 10:54 PM, Martin K. Petersen wrote: >>> "Lee" == Lee Duncan writes: >> Well, I'm a bit worried about the loss of a monotonically increasing host number from the debugging perspective. Right now, if you

Re: [PATCH v4 05/32] scsi: hisi_sas: scan device tree

Hi John, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.4-rc1 next-20151116] url: https://github.com/0day-ci/linux/commits/John-Garry/HiSilicon-SAS-driver/20151116-215304 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: i386

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

Bart Van Assche wrote: > [PATCH] qla2xxx: Fix rwlock recursion > > Fixes: 8dfa4b5a9b44 ("qla2xxx: Fix sparse annotation") > Signed-off-by: Bart Van Assche > Reported-by: Himanshu Madhani > Cc: Giridhar Malavali

[PATCH, RESEND] qla2xxx: Fix rwlock recursion

This patch fixes the following kernel bug: kernel:BUG: rwlock recursion on CPU#2, insmod/39333, 8803e998cb28 kernel: Call Trace: kernel: [] dump_stack+0x48/0x64 kernel: [] rwlock_bug+0x67/0x70 kernel: [] do_raw_write_lock+0x8a/0xa0 kernel: [] _raw_write_lock_irqsave+0x63/0x80 kernel: []

[PATCH v2] Separate target visibility from reaped state information

Instead of representing the states "visible in sysfs" and "has been removed from the target list" by a single state variable, use two variables to represent this information. This patch avoids that SCSI device removal can trigger a soft lockup. See also: * "scsi: restart list search after unlock

Re: [PATCH v5 00/11] exynos-ufs: add support for Exynos

Hi Alim, On Monday 16 November 2015 06:31 AM, Alim Akhtar wrote: > Hi Kishon, > > Any more concern on the PHY part of this series? Sorry for the late reply. Yes, I still have concerns. I'll comment on your patch. Thanks Kishon > > Thanks! > > On Mon, Nov 9, 2015 at 10:56 AM, Alim Akhtar

Re: [PATCH v5 02/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

Hi, On Monday 09 November 2015 10:56 AM, Alim Akhtar wrote: > From: Seungwon Jeon > > This patch introduces Exynos UFS PHY driver. This driver > supports to deal with phy calibration and power control > according to UFS host driver's behavior. > > Signed-off-by: Seungwon Jeon

Re: [PATCH v2] Separate target visibility from reaped state information

On Mon, 2015-11-16 at 16:18 -0800, Bart Van Assche wrote: > Instead of representing the states "visible in sysfs" and > "has been removed from the target list" by a single state > variable, use two variables to represent this information. > > This patch avoids that SCSI device removal can trigger

[PATCH] SCSI-libfc: Delete an unnecessary check before the function call "kmem_cache_destroy"

From: Markus Elfring Date: Mon, 16 Nov 2015 09:39:12 +0100 The kmem_cache_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH] ib_srp: initialize dma_length in srp_map_idb

On 15/11/2015 23:10, Or Gerlitz wrote: On Sun, Nov 15, 2015, Sagi Grimberg wrote: On 15/11/2015 19:59, Christoph Hellwig wrote: Without this sg_dma_len will return 0 on architectures tha have the dma_length field. and what wrong with that? Because it's not

Re: [PATCH 1/2] iscsi-target: Fix rx_login_comp hang after login failure

On 15/11/2015 02:21, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch addresses a case where iscsi_target_do_tx_login_io() fails sending the last login response PDU, after the RX/TX threads have already been started. The case centers around

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

On 11/16/2015 05:49 PM, Arnd Bergmann wrote: > Building the advansys driver in a big-endian configuration such as > ARM allmodconfig shows a warning: > > drivers/scsi/advansys.c: In function 'adv_build_req': > include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer > implicitly

[PATCH] SCSI-aic94xx: Delete unnecessary checks before the function call "kmem_cache_destroy"

From: Markus Elfring Date: Tue, 17 Nov 2015 08:14:52 +0100 The kmem_cache_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software.