RE: [Bug 111441] New: iscsi fails to attach to targets

Sure thing, I will test it tonight and let you know the result. Thank you Serguei -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Tuesday, February 02, 2016 3:12 PM To: Christoph Hellwig Cc: Serguei Bezverkhi (sbezverk)

[Bug 111441] iscsi fails to attach to targets

https://bugzilla.kernel.org/show_bug.cgi?id=111441 --- Comment #11 from Serguei Bezverkhi --- Sure thing, I will test it tonight and let you know the result. Thank you Serguei -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Tuesday,

Re: [PATCHv4 22/23] scsi_dh_alua: update 'access_state' field

This looks ok to me, but the context will change a bit due to changes in previous patches. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Bug 111441] New: iscsi fails to attach to targets

On 02/02/2016 12:09 PM, Christoph Hellwig wrote: > On Fri, Jan 29, 2016 at 05:32:54PM -0600, Mike Christie wrote: >> Hey Christoph and Hannes, >> >> The dh/alua changes that added this: >> >> error = scsi_dh_add_device(sdev); >> if (error) { >>

Re: [LSF/MM TOPIC] multiqueue and interrupt assignment

On 02/02/2016 08:31 AM, Hannes Reinecke wrote: here's another topic which I've hit during my performance tests: How should interrupt affinity be handled with blk-multiqueue? The problem is that the blk-multiqueue assumes a certain CPU-to-queue mapping, _and_ the 'queue' in blk-mq syntax is

RE: [Bug 111441] New: iscsi fails to attach to targets

HI Mike, It is working now, it spits alua related error messages but it attaches remote and local targets, so my OpenStack is back to life. Please let me know if you plan to commit this fix upstream. [ 27.579303] scsi 3:0:0:2: Direct-Access LIO-ORG san-disk-2 4.0 PQ: 0 ANSI: 5 [

Re: [PATCH] target: fix cast from pointer to phys_addr_t

(Adding Andy CC') On Mon, 2016-02-01 at 17:29 +0100, Arnd Bergmann wrote: > The uio_mem structure has a member that is a phys_addr_t, but can > be a number of other types too. The target core driver attempts > to assign a pointer from vmalloc() to it, by casting it to > phys_addr_t, but that

[Bug 111441] iscsi fails to attach to targets

https://bugzilla.kernel.org/show_bug.cgi?id=111441 --- Comment #12 from Serguei Bezverkhi --- HI Mike, It is working now, it spits alua related error messages but it attaches remote and local targets, so my OpenStack is back to life. Please let me know if you plan to commit

Re: [PATCH] add support for DWC UFS Host Controller

Hi Joao, On Wed, Feb 3, 2016 at 1:47 AM, Joao Pinto wrote: > Hi, > In order to make a ufs-dwc-pci glue driver I will need to create a "pci driver > lib" like we have already for platform (ufshcd-pltfm.c). Should I call the > samsung glue driver ufs-samsung-pci.c which

[Bug 111441] iscsi fails to attach to targets

https://bugzilla.kernel.org/show_bug.cgi?id=111441 --- Comment #14 from Serguei Bezverkhi --- Here you go, same output to compare for 4.4.1 and 3.10.0 Linux 4.4.1 #1 SMP Tue Feb 2 16:15:36 EST 2016 [root@sbezverk-osp-3 ~(keystone_admin)]# sg_inq -Hi /dev/sdc VPD INQUIRY:

Re: [Bug 111441] New: iscsi fails to attach to targets

On Mon, 2016-02-01 at 10:55 -0600, Mike Christie wrote: > On 01/30/2016 01:38 AM, Nicholas A. Bellinger wrote: > > On Fri, 2016-01-29 at 17:32 -0600, Mike Christie wrote: > >> On 01/29/2016 04:21 PM, Serguei Bezverkhi (sbezverk) wrote: > >>> HI Mike, > >>> > >>> I tried your patch and it is has

[Bug 111441] iscsi fails to attach to targets

https://bugzilla.kernel.org/show_bug.cgi?id=111441 --- Comment #13 from nab --- On Mon, 2016-02-01 at 10:55 -0600, Mike Christie wrote: > On 01/30/2016 01:38 AM, Nicholas A. Bellinger wrote: > > On Fri, 2016-01-29 at 17:32 -0600, Mike Christie wrote: > >> On 01/29/2016

Re: [PATCH-v3 1/5] target: Fix LUN_RESET active I/O handling for ACK_KREF

On Tue, 2016-02-02 at 10:37 +0100, Christoph Hellwig wrote: > > @@ -282,6 +305,16 @@ static void core_tmr_drain_state_list( > > if (prout_cmd == cmd) > > continue; > > > > + sess = cmd->se_sess; > > + if (WARN_ON_ONCE(!sess)) > > +

RE: [Bug 111441] New: iscsi fails to attach to targets

Here you go, same output to compare for 4.4.1 and 3.10.0 Linux 4.4.1 #1 SMP Tue Feb 2 16:15:36 EST 2016 [root@sbezverk-osp-3 ~(keystone_admin)]# sg_inq -Hi /dev/sdc VPD INQUIRY: Device Identification page Designation descriptor number 1, descriptor length: 20 designator_type: NAA,

Re: [PATCH] Separate target visibility from reaped state information

On Tue, 2016-02-02 at 10:29 -0800, Bart Van Assche wrote: > On 02/02/2016 03:46 AM, James Bottomley wrote: > > diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c > > index 4f18a85..00bc721 100644 > > --- a/drivers/scsi/scsi_sysfs.c > > +++ b/drivers/scsi/scsi_sysfs.c > > @@

Re: [PATCH-v3 4/5] target: Fix remote-port TMR ABORT + se_cmd fabric stop

On Tue, 2016-02-02 at 11:54 +0100, Christoph Hellwig wrote: > > + bool aborted = false, tas = false; > > > > /* > > * Allocate an struct iscsi_conn_recovery for this connection. > > @@ -398,7 +399,7 @@ int iscsit_prepare_cmds_for_realligance(struct > > iscsi_conn *conn) > > > >

[PATCH V5 00/10] aacraid: Patchset for aacraid driver version 41052

This patchset includes the following changes (bug fixes and new feature support) specific to aacraid driver. V2: Removed aac_fib_free_tag function Setup relevant fib variables only once Created aac_fib_vector_assign function Made EEH functions static Added character device status macros changed

[PATCH V5 02/10] aacraid: Fix RRQ overload

From: Raghava Aditya Renukunta The driver utilizes an array of atomic variables to keep track of IO submissions to each vector. To submit an IO multiple threads iterate through the array to find a vector which has empty slots to send an IO. The reading and

[PATCH V5 08/10] aacraid: Fix AIF triggered IOP_RESET

From: Raghava Aditya Renukunta while driver removal is in progress or PCI shutdown is invoked, driver kills AIF aacraid thread, but IOCTL requests from the management tools re-start AIF thread leading to IOP_RESET. Fixed by setting adapter_shutdown flag when

[PATCH V5 05/10] aacraid: Set correct msix count for EEH recovery

From: Raghava Aditya Renukunta During EEH recovery number of online CPU's might change thereby changing the number of MSIx vectors. Since each fib is allocated to a vector, changes in the number of vectors causes fib to be sent thru invalid vectors.In addition

[PATCH V5 04/10] aacraid: Fix memory leak in aac_fib_map_free

From: Raghava Aditya Renukunta aac_fib_map_free() calls pci_free_consistent() without checking that dev->hw_fib_va is not NULL and dev->max_fib_size is not zero.If they are indeed NULL/0, this will result in a hang as pci_free_consistent() will attempt to

[PATCH V5 01/10] aacraid: SCSI blk tag support

From: Raghava Aditya Renukunta The method to allocate and free FIB's in the present code utilizes spinlocks.Multiple IO's have to wait on the spinlock to acquire or free fibs creating a performance bottleneck. An alternative solution would be to use block layer

[PATCH V5 06/10] aacraid: Fundamental reset support for Series 7

From: Raghava Aditya Renukunta Series 7 does not support PCI hot reset used by EEH. Enabled fundamental reset only for Series 7 Changes in V2: None Changes in V3: None Changes in V4: None Changes in V5: None Signed-off-by: Raghava Aditya Renukunta

[PATCH V5 03/10] aacraid: Added EEH support

From: Raghava Aditya Renukunta Added support for PCI EEH(extended error handling). Changes in V2: Made local functions static Removed call to aac_fib_free_tag Set adapter_shutdown flag when PCI error detected Changes in V3: None Changes in V4: Removed

[PATCH V5 10/10] aacraid: Update driver version

From: Raghava Aditya Renukunta Updated diver version to 41052 Changes in V2: None Changes in V3: None Changes in V4: None Changes in V5: None Signed-off-by: Raghava Aditya Renukunta Reviewed-by: Johannes Thumshirn

[PATCH V5 09/10] aacraid: Fix character device re-initialization

From: Raghava Aditya Renukunta During EEH PCI hotplug activity kernel unloads and loads the driver, causing character device to be unregistered(aac_remove_one).When the driver is loaded back using aac_probe_one the character device needs to be registered again

[PATCH V5 07/10] aacraid: Created new mutex for ioctl path

aac_mutex was used to create protect the ioctl path for only the compat path, it would be make more sense to place mutex in aac_do_ioctl, which is the main ioctl function call that handles all ioctl commands. Created new mutex ioctl_mutex in struct aac_dev to protect switch case in aac_do_ioctl

Re: [PATCH] Separate target visibility from reaped state information

On 02/02/2016 04:43 PM, James Bottomley wrote: On Tue, 2016-02-02 at 10:29 -0800, Bart Van Assche wrote: On 02/02/2016 03:46 AM, James Bottomley wrote: diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 4f18a85..00bc721 100644 --- a/drivers/scsi/scsi_sysfs.c +++

Re: [Bug 111441] New: iscsi fails to attach to targets

On Fri, Jan 29, 2016 at 05:32:54PM -0600, Mike Christie wrote: > Hey Christoph and Hannes, > > The dh/alua changes that added this: > > error = scsi_dh_add_device(sdev); > if (error) { > sdev_printk(KERN_INFO, sdev, > "failed to add

RE: [LSF/MM TOPIC] multiqueue and interrupt assignment

> -Original Message- > From: linux-block-ow...@vger.kernel.org [mailto:linux-block- > ow...@vger.kernel.org] On Behalf Of Hannes Reinecke > Sent: Tuesday, February 2, 2016 10:31 AM > To: lsf...@lists.linux-foundation.org; linux-scsi@vger.kernel.org; linux- > bl...@vger.kernel.org >

Re: [PATCH] Separate target visibility from reaped state information

On 02/02/2016 03:46 AM, James Bottomley wrote: diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 4f18a85..00bc721 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -1272,16 +1272,18 @@ static void __scsi_remove_target(struct scsi_target *starget)

RE: [PATCH] megaraid: fix null pointer check in megasas_detach_one().

> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Tuesday, February 02, 2016 7:24 AM > To: Maurizio Lombardi > Cc: sumit.sax...@avagotech.com; kashyap.de...@avagotech.com; > uday.ling...@avagotech.com; linux-scsi@vger.kernel.org; >

Re: [PATCH-v3 12/14] xen-scsiback: Convert to TARGET_SCF_ACK_KREF I/O krefs

Hi Juergen, On Tue, 2016-02-02 at 17:31 +0100, Juergen Gross wrote: > On 30/01/16 08:05, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Cc: Juergen Gross > > Cc: Hannes Reinecke > > Cc: David Vrabel

Re: [PATCH] Separate target visibility from reaped state information

On Mon, Feb 01, 2016 at 08:11:29PM -0500, Martin K. Petersen wrote: > > "Sebastian" == Sebastian Herbszt writes: > > >> The only change from the current workflow is that the DEL transition > >> (now the reaped flag) is done before the spin lock is dropped which > >> would fix

[Bug 98171] [Regression] Marvell SE91xx SATA 3 controllers not recognized correctly

https://bugzilla.kernel.org/show_bug.cgi?id=98171 jrick...@myamigos.us changed: What|Removed |Added CC||jrick...@myamigos.us --- Comment

Re: [PATCH] add support for DWC UFS Host Controller

Hi, In order to make a ufs-dwc-pci glue driver I will need to create a "pci driver lib" like we have already for platform (ufshcd-pltfm.c). Should I call the samsung glue driver ufs-samsung-pci.c which will use common pci functions from a ufshcd-pci.c? Agree? On 2/2/2016 11:49 AM, Julian Calaby

Re: [PATCHv4 13/23] scsi_dh_alua: Use workqueue for RTPG

> static void release_port_group(struct kref *kref) > { > struct alua_port_group *pg; > > + synchronize_rcu(); > pg = container_of(kref, struct alua_port_group, kref); > + if (pg->rtpg_sdev) > + flush_delayed_work(>rtpg_work); > spin_lock(_group_lock); >

Re: [PATCHv4 15/23] scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA'

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH v7 02/14] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers

> Some of the data structures (like response UPIU) and/or its elements > (unused fields) should be cleared before sending out the respective > command to UFS device. > > This change clears the UPIU response data structure for query commands > and NOP command before sending out the command. We

Re: [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads

On Wed, Jan 20, 2016 at 10:35:15PM -0800, Alexander Duyck wrote: > Ultimately neither of these bugs were my root cause. It turns out the > Marvel Console SCSI device in my system needed to have a flag set to > disable VPD access in order to keep things from looping through the error > repeatedly.

Re: [PATCH-v3 3/5] target: Fix TAS handling for multi-session se_node_acls

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH-v3 2/5] target: Fix LUN_RESET active TMR descriptor handling

> + if (WARN_ON_ONCE(!sess)) > + continue; > + > + spin_lock(>sess_cmd_lock); > spin_lock(>t_state_lock); > if (!(cmd->transport_state & CMD_T_ACTIVE)) { > spin_unlock(>t_state_lock); > +

Re: [PATCH] add support for DWC UFS Host Controller

Hi Julian, Thanks for the review. My comments are below. On 2/2/2016 1:00 AM, Julian Calaby wrote: > Hi Joao, > > On Mon, Feb 1, 2016 at 11:47 PM, Joao Pinto wrote: >> This patch includes: >> - quirks in the ufs core driver to support Synopsys MPHY Test Chip config >>

Re: [PATCH-v3 4/5] target: Fix remote-port TMR ABORT + se_cmd fabric stop

> + bool aborted = false, tas = false; > > /* >* Allocate an struct iscsi_conn_recovery for this connection. > @@ -398,7 +399,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn > *conn) > > iscsit_free_all_datain_reqs(cmd); > > -

Re: [PATCH-v3 1/5] target: Fix LUN_RESET active I/O handling for ACK_KREF

> @@ -282,6 +305,16 @@ static void core_tmr_drain_state_list( > if (prout_cmd == cmd) > continue; > > + sess = cmd->se_sess; > + if (WARN_ON_ONCE(!sess)) > + continue; > + > + spin_lock(>sess_cmd_lock); >

Re: [PATCH-v3 5/5] target: Drop legacy se_cmd->task_stop_comp + REQUEST_STOP usage

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[Bug 111731] New: mpt2sas doesn't get built

https://bugzilla.kernel.org/show_bug.cgi?id=111731 Bug ID: 111731 Summary: mpt2sas doesn't get built Product: SCSI Drivers Version: 2.5 Kernel Version: 4.4.0 Hardware: x86-64 OS: Linux Tree: Mainline

Re: [PATCH-v3 12/14] xen-scsiback: Convert to TARGET_SCF_ACK_KREF I/O krefs

On 30/01/16 08:05, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Cc: Juergen Gross > Cc: Hannes Reinecke > Cc: David Vrabel > Signed-off-by: Nicholas Bellinger Sorry, with your

[LSF/MM TOPIC] multiqueue and interrupt assignment

Hi all, here's another topic which I've hit during my performance tests: How should interrupt affinity be handled with blk-multiqueue? The problem is that the blk-multiqueue assumes a certain CPU-to-queue mapping, _and_ the 'queue' in blk-mq syntax is actually a submission/completion queue pair.

Re: [PATCH] Separate target visibility from reaped state information

On Mon, 2016-02-01 at 19:43 -0800, Bart Van Assche wrote: > On 01/19/16 17:03, James Bottomley wrote: > > On Tue, 2016-01-19 at 19:30 -0500, Martin K. Petersen wrote: > > > > > > > > "Bart" == Bart Van Assche > > > > > > > > writes: > > > > > > Bart> Instead of

Re: [PATCH] add support for DWC UFS Host Controller

Hi Julian, I am already changing the architecture and I will send a v2 soon. Thanks for the review. Joao On 2/2/2016 11:44 AM, Julian Calaby wrote: > Hi Joao, > > On Tue, Feb 2, 2016 at 9:22 PM, Joao Pinto wrote: >> Hi Julian, >> >> Thanks for the review. My comments

Re: [PATCH] add support for DWC UFS Host Controller

Hi Joao, On Tue, Feb 2, 2016 at 9:22 PM, Joao Pinto wrote: > Hi Julian, > > Thanks for the review. My comments are below. > > On 2/2/2016 1:00 AM, Julian Calaby wrote: >> Hi Joao, >> >> On Mon, Feb 1, 2016 at 11:47 PM, Joao Pinto wrote: >>> diff

Re: [PATCH] add support for DWC UFS Host Controller

Hi Joao, On Tue, Feb 2, 2016 at 10:47 PM, Joao Pinto wrote: > > Hi Julian, > I am already changing the architecture and I will send a v2 soon. > Thanks for the review. Awesome, I look forward to it. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile:

[Bug 111441] iscsi fails to attach to targets

https://bugzilla.kernel.org/show_bug.cgi?id=111441 --- Comment #10 from Serguei Bezverkhi --- Hello, Any chance we could move forward with this investigation? I still cannot attach to any remove iscsi targets with either 4.4.0 or 4.4.1 kernels. Thank you Serguei

RE: [Bug 111441] New: iscsi fails to attach to targets

Hello, Any chance we could move forward with this investigation? I still cannot attach to any remove iscsi targets with either 4.4.0 or 4.4.1 kernels. Thank you Serguei -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Monday, February 01, 2016 11:55 AM

RE: [patch] bfa: use strncpy() instead of memcpy()

Acked-by: Anil Gurumurthy -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: 30 January 2016 20:06 To: Anil Gurumurthy Cc: Sudarsana Kalluru ; James E.J. Bottomley

Re: [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads

On Tue, Feb 02, 2016 at 09:45:48PM -0500, Martin K. Petersen wrote: > > "Kirill" == Kirill A Shutemov writes: > > Kirill> I have the same problem. > > Kirill> Shouldn't we put quirk for that? > > I was hoping that Hannes' patch would do the trick so we could avoid >

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Hello Finally got my firmware on my DAT updated. Using Kai's latest patch I validated the patch on my DAT driver as well Thanks to Shane for providing the correct mt code, as that was also one of my problems besides firmware. [root@srp-server mt-st-1.1-patched]# ./mt -f /dev/st0 stsetoption

RE: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Hi Kai, I've done more tested. Some stuff didn't work and I've got some suggested changes (there are two changes to the patch and one for the mt command). Testing results first: # echo 1 > /sys/bus/scsi/drivers/st/debug_flag # mt -f /dev/st2 stsetoption can-partitions # mt -f /dev/st1

Re: [PATCH-v3 4/5] target: Fix remote-port TMR ABORT + se_cmd fabric stop

Btw, here's the updated patch: >From 731b9981fc49d9b11e93b5c2f0a56e27862b4335 Mon Sep 17 00:00:00 2001 From: Nicholas Bellinger Date: Tue, 19 Jan 2016 15:23:02 -0800 Subject: [PATCH] target: Fix remote-port TMR ABORT + se_cmd fabric stop To address the bug where fabric

Re: [PATCH] Separate target visibility from reaped state information

On Tue, 2016-02-02 at 17:17 -0800, Bart Van Assche wrote: > On 02/02/2016 04:43 PM, James Bottomley wrote: > > On Tue, 2016-02-02 at 10:29 -0800, Bart Van Assche wrote: > > > On 02/02/2016 03:46 AM, James Bottomley wrote: > > > > diff --git a/drivers/scsi/scsi_sysfs.c > > > >

Re: [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads

> "Kirill" == Kirill A Shutemov writes: Kirill> I have the same problem. Kirill> Shouldn't we put quirk for that? I was hoping that Hannes' patch would do the trick so we could avoid blacklisting: https://patchwork.kernel.org/patch/8079011/ -- Martin K.