Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > Constify local structures. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > Just my two cents but: > > 1. You *can* use a static

Re: Observing Softlockup's while running heavy IOs

2016-09-12 Thread Sreekanth Reddy
On Thu, Sep 8, 2016 at 7:09 PM, Neil Horman wrote: > On Thu, Sep 08, 2016 at 11:12:40AM +0530, Sreekanth Reddy wrote: >> On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman wrote: >> > On Wed, Sep 07, 2016 at 11:30:04AM +0530, Sreekanth Reddy wrote: >> >> On

[Bug 156321] mpt3sas timeout with xen, works only with mpt3sas.msix_disable=1 (SAS3008 card)

2016-09-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=156321 --- Comment #3 from Sreekanth Reddy --- Hi John, Recently our FW team has fixed this type of issue in the Firmware. Maybe this fix went in the Phase13 FW. So you may need to wait to some more time until this

[PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY

2016-09-12 Thread Hannes Reinecke
SPC-2 and SPC-3 (or later) differ in the handling of reservation conflict for TEST UNIT READY. SPC-2 will return 'reservation conflict', whereas SPC-3 will return GOOD status. On a mixed system with both SPC-2 and SPC-3 targets one will see lots of 'reservation conflict' messages from the SPC-2

Re: status of NCR5380-based ISA drivers

2016-09-12 Thread Michael Schmitz
Christoph, I test the atari_scsi front end - haven't got any ISA cards handy. Probably no ISA slots on my PC main board either ... Cheers, Michael Am 12.09.2016 um 05:12 schrieb Christoph Hellwig: > Hi all, > > you seem to the currently active NCR580 cabal. Which frontends to NCR5380

Re: Observing Softlockup's while running heavy IOs

2016-09-12 Thread Neil Horman
On Mon, Sep 12, 2016 at 01:48:39PM +0530, Sreekanth Reddy wrote: > On Thu, Sep 8, 2016 at 7:09 PM, Neil Horman wrote: > > On Thu, Sep 08, 2016 at 11:12:40AM +0530, Sreekanth Reddy wrote: > >> On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman wrote: > >> >

Re: [PATCH 12/26] [SCSI] hptiop: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > Constify local structures. > > > > > > The semantic patch that makes this change is as follows: > > >

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > > Constify local structures. > > > > > > > > The

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Felipe Balbi
Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >>

[PATCH] scsi: megaraid_sas: add in missing white space in error message text

2016-09-12 Thread Colin King
From: Colin Ian King A dev_printk message spans two lines and the literal string is missing a white space between words. Add the white space. Signed-off-by: Colin Ian King --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 1 file changed,

[PATCH] scsi: introduce a quirk for false cache reporting

2016-09-12 Thread Oliver Neukum
Some SATA to USB bridges fail to cooperate with some drives resulting in no cache being present being reported to the host. That causes the host to skip sending a command to synchronize caches. That causes data loss when the drive is powered down. Signed-off-by: Oliver Neukum

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Geert Uytterhoeven
On Mon, Sep 12, 2016 at 3:43 PM, Felipe Balbi wrote: > Jarkko Sakkinen writes: >> On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >>> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >>> > On Sun, Sep 11, 2016 at 03:05:42PM

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 03:52:08PM +0200, Julia Lawall wrote: > > > On Mon, 12 Sep 2016, Felipe Balbi wrote: > > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >> > > >> > > >> On Sun, 11 Sep

[Bug 156321] mpt3sas timeout with xen, works only with mpt3sas.msix_disable=1 (SAS3008 card)

2016-09-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=156321 --- Comment #4 from john.wy...@gmx.de --- Thanks. I will keep an eye open for the new firmware to be published and will report back here. -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubscribe from

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > >> > On Sun, Sep 11, 2016 at

TRIM/UNMAP/DISCARD via ATA Passthrough

2016-09-12 Thread Jason A. Donenfeld
Hi folks, There's a huge quantity of USB enclosures flooding the market for quite sometime that support UASP, which is very nice. This allows for higher speeds by using the SCSI command set via the uas driver, and offers various other advantages over the classic usb-storage driver. These USB

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-09-12 Thread Alan Stern
On Mon, 12 Sep 2016, Oliver Neukum wrote: > Some SATA to USB bridges fail to cooperate with some > drives resulting in no cache being present being reported > to the host. That causes the host to skip sending > a command to synchronize caches. That causes data loss > when the drive is powered

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >> > > >> > > >> On Sun, 11 Sep 2016,

[RFC][PATCH v1 2/2] libsas: Fix hotplug issue in libsas

2016-09-12 Thread Yijing Wang
Now the libsas hotplug has some issues, Dan Williams report a similar bug here: https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg39187.html The root cause of the issues is we use one workqueue(shost->work_q) to process libsas event, and we divide a hot-on or hot-remove flow to several

[RFC][PATCH v1 1/2] libsas: Alloc dynamic work to avoid missing sas events

2016-09-12 Thread Yijing Wang
Now libsas hotplug work is static, LLDD driver queue the hotplug work into shost->work_q. If LLDD driver burst post lots hotplug event to libsas, the hotplug events may pending in the workqueue like shost->workq tail | PHYE_LOSS_OF_SIGNAL | PORTE_BYTES_DMAED | head In this case, if a new

Re: [PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY

2016-09-12 Thread Laurence Oberman
- Original Message - > From: "Hannes Reinecke" > To: "Martin K. Petersen" > Cc: "Christoph Hellwig" , "James Bottomley" > , > linux-scsi@vger.kernel.org, "Hannes Reinecke" ,