Re: [PATCH v2 00/14] qla2xxx: Bug Fixes and updates for target.

On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: > Please consider this series for inclusion in target-pending. Hello Himanshu, I gave this patch series a try on a system equipped with two QLogic FC HBAs where an FC cable connects both HBAs to each other. qlini_mode has been set to

Re: [PATCH v2 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

On 8.2.2017 10:29, Shivasharan S wrote: > fix in v2 - split patches into two. > discussed below > http://marc.info/?l=linux-scsi=148638999110404=2 > > No functional change. Code clean up. Removing error code which is not > valid scenario. > In megasas_get_request_descriptor we can remove the

[PATCH -next] scsi: sd: make sd_devt_release() static

From: Wei Yongjun Fixes the following sparse warning: drivers/scsi/sd.c:3087:6: warning: symbol 'sd_devt_release' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/scsi/sd.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

David Miller writes: > From: Florian Fainelli > Date: Tue, 7 Feb 2017 15:02:53 -0800 > >> I'm hoping this doesn't conflict with what's already in net-next... >> >> David, this should probably go via your tree considering the diffstat. > > I think you

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

From: Florian Fainelli Date: Tue, 7 Feb 2017 15:02:53 -0800 > I'm hoping this doesn't conflict with what's already in net-next... > > David, this should probably go via your tree considering the diffstat. I think you need one more respin. Are you doing an allmodconfig

Re: [PATCH 4/5] target: Fix multi-session dynamic se_node_acl double free OOPs

On Tue, 2017-02-07 at 19:46 -0800, Nicholas A. Bellinger wrote: > On Tue, 2017-02-07 at 15:12 -0800, Christoph Hellwig wrote: > > And the real patch after compile fixing it is here of course: > > > > Getting rid of the extra se_node_acl->acl_free_comp seems to make sense > here.. > > The only

Re: [PATCH v2 10/39] megaraid_sas: NVME Interface detection and prop settings

On 8.2.2017 10:29, Shivasharan S wrote: > New functionality > Adding detection logic for NVME device attached behind Ventura controller. > Driver set HostPageSize in IOC_INIT frame to inform about page size for NVME > devices. > Firmware reports NVME page size to the driver. > PD INFO DCMD

Re: [PATCH v2 09/39] megaraid_sas: change issue_dcmd to return void from int

On 8.2.2017 10:29, Shivasharan S wrote: > fix in v2 : > 1. split patches into two as discussed below > http://marc.info/?l=linux-scsi=148638999110404=2 > 2. issue_dcmd return type changed from int to void. > > > With the changes to remove checks for a valid request descriptor, > issue_dcmd will

Re: [RFC 07/19] wireless: ipw2200: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:45PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

Re: [RFC 12/19] scsi: mpt3sas: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:50PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

Re: [RFC 08/19] scsi: be2iscsi: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:46PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by:

Re: [PATCH v2 01/14] qla2xxx: Fix delayed response to command for loop mode/direct connect.

On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: > +static void qla2x00_iocb_work_fn(struct work_struct *work) > +{ > + struct scsi_qla_host *vha = container_of(work, > + struct scsi_qla_host, iocb_work); > + unsigned long flags; > + int cnt = 0; > + > + while

Re: [RFC 01/19] block: DAC960: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:39PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier Tested by compilation only. Some

Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion

On Tue, 2017-02-07 at 14:44 -0800, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 01:17:46PM +, Nicholas A. Bellinger wrote: > > + if (orig->se_lun_acl != NULL) { > > + pr_warn_ratelimited("Detected existing explicit" > > + "

Re: [RFC 06/19] mlx5: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:44PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

Re: [RFC 16/19] usb: gadget: net2280: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:54PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by:

Re: [PATCH v2 00/14] qla2xxx: Bug Fixes and updates for target.

Hi Bart, On 2/8/17, 7:02 AM, "Bart Van Assche" wrote: >On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: >> Please consider this series for inclusion in target-pending. > >Hello Himanshu, > >I gave this patch series a try on a system equipped with two

Re: [RFC 13/19] scsi: mvsas: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:51PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/mvsas/mv_init.c |

Re: [RFC 09/19] scsi: csiostor: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:47PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/csiostor/csio_hw.h

Re: [RFC 18/19] PCI: Remove PCI pool macro functions

On Wed, Feb 08, 2017 at 05:34:56PM +0100, Romain Perier wrote: > Now that all the drivers use dma pool API, we can remove the macro > functions for PCI pool. Good news: make allyesconfig;make succeed after the changes until this point, but: $ grep -R pci_pool ...

Re: [RFC 04/19] net: e100: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:42PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by:

Re: [PATCH v2 02/14] qla2xxx: Allow relogin to proceed if remote login did not finish

On 2/8/17, 10:42 AM, "Bart Van Assche" wrote: >The above code occurs two times in this patch. We try to avoid duplicating >code in the Linux kernel, especially code that contains hardcoded constants. >Have you considered to change the name of plogi_nack_done_jiff

Re: [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E

On 2/8/2017 4:47 AM, Christoph Hellwig wrote: On Tue, Feb 07, 2017 at 06:32:30PM -0800, James Smart wrote: I realize I cut these in a silly way. In the v1 patches, I had a big patch that I then cut into 6 parts, by file. In the v2 patches, I tried to keep the patches as is, and address the

Re: [RFC 05/19] mlx4: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:43PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by:

Re: [PATCH v2 04/14] qla2xxx: Use IOCB interface to submit non-critical MBX.

On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: > diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c > index db6bd92..4225256 100644 > --- a/drivers/scsi/qla2xxx/qla_mbx.c > +++ b/drivers/scsi/qla2xxx/qla_mbx.c > @@ -10,6 +10,29 @@ > #include > #include >

Re: [RFC 11/19] scsi: megaraid: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:49PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

Re: [PATCH v2 10/14] qla2xxx: Fix request queue corruption.

On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: > From: Quinn Tran > > When FW notify driver or driver detects low FW resource, > driver tries to send out Busy SCSI Status to tell Initiator > side to back off. During the send process, the lock was not held. > >

[PATCH v2] scsi/sd: release scan_mutex during sync_cache and start_stop

When a device is deleted through sysfs handle "delete", the code locks shost->scan_mutex. If multiple devices are deleted at the same time, these deletes will be handled in series. On the other hand, sd_shutdown() sometimes issues long latency commands: sync cache and start_stop. It is not

Re: [PATCH v2 02/14] qla2xxx: Allow relogin to proceed if remote login did not finish

On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: > + if (fcport->fw_login_state == DSC_LS_PLOGI_COMP) { > + unsigned long t = fcport->plogi_nack_done_jiff + HZ; > + > + if (time_before_eq(jiffies, t)) > + return; > + } The above code

Re: [RFC 00/19] Replace PCI pool by DMA pool API

On Wed, Feb 08, 2017 at 05:34:38PM +0100, Romain Perier wrote: Hi Romain, Nice set of patches! Thank you. I sent a few comments, but basically you missed to run checkpatch.pl on your patches. Also you can take the chance to fix some white space issues that are on the lines you are changing like

Re: [PATCH v2 06/14] qla2xxx: Improve T10-DIF/PI handling in driver.

On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: > + /* Response code and sense key */ > + ((uint32_t *)ctio->u.status1.sense_data)[0] = > + cpu_to_le32((0x70 << 24) | (sense_key << 8)); > + /* Additional sense length */ > + ((uint32_t

Re: [RFC 02/19] dmaengine: pch_dma: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:40PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by:

Re: [RFC 19/19] checkpatch: warn for use of old PCI pool API

On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote: > pci_pool_*() functions should be replaced by the corresponding functions > in the DMA pool API. This adds support to check for use of these pci > functions and display a warning when it is the case. Don't know if relevant, but did

Re: [PATCH v2 03/14] qla2xxx: Allow vref count to timeout on vport delete.

On 2/8/17, 5:03 AM, "Christoph Hellwig" wrote: >On Fri, Feb 03, 2017 at 02:40:44PM -0800, Himanshu Madhani wrote: >> -spin_lock_irqsave(>vport_slock, flags); >> -while (atomic_read(>vref_count)) { >> -spin_unlock_irqrestore(>vport_slock, flags); >> - >> +

Re: [PATCH v2 06/14] qla2xxx: Improve T10-DIF/PI handling in driver.

Hi Nic, On 2/7/17, 8:13 PM, "Nicholas A. Bellinger" wrote: >On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> Add routines to support T10 DIF tag. >> >> Signed-off-by: Quinn Tran >>

Re: [RFC 17/19] usb: gadget: pch_udc: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:55PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- >

Re: [RFC 15/19] usb: gadget: amd5536udc: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:53PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by:

Re: [PATCH v2 06/14] qla2xxx: Improve T10-DIF/PI handling in driver.

Hi Bart, On 2/8/17, 10:57 AM, "Bart Van Assche" wrote: >On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: >> +/* Response code and sense key */ >> +((uint32_t *)ctio->u.status1.sense_data)[0] = >> +cpu_to_le32((0x70 << 24) | (sense_key <<

Re: [RFC 14/19] scsi: pmcraid: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:52PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by:

Re: [RFC 03/19] IB/mthca: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:41PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Tested by compilation only. Acked-by: Peter Senna Tschudin Tested-by:

Re: [RFC 19/19] checkpatch: warn for use of old PCI pool API

On Wed, 2017-02-08 at 19:55 +0100, Peter Senna Tschudin wrote: > On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote: > > pci_pool_*() functions should be replaced by the corresponding functions > > in the DMA pool API. This adds support to check for use of these pci > > functions and

RE: [PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

> > +static inline void > > +megasas_complete_r1_command(struct megasas_instance *instance, > > + struct megasas_cmd_fusion *cmd) { > > + u8 *sense, status, ex_status; > > + u32 data_length; > > + u16 peer_smid; > > + struct fusion_context *fusion; > > + struct

Re: [PATCH v2 04/14] qla2xxx: Use IOCB interface to submit non-critical MBX.

On 2/8/17, 10:48 AM, "Bart Van Assche" wrote: >On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: >> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c >> index db6bd92..4225256 100644 >> --- a/drivers/scsi/qla2xxx/qla_mbx.c >> +++

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

On 02/08/2017 08:11 AM, Kalle Valo wrote: > David Miller writes: > >> From: Florian Fainelli >> Date: Tue, 7 Feb 2017 15:02:53 -0800 >> >>> I'm hoping this doesn't conflict with what's already in net-next... >>> >>> David, this should probably go via

Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT to 128 for default larger sg_io capability

We have been seeing issues with qemu_kvm virtual guests where if they issue I/O to direct attached SCSI passthrough LUNS with large I/O sizes such as 512K the sg_io will fail with -EINVAL. Simple reproducer is here. strace -e ioctl sg_dd if=/dev/zero of=/dev/sdae bpt=0x400 count=0x400

Re: [RFC 10/19] scsi: lpfc: Replace PCI pool old API

On Wed, Feb 08, 2017 at 05:34:48PM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. > > Signed-off-by: Romain Perier > --- > drivers/scsi/lpfc/lpfc.h |

Re: [PATCH v2] scsi/sd: release scan_mutex during sync_cache and start_stop

On Wed, Feb 08, 2017 at 12:42:40PM -0800, Song Liu wrote: > When a device is deleted through sysfs handle "delete", the code > locks shost->scan_mutex. If multiple devices are deleted at the > same time, these deletes will be handled in series. > > On the other hand, sd_shutdown() sometimes

[PATCH v3] scsi/sd: release scan_mutex during sync_cache and start_stop

When a device is deleted through sysfs handle "delete", the code locks shost->scan_mutex. If multiple devices are deleted at the same time, these deletes will be handled in series. On the other hand, sd_shutdown() sometimes issues long latency commands: sync cache and start_stop. It is not

Re: [PATCH v3] scsi/sd: release scan_mutex during sync_cache and start_stop

> On Feb 8, 2017, at 2:53 PM, Song Liu wrote: > > When a device is deleted through sysfs handle "delete", the code > locks shost->scan_mutex. If multiple devices are deleted at the > same time, these deletes will be handled in series. > > On the other hand, sd_shutdown()

Re: [PATCH v2] scsi/sd: release scan_mutex during sync_cache and start_stop

> On Feb 8, 2017, at 1:02 PM, Christoph Hellwig wrote: > > On Wed, Feb 08, 2017 at 12:42:40PM -0800, Song Liu wrote: >> When a device is deleted through sysfs handle "delete", the code >> locks shost->scan_mutex. If multiple devices are deleted at the >> same time, these

Darlehen

Sie benötigen eine Finanzierung? Wir vergeben Darlehen. Bewerben Sie sich jetzt. Senden Sie uns u.a. Details zurück und Sie erhalten in Kürze Antwort Vorname: Familienname: Geschlecht: Land: Telefonnummer: benötigter Darlehensbetrag: Gewünschte Laufzeit: Mit

Re: [PATCH v3] scsi/sd: release scan_mutex during sync_cache and start_stop

On Wed, 2017-02-08 at 14:53 -0800, Song Liu wrote: > + try_lock_scan_mutex = mutex_trylock(>scan_mutex); This is at least as bad as the approach of your previous patch because whether or not this mutex_trylock() call succeeds not only depends on whether or not the caller holds the scan_mutex

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

On Mon, 2017-02-06 at 21:42 -0800, Dan Williams wrote: > On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe wrote: > > On 02/06/2017 05:14 PM, James Bottomley wrote: > > > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: > > > > On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig

[PATCH v4] scsi/sd: release scan_mutex during sync_cache and start_stop

When a device is deleted through sysfs handle "delete", the code locks shost->scan_mutex. If multiple devices are deleted at the same time, these deletes will be handled in series. On the other hand, sd_shutdown() sometimes issues long latency commands: sync cache and start_stop. It is not

Re: [PATCH v3] scsi/sd: release scan_mutex during sync_cache and start_stop

> On Feb 8, 2017, at 2:58 PM, Bart Van Assche > wrote: > > On Wed, 2017-02-08 at 14:53 -0800, Song Liu wrote: >> +try_lock_scan_mutex = mutex_trylock(>scan_mutex); > > This is at least as bad as the approach of your previous patch because > whether or not this

Re: Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT to 128 for default larger sg_io capability

- Original Message - > From: "Laurence Oberman" > To: "Linux SCSI List" > Sent: Wednesday, February 8, 2017 3:07:12 PM > Subject: Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT to 128 for > default larger sg_io capability > >

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

On Wed, Dec 28, 2016 at 4:35 PM, ojab wrote: > MPI2 controllers sometimes got lost (i. e. disappears from > /sys/bus/pci/devices) if ASMP is enabled. > > Signed-off-by: Slava Kardakov > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=60644 >From some of our system

[PATCH v2 13/39] megaraid_sas: raid 1 write performance for large io

Avoid Host side PCI bandwidth bottleneck and hint FW to do Write buffering using RaidFlag MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT. Once IO is landed in FW with MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT, it will do single DMA from host and buffer the Write operation. On back end, FW will DMA same

[PATCH v2 03/39] megaraid_sas: raid 1 fast path code optimize

fix in v2 - ex_status and status was wrongly re-used in megasas_complete_r1_command. discussed below - http://marc.info/?l=linux-scsi=148638763409385=2 No functional change. Code refactor. Remove function megasas_fpio_to_ldio as we never require to convert fpio to ldio because of frame

[PATCH v2 11/39] megaraid_sas: NVME interface target prop added

This patch fetch true values of NVME property from FW using New DCMD interface MR_DCMD_DEV_GET_TARGET_PROP Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke Reviewed-by:

[PATCH v2 17/39] megaraid_sas: reduce size of fusion_context and use vmalloc if kmalloc fails

Currently fusion context has fixed array load_balance_info. Use dynamic allocation. In few places, driver do not want physically contigious memory. Attempt to use vmalloc if physical contiguous memory is not available. Signed-off-by: Shivasharan S

[PATCH v2 20/39] megaraid_sas: Big endian RDPQ mode fix

Fix if RDPQ mode enabled MR FW is deployed on big endian host machine, driver does not setup reply address correctly. Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke

[PATCH v2 19/39] megaraid_sas: MR_TargetIdToLdGet u8 to u16 and avoid invalid raid-map access

fix in v2 - updated description content. Change MR_TargetIdToLdGet return type from u8 to u16. ld id range check is added at two places in this patch - @megasas_build_ldio_fusion and @megasas_build_ld_nonrw_fusion. Previous driver code used different data type for lds TargetId returned from

[PATCH v2 12/39] megaraid_sas: NVME fast path io support

This patch provide true fast path IO support. Driver creates PRP for NVME drives and send Fast Path for performance. Certain h/w requirement needs to be taken care in driver. Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai

[PATCH v2 28/39] megaraid_sas: megasas_return_cmd does not memset IO frame to zero

Memset the IO frame to zero after release. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl ---

[PATCH v2 24/39] megaraid_sas: set pd_after_lb from MR_BuildRaidContext and initialize pDevHandle to MR_DEVHANDLE_INVALID

Issue is limited for Syncro firmware where pd_after_lb is not set but is accidentally used. Not a functional issue, but results in low performance due to improper load balancing between two LUNs. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S

[PATCH v2 27/39] megaraid_sas: max_fw_cmds are decremented twice, remove duplicate

Fix to account for the reply_q_sz not exceeding the maximum commands that the firmware can support, instance->max_fw_cmds is already decremented in megasas_fusion_update_can_queue(). Remove the extra decrement logic in code. Signed-off-by: Kashyap Desai Signed-off-by:

[PATCH v2 16/39] megaraid_sas: add print in device removal path

Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_base.c | 19 +++ 1 file

[PATCH v2 09/39] megaraid_sas: change issue_dcmd to return void from int

fix in v2 : 1. split patches into two as discussed below http://marc.info/?l=linux-scsi=148638999110404=2 2. issue_dcmd return type changed from int to void. With the changes to remove checks for a valid request descriptor, issue_dcmd will now always return DCMD_SUCCESS. This patch changes

Re: [PATCH v2 09/39] megaraid_sas: change issue_dcmd to return void from int

On 02/08/2017 10:29 AM, Shivasharan S wrote: > fix in v2 : > 1. split patches into two as discussed below > http://marc.info/?l=linux-scsi=148638999110404=2 > 2. issue_dcmd return type changed from int to void. > > > With the changes to remove checks for a valid request descriptor, >

[PATCH v2 32/39] megaraid_sas: Change build_mpt_mfi_pass_thru to return void

Code refactoring to build_mpt_mfi_pass_thru to return void. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl ---

[PATCH v2 14/39] megaraid_sas: set residual bytes count during IO completion

Fixing issue of not setting residual bytes correctly. Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl ---

[PATCH v2 21/39] megaraid_sas: big endian support changes

Fix endiannes fixes for Ventura specific. Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl ---

[PATCH v2 26/39] megaraid_sas: update can_queue only if the new value is less

Minor Optimization: No need to update HBA can_queue value if the current max FW commands is equal to earlier value. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke

[PATCH v2 31/39] megaraid_sas: During OCR, if get_ctrl_info fails do not continue with OCR

Error handling: If controller reset is not able to recover, kill HBA and quit immediately. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl

[PATCH v2 37/39] megaraid_sas: Indentation and smatch warning fixes

Fix indentation issues and smatch warning reported by Dan Carpenter for previous series as discussed below. http://www.spinics.net/lists/linux-scsi/msg103635.html http://www.spinics.net/lists/linux-scsi/msg103603.html Reported-by: Dan Carpenter Signed-off-by: Kashyap

[PATCH v2 25/39] megaraid_sas: Change max_cmd from u32 to u16 in all functions

Since maximum supported FW commands are all defined as u16, change all local variables referring to max_cmd from u32 to u16. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke

[PATCH v2 34/39] megaraid_sas: Use synchronize_irq to wait for IRQs to complete

FIX - Do not use random delay to synchronize with IRQ. Use kernel API. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl ---

[PATCH v2 36/39] megaraid_sas: Cleanup VD_EXT_DEBUG and SPAN_DEBUG related debug prints

Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas.h| 2 -

[PATCH v2 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

fix in v2 - split patches into two. discussed below http://marc.info/?l=linux-scsi=148638999110404=2 No functional change. Code clean up. Removing error code which is not valid scenario. In megasas_get_request_descriptor we can remove the error handling which is not required. With fusion

[PATCH v2 02/39] megaraid_sas: cpu select rework.

No functional change. Code refactor. Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl ---

[PATCH v2 07/39] megaraid_sas: Use DID_REQUEUE

Moving to use DID_REQUEUE return type for reliable unconditional retries. Driver wants unconditional re-queue, so replace DID_RESET with DID_REQUEUE Discussed below - https://www.spinics.net/lists/linux-scsi/msg102848.html Signed-off-by: Shivasharan S

[PATCH v2 04/39] megaraid_sas: 32 bit descriptor fire cmd optimization

No functional change. Code refactor. megasas_fire_cmd_fusion can always use 32 bit descriptor write for ventura. No need to pass extra flag. Only IOC INIT required 64 bit Descriptor write. Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai

[PATCH v2 15/39] megaraid_sas: enhance debug logs in OCR context

Add additional logging from driver in OCR context. Add debug logs for partial completion of IOs is iodone context. Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke

[PATCH v2 30/39] megaraid_sas: Do not set fp_possible if TM capable for non-RW syspdIO, change fp_possible to bool

FIX - firmware wants non-RW SYS PD IOs to avoid FastPath for better tracking and other functionalities if the device is task management capable. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes

[PATCH v2 10/39] megaraid_sas: NVME Interface detection and prop settings

New functionality Adding detection logic for NVME device attached behind Ventura controller. Driver set HostPageSize in IOC_INIT frame to inform about page size for NVME devices. Firmware reports NVME page size to the driver. PD INFO DCMD provide new interface type NVME_PD. Driver set property of

[PATCH v2 33/39] megaraid_sas: Bail out the driver load if ld_list_query fails

Error handling: Bail out the driver load if key FW cmds (LD_LIST) are not return successful. Clean up error handling in megasas_init_fw. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke

[PATCH v2 00/39] megaraid_sas: Updates for scsi-next

Changes in v2: Patch 3: Fix to update status and ex_status from failed r1_cmd Patch 8: Split into two separate patches, 1. megasas_get_request_descriptor will always return valid request descriptor 2. With above changes, issue_dcmd always return DCMD_SUCCESS. Change return type to void

[PATCH v2 05/39] megaraid_sas: Refactor MEGASAS_IS_LOGICAL macro using sdev

Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas.h| 4 ++--

[PATCH v2 01/39] Revert "scsi: megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth"

This reverts commit "3e5eadb1a881" ("scsi: megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth") This patch was aimed to increase performance of R1 Write operation for large IO size. Since this method used timer approach, it turn on/off fast path did not work as

[PATCH v2 39/39] megaraid_sas: driver version upgrade

Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2

[PATCH v2 35/39] megaraid_sas: Increase internal command pool

Fix - increase internal command pool to 8. Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl ---

[PATCH v2 38/39] megaraid_sas: Change RAID_1_10_RMW_CMDS to RAID_1_PEER_CMDS and set value to 2

For RAID1 FastPath writes, driver needs to allocate extra commands internally to accommodate for the extra peer command being sent. Currently driver is allocating 2 extra commands for each but only one extra command is necessary. Set RAID_1_10_RMW_CMDS to 2 and also change macro name to

[PATCH v2 06/39] megaraid_sas: RAID map is accessed for SYS PDs when use_seqnum_jbod_fp is not set

Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas_base.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git

[PATCH v2 18/39] megaraid_sas: In validate raid map, raid capability is not converted to cpu format for all lds

On a host, if an ld is deleted there is a hole in the ld array returned by the FW. But in MR_ValidateMapInfo we are not accounting for holes in the ld array and traverse only upto index num_lds. This patch takes care of converting the capability field of all the valid lds in the ld raid map.

[PATCH v2 23/39] megaraid_sas: latest controller OCR capability from FW before sending shutdown DCMD

Fetch the latest controller OCR capability from FW before sending MR_DCMD_CTRL_SHUTDOWN When application sends a shutdown DCMD (MR_DCMD_CTRL_SHUTDOWN), driver will fetch latest controller information from firmware. This is to ensure that driver always has latest OCR capability of controller before

[PATCH v2 22/39] megaraid_sas: avoid unaligned access in ioctl path

Fix kernel warning for accessing unaligned memory access in driver. Signed-off-by: Shivasharan S Signed-off-by: Kashyap Desai Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl ---

[PATCH v2 29/39] megaraid_sas: Remove unused pd_index from megasas_build_ld_nonrw_fusion

Signed-off-by: Kashyap Desai Signed-off-by: Shivasharan S Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +-- 1 file changed, 1

Re: [PATCH v2 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

On 02/08/2017 10:29 AM, Shivasharan S wrote: > fix in v2 - split patches into two. > discussed below > http://marc.info/?l=linux-scsi=148638999110404=2 > > No functional change. Code clean up. Removing error code which is not > valid scenario. > In megasas_get_request_descriptor we can remove

Re: [PATCH v2 01/18] lpfc: Correct WQ creation for pagesize

Looks fine, Reviewed-by: Christoph Hellwig On Mon, Feb 06, 2017 at 03:08:50PM -0800, James Smart wrote: > > Correct WQ creation for pagesize Except that the (partial) subject should not be repeated in the body.

  1   2   >