Re: [PATCH v3 01/16] lpfc: Correct WQ creation for pagesize

2017-03-07 Thread Greg KH
On Tue, Mar 07, 2017 at 10:44:51AM -0300, Mauricio Faria de Oliveira wrote: > Hello stable kernel maintainers, > > On 03/07/2017 12:35 AM, Martin K. Petersen wrote: > > Mauricio> Please flag this patch for stable. > > > > Mauricio> This patch resolves a serious problem on IBM Power systems at >

RE: [PATCH] storvsc: workaround for virtual DVD SCSI version

2017-03-07 Thread KY Srinivasan
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, March 7, 2017 9:16 AM > To: KY Srinivasan ; Haiyang Zhang > ; Long Li ; > martin.peter...@oracle.com; h...@lst.de;

Re: [PATCH] lpfc: Finalize Kconfig options for nvme

2017-03-07 Thread Christoph Hellwig
> +#if defined(CONFIG_NVME_FC) > +#define CONFIG_LPFC_NVME_INITIATOR > +#endif > + > +#if defined(CONFIG_NVME_TARGET_FC) > +#define CONFIG_LPFC_NVME_TARGET > +#endif The CONFIG_* namespace is reserved for Kconfig defined symbols. Also I think the above is wrong if the nvme fc core code is built

RE: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-07 Thread Reshetova, Elena
> Hello. > > On 03/06/2017 05:20 PM, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > >

RE: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-07 Thread Reshetova, Elena
> On 03/06/2017 03:21 PM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > >

Re: [PATCH 12/29] drivers, media: convert s2255_dev.num_channels from atomic_t to refcount_t

2017-03-07 Thread Sakari Ailus
Hi Elena, On Mon, Mar 06, 2017 at 04:20:59PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-07 Thread Sakari Ailus
On Mon, Mar 06, 2017 at 04:20:58PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. >

Re: [PATCH v3 01/16] lpfc: Correct WQ creation for pagesize

2017-03-07 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Mauricio, Mauricio> Please flag this patch for stable. Mauricio> This patch resolves a serious problem on IBM Power systems at Mauricio> least. Both patches are already upstream so I can't tag them for

Re: [PATCH 13/29] drivers, media: convert vb2_vmarea_handler.refcount from atomic_t to refcount_t

2017-03-07 Thread Sakari Ailus
Hi Elena, On Mon, Mar 06, 2017 at 04:21:00PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: Help needed for a SCSI hang (SATA drives)

2017-03-07 Thread Jack Wang
2017-03-07 1:54 GMT+01:00 V : > Hi, > > I am reaching out regarding a SCSI error handler issue, which we see > in our lab systems. > > Environment: Ubuntu 4.4.0-31-generic > > Issue: Write IOs are getting stuck in our system randomly. All drives > seen with the issue are

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-07 Thread Sergei Shtylyov
On 3/7/2017 10:52 AM, Reshetova, Elena wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena

Re: [RFC] hv_storvsc: error handling.

2017-03-07 Thread Christoph Hellwig
> Was the invalid LUN in the LUN0 position. Inquiry of LUN0 support (when LUN0 > is not populated) > was added only recently to address host side issue. How does HyperV expect device scanning to happen for a not populated LUN? REPORT SUPPORTED LUNS but nothing else on LUN 0? Maybe a TEST UNIT

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-03-07 Thread Mauricio Faria de Oliveira
Martin, On 03/07/2017 02:24 AM, Benjamin Herrenschmidt wrote: On Mon, 2017-03-06 at 22:46 -0500, Martin K. Petersen wrote: I don't recall a consensus being reached on this patch. What would be the opposition ? Without it kexec breaks. With it, it works ... That is the argument I'd

RE: [RFC] hv_storvsc: error handling.

2017-03-07 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Monday, March 6, 2017 9:06 PM > To: KY Srinivasan > Cc: Stephen Hemminger ; James > Bottomley ; Hannes Reinecke >

Re: [PATCH v3 01/16] lpfc: Correct WQ creation for pagesize

2017-03-07 Thread Mauricio Faria de Oliveira
Hi Martin, On 03/07/2017 12:35 AM, Martin K. Petersen wrote: Mauricio> Please flag this patch for stable. Both patches are already upstream so I can't tag them for stable. Either you or James should mail sta...@vger.kernel.org and request for the patches to be queued up. Right, sorry; I

Re: [bdi_unregister] 165a5e22fa INFO: task swapper:1 blocked for more than 120 seconds.

2017-03-07 Thread Jan Kara
On Mon 06-03-17 09:25:42, James Bottomley wrote: > On Mon, 2017-03-06 at 17:13 +0100, Jan Kara wrote: > > On Mon 06-03-17 07:44:55, James Bottomley wrote: ... > > > > Sure. The call trace is: > > > > > > > > [ 41.919244] [ cut here ] > > > > [ 41.919263] WARNING: CPU:

RE: [PATCH 13/29] drivers, media: convert vb2_vmarea_handler.refcount from atomic_t to refcount_t

2017-03-07 Thread Reshetova, Elena
> Hi Elena, > > On Mon, Mar 06, 2017 at 04:21:00PM +0200, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to

With due respect

2017-03-07 Thread U B A
Base on the last email i sent to you, I wish to bring to your notice that i am still waiting patiently for your response. Mrs. Anna Johnson.

RE: [PATCH 12/29] drivers, media: convert s2255_dev.num_channels from atomic_t to refcount_t

2017-03-07 Thread Reshetova, Elena
> Hi Elena, > > On Mon, Mar 06, 2017 at 04:20:59PM +0200, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to

RE: [PATCHv2] hpsa: expose enclosures

2017-03-07 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, February 23, 2017 4:55 AM > To: Martin K. Petersen > Cc: Christoph Hellwig ; James Bottomley > ; linux-scsi@vger.kernel.org;

Re: [PATCH v3 01/16] lpfc: Correct WQ creation for pagesize

2017-03-07 Thread Mauricio Faria de Oliveira
Hello stable kernel maintainers, On 03/07/2017 12:35 AM, Martin K. Petersen wrote: Mauricio> Please flag this patch for stable. Mauricio> This patch resolves a serious problem on IBM Power systems at Mauricio> least. Both patches are already upstream so I can't tag them for stable. Either you

Re: [PATCHv2] hpsa: expose enclosures

2017-03-07 Thread Hannes Reinecke
On 03/07/2017 04:05 PM, Don Brace wrote: >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: Thursday, February 23, 2017 4:55 AM >> To: Martin K. Petersen >> Cc: Christoph Hellwig ; James Bottomley >>

Re: [bdi_unregister] 165a5e22fa INFO: task swapper:1 blocked for more than 120 seconds.

2017-03-07 Thread Jan Kara
On Tue 07-03-17 08:10:29, James Bottomley wrote: > On Tue, 2017-03-07 at 15:41 +0100, Jan Kara wrote: > > On Mon 06-03-17 09:25:42, James Bottomley wrote: > > > On Mon, 2017-03-06 at 17:13 +0100, Jan Kara wrote: > > > > On Mon 06-03-17 07:44:55, James Bottomley wrote: > > ... > > > > > > Sure. The

RE: [PATCHv2] hpsa: expose enclosures

2017-03-07 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Tuesday, March 07, 2017 9:25 AM > To: Don Brace ; Hannes Reinecke > ; Martin K. Petersen > Cc: Christoph Hellwig ; James Bottomley >

Re: [PATCH v3 01/16] lpfc: Correct WQ creation for pagesize

2017-03-07 Thread Martin K. Petersen
> "Greg" == Greg KH writes: Greg, >> Can this commit be included on stable v4.4+ , please? (in Linus tree) >> >> 8ea73db486cda442f0671f4bc9c03a76be398a28 "scsi: lpfc: Correct WQ >> creation for pagesize" Greg> I need an ack from a scsi maintainer that this is

Re: [PATCH] storvsc: workaround for virtual DVD SCSI version

2017-03-07 Thread Christoph Hellwig
Thanks Stephen, this looks good to me: Reviewed-by: Christoph Hellwig

Re: [PATCH] lpfc: Finalize Kconfig options for nvme

2017-03-07 Thread James Smart
On 3/7/2017 1:23 PM, Christoph Hellwig wrote: +#if defined(CONFIG_NVME_FC) +#define CONFIG_LPFC_NVME_INITIATOR +#endif + +#if defined(CONFIG_NVME_TARGET_FC) +#define CONFIG_LPFC_NVME_TARGET +#endif The CONFIG_* namespace is reserved for Kconfig defined symbols. Also I think the above is

Re: Help needed for a SCSI hang (SATA drives)

2017-03-07 Thread V
On Tue, Mar 7, 2017 at 3:58 AM, Jack Wang wrote: > 2017-03-07 1:54 GMT+01:00 V : >> Hi, >> >> I am reaching out regarding a SCSI error handler issue, which we see >> in our lab systems. >> >> Environment: Ubuntu 4.4.0-31-generic >> >> Issue: Write IOs

Re: [PATCH] storvsc: workaround for virtual DVD SCSI version

2017-03-07 Thread Martin K. Petersen
> "Stephen" == Stephen Hemminger writes: Stephen, Stephen> Hyper-V host emulation of SCSI for virtual DVD device reports Stephen> SCSI version 0 (UNKNOWN) but is still capable of supporting Stephen> REPORTLUN. Stephen> Without this patch, a GEN2 Linux guest on

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-03-07 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Mauricio> I think I should have included this in the tested-by tag Mauricio> email, for documentation/evidence: no regression observed in Mauricio> system shutdown path. Applied to 4.11/scsi-fixes. --

Re: [PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target.

2017-03-07 Thread Nicholas A. Bellinger
On Mon, 2017-03-06 at 00:43 +, Bart Van Assche wrote: > On Fri, 2017-02-24 at 13:37 -0800, Himanshu Madhani wrote: > > Please consider this series for inclusion in target-pending. > > Hello Himanshu, > > I applied this patch series on top of kernel v4.11-rc1 and installed it on > a test

Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

2017-03-07 Thread Nicholas A. Bellinger
Hi Elena, On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [bdi_unregister] 165a5e22fa INFO: task swapper:1 blocked for more than 120 seconds.

2017-03-07 Thread James Bottomley
On Tue, 2017-03-07 at 15:41 +0100, Jan Kara wrote: > On Mon 06-03-17 09:25:42, James Bottomley wrote: > > On Mon, 2017-03-06 at 17:13 +0100, Jan Kara wrote: > > > On Mon 06-03-17 07:44:55, James Bottomley wrote: > ... > > > > > Sure. The call trace is: > > > > > > > > > > [ 41.919244]

Re: [PATCH 10/29] drivers, md: convert stripe_head.count from atomic_t to refcount_t

2017-03-07 Thread Shaohua Li
On Mon, Mar 06, 2017 at 04:20:57PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. >

[PATCH] lpfc: Finalize Kconfig options for nvme

2017-03-07 Thread jsmart2021
From: James Smart Reviewing the result of what was just added for Kconfig, we made a poor choice. It worked well for full kernel builds, but not so much for how it would be deployed on a distro. Here's the final result: - lpfc will compile in NVME initiator and/or NVME

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-07 Thread Shaohua Li
On Mon, Mar 06, 2017 at 04:20:55PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations.

[PATCH] storvsc: workaround for virtual DVD SCSI version

2017-03-07 Thread Stephen Hemminger
Hyper-V host emulation of SCSI for virtual DVD device reports SCSI version 0 (UNKNOWN) but is still capable of supporting REPORTLUN. Without this patch, a GEN2 Linux guest on Hyper-V will not boot 4.11 successfully with virtual DVD ROM device. What happens is that the SCSI scan process falls