[PATCH 4/4] scsi: pmcraid: fix minor sparse warnings

pmcraid_minor is only used in this one file and should be 'static' as suggested by sparse: drivers/scsi/pmcraid.c:80:1: warning: symbol 'pmcraid_minor' was not declared. Should it be static? In Linux coding style, a literal '0' integer should not be used to represent a NULL pointer:

Re: [PATCH 22/23] blktrace: remove the unused block_rq_abort tracepoint

On Thu, Apr 20 2017, Johannes Thumshirn wrote: > On Thu, Apr 20, 2017 at 04:03:15PM +0200, Christoph Hellwig wrote: > > Signed-off-by: Christoph Hellwig > > --- > > Just to be sure nothings forgotten, does this change need an update for > blktrace as well? blktrace doesn't use this

Re: kill req->errors V4

On Thu, Apr 20 2017, Christoph Hellwig wrote: > Currently the request structure has an errors field that is used in > various different ways. The oldest drivers use it as an error count, > blk-mq and the generic timeout code assume that it holds a Linux > errno for block completions, and various

(From: Mr. James Tan (Urgent & Confidential)

-- (From: Mr.James Tan (Urgent & Confidential) Good Day, Please Read. My name is Mr.James Tan , I am the Bill and Exchange manager here in Bank of Africa (BOA) Lome-Togo.West-Africa. I have a business proposal in the tune of $9.7m, (Nine Million Seven Hundred Thousand Dollars Only) after the

Re: [PATCH-v1 01/22] Standardize nvme SGL segment count

On Wed, Apr 19, 2017 at 09:46:20PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > Standardize default SGL segment count for nvme target and initiator > > The driver needs to make them the same for clarity. > > Signed-off-by: Dick Kennedy

Re: [PATCH-v1 02/22] Fix nvme unregister port timeout.

On Wed, Apr 19, 2017 at 09:46:21PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > During some link event testing it was observed that the > wait_for_completion_timeout in the lpfc_nvme_unregister_port > was timing out all the time. > > The initiator is claiming

Re: [PATCH-v1 03/22] Fix rejected nvme LS Req.

On Wed, Apr 19, 2017 at 09:46:22PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > In this case, the NVME initiator is sending an LS REQ command on an NDLP > that is not MAPPED. The FW rejects it. > > The lpfc_nvme_ls_req routine checks for a NULL ndlp pointer

Re: [PATCH-v1 04/22] Fix log message in completion path.

On Wed, Apr 19, 2017 at 09:46:23PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > In the lpfc_nvme_io_cmd_wqe_cmpl routine the driver was printing two > pointers and the DID for the rport whenever an IO completed on a now > that had transitioned to a non active

Re: [PATCH-v1 05/22] Add debug messages for nvme/fcp resource allocation.

On Wed, Apr 19, 2017 at 09:46:24PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > The xri resources are split into pools for NVME and FCP IO when NVME is > enabled. There was not message in the log that identified this allocation. > > Added debug message to log

Re: [PATCH-v1 08/22] Remove NULL ptr check before kfree.

On Wed, Apr 19, 2017 at 09:46:27PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > The check for NULL ptr is not necessary, kfree will check it. > > Removing NULL ptr check. > > Signed-off-by: Dick Kennedy > Signed-off-by: James

Re: [PATCH-v1 09/22] Fix extra line print in rqpair debug print.

On Wed, Apr 19, 2017 at 09:46:28PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > An extra blank line was being added the the rqpair printing. > > Remove the extra line feed. > > Signed-off-by: Dick Kennedy > Signed-off-by: James

Re: [PATCH-v1 06/22] Fix spelling in comments.

On Wed, Apr 19, 2017 at 09:46:25PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > Comment should have said Repost. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Johannes

Re: [PATCH-v1 07/22] Remove unused defines for NVME PostBuf.

On Wed, Apr 19, 2017 at 09:46:26PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > These defines for the posting of buffers for nvmet target were not used. > > Removing the unused defines. > > Signed-off-by: Dick Kennedy >

Re: [PATCH-v1 10/22] Fix PRLI ACC rsp for NVME

On Wed, Apr 19, 2017 at 09:46:29PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > PRLI ACC from target is FCP oriented. > > Word 0 was wrong. This was noticed by another nvmet-fc vendor that > was testing the lpfc nvme-fc initiator with their target. > >

Re: [PATCH-v1 11/22] Fix driver unload/reload operation.

On Wed, Apr 19, 2017 at 09:46:30PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > There are couple of different load/unload issues fixed with this patch. > One of the issues was reported by Junichi Nomura, a patch was submitted > by Johannes Thumsrhirn which did

Re: [PATCH-v1 12/22] Fix driver usage of 128B WQEs when WQ_CREATE is V1.

On Wed, Apr 19, 2017 at 09:46:31PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > There are two versions of a structure for queue creation and setup that the > driver shares with FW. The driver was only treating as version 0. > > Verify WQ_CREATE with 128B WQEs

Re: [PATCH-v1 13/22] Fix nvme initiator handling when not enabled.

On Wed, Apr 19, 2017 at 09:46:32PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > Fix nvme initiator handline when CONFIG_LPFC_NVME_INITIATOR is not enabled. > > With update nvme upstream driver sources, loading > the driver with nvme enabled resulting in this

Re: [PATCH-v1 14/22] Remove hba lock from NVMET issue WQE.

On Wed, Apr 19, 2017 at 09:46:33PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > Unnecessary lock is taken. ring lock should be sufficient to protect the > work queue submission. > > This was noticed when doing performance testing. The hbalock is not > needed

Re: [PATCH-v1 16/22] Fix crash after issuing lip reset

On Wed, Apr 19, 2017 at 09:46:35PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > When RPI is not available, driver sends WQE with invalid RPI value and > rejected by HBA. > lpfc :82:00.3: 1:3154 BLS ABORT RSP failed, data: x3/xa0320008 > and > lpfc :2753

Re: [PATCH-v1 15/22] Fix driver load issues when MRQ=8

On Wed, Apr 19, 2017 at 09:46:34PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > The symptom is that the driver will fail to login to the fabric. > The reason is because it is out of iocb resources. > > There is a one to one relationship between MRQs >

Re: [PATCH-v1 18/22] Add Fabric assigned WWN support.

On Wed, Apr 19, 2017 at 09:46:37PM -0700, jsmart2...@gmail.com wrote: > From: James Smart > > Adding support for Fabric assigned WWPN and WWNN. > > Firmware sends first FLOGI to fabric with vendor version changes. > On link up driver gets updated service parameter with

<    1   2