Re: [PATCH 2/3] target: Add TARGET_SCF_LOOKUP_LUN_FROM_TAG support for ABORT_TASK

2017-06-06 Thread Tran, Quinn
Looks Good. Regards, Quinn Tran -Original Message- From: Nicholas Bellinger Date: Saturday, June 3, 2017 at 3:10 PM To: target-devel Cc: linux-scsi , lkml , Nicholas Bellinger

Re: [PATCH 1/3] target: Add support for TMR percpu reference counting

2017-06-06 Thread Tran, Quinn
Looks good. Regards, Quinn Tran -Original Message- From: Nicholas Bellinger Date: Saturday, June 3, 2017 at 3:10 PM To: target-devel Cc: linux-scsi , lkml , Nicholas Bellinger

Re: [PATCH v2 00/17] lpfc updates for 11.4.0.0

2017-06-06 Thread James Smart
On 6/5/2017 6:13 PM, Martin K. Petersen wrote: Hi James, This patch set provides a number of bug fixes, code cleanups, and error handling in lpfc. The patches were cut against the Martin's 4.12/scsi-fixes tree. There are no outside dependencies. The patches should merge via Martin's tree.

Re: [PATCH 0/3] target: Add TARGET_SCF_LOOKUP_LUN_FROM_TAG support

2017-06-06 Thread Madhani, Himanshu
> On Jun 3, 2017, at 3:10 PM, Nicholas A. Bellinger > wrote: > > From: Nicholas Bellinger > > Hi Himanshu + Quinn, > > Here is a small series to introduce proper percpu se_lun->lun_ref > counting for TMR, and add common code in target_submit_tmr()

Re: [PATCH 1/6] libata: move ata_read_log_page to libata-core.c

2017-06-06 Thread Hannes Reinecke
On 06/04/2017 02:42 PM, Christoph Hellwig wrote: > It is core functionality, and only one of the users is in the EH code. > > Signed-off-by: Christoph Hellwig > --- > drivers/ata/libata-core.c | 64 > +++ > drivers/ata/libata-eh.c | 64

Re: [PATCH 2/6] libata: factor out a ata_log_supported helper

2017-06-06 Thread Hannes Reinecke
On 06/04/2017 02:42 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/ata/libata-core.c | 59 > +-- > 1 file changed, 16 insertions(+), 43 deletions(-) > Reviewed-by: Hannes Reinecke Cheers,

Re: [PATCH V2 1/2] scsi: ufs: Tidy clocks list head usage

2017-06-06 Thread Adrian Hunter
Oops, sorry, didn't mean to send this one again, since it has been applied.

Re: [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks

2017-06-06 Thread Hannes Reinecke
On 06/04/2017 02:42 PM, Christoph Hellwig wrote: > Just wire up the generic TCG OPAL infrastructure to the SCSI disk driver > and the Security In/Out commands. > > Note that I don't know of any actual SCSI disks that do support TCG OPAL, > but this is required to support ATA disks through libata.

Re: [PATCH 5/6] libata: implement SECURITY PROTOCOL IN/OUT

2017-06-06 Thread Hannes Reinecke
On 06/04/2017 02:42 PM, Christoph Hellwig wrote: > This allows us to use the generic OPAL code with ATA devices. > > Signed-off-by: Christoph Hellwig > --- > drivers/ata/libata-core.c | 32 > drivers/ata/libata-scsi.c | 76 >

[PATCH V2 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers

2017-06-06 Thread Adrian Hunter
From: Szymon Mielczarek This patch adds a glue pci driver for Intel UFS Host controllers. Signed-off-by: Szymon Mielczarek Signed-off-by: Adrian Hunter --- Changes in V2: Change variant name from

[PATCH V2 1/2] scsi: ufs: Tidy clocks list head usage

2017-06-06 Thread Adrian Hunter
From: Szymon Mielczarek Move the initialization of clocks list head to ufshcd_alloc_host so that every driver doesn't have to do it. Remove checks for the list head being NULL because that is not possible. Signed-off-by: Szymon Mielczarek

Re: [PATCH 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers

2017-06-06 Thread Christoph Hellwig
> +#define PCI_CLASS_STORAGE_UFSHCI 0x010901 should me move to pci_ids.h > + > +#define UFSHCD_INTEL_PCI_UFSHCI_DEVICE() { \ > + .vendor = PCI_VENDOR_ID_INTEL, \ > + .device = PCI_ANY_ID, \ > + .subvendor = PCI_ANY_ID, \ > + .subdevice = PCI_ANY_ID, \ > + .class

[no subject]

2017-06-06 Thread From Lori J. Robinson
Hello, I am General Lori J. Robinson, I am presently in Afghanistan serving the UN/NATO military assignment here,i have an important discussion with you kindly respond to me through my private box lori_robinson@hotmail.com so that we can know ourselves better. I hope to read from you if

Re: [PATCH 4/6] libata: factor out a ata_identify_page_supported helper

2017-06-06 Thread Hannes Reinecke
On 06/04/2017 02:42 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/ata/libata-core.c | 59 > +-- > 1 file changed, 32 insertions(+), 27 deletions(-) > Reviewed-by: Hannes Reinecke Cheers,

Re: [PATCH 3/6] libata: clarify log page naming / grouping

2017-06-06 Thread Hannes Reinecke
On 06/04/2017 02:42 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/ata/libata-core.c | 10 +- > include/linux/ata.h | 10 +++--- > 2 files changed, 12 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke

[PATCH V3 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers

2017-06-06 Thread Adrian Hunter
From: Szymon Mielczarek This patch adds a glue pci driver for Intel UFS Host controllers. Signed-off-by: Szymon Mielczarek Signed-off-by: Adrian Hunter --- Changes in V3: Remove UFSHCI class code

Re: [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks

2017-06-06 Thread Christoph Hellwig
On Mon, Jun 05, 2017 at 08:48:00PM -0400, Martin K. Petersen wrote: > For WRITE SAME, scsi_report_opcode() is gated not only by > sdev->no_report_opcodes but by sdev->no_write_same. > > I'm concerned about firing off REPORT OPCODES to random devices without > a sufficiently good heuristic.

Re: [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks

2017-06-06 Thread Christoph Hellwig
On Mon, Jun 05, 2017 at 03:15:31PM -0600, Scott Bauer wrote: > I'm not familiar at all with ATA, but I noticed there was no unlock from > suspend support > in the series. Does ATA not have a way to determine if we're coming out of a > suspend? I don't know, and not having a test system with a

[PATCH v4 1/5] tcmu: Support emulate_write_cache

2017-06-06 Thread Bryant G. Ly
This will enable the toggling of write_cache in tcmu through targetcli-fb Signed-off-by: Bryant G. Ly Reviewed-By: Mike Christie --- drivers/target/target_core_user.c | 30 ++ 1 file changed, 30 insertions(+) diff

[PATCH v4 0/5] tcmu: Add Type of reconfig into netlink

2017-06-06 Thread Bryant G. Ly
From: "Bryant G. Ly" This patch consists of adding a netlink to allow for reconfiguration of a device in tcmu. It also changes and adds some attributes that are reconfigurable: write_cache, device size, and device path. V2 - Fixes kfree in tcmu: Make dev_config configurable V3

[PATCH v4 3/5] tcmu: Make dev_size configurable via userspace

2017-06-06 Thread Bryant G. Ly
Allow tcmu backstores to be able to set the device size after it has been configured via set attribute. Part of support in userspace to support certain backstores changing device size. Signed-off-by: Bryant G. Ly --- drivers/target/target_core_user.c | 59

[PATCH v4 5/5] tcmu: Add Type of reconfig into netlink

2017-06-06 Thread Bryant G. Ly
This patch adds more info about the attribute being changed, so that usersapce can easily figure out what is happening. Signed-off-by: Bryant G. Ly --- drivers/target/target_core_user.c | 20 ++-- include/uapi/linux/target_core_user.h | 8

[PATCH v4 2/5] tcmu: Add netlink for device reconfiguration

2017-06-06 Thread Bryant G. Ly
This gives tcmu the ability to handle events that can cause reconfiguration, such as resize, path changes, write_cache, etc... Signed-off-by: Bryant G. Ly Reviewed-By: Mike Christie --- drivers/target/target_core_user.c | 12

[PATCH v4 4/5] tcmu: Make dev_config configurable

2017-06-06 Thread Bryant G. Ly
This allows for userspace to change the device path after it has been created. Thus giving the user the ability to change the path. The use case for this is to allow for virtual optical to have media change. Signed-off-by: Bryant G. Ly ---

[PATCH v5 06/12] blk-mq: use the introduced blk_mq_unquiesce_queue()

2017-06-06 Thread Ming Lei
blk_mq_unquiesce_queue() is used for unquiescing the queue explicitly, so replace blk_mq_start_stopped_hw_queues() with it. For the scsi part, this patch takes Bart's suggestion to switch to block quiesce/unquiesce API completely. Cc: linux-n...@lists.infradead.org Cc: linux-scsi@vger.kernel.org

RE: Application stops due to ext4 filesytsem IO error

2017-06-06 Thread Sumit Saxena
Gentle ping.. >-Original Message- >From: Sumit Saxena [mailto:sumit.sax...@broadcom.com] >Sent: Monday, June 05, 2017 12:59 PM >To: 'Jens Axboe' >Cc: 'linux-bl...@vger.kernel.org'; 'linux-scsi@vger.kernel.org' >Subject: Application stops due to ext4 filesytsem IO error > >Jens, > >We am

Re: next build: 113 warnings 0 failures (next/next-20170605)

2017-06-06 Thread Wolfram Sang
> > 2 drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined > > Caused by 6c42778780c4 ("i2c: stub: use pr_fmt"): "#define DEBUG" > now conflicts with "ccflags-$(CONFIG_I2C_DEBUG_CORE) := -DDEBUG" > in the Makefile. I'll fix it tomorrow! signature.asc Description: PGP signature

Re: [PATCH 6/6] sd: add support for TCG OPAL self encrypting disks

2017-06-06 Thread Scott Bauer
On Tue, Jun 06, 2017 at 11:59:55AM +0200, Christoph Hellwig wrote: > On Mon, Jun 05, 2017 at 03:15:31PM -0600, Scott Bauer wrote: > > I'm not familiar at all with ATA, but I noticed there was no unlock from > > suspend support > > in the series. Does ATA not have a way to determine if we're

Re: [PATCH 3/3] qla2xxx: Convert QLA_TGT_ABTS to TARGET_SCF_LOOKUP_LUN_FROM_TAG

2017-06-06 Thread Tran, Quinn
Nic, Thanks. It looks good. Regards, Quinn Tran -Original Message- From: Nicholas Bellinger Date: Saturday, June 3, 2017 at 3:10 PM To: target-devel Cc: linux-scsi , lkml ,

[PATCH V4 1/2] scsi: ufshcd-pci: Fix PM config

2017-06-06 Thread Adrian Hunter
Put PM functions under correct config options and use standard PM macros to set callbacks. Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd-pci.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git

[PATCH V4 2/2] scsi: ufshcd-pci: Add Intel CNL support

2017-06-06 Thread Adrian Hunter
Add PCI id and variant ops for Intel CNL UFS host controller. Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd-pci.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd-pci.c

[PATCH V4 0/2] scsi: ufshcd-pci: Add Intel CNL support

2017-06-06 Thread Adrian Hunter
Hi Here is V4 of patches to add support for Intel UFS host controllers. Changes in V4: New patch "scsi: ufshcd-pci: Fix PM config" Do not use a separate driver for Intel Changes in V3: Remove UFSHCI class code and match on PCI device ID Changes in V2: Change

Re: [PATCH V3 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers

2017-06-06 Thread Christoph Hellwig
This looks much better. But the new file still looks almost like a copy and paste of tc-dwc-g210-pci.c. Wouldnt it make more sense to start with a common ufshcd-pci driver that sets up the ufs_hba_variant_opsA based on the PCI ID table? Also given that this almost entitrely a copy & paste job

Re: next build: 113 warnings 0 failures (next/next-20170605)

2017-06-06 Thread Arnd Bergmann
On Mon, Jun 5, 2017 at 11:02 AM, Olof's autobuilder wrote: > Here are the build results from automated periodic testing. > > The tree being built was next, found at: > > http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git (master > branch) > > Topmost commit: > >

[PATCH 4/7] scsi/be2iscsi: Update beiscsi_ep_connect to accept iface and sockaddr_storage.

2017-06-06 Thread Robert LeBlanc
Update Emulex BladeEngine driver to accept the session iface for creating the iSCSI connection. Also accept dst_addr as sockaddr_storage instead of sockaddr. Signed-off-by: Robert LeBlanc --- drivers/scsi/be2iscsi/be_cmds.c | 1 + drivers/scsi/be2iscsi/be_iscsi.c | 8

[PATCH 1/7] scsi/scsi_transport_iscsi: Add iface struct to kernel.

2017-06-06 Thread Robert LeBlanc
Allow the userspace iscsiadm to pass the iface struct of the connection so that the underlying driver can use what is most appropriate to create the iSCSI connection. Signed-off-by: Robert LeBlanc --- include/scsi/scsi_transport_iscsi.h | 95

[PATCH 3/7] ib/iSER: Add binding to source IP address.

2017-06-06 Thread Robert LeBlanc
If the iface passed in has ip address set, then attept to create an RDMA connection using it as the source IP address. This allows iSER to use multiple ports on the same network or in more complex routing configurations. Also update to accepting sockaddr_storage. Signed-off-by: Robert LeBlanc

[PATCH 6/7] scsi/cxgbi: Update cxgbi_ep_connect to accept iface and sockaddr_storage.

2017-06-06 Thread Robert LeBlanc
Update Chelsio iSCSI driver to accept the session iface for creating the iSCSI connection. Also accept dst_addr as sockaddr_storage instead of sockaddr. Signed-off-by: Robert LeBlanc --- drivers/scsi/cxgbi/libcxgbi.c | 15 --- drivers/scsi/cxgbi/libcxgbi.h | 2

[PATCH 7/7] scsi/qla4xxx: Update qla4xxx_ep_connect to accept iface and sockaddr_storage.

2017-06-06 Thread Robert LeBlanc
Update QLogic ISP4XXX and ISP82XX drivers to accept the session iface for creating the iSCSI connection. Also accept dst_addr as sockaddr_storage instead of sockaddr. Signed-off-by: Robert LeBlanc --- drivers/scsi/qla4xxx/ql4_os.c | 15 --- 1 file changed, 8

[PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

2017-06-06 Thread Robert LeBlanc
This patchset enables iSCSI offload drivers to have access to the iface information provided by iscsid. This allows users to have more control of how the driver connects to the iSCSI target. iSER is updated to use iface.ipaddress to set the source IP address if configured. This allows iSER to use

[PATCH 5/7] scsi/bnx2i: Update bnx2i_ep_connect to accept iface and sockaddr_storage.

2017-06-06 Thread Robert LeBlanc
Update QLogic NetXtreme II driver to accept the session iface for creating the iSCSI connection. Also accept dst_addr as sockaddr_storage instead of sockaddr. Signed-off-by: Robert LeBlanc --- drivers/scsi/bnx2i/bnx2i_hwi.c | 1 + drivers/scsi/bnx2i/bnx2i_iscsi.c | 13

[PATCH] Pass iface for connection

2017-06-06 Thread Robert LeBlanc
--- usr/netlink.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/usr/netlink.c b/usr/netlink.c index 1a0bf80..c474375 100644 --- a/usr/netlink.c +++ b/usr/netlink.c @@ -848,10 +848,13 @@ krecv_pdu_end(struct iscsi_conn *conn) int

[PATCH v1] ibmvscsis: Use tpgt passed in by user

2017-06-06 Thread Bryant G. Ly
ibmvscsis always returned 0 for the tpg/tag, since it did not parse the value passed in by the user. When functions like ALUA members exports the value, it will be incorrect because targetcli/rtslib starts the tpg numbering at 1. Signed-off-by: Bryant G. Ly

[PATCH] qla2xxx: Fix compile warning

2017-06-06 Thread Himanshu Madhani
Fixes following 0-day kernel build warnings drivers/scsi/qla2xxx/qla_init.c:6407:50: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=] drivers/scsi/qla2xxx/qla_init.c:6709:50: warning: format '%lx' expects argument of type 'long