[PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class_attrs

The class_attrs pointer is going away and it's not even being used in this driver, so just remove it entirely. Cc: "Bryant G. Ly" Cc: Michael Cyr Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen"

Re: [PATCH] configfs: Fix race between create_link and configfs_rmdir

Thanks Nic, applied to the configfs-for-next tree. I'm not entirely sure if we should bother adding this to 4.12 or if it hits rarely enough?

Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

Hi John, sorry for dropping the ball, but your repost reminded me. On Thu, Jun 01, 2017 at 11:36:55AM +0100, John Garry wrote: > In the command completion code we need to check for abnormal completion due > to underflow, but ignore it when it occurs in some commands, like inquiry. > This is why

Re: [PATCH V4 2/2] scsi: ufshcd-pci: Add Intel CNL support

Hello to all, Às 2:16 PM de 6/7/2017, Christoph Hellwig escreveu: > On Tue, Jun 06, 2017 at 02:35:31PM +0300, Adrian Hunter wrote: >> Add PCI id and variant ops for Intel CNL UFS host controller. > > Looks good: > > Reviewed-by: Christoph Hellwig > > It would be great if we could

Re: [PATCH 0/3] target: Add TARGET_SCF_LOOKUP_LUN_FROM_TAG support

Hi Himanshu & Quinn, On Wed, 2017-06-07 at 05:02 +, Madhani, Himanshu wrote: > > On Jun 3, 2017, at 3:10 PM, Nicholas A. Bellinger > > wrote: > > > > From: Nicholas Bellinger > > > > Hi Himanshu + Quinn, > > > > Here is a small series to

Re: [PATCH 2/3] target: Add TARGET_SCF_LOOKUP_LUN_FROM_TAG support for ABORT_TASK

On Mon, 2017-06-05 at 15:57 +, Bart Van Assche wrote: > On Sat, 2017-06-03 at 22:10 +, Nicholas A. Bellinger wrote: > > +static bool target_lookup_lun_from_tag(struct se_session *se_sess, u64 tag, > > + u64 *unpacked_lun) > > +{ > > + struct se_cmd

Re: [PATCH] target: Fix kref->refcount underflow in transport_cmd_finish_abort

(Adding Quinn CC') Reviews please..? On Sat, 2017-06-03 at 21:09 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch fixes a se_cmd->cmd_kref underflow during CMD_T_ABORTED > when a fabric driver drops it's second reference from below the >

Re: [PATCH] iscsi-target: Fix delayed logout processing greater than SECONDS_FOR_LOGOUT_COMP

Reviews pretty please..? On Sat, 2017-06-03 at 21:32 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch fixes a BUG() in iscsit_close_session() that could be > triggered when iscsit_logout_post_handler() execution from within > tx thread context

Re: [PATCH v1] ibmvscsis: Use tpgt passed in by user

On Tue, 2017-06-06 at 15:45 -0500, Bryant G. Ly wrote: > ibmvscsis always returned 0 for the tpg/tag, since it did not > parse the value passed in by the user. > > When functions like ALUA members exports the value, it will > be incorrect because targetcli/rtslib starts the tpg numbering > at 1.

[PATCH 2/2] scsi: esas2r: Replace semaphore fs_api_semaphore with mutex

The semaphore 'fs_api_semaphore' is used as a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- drivers/scsi/esas2r/esas2r.h | 2 +- drivers/scsi/esas2r/esas2r_init.c | 2 +-

[PATCH 0/2] esas2r: Replace semaphores with mutexes

These are a set of patches which removes semaphores from esas2r. These are part of a bigger effort to eliminate unwanted semaphores from the linux kernel. Binoy Jayan (2): scsi: esas2r: Replace semaphore fm_api_semaphore with mutex scsi: esas2r: Replace semaphore fs_api_semaphore with mutex

[PATCH 1/2] scsi: esas2r: Replace semaphore fm_api_semaphore with mutex

The semaphore 'fm_api_semaphore' is used as a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- drivers/scsi/esas2r/esas2r.h | 2 +- drivers/scsi/esas2r/esas2r_init.c | 2 +-

Re: [PATCH 1/7] scsi/scsi_transport_iscsi: Add iface struct to kernel.

Hi Robert, [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.12-rc4 next-20170608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Robert-LeBlanc/Enable-iSCSI-offload

Re: [PATCH 2/7] scsi/scsi_transport_iscsi: Update ep_connect to include iface.

Hi Robert, [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.12-rc4 next-20170608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Robert-LeBlanc/Enable-iSCSI-offload

Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

On 08/06/2017 08:34, Christoph Hellwig wrote: Hi John, sorry for dropping the ball, but your repost reminded me. On Thu, Jun 01, 2017 at 11:36:55AM +0100, John Garry wrote: In the command completion code we need to check for abnormal completion due to underflow, but ignore it when it occurs

Re: [PATCH] configfs: Fix race between create_link and configfs_rmdir

Thanks Nic, applied to the configfs-for-next tree. I'm not entirely sure if we should bother adding this to 4.12 or if it hits rarely enough? It hits for us pretty often when we have a GPFS setup with 10 hosts and 1k+ vms. That is how we discovered the bug in the first place. -Bryant

Re: [PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class_attrs

The class_attrs pointer is going away and it's not even being used in this driver, so just remove it entirely. Cc: "Bryant G. Ly" Cc: Michael Cyr Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen"

Re: [PATCH 2/7] scsi/scsi_transport_iscsi: Update ep_connect to include iface.

Hi Robert, [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on v4.12-rc4 next-20170608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Robert-LeBlanc/Enable-iSCSI-offload

Re: [PATCH 0/2] esas2r: Replace semaphores with mutexes

On Thu, Jun 8, 2017 at 12:07 PM, Binoy Jayan wrote: > These are a set of patches which removes semaphores from esas2r. > These are part of a bigger effort to eliminate unwanted semaphores > from the linux kernel. > > Binoy Jayan (2): > scsi: esas2r: Replace semaphore

Re: [PATCH] iscsi-target: Reject immediate data underflow larger than SCSI transfer length

On Thu, 2017-06-08 at 04:21 +, Nicholas A. Bellinger wrote: > + /* > + * Check for underflow case where both EDTL and immediate data payload > + * exceeds what is presented by CDB's TRANSFER LENGTH, and what has > + * already been set in target_cmd_size_check() as

Re: [PATCH v3 04/12] Protect SCSI device state changes with a mutex

On Mon, Jun 05, 2017 at 06:36:19PM +, Bart Van Assche wrote: > > The mpt3sas driver is the only driver that calls > > scsi_internal_device_block() > > and scsi_internal_device_unblock() from atomic context. Since it's not an > > option > > to protect the SCSI device state changes with a

[PATCH] scsi: ipr: remove unnecessary variable assignments and the variable itself

Remove unnecessary variable assignments, the variable itself and refactor the code. Addresses-Coverity-ID: 1227034 Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/ipr.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 06/15] qla2xxx: Add fw_started flags to qpair

Hi Quinn, [auto build test ERROR on scsi/for-next] [also build test ERROR on next-20170608] [cannot apply to v4.12-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx

Re: [RFC v2 2/2] scsi: add rate limit to scsi sense code uevent

> On Jun 6, 2017, at 6:22 AM, Ewan D. Milne wrote: > > On Thu, 2017-05-18 at 11:14 -0700, Song Liu wrote: >> This patch adds rate limits to SCSI sense code uevets. Currently, >> the rate limit is hard-coded to 16 events per second. >> >> The code tracks nano second time of