Re: [PATCH 2/6] SCSI: use blk_mq_run_hw_queues() in scsi_kick_queue()

On Tue, Jul 11, 2017 at 07:57:53PM +, Bart Van Assche wrote: > On Wed, 2017-07-12 at 02:20 +0800, Ming Lei wrote: > > Now SCSI won't stop queue, and not necessary to use > > blk_mq_start_hw_queues(), so switch to blk_mq_run_hw_queues() > > instead. > > > > Cc: "James E.J. Bottomley"

Re: [PATCH v2 01/15] qla2xxx: Combine Active command arrays.

Hi Bart, > On Jul 11, 2017, at 5:39 PM, Nicholas A. Bellinger > wrote: > > On Tue, 2017-07-11 at 23:43 +, Bart Van Assche wrote: >> On Tue, 2017-06-13 at 20:47 -0700, Himanshu Madhani wrote: >>> typedef struct srb { >>> + /* >>> +* Do not move cmd_type field, it

Re: [PATCH] virtio_scsi: always read VPD pages for multiqueue too

On Wed, Jul 05, 2017 at 10:30:56AM +0200, Paolo Bonzini wrote: > Multi-queue virtio-scsi uses a different scsi_host_template struct. > Add the .device_alloc field there, too. > > Fixes: 25d1d50e23275e141e3a3fe06c25a99f4c4bf4e0 > Cc: sta...@vger.kernel.org > Cc: David Gibson

Re: tgtd CPU 100% problem

Thanks very much for reply. I think it may be better to assert failed to exit problem than run the endless loop after receivered DEVICE_REMOVAL event. Or we can sleep 5 ms to check if the conn->h.state is STATE_FULL. 2017-07-11 16:29 GMT+08:00 Sagi Grimberg : > > > On 11/07/17

Re: [PATCH] scsi: default to scsi-mq

csi(void) Since a fix for the performance regression triggered by this patch will be upstream soon (see also https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus=32825c45ff8f4cce937ab85b030dc693ceb1aa0a): FYI, on linux-next 20170711 (which now in

RE: [PATCH v2 09/15] megaraid_sas: use vmalloc for crash dump buffers and driver's local RAID map

> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Monday, July 10, 2017 7:15 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; > kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; > h...@suse.com;

[PATCH] scsi: hisi_sas: make several const arrays static

From: Colin Ian King Don't populate various tables on the stack but make them static const. Makes the object code smaller by over 280 bytes: Before: textdata bss dec hex filename 398875080 64 45031afe7 hisi_sas_v2_hw.o After:

Re: [PATCH v2 09/15] megaraid_sas: use vmalloc for crash dump buffers and driver's local RAID map

On 11.7.2017 12:49, Shivasharan Srikanteshwara wrote: >> -Original Message- >> From: Tomas Henzl [mailto:the...@redhat.com] >> Sent: Monday, July 10, 2017 7:15 PM >> To: Shivasharan S; linux-scsi@vger.kernel.org >> Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; >>

Aviso de conta

Alguém tentou acessar sua conta webmail / zimbra da África do Sul com IP no: 87.228.204.106. Ignore esta mensagem se você é o único, mas se você não é o único, clique no link seguro da conta abaixo e faça login nos detalhes do seu webmail / zimbra e clique em cimeira para proteger e proteger sua

[PATCHv2] tcmu: Fix possbile memory leak when recalculating the cmd base size

From: Xiubo Li For all the entries allocated from the ring cmd area, the memory is something like the stack memory, which will always reserve the old data, so the entry->req.iov_bidi_cnt maybe none zero. On some environments, the crash could be reporduce very easy

Re: tgtd CPU 100% problem

Thanks very much for reply. I think it may be better to assert failed to exit problem than run the endless loop after receivered DEVICE_REMOVAL event. Or we can sleep 5 ms to check if the conn->h.state is STATE_FULL. Note that neither of the CC'd lists are the correct list for stgt, you

[PATCH] tcmu: clean up the code and with one small fix

From: Xiubo Li Remove useless blank line and code and at the same time add one error path to catch the errors. Signed-off-by: Xiubo Li --- drivers/target/target_core_user.c | 24 +++- 1 file changed, 11

Re: [PATCH] hpsa: add support for legacy boards

> Add support for legacy boards, ensuring to enable the driver for > those boards only when 'hpsa_allow_any' is set. Applied this patch, made sure I had compiled in hpsa and not cciss to avoid any variables from initramfs, and still I get this: [4.015080] hpsa :00:04.0: unrecognized

Re: [PATCH v2 15/15] megaraid_sas: driver version upgrade

On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

On 10/07/2017 08:06, Yijing Wang wrote: Now libsas hotplug work is static, every sas event type has its own static work, LLDD driver queue the hotplug work into shost->work_q. If LLDD driver burst post lots hotplug events to libsas, the hotplug events may pending in the workqueue like

Re: [PATCH v2 14/15] megaraid_sas: call megasas_dump_frame with correct IO frame size

On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 1/4] scsi: scsi_dh_alua: allow I/O in target port unavailable and standby states

On 07/11/2017 06:18 AM, Hannes Reinecke wrote: NACK. The whole_point_ of having device handlers is to_avoid_ I/O errors during booting. And the ALUA checker is prepared to handle this situation properly. The directio checker of course doesn't know about this, but then no-one expected the

RE: [PATCH] hpsa: add support for legacy boards

> -Original Message- > From: mr...@math.ut.ee [mailto:mr...@math.ut.ee] On Behalf Of Meelis > Roos > Sent: Tuesday, July 11, 2017 9:26 AM > To: Hannes Reinecke > Cc: Martin K. Petersen ; Christoph Hellwig > ; James Bottomley >

Re: [PATCH v2 13/15] megaraid_sas: modified few prints in OCR and IOC INIT path

On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 10/15] megaraid_sas: Return pended IOCTLs with cmd_status MFI_STAT_WRONG_STATE in case adapter is dead

On 5.7.2017 14:00, Shivasharan S wrote: > Fix - After a kill adapter, since the cmd_status is not set the > IOCTLs will be hung in driver resulting in application hang. > Set cmd_status MFI_STAT_WRONG_STATE when completing pended IOCTLs. > > Signed-off-by: Kashyap Desai

Re: [PATCH v2 11/15] megaraid_sas: Set device queue_depth same as HBA can_queue value in scsi-mq mode

On 5.7.2017 14:00, Shivasharan S wrote: > Currently driver sets default queue_depth for VDs at 256 and JBODs based on > interface type, > ie., for SAS JBOD QD will be 64, for SATA JBOD QD will be 32. > During performance runs with scsi-mq enabled, we are seeing better results by > setting QD same

Re: [PATCH v2 3/4] scsi: scsi_dh_alua: do not print RTPG state if it remains unavailable/standby

Hi Mauricio, [auto build test WARNING on bvanassche/for-next] [also build test WARNING on v4.12 next-20170711] [cannot apply to mkp-scsi/for-next scsi/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH] scsi: default to scsi-mq

/axboe/linux-block.git/commit/?h=for-linus=32825c45ff8f4cce937ab85b030dc693ceb1aa0a): FYI, on linux-next 20170711 (which now includes the above patch Bart mentioned) we see a large performance regression on hisi_sas (LLDD does not config shost for mq). fio read mode iops goes from ~833K

Re: [PATCH] scsi: default to scsi-mq

e/linux-block.git/commit/?h=for-linus=32825c45ff8f4cce937ab85b030dc693ceb1aa0a): > > > > FYI, on linux-next 20170711 (which now includes the above patch Bart > mentioned) we see a large performance regression on hisi_sas (LLDD does > not config shost for mq). > > fio re

Re: [PATCH v2 12/15] megaraid_sas: replace internal FALSE/TRUE definitions with false/true

On 5.7.2017 14:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl tomash

Re: [PATCH v2 11/15] megaraid_sas: Set device queue_depth same as HBA can_queue value in scsi-mq mode

On Wed, Jul 05, 2017 at 05:00:25AM -0700, Shivasharan S wrote: > Currently driver sets default queue_depth for VDs at 256 and JBODs based on > interface type, > ie., for SAS JBOD QD will be 64, for SATA JBOD QD will be 32. > During performance runs with scsi-mq enabled, we are seeing better

[PATCH] scsi: scsi_dh_alua: fix boolreturn.cocci warnings

drivers/scsi/device_handler/scsi_dh_alua.c:594:9-10: WARNING: return of 0/1 in function 'alua_rtpg_print_check' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: cb809ba2fcbf

Re: [PATCH] scsi: hisi_sas: make several const arrays static

On 11/07/2017 13:11, Colin King wrote: From: Colin Ian King Don't populate various tables on the stack but make them static const. Makes the object code smaller by over 280 bytes: Before: textdata bss dec hex filename 398875080 64

Re: [PATCH] tcmu: clean up the code and with one small fix

On 07/11/2017 05:06 AM, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > Remove useless blank line and code and at the same time add one error > path to catch the errors. > > Signed-off-by: Xiubo Li Thanks. Reviewed-by: Mike

RE: [PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128

> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.h > @@ -115,7 +115,7 @@ > > #define MPT3SAS_RAID_MAX_SECTORS 8192 > #define MPT3SAS_HOST_PAGE_SIZE_4K12 > - > +#define MPT3SAS_NVME_QUEUE_DEPTH 128 ... > + /*TODO-right Queue Depth?*/ > + qdepth =

Re: [PATCHv2] tcmu: Fix possbile memory leak when recalculating the cmd base size

On Tue, 2017-07-11 at 17:59 +0800, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > For all the entries allocated from the ring cmd area, the memory is > something like the stack memory, which will always reserve the old > data, so the

Re: [PATCH] tcmu: clean up the code and with one small fix

On Tue, 2017-07-11 at 18:06 +0800, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > Remove useless blank line and code and at the same time add one error > path to catch the errors. > > Signed-off-by: Xiubo Li > --- >

Re: [PATCH] scsi: default to scsi-mq

by this patch will be upstream soon (see also https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus=32825c45ff8f4cce937ab85b030dc693ceb1aa0a): FYI, on linux-next 20170711 (which now includes the above patch Bart mentioned) we see a large performance regression

Re: [PATCH] scsi: default to scsi-mq

ession triggered by this patch will > > > > be upstream > > > > soon (see also > > > > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus=32825c45ff8f4cce937ab85b030dc693ceb1aa0a): > > > > > > > > > > FYI,

RE: [PATCH] hpsa: add support for legacy boards

> The 5i controller is probably too old for the hpsa driver to support. > The hpsa driver is looking for information to determine if the drive is > online/offline and > this information is not available. > > What was the original issue you were having with the cciss driver? Christoph Hellwig

Re: [PATCH 02/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

On Tue, Jul 11, 2017 at 01:55:02AM -0700, Suganath Prabu S wrote: > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h > b/drivers/scsi/mpt3sas/mpt3sas_base.h > index 60fa7b6..cebdd8e 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.h > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.h > @@ -54,6 +54,7 @@

RE: [PATCH v2 11/15] megaraid_sas: Set device queue_depth same as HBA can_queue value in scsi-mq mode

> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Tuesday, July 11, 2017 7:28 PM > To: Shivasharan S > Cc: linux-scsi@vger.kernel.org; martin.peter...@oracle.com; > the...@redhat.com; j...@linux.vnet.ibm.com; > kashyap.de...@broadcom.com;

Re: [PATCH] iscsi-target: Reject immediate data underflow larger than SCSI transfer length

On Tue, 2017-07-11 at 00:22 -0700, Nicholas A. Bellinger wrote: > So rejecting this case as already done in commit abb85a9b51 is the > correct approach for >= v4.3.y. Hello Nic, I hope that you agree that the current target_cmd_size_check() implementation is complicated and ugly. Patch 30/33 of

Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion

On 10/07/2017 08:06, Yijing Wang wrote: No one uses the port_gone_completion in struct asd_sas_port, clean it out. This seems like a reasonable tidy-up patch which could be taken in isolation, having no dependency on the rest of the series. Signed-off-by: Yijing Wang

Re: [PATCHv2] tcmu: Fix possbile memory leak when recalculating the cmd base size

From: Xiubo Li For all the entries allocated from the ring cmd area, the memory is something like the stack memory, which will always reserve the old data, so the entry->req.iov_bidi_cnt maybe none zero. On some environments, the crash could be reporduce very

Re: [PATCH 2/6] SCSI: use blk_mq_run_hw_queues() in scsi_kick_queue()

On Wed, 2017-07-12 at 02:20 +0800, Ming Lei wrote: > Now SCSI won't stop queue, and not necessary to use > blk_mq_start_hw_queues(), so switch to blk_mq_run_hw_queues() > instead. > > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" >

[PATCH 2/6] SCSI: use blk_mq_run_hw_queues() in scsi_kick_queue()

Now SCSI won't stop queue, and not necessary to use blk_mq_start_hw_queues(), so switch to blk_mq_run_hw_queues() instead. Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Ming Lei

Re: [PATCH v2] scsi: sg: fix SG_DXFER_FROM_DEV transfers

On 2017-07-07 04:56 AM, Johannes Thumshirn wrote: SG_DXFER_FROM_DEV transfers do not necessarily have a dxferp as we set it to NULL for the old sg_io read/write interface, but must have a length bigger than 0. This fixes a regression introduced by commit 28676d869bbb ("scsi: sg: check for valid

Re: [PATCH] tcmu: Fix possible overflow for memcpy address in iovec

Hey Xiubo, On Tue, 2017-07-11 at 16:04 +0800, Xiubo Li wrote: > Hi All > > Please ignore about this patch. > > Just my mistake. > > Sorry. > Damien (CC'ed) has been observing something similar atop the latest target-pending/for-next with his user-space ZBC backend:

Re: [PATCH] tcmu: Fix possible overflow for memcpy address in iovec

Nicholas, On 7/11/17 17:41, Nicholas A. Bellinger wrote: > Hey Xiubo, > > On Tue, 2017-07-11 at 16:04 +0800, Xiubo Li wrote: >> Hi All >> >> Please ignore about this patch. >> >> Just my mistake. >> >> Sorry. >> > > Damien (CC'ed) has been observing something similar atop the latest >

[PATCH 06/13] mpt3sas: API 's to support NVMe drive addition to SML

Below Functions are added in various paths to support NVMe drive addition. _scsih_pcie_add_device _scsih_pcie_device_add _scsih_pcie_device_init_add _scsih_check_pcie_access_status _scsih_pcie_check_device mpt3sas_get_pdev_by_wwid mpt3sas_get_pdev_by_idchannel mpt3sas_get_pdev_by_handle

[PATCH 01/13] mpt3sas: Add nvme device support in slave alloc, target alloc and probe

1) Added support for probing pcie device and adding NVMe drives to SML and driver's internal list pcie_device_list. 2) Added support for determing NVMe as boot device. 3) Added nvme device support for call back functions scan_finished target_alloc,slave_alloc,target destroy and slave destroy.

[PATCH 10/13] mpt3sas: NVMe drive support for BTDHMAPPING ioctl command and log info

* Added debug prints for pcie devices in ioctl debug path. Which will be helpful for debugging. * Added PCIe device support for ioctl BTDHMAPPING ioctl. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S ---

[PATCH 00/13]mpt3sas driver NVMe support:

Ventura Series controller are Tri-mode. The controller and firmware are capable of supporting NVMe devices and PCIe switches to be connected with the controller. This patch set adds driver level support for NVMe devices and PCIe switches. Suganath Prabu S (13): mpt3sas: Add nvme device support

Re: [PATCH] iscsi-target: Add login_keys_workaround attribute for non RFC initiators

Hey Robert, Any chance to test this with your Flexboot PXE setup..? Please give this a spin ASAP to verify it addresses the regression you reported earlier, wrt FirstBurstLength not being proposed nor responded to using Flexboot PXE. Thank you. On Fri, 2017-07-07 at 22:24 +, Nicholas A.

Re: [PATCH v2 1/4] scsi: scsi_dh_alua: allow I/O in target port unavailable and standby states

On 07/11/2017 12:47 AM, Mauricio Faria de Oliveira wrote: > According to SPC-4 (5.15.2.4.5 Unavailable state), the unavailable > state may (or may not) transition to other states (e.g., microcode > downloading or hardware error, which may be temporary or permanent). > > But, scsi_dh_alua

Re: [PATCH] tcmu: Fix possible overflow for memcpy address in iovec

On 2017年07月11日 17:17, Damien Le Moal wrote: Xiubo, On Tue, 2017-07-11 at 17:04 +0800, Xiubo Li wrote: diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 930800c..86a845a 100644 --- a/drivers/target/target_core_user.c +++

Re: [PATCH] tcmu: Fix possbile memory leak when recalculating the cmd base size

On Tue, 2017-07-11 at 09:24 +, Damien Le Moal wrote: > Xiubo, > > Well done ! This fixed my problem. The ZBC test suite now passes all tests on > my target without crashing the kernel. > > Please see some comments/nitpicks below. > > Otherwise, please feel free to add my "tested-by" >

Re: [PATCH] tcmu: Fix possbile memory leak when recalculating the cmdbase size

Hi Damien, Good news. Thanks very much for you help to test about this. On 2017年07月11日 17:24, Damien Le Moal wrote: Xiubo, Well done ! This fixed my problem. The ZBC test suite now passes all tests on my target without crashing the kernel. Please see some comments/nitpicks below.

Re: [PATCH] tcmu: Fix possbile memory leak when recalculating thecmd base size

On 2017年07月11日 17:34, Nicholas A. Bellinger wrote: On Tue, 2017-07-11 at 09:24 +, Damien Le Moal wrote: Xiubo, Well done ! This fixed my problem. The ZBC test suite now passes all tests on my target without crashing the kernel. Please see some comments/nitpicks below. Otherwise, please

[PATCH 13/13] mpt3sas: Update mpt3sas driver version.

Updated mpt3sas driver version to 15.101.00.00 Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 08/13] mpt3sas: scan and add nvme device after controller reset

After Controller reset, Scan and add nvme device back to the topology. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 196 +- 1 files

[PATCH 12/13] mpt3sas: Update MPI Header

Update MPI Files for NVMe support Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpi/mpi2.h | 43 +++- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 647 +-

[PATCH 11/13] mpt3sas: Fix nvme drives checking for tlr.

Check for NVMe drives before enabling or checking tlr. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 22 -- 1 files changed, 16 insertions(+), 6

[PATCH 09/13] mpt3as: Add-Task-management-debug-info-for-NVMe-drives.

Added debug information for NVMe/PCIe drives in target rest path. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 86 -- 1 files changed,

[PATCH 02/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

* Added support for translating the SGLs associated with incoming commands either to IEE SGL or NVMe PRPs for NVMe devices. * The hardware translation of IEEE SGL to NVMe PRPs has limitation and if a command cannot be translated by hardware then it will go to firmware and the firmware needs to

[PATCH 03/13] mpt3sas: Added support for nvme encapsulated request message.

* Mpt3sas driver uses the NVMe Encapsulated Request message to send an NVMe command to an NVMe device attached to the IOC. * Normal I/O commands like reads and writes are passed to the controller as SCSI commands and the controller has the ability to translate the commands to NVMe equivalent. *

[PATCH 04/13] mpt3sas: Handle NVMe PCIe device related events generated from firmware.

* The controller firmware sends separate events for NVMe devices and PCIe switches similar to existing SAS events. * NVMe device detection, addition and removal are reported by the firmware through PCIe Topology Change list events. * The PCIe device state change events are sent when the firmware

[PATCH 07/13] mpt3sas: API's to remove nvme drive from sml

Below API's are included in nvme drive remove path. _scsih_pcie_device_remove _scsih_pcie_device_remove_by_handle _scsih_pcie_device_remove_from_sml Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S ---

[PATCH 05/13] mpt3sas: Set NVMe device queue depth as 128

Sets nvme device queue depth, name and displays device capabilities. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h |2 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 40

Re: [PATCH] tcmu: Fix possible overflow for memcpy address in iovec

On 2017年07月11日 16:41, Nicholas A. Bellinger wrote: Hey Xiubo, On Tue, 2017-07-11 at 16:04 +0800, Xiubo Li wrote: Hi All Please ignore about this patch. Just my mistake. Sorry. Damien (CC'ed) has been observing something similar atop the latest target-pending/for-next with his user-space

Re: [PATCH] tcmu: Fix possible overflow for memcpy address in iovec

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 930800c..86a845a 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -437,7 +437,7 @@ static int scatter_data_area(struct tcmu_dev *udev,

Re: [PATCH] tcmu: Fix possbile memory leak when recalculating the cmd base size

To Damien, Please test this, I think this maybe helpful. Thanks, BRs On 2017年07月11日 16:05, lixi...@cmss.chinamobile.com wrote: From: Xiubo Li For all the entries allocated from the ring cmd area, the memory is something like the stack, which will reserve

Re: [PATCH] scsi: qla2xxx: Off by one in qlt_ctio_to_cmd()

On Mon, 2017-07-10 at 11:47 +0300, Dan Carpenter wrote: > There are "req->num_outstanding_cmds" elements in the > req->outstanding_cmds[] array so the > here should be >=. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/qla2xxx/qla_target.c >

Re: [PATCH] tcmu: Fix possible overflow for memcpy address in iovec

Xiubo, On Tue, 2017-07-11 at 17:04 +0800, Xiubo Li wrote: > > > > > diff --git a/drivers/target/target_core_user.c > > > > > b/drivers/target/target_core_user.c > > > > > index 930800c..86a845a 100644 > > > > > --- a/drivers/target/target_core_user.c > > > > > +++

Re: [PATCH] tcmu: Fix possbile memory leak when recalculating the cmd base size

Xiubo, Well done ! This fixed my problem. The ZBC test suite now passes all tests on my target without crashing the kernel. Please see some comments/nitpicks below. Otherwise, please feel free to add my "tested-by" On Tue, 2017-07-11 at 17:06 +0800, Xiubo Li wrote: > On 2017年07月11日 16:05,

Re: [PATCH v2 1/4] scsi: scsi_dh_alua: allow I/O in target port unavailable and standby states

On 07/11/2017 12:32 PM, Mauricio Faria de Oliveira wrote: Also, it seems the Unavailable/Standby states would not be logged without a recheck from alua_check_sense(), since the only callers of alua_rtpg_queue() are alua_activate() and alua_check[_sense]() Well, actually it does get logged if

tgtd CPU 100% problem

We have meet a problem of tgtd CPU 100%. the infinband network card was negotiate as eth mode by mistake, after we change it to ib mode and restart opensmd for correct State（Active） the tgtd using 100% of CPU. and when we connect to it using tgtadm, tgtadm hang forever. # how to repeat * tgtd

[PATCH] hpsa: add support for legacy boards

Add support for legacy boards, ensuring to enable the driver for those boards only when 'hpsa_allow_any' is set. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 35 +-- drivers/scsi/hpsa.h | 44

Re: [PATCH 00/13]mpt3sas driver NVMe support:

Is there any update on this ? Will include linux-n...@lists.infradead.org in next version of this patch submission, if there is any change suggestion. Thanks, Suganath Prabu S On Thu, Jun 29, 2017 at 8:01 PM, Johannes Thumshirn wrote: > On Thu, Jun 29, 2017 at 07:49:01PM

[PATCH] tcmu: Fix possible overflow for memcpy address in iovec

From: Xiubo Li Before the data area dynamic grow patches, though the overflow bug was already exist, since the data area memories are all preallocated, so there mostly won't any bad page fault core trace produced. The dynamic grow patches will only allocate and map

[PATCH] tcmu: Fix possbile memory leak when recalculating the cmd base size

From: Xiubo Li For all the entries allocated from the ring cmd area, the memory is something like the stack, which will reserve the old data, so the entry->req.iov_bidi_cnt maybe none zero. To fix this, just memset all the entry memory before using it, and also to

Re: tgtd CPU 100% problem

On 11/07/17 10:51, 李春 wrote: We have meet a problem of tgtd CPU 100%. the infinband network card was negotiate as eth mode by mistake, after we change it to ib mode and restart opensmd for correct State（Active） the tgtd using 100% of CPU. and when we connect to it using tgtadm, tgtadm hang

Re: [PATCH] iscsi-target: Reject immediate data underflow larger than SCSI transfer length

Hi Bart, On Thu, 2017-06-08 at 23:55 -0700, Nicholas A. Bellinger wrote: > On Thu, 2017-06-08 at 15:37 +, Bart Van Assche wrote: > > On Thu, 2017-06-08 at 04:21 +, Nicholas A. Bellinger wrote: > > > + /* > > > + * Check for underflow case where both EDTL and immediate data payload > > >

Re: [PATCH 00/13]mpt3sas driver NVMe support:

On Tue, Jul 11, 2017 at 01:05:29PM +0530, Suganath Prabu Subramani wrote: > Is there any update on this ? > Will include linux-n...@lists.infradead.org in next version of this > patch submission, if there is any change suggestion. can you please re-send with Cc to linux-nvme? Thanks,

Re: [PATCH] tcmu: Fix possible overflow for memcpy address in iovec

Hi All Please ignore about this patch. Just my mistake. Sorry. Brs Xiubo On 2017年07月11日 15:40, lixi...@cmss.chinamobile.com wrote: From: Xiubo Li Before the data area dynamic grow patches, though the overflow bug was already exist, since the data area

Re: [PATCHv2] tcmu: Fix possbile memory leak when recalculating the cmd base size

On 07/11/2017 04:59 AM, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > For all the entries allocated from the ring cmd area, the memory is > something like the stack memory, which will always reserve the old > data, so the entry->req.iov_bidi_cnt maybe

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

>> -unsigned long port_events_pending; >> -unsigned long phy_events_pending; >> +struct asd_sas_event port_events[PORT_POOL_SIZE]; >> +struct asd_sas_event phy_events[PHY_POOL_SIZE]; >> >> int error; > > Hi Yijing, > > So now we are creating a static pool of events per

Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion

在 2017/7/11 23:54, John Garry 写道: > On 10/07/2017 08:06, Yijing Wang wrote: >> No one uses the port_gone_completion in struct asd_sas_port, >> clean it out. > > This seems like a reasonable tidy-up patch which could be taken in isolation, > having no dependency on the rest of the series. Yes.

Re: [PATCH 02/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

Hi Suganath, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.12 next-20170711] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Suganath-Prabu-S/mpt3sas-Add-nvme-device

Re: [PATCH] iscsi-target: Add login_keys_workaround attribute for non RFC initiators

On Tue, 2017-07-11 at 23:38 +, Bart Van Assche wrote: > On Fri, 2017-07-07 at 22:24 +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch re-introduces part of a long standing login workaround that > > was recently dropped by: > > > >

Re: [PATCH v2 01/15] qla2xxx: Combine Active command arrays.

On Tue, 2017-07-11 at 23:43 +, Bart Van Assche wrote: > On Tue, 2017-06-13 at 20:47 -0700, Himanshu Madhani wrote: > > typedef struct srb { > > + /* > > +* Do not move cmd_type field, it needs to > > +* line up with qla_tgt_cmd->cmd_type > > +*/ > > + uint8_t cmd_type; > > +

Re: [PATCH] iscsi-target: Add login_keys_workaround attribute for non RFC initiators

On Fri, 2017-07-07 at 22:24 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch re-introduces part of a long standing login workaround that > was recently dropped by: > > commit 1c99de981f30b3e7868b8d20ce5479fa1c0fea46 > Author: Nicholas

Re: [PATCH v2 01/15] qla2xxx: Combine Active command arrays.

On Tue, 2017-06-13 at 20:47 -0700, Himanshu Madhani wrote: > typedef struct srb { > + /* > + * Do not move cmd_type field, it needs to > + * line up with qla_tgt_cmd->cmd_type > + */ > + uint8_t cmd_type; > + uint8_t pad[3]; Hello Himanshu, Had I understood correctly

Re: [PATCH 02/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

On Tue, Jul 11, 2017 at 01:55:02AM -0700, Suganath Prabu S wrote: > +/** > + * _base_check_pcie_native_sgl - This function is called for PCIe end > devices to > + * determine if the driver needs to build a native SGL. If so, that native > + * SGL is built in the special contiguous buffers