Re: [PATCH] sd: implement stop_on_shutdown

2007-02-05 Thread Tejun Heo
James Bottomley wrote: There are practical problems to handling this in sd, namely that the power handling commands and state model are part of the ATA command set, not part of the SCSI command set. SAT really only covers the basics of mapping the different power management models. I see. I

Re: [PATCH] sd: implement stop_on_shutdown

2007-02-05 Thread James Bottomley
On Mon, 2007-02-05 at 18:43 +0900, Tejun Heo wrote: James, do you think such change to sd is acceptable? As the original patch, the default behavior won't be changed, so unless specifically configured (probably during boot by dist) there won't be any behavior change. Yes, as long as the

RE: Fw: SAS1068 PCI-X Fusion-MPT SAS 1000:0055

2007-02-05 Thread Moore, Eric
The 2.6.9-22.EL kernel is RHEL4 Update 2. You may want to contact someone from the LSI MegaRAID group, or Red Hat since this is a binary only deliverable. You should be able to find a MegaRAID contact in the MAINTAINERS file in the top directory of the kernel source tree. I work on mpt fusion

SG_IO weirdness

2007-02-05 Thread Cameron, Steve
I noticed that when I do two SG_IO ioctls to a target device (say, tape drive, disk drive, whatever) in which the first request is well formed (e.g. an inquiry) and the second one has a malformed CDB, such that it gets check condition with sense key == 5 (ILLEGAL REQUEST), the data buffer

Re: SG_IO weirdness

2007-02-05 Thread Douglas Gilbert
Cameron, Steve wrote: I noticed that when I do two SG_IO ioctls to a target device (say, tape drive, disk drive, whatever) in which the first request is well formed (e.g. an inquiry) and the second one has a malformed CDB, such that it gets check condition with sense key == 5 (ILLEGAL

RE: SG_IO weirdness

2007-02-05 Thread Cameron, Steve
Steve, Even though the SCSI status is CHECK CONDITION, the data-in buffer may still be transferred. One obvious example is a READ command when the sense key is RECOVERED ERROR. Yep, of course. The sg driver and I suspect the block layer SG_IO do not check the SCSI status to determine

[PATCH] scsi spi transport: SCSI domain validation after reset

2007-02-05 Thread Mark Haverkamp
James, Some months ago, I had problems with a mis-behaving disk that failed domain validation on a fusion card resulting in an infinite loop of domain validation. At the time Eric proposed a patch to the mptspi driver to reload devices with parameters previously negotiated when a reset occurred.

Re: SG_IO weirdness

2007-02-05 Thread Douglas Gilbert
Cameron, Steve wrote: Steve, Even though the SCSI status is CHECK CONDITION, the data-in buffer may still be transferred. One obvious example is a READ command when the sense key is RECOVERED ERROR. Yep, of course. The sg driver and I suspect the block layer SG_IO do not check the SCSI

Re: [PATCH] scsi spi transport: SCSI domain validation after reset

2007-02-05 Thread James Bottomley
On Mon, 2007-02-05 at 12:49 -0800, Mark Haverkamp wrote: James, Some months ago, I had problems with a mis-behaving disk that failed domain validation on a fusion card resulting in an infinite loop of domain validation. At the time Eric proposed a patch to the mptspi driver to reload

Re: [PATCH] scsi spi transport: SCSI domain validation after reset

2007-02-05 Thread Mark Haverkamp
On Mon, 2007-02-05 at 15:50 -0600, James Bottomley wrote: On Mon, 2007-02-05 at 12:49 -0800, Mark Haverkamp wrote: James, Some months ago, I had problems with a mis-behaving disk that failed domain validation on a fusion card resulting in an infinite loop of domain validation. At the

megaraid_sas : Error message from SYNC CACHE cmd fills up kernel log

2007-02-05 Thread Patro, Sumant
MegaRAID (MR) SAS Adapter FW is exposing VDs (Logical Disks) with WCE enabled in Mode Sense command for drives that are configured as WriteBack by the user. When the VDs are exported as Write Back drives, OS is sending Synchronize Cache command to the drives frequently. Per SCSI Spec, this

Re: megaraid_sas : Error message from SYNC CACHE cmd fills up kernel log

2007-02-05 Thread James Bottomley
On Mon, 2007-02-05 at 15:14 -0700, Patro, Sumant wrote: 1. Shouldn't the OS stop sending the sync cache cmd if it sees it is Failed with Invalid Command in sense info ? Possibly, but supporting a write back cache but not supporting the command to flush it is unusual (or more likely

RE: SG_IO weirdness

2007-02-05 Thread Cameron, Steve
Steve, From memory, between SPC-2 and SPC-3 the INQUIRY allocation length field went from 8 bits to 16 bits. If you do the above calculation modulo 256 it comes out correct :-) The moral here is don't set INQUIRY lengths 252 unless the target can handle it. There is no point anyway for

aic79xx noise on hot insert in 2.6.19.x and 2.6.20

2007-02-05 Thread Mark Rustad
I have systems with Supermicro X6-class (Nocona/Lindenhurst) motherboards with Adaptec SCSI and SAFTE backplanes running software RAID-1 (md) on a pair of drives. When I hot-insert a drive, I get a lot of noise from the kernel apparently due to lack of handling something in the interrupt

[PATCH 0/2] bsg: ring buffer interface

2007-02-05 Thread FUJITA Tomonori
This patchset adds a generic ring buffer interface and converts bsg to use it. The scsi target infrastructure invented its own mmap ring buffer interface. It seems that kevent would use a slightly different ring buffer interface. I think it would be nice to have common ring buffer code rather

[PATCH 2/2] bsg: convert bsg to use the generic ring buffer code

2007-02-05 Thread FUJITA Tomonori
This converts bsg to use the generic ring buffer code. A new data structure, bsg_fd, is introduced to let each process to have its own ring buffers (that is, several ring buffer pairs could be attached to one bsg device). Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] --- block/bsg.c | 252

[patch 06/33] drivers/scsi/pcmcia/nsp_cs.h: removal of old scsi code

2007-02-05 Thread akpm
From: Michal Piotrowski [EMAIL PROTECTED] Signed-off-by: Michal Piotrowski [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/pcmcia/nsp_cs.h | 66 - 1 file changed, 66 deletions(-) diff -puN

[patch 07/33] scsi: remove unnecessary check in drivers/scsi/sg.c

2007-02-05 Thread akpm
From: Eric Sesterhenn [EMAIL PROTECTED] coverity spotted this (cid #758). All callers dereference sfp, so we dont need this check. In addition to this, we dereference it earlier in the function. Signed-off-by: Eric Sesterhenn [EMAIL PROTECTED] Cc: Douglas Gilbert [EMAIL PROTECTED] Cc: James

[patch 10/33] pci_module_init() convertion in the legacy megaraid driver

2007-02-05 Thread akpm
From: Henrik Kretzschmar [EMAIL PROTECTED] pci_module_init() convertion in the legacy megaraid driver. Signed-off-by: Henrik Kretzschmar [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/megaraid.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[patch 13/33] MPT fusion: handle PCI layer error on resume

2007-02-05 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] In the unlikely event of pci_enable_device() failure during resume, we do the minimalist solution and simply exit, rather than continuing to enable the hardware. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Cc: Moore, Eric Dean [EMAIL PROTECTED] Cc: James

[patch 11/33] pci_module_init() convertion in tmscsim.c

2007-02-05 Thread akpm
From: Henrik Kretzschmar [EMAIL PROTECTED] pci_module_init() convertion in tmscsim.c Signed-off-by: Henrik Kretzschmar [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/tmscsim.c |6 -- 1 file changed, 4

[patch 19/33] scsi: sic7xxx stray bracket fix

2007-02-05 Thread akpm
From: Mariusz Kozlowski [EMAIL PROTECTED] Fix broken-but-unused macro. Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/aic7xxx/aic79xx_pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN

[patch 24/33] DAC960: kmalloc-kzalloc/Casting cleanups

2007-02-05 Thread akpm
From: Ahmed S. Darwish [EMAIL PROTECTED] A patch to switch kmalloc-kzalloc and to clean unneeded kammloc, pci_alloc_consistent casts Signed-off-by: Ahmed Darwish [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/block/DAC960.c | 27 +-- 1

[patch 25/33] Fix the reproducible oops in scsi

2007-02-05 Thread akpm
From: OGAWA Hirofumi [EMAIL PROTECTED] I got the oops after some hotplug events. And the similar oops can reproduce by the following step. plug usb-storage (e.g. scsi_host of usb is host5, and device is sde) # mount /dev/sde1 /mnt # echo 1 /sys/block/sde/device/delete # echo - - -

[patch 30/33] Remove some unused SCSI-related kernel config variables.

2007-02-05 Thread akpm
From: Robert P. J. Day [EMAIL PROTECTED] Remove the unused SCSI-related kernel config variables SCSI_NCR53C8XX_PROFILE_SUPPORT SCSI_NCR53C8XX_PROFILE 53C700_IO_MAPPED AIC79XX_ENABLE_RD_STRM AIC7XXX_PROBE_EISA_VL Signed-off-by: Robert P. J. Day [EMAIL

[patch 21/33] sym53c8xx_2 claims cpqarray device

2007-02-05 Thread akpm
From: Chip Coldwell [EMAIL PROTECTED] Apropos this thread http://marc.theaimsgroup.com/?l=linux-scsim=115591706804045w=2 which led to this patch http://www.kernel.org/git/?p=linux/kernel/git/jejb/scsi-rc-fixes-2.6.git;a=commit;h=b2b3c121076961333977f485f0d54c22121df920 do we not also need the

[patch 31/33] scsi_kmap_atomic_sg(): check that local irqs are disabled

2007-02-05 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] The KM_BIO_SRC_IRQ kmap slot must be taken with local irqs disabled. Add a check into scsi for this. Cc: James Bottomley [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/scsi_lib.c |2 ++ 1 file changed, 2

[patch 28/33] drivers/scsi/BusLogic: Replace 'boolean' by 'bool'

2007-02-05 Thread akpm
From: Richard Knutsson [EMAIL PROTECTED] Signed-off-by: Richard Knutsson [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/BusLogic.c | 42 ++--- drivers/scsi/BusLogic.h | 300 +--- drivers/scsi/FlashPoint.c |4 3 files

[patch 14/33] drivers/scsi/NCR5380.c: Replacing yield() with a better alternative

2007-02-05 Thread akpm
From: Amol Lad [EMAIL PROTECTED] Replaced yield() with cond_resched() Signed-off-by: Amol Lad [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/NCR5380.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN

[patch 15/33] drivers/scsi/megaraid.c: Replacing yield() with a better alternative

2007-02-05 Thread akpm
From: Amol Lad [EMAIL PROTECTED] For this driver cond_resched() seems to be a better alternative Signed-off-by: Amol Lad [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/megaraid.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN

[patch 33/33] SCSI: Fix obvious typo spin_lock_irqrestore() in gdth.c

2007-02-05 Thread akpm
From: Robert P. J. Day [EMAIL PROTECTED] Fix misspelled spin_lock_irqrestore to read spin_unlock_irqrestore instead. Presumably, GDTH_RTC doesn't get used a lot. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Signed-off-by: Andrew

[patch 32/33] SCSI-BusLogic: local_irq_disable() is redundant after local_irq_save()

2007-02-05 Thread akpm
From: Jiri Kosina [EMAIL PROTECTED] drivers/scsi/BusLogic.c::BusLogic_Command() contains local_irq_disable() call after local_irq_save(). This looks redundant. Signed-off-by: Jiri Kosina [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 17/33] drivers/scsi/mca_53c9x.c : save_flags()/cli() removal

2007-02-05 Thread akpm
From: Amol Lad [EMAIL PROTECTED] Replaced save_flags()/cli() with spin_lock alternatives [EMAIL PROTECTED]: no longer BROKEN_ON_SMP] Signed-off-by: Amol Lad [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 26/33] scsi: handle bad inquiry responses

2007-02-05 Thread akpm
From: Alan Stern [EMAIL PROTECTED] From Meelis's USB device: It contains the device's response to an INQUIRY command. 8100795e84c0 1469131296 C Bi:006:02 0 36 = 0081 47454e45 52494320 55534220 4449534b 20444556 49434520 The fifth byte of the response is 0, meaning that all

[patch 04/33] drivers/scsi/advansys.c: cleanups

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] - remove the unneeded advansys.h - remove the unused advansys_setup() - make needlessly global functions static Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/advansys.c | 101

[patch 03/33] scsi: clean up warnings in Advansys driver

2007-02-05 Thread akpm
From: Ken Witherow [EMAIL PROTECTED] Fix typecast warnings and switch from check_region to request_region (akpm: Ken and Jeffrey Phillips Freeman [EMAIL PROTECTED] are possible advansys testers) Signed-off-by: Ken Witherow [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 01/33] drivers/scsi/: small cleanups

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] This patch contains the following cleanups: - make needlessly global functions static - every file should #include the headers containing the prototypes for it's global functions Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Cc: James Bottomley [EMAIL

[patch 02/33] drivers/scsi/aic7xxx/aic79xx_core.c: make ahd_match_scb() static

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Cc: James Bottomley [EMAIL PROTECTED] Acked-by: Hannes Reinecke [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/aic7xxx/aic79xx.h |3 ---

[patch 05/33] megaraid: fix warnings when CONFIG_PROC_FS=n

2007-02-05 Thread akpm
From: walter harms [EMAIL PROTECTED] Signed-off-by: walter harms [EMAIL PROTECTED] Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] Cc: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/megaraid.c | 17 +++-- drivers/scsi/megaraid.h |

[patch 12/33] drivers/scsi/dpt_i2o.c: remove dead code

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] The Coverity checker spotted this dead code introduced by commit a07f353701acae77e023f6270e8af353b37af7c4. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/dpt_i2o.c |2 -- 1 file changed, 2

[patch 18/33] drivers/scsi/aic7xxx/: make functions static

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/aic7xxx/aic79xx_osm.c |6 -- drivers/scsi/aic7xxx/aic79xx_osm.h |2 -- drivers/scsi/aic7xxx/aic7xxx.h |5 -

[patch 29/33] make seagate_st0x_detect() static

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] seagate_st0x_detect() can become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/seagate.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN

[patch 22/33] drivers/scsi/wd33c93.c: cleanups

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] - #include asm/irq.h for getting the prototypes of {dis,en}able_irq() - make the needlessly global wd33c93_setup() static Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/wd33c93.c |4 +++- 1

[patch 27/33] drivers/scsi/qla4xxx/: possible cleanups

2007-02-05 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] - make needlessly global code static - #if 0 unused functions Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: Ravi Anand [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_dbg.c |4

panic in sd_rw_initr of SLSE10 PPC

2007-02-05 Thread Qi, Yanling
Hi All, We have a 4GB Emulex HBA with 8.1.6 lpfc driver. The distribution is SLES10 on PowerPc. When we do a number of target-storage-system reboots, we see the following panic. Has any one seen this before? Thanks, Yanling Oops: Kernel access of bad area, sig: 11 [#1] SMP NR_CPUS=128 NUMA