[PATCH 1/6] qla2xxx: Determine the number of outstanding commands based on available resources.

2012-12-07 Thread Saurav Kashyap
From: Chad Dupuis chad.dup...@qlogic.com Base the number of outstanding requests the driver will keep track of on the available resources instead of being hard-coded. Signed-off-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com ---

Re: [PATCH 04/12] [SCSI] qla2xxx: Use standard PCIe Capability Link register field names

2012-12-07 Thread Saurav Kashyap
Acked-by: Saurav Kashyap saurav.kash...@qlogic.com Thanks, ~Saurav Use the standard #defines for PCIe Link Capability register fields rather than bare numbers. This also uses the new PCI Express Capability accessor rather than reading the capability directly. Signed-off-by: Bjorn Helgaas

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-07 Thread Or Gerlitz
On Thu, Dec 6, 2012 at 4:27 PM, Or Gerlitz ogerl...@mellanox.com wrote: [...] looking on the current locks in the system, we see that this kworker task holds four locks, but none of them seems to be mutually held by another task, That was ofcourse a wrong assertion, as a lock can't be mutually

Re: [PATCH v7 3/9] Introduce scsi_device_being_removed()

2012-12-07 Thread Rolf Eike Beer
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 55367b0..767dd16 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -442,6 +442,11 @@ static inline int scsi_device_created(struct scsi_device *sdev) return sdev-sdev_state == SDEV_CREATED

Re: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-07 Thread Rolf Eike Beer
ioc-diag_trigger_mpi is an SL_WH_MPI_TRIGGERS_T struct. There is a cut and paste error here and SL_WH_EVENT_TRIGGERS_T is used instead of SL_WH_MPI_TRIGGERS_T. Since the SL_WH_EVENT_TRIGGERS_T is smaller than SL_WH_MPI_TRIGGERS_T, it means we only clear part of the buffer. Signed-off-by: Dan

Re: [PATCH v7 3/9] Introduce scsi_device_being_removed()

2012-12-07 Thread Bart Van Assche
On 12/07/12 09:40, Rolf Eike Beer wrote: diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 55367b0..767dd16 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -442,6 +442,11 @@ static inline int scsi_device_created(struct scsi_device *sdev)

Re: [PATCH v7 3/9] Introduce scsi_device_being_removed()

2012-12-07 Thread Rolf Eike Beer
Am , schrieb Bart Van Assche: On 12/07/12 09:40, Rolf Eike Beer wrote: diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 55367b0..767dd16 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -442,6 +442,11 @@ static inline int

[patch v2] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-07 Thread Dan Carpenter
ioc-diag_trigger_mpi is an SL_WH_MPI_TRIGGERS_T struct. There is a cut and paste error here and SL_WH_EVENT_TRIGGERS_T is used instead of SL_WH_MPI_TRIGGERS_T. Since the SL_WH_EVENT_TRIGGERS_T is smaller than SL_WH_MPI_TRIGGERS_T, it means we only clear part of the buffer. I've changed it to

Re: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-07 Thread Dan Carpenter
On Fri, Dec 07, 2012 at 09:41:56AM +0100, Rolf Eike Beer wrote: memset(ioc-diag_trigger_mpi, 0, -sizeof(struct SL_WH_EVENT_TRIGGERS_T)); +sizeof(struct SL_WH_MPI_TRIGGERS_T)); memcpy(ioc-diag_trigger_mpi, buf, sz); if (ioc-diag_trigger_mpi.ValidEntries

Re: [PATCH] scsi_ram: a RAM-based SCSI driver

2012-12-07 Thread Kirill A. Shutemov
On Thu, Dec 06, 2012 at 11:09:07AM +0100, Paolo Bonzini wrote: Il 05/12/2012 17:45, Kirill A. Shutemov ha scritto: From: Kirill A. Shutemov kirill.shute...@linux.intel.com This driver is intended to run as fast as possible, hence the options to discard writes and reads. It's designed to

Re: [PATCH v7 3/9] Introduce scsi_device_being_removed()

2012-12-07 Thread Bart Van Assche
On 12/07/12 11:02, Rolf Eike Beer wrote: Am , schrieb Bart Van Assche: On 12/07/12 09:40, Rolf Eike Beer wrote: diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 55367b0..767dd16 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -442,6

Re: [PATCH v7 5/9] Disallow changing the device state via sysfs into deleted

2012-12-07 Thread Bart Van Assche
On 12/07/12 07:55, Hannes Reinecke wrote: On 12/06/2012 04:56 PM, Bart Van Assche wrote: Changing the state of a SCSI device via sysfs into cancel or deleted prevents scsi_remove_host() to remove these devices. Hence do not allow this. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc:

Re: [PATCH v7 5/9] Disallow changing the device state via sysfs into deleted

2012-12-07 Thread Bart Van Assche
On 12/07/12 13:46, Bart Van Assche wrote: On 12/07/12 07:55, Hannes Reinecke wrote: On 12/06/2012 04:56 PM, Bart Van Assche wrote: Changing the state of a SCSI device via sysfs into cancel or deleted prevents scsi_remove_host() to remove these devices. Hence do not allow this.

Re: [PATCH v7 5/9] Disallow changing the device state via sysfs into deleted

2012-12-07 Thread Hannes Reinecke
On 12/07/2012 02:33 PM, Bart Van Assche wrote: On 12/07/12 13:46, Bart Van Assche wrote: On 12/07/12 07:55, Hannes Reinecke wrote: On 12/06/2012 04:56 PM, Bart Van Assche wrote: Changing the state of a SCSI device via sysfs into cancel or deleted prevents scsi_remove_host() to remove these

Re: [PATCH v7 3/9] Introduce scsi_device_being_removed()

2012-12-07 Thread Rolf Eike Beer
Am , schrieb Bart Van Assche: On 12/07/12 11:02, Rolf Eike Beer wrote: Am , schrieb Bart Van Assche: On 12/07/12 09:40, Rolf Eike Beer wrote: diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index 55367b0..767dd16 100644 --- a/include/scsi/scsi_device.h +++

Re: Odd behavior of a SAS-2 backplane with SGPIO commands

2012-12-07 Thread Pasi Kärkkäinen
On Thu, Nov 01, 2012 at 11:55:25AM -0400, Rich wrote: On Sun, Oct 21, 2012 at 8:46 AM, Pasi Kärkkäinen pa...@iki.fi wrote: On Mon, Sep 10, 2012 at 07:13:15PM +0300, Pasi Kärkkäinen wrote: On Mon, Sep 10, 2012 at 12:07:45PM -0400, Rich wrote: On Mon, Sep 10, 2012 at 12:04 PM, Pasi

[PATCH][RFC] scsi_transport_fc: Implement I_T nexus reset

2012-12-07 Thread Hannes Reinecke
'Bus reset' is not really applicable to FibreChannel, as the concept of a bus doesn't apply. Hence all FC LLDD simulate a 'bus reset' by sending a target reset to each attached remote port, causing error handling to spill over to unaffected devices. This patch implements a 'I_T nexus reset'

Re: [PATCH v7 4/9] Remove offline devices when removing a host

2012-12-07 Thread Hannes Reinecke
On 12/06/2012 04:55 PM, Bart Van Assche wrote: Currently __scsi_remove_device() skips devices that are visible and offline. Make sure that these devices get removed by changing their device state into SDEV_DEL at the start of __scsi_remove_device(). Also, avoid that __scsi_remove_device() gets

Re: [PATCH v7 4/9] Remove offline devices when removing a host

2012-12-07 Thread Bart Van Assche
On 12/07/12 16:10, Hannes Reinecke wrote: On 12/06/2012 04:55 PM, Bart Van Assche wrote: Currently __scsi_remove_device() skips devices that are visible and offline. Make sure that these devices get removed by changing their device state into SDEV_DEL at the start of __scsi_remove_device().

Re: [PATCH v7 4/9] Remove offline devices when removing a host

2012-12-07 Thread Bart Van Assche
On 12/07/12 16:33, Bart Van Assche wrote: On 12/07/12 16:10, Hannes Reinecke wrote: On 12/06/2012 04:55 PM, Bart Van Assche wrote: Currently __scsi_remove_device() skips devices that are visible and offline. Make sure that these devices get removed by changing their device state into SDEV_DEL

Re: [PATCH][RFC] scsi_transport_fc: Implement I_T nexus reset

2012-12-07 Thread Mike Christie
On 12/07/2012 08:51 AM, Hannes Reinecke wrote: 'Bus reset' is not really applicable to FibreChannel, as the concept of a bus doesn't apply. Hence all FC LLDD simulate a 'bus reset' by sending a target reset to each attached remote port, causing error handling to spill over to unaffected

qla2xxx firmware

2012-12-07 Thread Xose Vazquez Perez
hi, please qlogic guys, send latest fw to upstream linux-firmware.git linux-firmware brings old releases: File: ql2400_fw.bin Version: 5.06.05 MID File: ql2500_fw.bin Version: 5.06.05 MIDQ qlogic-ftp releases: ql2400_fw.bin -- 5.08.00 MID ql2500_fw.bin -- 5.08.00 MIDQ -thank you- -- To

Re: [PATCH][RFC] scsi_transport_fc: Implement I_T nexus reset

2012-12-07 Thread Chad Dupuis
On Fri, 7 Dec 2012, Mike Christie wrote: On 12/07/2012 08:51 AM, Hannes Reinecke wrote: 'Bus reset' is not really applicable to FibreChannel, as the concept of a bus doesn't apply. Hence all FC LLDD simulate a 'bus reset' by sending a target reset to each attached remote port, causing error

Re: [PATCH][RFC] scsi_transport_fc: Implement I_T nexus reset

2012-12-07 Thread Mike Christie
On 12/07/2012 03:05 PM, Jeremy Linton wrote: On 12/7/2012 1:58 PM, Chad Dupuis wrote: Also, are there certain port types we wouldn't want to send this reset to such as tape? AFAIK, for tape it shouldn't cause any more harm than the target reset which happens immediately before it.

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-07 Thread Vu Pham
Alex Turin wrote: On 12/6/2012 5:04 PM, Bart Van Assche wrote: On 12/06/12 15:27, Or Gerlitz wrote: The core problem here seems to be that scsi_remove_host simply never ends. Hello Or, The later patches in the srp-ha patch series avoided such behavior by checking whether the

Re: [PATCH] scsi_ram: a RAM-based SCSI driver

2012-12-07 Thread Paolo Bonzini
Il 07/12/2012 12:20, Kirill A. Shutemov ha scritto: Is this that much faster than scsi-debug? The discarding options surely can be added there. scsi_ram is about 9% faster (without fake_rw/throw_away_*) on my machine: There are two main differences in the data path: - scsi_debug uses

Re: [PATCH 04/12] [SCSI] qla2xxx: Use standard PCIe Capability Link register field names

2012-12-07 Thread Giridhar Malavali
Acked-by: Giridhar Malavali On 12/7/12 12:17 AM, Saurav Kashyap saurav.kash...@qlogic.com wrote: Acked-by: Saurav Kashyap saurav.kash...@qlogic.com Thanks, ~Saurav Use the standard #defines for PCIe Link Capability register fields rather than bare numbers. This also uses the new PCI Express

Re: [PATCH][RFC] scsi_transport_fc: Implement I_T nexus reset

2012-12-07 Thread Jeremy Linton
On 12/7/2012 3:20 PM, Mike Christie wrote: On 12/07/2012 03:05 PM, Jeremy Linton wrote: That said, its far from perfect. The code (as I understand it) isn't differentiating between isolating the failure, or bringing out the big hammer in an attempt to correct problems on a specific I_T_L. If