Re: [PATCH v3] qla2xxx: silence two GCC warnings

2013-01-30 Thread Saurav Kashyap
On Mon, 2012-10-08 at 11:15 -0500, Saurav Kashyap wrote: Acked-by: Saurav Kashyap saurav.kash...@qlogic.com Thanks, ~Saurav Compiling qla_gs.o (part of the qla2xxx module) triggers two GCC warnings: drivers/scsi/qla2xxx/qla_gs.c: In function Œqla2x00_fdmi_rhba¹:

Re: [PATCH v3] qla2xxx: silence two GCC warnings

2013-01-30 Thread Paul Bolle
On Wed, 2013-01-30 at 08:07 +, Saurav Kashyap wrote: I am submitting some correction patches today and this patch will be part of the scsi-misc submission after that set. Thanks. Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread walter harms
Am 30.01.2013 08:06, schrieb Dan Carpenter: There wasn't any error handling for this kzalloc(). Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c index c06b8e5..d8293f2 100644 ---

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Dan Carpenter
On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote: Am 30.01.2013 08:06, schrieb Dan Carpenter: There wasn't any error handling for this kzalloc(). Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/scsi/osd/osd_initiator.c

Re: [PATCH] target/iblock: Use backend REQ_FLUSH hint for WriteCacheEnabled status

2013-01-30 Thread Nicholas A. Bellinger
On Wed, 2013-01-30 at 15:39 +0800, Asias He wrote: On 01/30/2013 02:57 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch allows IBLOCK to check block hints in request_queue-flush_flags when reporting current backend device WriteCacheEnabled status

[PATCH 4/6] qla2xxx: Allow ISP81xx to create ATIO queues.

2013-01-30 Thread Saurav Kashyap
From: Arun Easi arun.e...@qlogic.com Signed-off-by: Arun Easi arun.e...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_os.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c

[PATCH 0/6] qla2xxx: Patches for scsi misc branch.

2013-01-30 Thread Saurav Kashyap
Hi James, Please apply the following patches to the scsi tree at your earliest convenience for inclusion in the next mainline merge window. Thanks, ~Saurav Arun Easi (3): qla2xxx: Enable target mode support for ISP83xx. qla2xxx: Allow ISP81xx to create ATIO queues. qla2xxx: Prevent

[PATCH 3/6] qla2xxx: Enable target mode support for ISP83xx.

2013-01-30 Thread Saurav Kashyap
From: Arun Easi arun.e...@qlogic.com Signed-off-by: Arun Easi arun.e...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c|2 +- drivers/scsi/qla2xxx/qla_def.h|8 ++ drivers/scsi/qla2xxx/qla_fw.h |3 +-

[PATCH 2/6] qla2xxx: Ramp down queue depth for attached SCSI devices when driver resources are low.

2013-01-30 Thread Saurav Kashyap
From: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c|2 +- drivers/scsi/qla2xxx/qla_def.h|9 +++ drivers/scsi/qla2xxx/qla_gbl.h|1 +

[PATCH 5/6] qla2xxx: Prevent enabling target mode for unsupported HBAs.

2013-01-30 Thread Saurav Kashyap
From: Arun Easi arun.e...@qlogic.com Signed-off-by: Arun Easi arun.e...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c|2 +- drivers/scsi/qla2xxx/qla_def.h|1 + drivers/scsi/qla2xxx/qla_target.c |6 ++ 3 files

[PATCH 6/6] qla2xxx: Correction to the message ids.

2013-01-30 Thread Saurav Kashyap
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c index

Re: [PATCH 0/3] target: Fix zero-length regressions in v3.8-rc1 code

2013-01-30 Thread Paolo Bonzini
Il 29/01/2013 23:26, Nicholas A. Bellinger ha scritto: From: Nicholas Bellinger n...@linux-iscsi.org Hi folks, The following are a handful of zero-length CDB regression bugfixes to address breakage introduced by the recent sense_reason_t conversion in v3.8-rc1 code, which incorrectly

[PATCH v8 0/4] block layer runtime pm

2013-01-30 Thread Aaron Lu
In August 2010, Jens and Alan discussed about Runtime PM and the block layer. http://marc.info/?t=12825910841r=1w=2 And then Alan has given a detailed implementation guide: http://marc.info/?l=linux-scsim=133727953625963w=2 To test: # ls -l /sys/block/sda

[PATCH v8 4/4] sd: change to auto suspend mode

2013-01-30 Thread Aaron Lu
From: Lin Ming ming.m@intel.com Uses block layer runtime pm helper functions in scsi_runtime_suspend/resume for devices that take advantage of it. Remove scsi_autopm_* from sd open/release path and check_events path. Signed-off-by: Lin Ming ming.m@intel.com Signed-off-by: Aaron Lu

[PATCH v8 3/4] block: implement runtime pm strategy

2013-01-30 Thread Aaron Lu
From: Lin Ming ming.m@intel.com When a request is added: If device is suspended or is suspending and the request is not a PM request, resume the device. When the last request finishes: Call pm_runtime_mark_last_busy(). When pick a request: If device is resuming/suspending,

[PATCH v8 2/4] block: add runtime pm helpers

2013-01-30 Thread Aaron Lu
From: Lin Ming ming.m@intel.com Add runtime pm helper functions: void blk_pm_runtime_init(struct request_queue *q, struct device *dev) - Initialization function for drivers to call. int blk_pre_runtime_suspend(struct request_queue *q) - If any requests are in the queue, mark last busy

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Benny Halevy
On Wed, Jan 30, 2013 at 10:57 AM, walter harms wha...@bfs.de wrote: Am 30.01.2013 09:27, schrieb Dan Carpenter: On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote: Am 30.01.2013 08:06, schrieb Dan Carpenter: There wasn't any error handling for this kzalloc(). Signed-off-by: Dan

Re: storvsc loops with No Sense messages

2013-01-30 Thread Olaf Hering
On Tue, Jan 29, Olaf Hering wrote: On Tue, Jan 29, KY Srinivasan wrote: Was the installation done on a vhd or VHDX. I checked with Hyper-V guys and they say they never supported WRITE_SAME. I am wondering how it worked on ws2008. Its a vhdx image, both fixed and dynamically size have

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Benny Halevy
On Wed, Jan 30, 2013 at 9:06 AM, Dan Carpenter dan.carpen...@oracle.com wrote: There wasn't any error handling for this kzalloc(). Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c index c06b8e5..d8293f2

Re: [patch] [SCSI] qla4xxx: don't free NULL dma pool

2013-01-30 Thread Vikas Chaudhary
-Original Message- From: Dan Carpenter dan.carpen...@oracle.com Date: Wednesday 30 January 2013 12:37 PM To: Ravi Anand ravi.an...@qlogic.com Cc: Vikas vikas.chaudh...@qlogic.com, Dept-Eng iSCSI Driver dept-iscsidri...@qlogic.com, James E.J. Bottomley jbottom...@parallels.com, scsi

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread walter harms
Am 30.01.2013 10:51, schrieb Benny Halevy: On Wed, Jan 30, 2013 at 10:57 AM, walter harms wha...@bfs.de wrote: Am 30.01.2013 09:27, schrieb Dan Carpenter: On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote: Am 30.01.2013 08:06, schrieb Dan Carpenter: There wasn't any error

Re: storvsc loops with No Sense messages

2013-01-30 Thread Olaf Hering
On Wed, Jan 30, Olaf Hering wrote: Is there a way to not use WRITE_SAME at all? While browsing the code its not clear if there is a conditional for this command. It seems scsi_device-no_write_same may avoid this command, I will test this patch: # Subject: [PATCH] scsi: storvsc: avoid usage of

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Benny Halevy
On Wed, Jan 30, 2013 at 3:00 PM, walter harms wha...@bfs.de wrote: Am 30.01.2013 10:51, schrieb Benny Halevy: On Wed, Jan 30, 2013 at 10:57 AM, walter harms wha...@bfs.de wrote: Am 30.01.2013 09:27, schrieb Dan Carpenter: On Wed, Jan 30, 2013 at 09:15:43AM +0100, walter harms wrote: Am

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread walter harms
Am 30.01.2013 14:40, schrieb Benny Halevy: On Wed, Jan 30, 2013 at 3:00 PM, walter harms wha...@bfs.de wrote: Am 30.01.2013 10:51, schrieb Benny Halevy: On Wed, Jan 30, 2013 at 10:57 AM, walter harms wha...@bfs.de wrote: Am 30.01.2013 09:27, schrieb Dan Carpenter: On Wed, Jan 30, 2013

[PATCH] scsi: storvsc: avoid usage of WRITE_SAME

2013-01-30 Thread Olaf Hering
Set scsi_device-no_write_same because the host does not support it. Also blacklist WRITE_SAME to avoid (and log) accident usage. If the guest uses the ext4 filesystem, storvsc hangs while it prints these messages in an endless loop: ... [ 161.459523] hv_storvsc vmbus_0_1: cmd 0x41 scsi status

Re: [PATCH v8 4/4] sd: change to auto suspend mode

2013-01-30 Thread Alan Stern
On Wed, 30 Jan 2013, Aaron Lu wrote: From: Lin Ming ming.m@intel.com Uses block layer runtime pm helper functions in scsi_runtime_suspend/resume for devices that take advantage of it. Remove scsi_autopm_* from sd open/release path and check_events path. Signed-off-by: Lin Ming

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Boaz Harrosh
On 01/30/2013 04:34 PM, walter harms wrote: I start to see the complexity of the situation. Would you mind to add the comment it can be anything. UTF-8 is more likely but not guaranteed either ? For now using a pascal-string seems the best solution but it should be warned that

Re: [PATCH v8 2/4] block: add runtime pm helpers

2013-01-30 Thread Alan Stern
On Wed, 30 Jan 2013, Aaron Lu wrote: From: Lin Ming ming.m@intel.com Add runtime pm helper functions: void blk_pm_runtime_init(struct request_queue *q, struct device *dev) - Initialization function for drivers to call. int blk_pre_runtime_suspend(struct request_queue *q) - If

Re: [patch] [SCSI] libosd: check for kzalloc() failure

2013-01-30 Thread Boaz Harrosh
On 01/30/2013 09:06 AM, Dan Carpenter wrote: There wasn't any error handling for this kzalloc(). ACK-by: Boaz Harrosh bharr...@panasas.com James please queue for inclusion Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Thanks Dan diff --git a/drivers/scsi/osd/osd_initiator.c

RE: storvsc loops with No Sense messages

2013-01-30 Thread KY Srinivasan
-Original Message- From: Olaf Hering [mailto:o...@aepfle.de] Sent: Wednesday, January 30, 2013 5:00 AM To: KY Srinivasan Cc: linux-scsi@vger.kernel.org Subject: Re: storvsc loops with No Sense messages On Tue, Jan 29, Olaf Hering wrote: On Tue, Jan 29, KY Srinivasan wrote:

RE: storvsc loops with No Sense messages

2013-01-30 Thread KY Srinivasan
-Original Message- From: Olaf Hering [mailto:o...@aepfle.de] Sent: Wednesday, January 30, 2013 8:35 AM To: KY Srinivasan Cc: linux-scsi@vger.kernel.org Subject: Re: storvsc loops with No Sense messages On Wed, Jan 30, Olaf Hering wrote: Is there a way to not use WRITE_SAME

Re: [PATCH 1/6] qla2xxx: Determine the number of outstanding commands based on available resources.

2013-01-30 Thread Chad Dupuis
FYI, the fix the smatch warning: + drivers/scsi/qla2xxx/qla_os.c:364 qla2x00_free_req_que() info: + redundant null check on req-outstanding_cmds calling kfree() has been merged with this patch. On Wed, 30 Jan 2013, Saurav Kashyap wrote: From: Chad Dupuis chad.dup...@qlogic.com Base the

Re: [PATCH v8 2/4] block: add runtime pm helpers

2013-01-30 Thread Aaron Lu
On Wed, Jan 30, 2013 at 10:54:53AM -0500, Alan Stern wrote: On Wed, 30 Jan 2013, Aaron Lu wrote: From: Lin Ming ming.m@intel.com Add runtime pm helper functions: void blk_pm_runtime_init(struct request_queue *q, struct device *dev) - Initialization function for drivers to

Re: [PATCH v8 4/4] sd: change to auto suspend mode

2013-01-30 Thread Aaron Lu
On Wed, Jan 30, 2013 at 10:38:26AM -0500, Alan Stern wrote: On Wed, 30 Jan 2013, Aaron Lu wrote: From: Lin Ming ming.m@intel.com Uses block layer runtime pm helper functions in scsi_runtime_suspend/resume for devices that take advantage of it. Remove scsi_autopm_* from sd

[PATCH 0/1] Fix oops while resetting an ipr adapter

2013-01-30 Thread wenxiong
When hotplug removing an adapter, we've seen the issues with scsi_unblock_requests running after the adapter's memory has been freed. This patch fixes the oops while resetting an ipr adapter. Thanks! Wendy -- -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of

[PATCH 1/1] ipr: Fix oops while resetting an ipr adapter

2013-01-30 Thread wenxiong
From: Brian King brk...@linux.vnet.ibm.com When resetting an ipr adapter, we use scsi_block_requests to block any new commands from scsi core, and then unblock after the reset. When hotplug removing an adapter, we shut it down and go through this same code, but we've seen issues with