[PATCH 1/8] qla4xxx: Take E-port out of reset before disabling pause frames

2013-03-07 Thread vikas . chaudhary
From: Manish Dusane manish.dus...@qlogic.com Problem Description: Disabling pause frames might cause hardware wedging needing a power cycle. This might happen if the Eport is not initialized and is in reset. Solution: Before disabling pause frames ensure that eport is out of reset.

[PATCH 2/8] qla4xxx: Boot from SAN fix for ISP83XX

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Issue: ISP83XX check is missing in function get_fw_boot_info() because of this qla4xxx will not export boot target to sysfs and iscsistart cannot issue login to boot target. Fix: Added check for ISP83XX in function get_fw_boot_info()

[PATCH 4/8] qla4xxx: Fix double reset in case of firmware hung for ISP83XX

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com In case of firmware hung we need to call mailbox_premature_completion to complete any pending mbox command as firmware is not alive. Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_os.c | 18

[PATCH 7/8] qla4xxx: Fixed request queue count manipulation on response path

2013-03-07 Thread vikas . chaudhary
From: Tej Parkash tej.park...@qlogic.com Issue: Request queue count holds the information about free space in request queue which has to be manipulated based on request in and out pointer. But in driver response path, this count was incremented unconditionally, which could move req_in pointer

[PATCH 8/8] qla4xxx: Update driver version to 5.03.00-k5

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index

[PATCH 6/8] qla4xxx: Fix debug level to avoid floods of same message

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Move Incorrect function ID print message in case INTX interrupt from DEBUG2 to DEBUG7. This will avoid floods of this message if DEBUG2 is enabled. Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_dbg.h | 7

[PATCH 0/8] qla4xxx: Updates for scsi misc branch

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. Manish Dusane (1): qla4xxx: Take E-port out of reset before disabling pause frames Tej Parkash (1): qla4xxx: Fixed request queue

[PATCH 5/8] qla4xxx: Pass correct LUN address to firmware in case of lun_reset

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Use function int_to_scsilun() in qla4xxx_reset_lun() to convert integer value comming from scsi_transport to scsi LUN address format. Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_mbx.c | 9 - 1

Re: [PATCH] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-03-07 Thread Jan Vesely
Hi Jens, I have added you to cc, I'm not sure who to bug to get this patch merged. thanks, Jan Vesely On Thu 21 Feb 2013 09:30:26 CET, Jan Vesely wrote: The original behavior was to refuse all pages after the maximum number of segments has been reached. However, some drivers (like st) craft

Re: Kernel oops on st module cycling

2013-03-07 Thread Jean Delvare
Hi Joe, Thanks for your fast answer. Le vendredi 22 février 2013 à 10:30 -0500, Joe Lawrence a écrit : I remember finding an st module load/unload kref accounting bug a while ago: http://thread.gmane.org/gmane.linux.scsi/77539 I replied to the report with a hack-patch that grabbed an extra

[PATCH V3 0/4] Configure number of LUs reported by 'report-luns'

2013-03-07 Thread Rob Evers
This patch set retrieves the number of LUs available on a target using the report-luns command. The initial size of the report-luns command is 512 entries, as the previous default initial number was. If more LUs than 511 are present on a target, the report-luns is re-issued with the size

[PATCH V3 1/4] Encapsulate scsi_do_report_luns

2013-03-07 Thread Rob Evers
--- drivers/scsi/scsi_scan.c | 109 +-- 1 file changed, 59 insertions(+), 50 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 3e58b22..b2abf22 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@

[PATCH V3 2/4] Configure reported luns

2013-03-07 Thread Rob Evers
Change default value of max_report_luns to 16k-1. Use data returned from max report luns command to configure the number of logical units present if previous default of 511 isn't enough. --- drivers/scsi/scsi_scan.c | 89 1 file changed, 68

[PATCH V3 4/4] Use set/get_unaligned_be32 in report_luns

2013-03-07 Thread Rob Evers
--- drivers/scsi/scsi_scan.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 1d41730..31bda4b 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -34,6 +34,7 @@ #include

[PATCH V3 3/4] Change kmallocs in report_luns to use GFP_KERNEL

2013-03-07 Thread Rob Evers
--- drivers/scsi/scsi_scan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 671ff58..1d41730 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1419,7 +1419,7 @@ static int

Re: [PATCH V3 0/4] Configure number of LUs reported by 'report-luns'

2013-03-07 Thread Ewan Milne
On Thu, 2013-03-07 at 08:38 -0500, Rob Evers wrote: This patch set retrieves the number of LUs available on a target using the report-luns command. The initial size of the report-luns command is 512 entries, as the previous default initial number was. If more LUs than 511 are present on a

RE: [PATCH V3 1/4] Encapsulate scsi_do_report_luns

2013-03-07 Thread Elliott, Robert (Server Storage)
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Rob Evers Sent: Thursday, 07 March, 2013 7:39 AM To: linux-scsi@vger.kernel.org Cc: rev...@redhat.com; micha...@cs.wisc.edu; bvanass...@acm.org; emi...@redhat.com

[PATCH RESEND] qla2xxx: Update firmware link in Kconfig file.

2013-03-07 Thread Chad Dupuis
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Chad Dupuis chad.dup...@qlogic.com --- drivers/scsi/qla2xxx/Kconfig |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig index

Re: [PATCH V3 1/4] Encapsulate scsi_do_report_luns

2013-03-07 Thread Jeremy Linton
On 3/7/2013 9:47 AM, Elliott, Robert (Server Storage) wrote: +int scsi_do_report_luns(struct scsi_device *sdev, int length, + * We can get a UNIT ATTENTION, for example a power on/reset, so + * retry a few times (like sd.c does for TEST UNIT READY). + * Experience shows some

Re: [PATCH V3 1/4] Encapsulate scsi_do_report_luns

2013-03-07 Thread James Bottomley
On Thu, 2013-03-07 at 17:01 +, Elliott, Robert (Server Storage) wrote: Good point; INQUIRY, REPORT LUNS, REQUEST SENSE, and NOTIFY DATA TRANSFER DEVICE do not report unit attention conditions. Well, yes they do, at least on several devices I have here. Can I point out again that we can't

RE: [PATCH V3 1/4] Encapsulate scsi_do_report_luns

2013-03-07 Thread Elliott, Robert (Server Storage)
So far the T10 Base feature set proposal has not been restating requirements already required by the core standards - it's just upgrading mays and shoulds to shalls. Should we also include a list of shall rules like this that have had known violations in the past? -Original Message-

Re: [PATCH V3 1/4] Encapsulate scsi_do_report_luns

2013-03-07 Thread Jeremy Linton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 3/7/2013 11:30 AM, James Bottomley wrote: This also means we can't go through the linux SCSI subsystem changing behaviour based on what SAM says the behaviour should be. Most of what the SCSI subsystem does is an accumulation based on years

Re: [PATCH V3 1/4] Encapsulate scsi_do_report_luns

2013-03-07 Thread James Bottomley
On Thu, 2013-03-07 at 17:38 +, Elliott, Robert (Server Storage) wrote: So far the T10 Base feature set proposal has not been restating requirements already required by the core standards - it's just upgrading mays and shoulds to shalls. Should we also include a list of shall rules like

Re: [PATCH v1] lpfc 8.3.37: Remove redundant NULL check before kfree

2013-03-07 Thread James Smart
I don't disagree.My intent would be it is all one way - with my leaning toward being explicit. Unfortunately, it's a low priority task. -- james s On 3/6/2013 6:32 PM, Elliott, Robert (Server Storage) wrote: If the other approach is taken, then not all kfree() calls are protected by a

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2013-03-07 Thread Mike Christie
Sorry for the late reply. On 12/11/2012 02:23 AM, Hannes Reinecke wrote: @@ -793,7 +793,8 @@ struct scsi_host_template bfad_im_scsi_host_template = { .queuecommand = bfad_im_queuecommand, .eh_abort_handler = bfad_im_abort_handler, .eh_device_reset_handler =

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2013-03-07 Thread Jeremy Linton
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 3/7/2013 1:19 PM, Mike Christie wrote: What happens for lpfc? It seems __fc_remote_port_delete ends up calling the fast io fail code right away and that sets FC_RPORT_FAST_FAIL_TIMEDOUT. We will then call lpfc_terminate_rport_io which only will

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2013-03-07 Thread Mike Christie
On 03/07/2013 02:20 PM, Mike Christie wrote: On 03/07/2013 02:13 PM, Jeremy Linton wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 3/7/2013 1:19 PM, Mike Christie wrote: What happens for lpfc? It seems __fc_remote_port_delete ends up calling the fast io fail code right away and that

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2013-03-07 Thread Jeremy Linton
On 3/7/2013 2:20 PM, Mike Christie wrote: On 03/07/2013 02:13 PM, Jeremy Linton wrote: For lpfc, you never get to the code. Or rather when I was testing it, I couldn't find any way to propagate an error beyond the initial lpfc_reset_flush_io_context() call in lpfc_device_reset_handler().

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2013-03-07 Thread Douglas Gilbert
On 13-03-07 03:13 PM, Jeremy Linton wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 3/7/2013 1:19 PM, Mike Christie wrote: What happens for lpfc? It seems __fc_remote_port_delete ends up calling the fast io fail code right away and that sets FC_RPORT_FAST_FAIL_TIMEDOUT. We will then

[RFC 00/11] Add support for iSCSI Extentions for RDMA (ISER) target

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Folks, This series is first RFC for iSCSI Extentions for RDMA (ISER) target support with existing iscsi-target TCP based socket code for a future v3.10 merge. This code is available in git here:

[RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Add basic struct iscsit_transport API template to allow iscsi-target for running with external transport modules using existing iscsi_target_core.h code. For all external modules, this calls try_module_get() and module_put() to obtain + release an

[RFC 02/11] iscsi-target: Initial traditional TCP conversion to iscsit_transport

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch performs the initial conversion of existing traditional iscsi to use iscsit_transport API callers. This includes: - iscsi-np cleanups for iscsit_transport_type - Add iscsi-np transport calls w/ -iscsit_setup_up() and -iscsit_free_np() -

[RFC 03/11] iscsi-target: Add iser-target parameter keys + setup during login

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds RDMAExtensions, InitiatorRecvDataSegmentLength and TargetRecvDataSegmentLength parameters keys necessary for iser-target login to occur. This includes setting the necessary parameters during login path code within

[RFC 04/11] iscsi-target: Add per transport iscsi_cmd alloc/free

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch converts struct iscsi_cmd memory allocation + free to use -iscsit_alloc_cmd() + -iscsit_free_cmd() iscsit_transport API caller, and export iscsit_allocate_cmd() + iscsit_free_cmd() symbols Also update iscsit_free_cmd() to include a final

[RFC 05/11] iscsi-target: Refactor RX PDU logic + export request PDU handling

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch refactors existing traditional iscsi RX side PDU handling to use iscsit_transport, and exports the necessary logic for external transport modules. This includes: - Refactor iscsit_handle_scsi_cmd() into PDU setup / processing - Add

[RFC 07/11] iscsi-target: Add iser network portal attribute

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a new network portal attribute for iser, that lives under existing iscsi-target configfs layout at: /sys/kernel/config/target/iscsi/$TARGETNAME/$TPGT/np/$PORTAL/iser When lio_target_np_store_iser() is enabled,

[RFC 06/11] iscsi-target: Refactor TX queue logic + export response PDU creation

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch refactors TX immediate + response queue handling to use the new iscsit_transport API callers, and exports the necessary traditional iscsi PDU response creation functions for iser-target to utilize. This includes: - Add

[RFC 09/11] iser-target: Add logic for verbs

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/isert_verbs.c | 476 drivers/infiniband/ulp/isert/isert_verbs.h |5 + 2 files changed, 481 insertions(+), 0 deletions(-) create

[RFC 08/11] iser-target: Add base + proto includes

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/isert_base.h | 123 drivers/infiniband/ulp/isert/isert_proto.h | 47 +++ 2 files changed, 170 insertions(+), 0

[RFC 10/11] iser-target: Add logic for core

2013-03-07 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/infiniband/ulp/isert/isert_core.c | 1720 + drivers/infiniband/ulp/isert/isert_core.h | 12 + 2 files changed, 1732 insertions(+), 0 deletions(-) create

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-07 Thread Roland Dreier
On Thu, Mar 7, 2013 at 5:45 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +EXPORT_SYMBOL(iscsit_get_transport); It's not clear to me why this needs to be exported. Who would use it outside the core iscsi target module? -- To unsubscribe from this list: send the line unsubscribe

Re: [RFC 01/11] iscsi-target: Add iscsit_transport API template

2013-03-07 Thread Nicholas A. Bellinger
On Thu, 2013-03-07 at 20:14 -0800, Roland Dreier wrote: On Thu, Mar 7, 2013 at 5:45 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +EXPORT_SYMBOL(iscsit_get_transport); It's not clear to me why this needs to be exported. Who would use it outside the core iscsi target module?