Re: [PATCH 08/15] be2iscsi: Fix displaying the FW Version from driver.

2013-03-23 Thread Mike Christie
I agree with Steffan's concerns below. Please fix or explain. On 03/13/2013 05:29 AM, Steffen Maier wrote: On 03/12/2013 05:39 AM, jayamoh...@gmail.com wrote: From: Jayamohan.Kallickal jayamohan.kallic...@emulex.com This patch fixes the display of proper FW Version from the driver.

Re: [PATCH 0/4] qla4xxx: Updates for scsi misc branch

2013-03-23 Thread Mike Christie
On 03/22/2013 06:08 AM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Please apply the following patches to the scsi tree at your earliest convenience. Nilesh Javali (1): qla4xxx: Skip retry of initialize_adapter only for ISP8XXX

Re: [PATCH 0/4] qla4xxx: Patches for iSCSI flash node mgmt support

2013-03-23 Thread Mike Christie
On 03/22/2013 06:41 AM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Following patches allows iscsiadm to manage iSCSI target information stored on adapter flash on per host basis and and perform various operations like add, delete, login,

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-23 Thread Paolo Bonzini
Il 20/03/2013 08:56, Wanlong Gao ha scritto: This one does not apply on top of virtio-next + patch 1-4 in this series. I'm very sorry. This fault is because I modified the 4/5 from /* if the affinity hint is set for virtqueues */ to /* If the affinity hint is set for virtqueues */ by

[PATCH V7 0/5] virtio-scsi multiqueue

2013-03-23 Thread Wanlong Gao
This series implements virtio-scsi queue steering, which gives performance improvements of up to 50% (measured both with QEMU and tcm_vhost backends). This version rebased on Rusty's virtio ring rework patches, which has already gone into virtio-next today. We hope this can go into virtio-next

[PATCH V7 4/5] virtio-scsi: introduce multiqueue support

2013-03-23 Thread Wanlong Gao
From: Paolo Bonzini pbonz...@redhat.com This patch adds queue steering to virtio-scsi. When a target is sent multiple requests, we always drive them to the same queue so that FIFO processing order is kept. However, if a target was idle, we can choose a queue arbitrarily. In this case the queue

[PATCH V7 1/5] virtio-scsi: redo allocation of target data

2013-03-23 Thread Wanlong Gao
virtio_scsi_target_state is now empty. We will find new uses for it in the next few patches, so this patch does not drop it completely. And as James suggested, we use entries target_alloc and target_destroy in the host template to allocate and destroy the virtio_scsi_target_state of each target,

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-23 Thread Wanlong Gao
On 03/23/2013 02:36 PM, Paolo Bonzini wrote: Il 20/03/2013 08:56, Wanlong Gao ha scritto: This one does not apply on top of virtio-next + patch 1-4 in this series. I'm very sorry. This fault is because I modified the 4/5 from /* if the affinity hint is set for virtqueues */ to /* If the

[PATCH V7 3/5] virtio-scsi: push vq lock/unlock into virtscsi_vq_done

2013-03-23 Thread Wanlong Gao
From: Paolo Bonzini pbonz...@redhat.com Avoid duplicated code in all of the callers. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 22

[PATCH V7 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-23 Thread Wanlong Gao
Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 29

[PATCH V7 2/5] virtio-scsi: pass struct virtio_scsi to virtqueue completion function

2013-03-23 Thread Wanlong Gao
From: Paolo Bonzini pbonz...@redhat.com This will be needed soon in order to retrieve the per-target struct. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Asias He as...@redhat.com ---

[GIT PULL] target fixes for v3.9-rc4

2013-03-23 Thread Nicholas A. Bellinger
Hi Linus! Here is the current set of target-pending/master fixes for v3.9-rc4. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master These are mostly minor fixes this time around. The iscsi-target CHAP big-endian bugfix and bump