PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
I'm not sure what is more ridiculous, whether the seven pings or the lack of review... Paolo Il 06/02/2013 16:15, Paolo Bonzini ha scritto: This series regards the whitelist that is used for the SG_IO ioctl. This whitelist has three problems: * the bitmap of allowed commands is designed

Re: [PATCH 0/5] scsi: Allow fast io fail without waiting through timeout

2013-05-22 Thread Ren Mingxin
Hi, James, On 05/20/2013 11:53 PM, James Smart wrote: Based on the discussion recently held at LSF 2013, we are reworking the error recovery path to address all the issues you are mentioning. That work contradicts these patches. So for now, these should be held off. Interesting. Can I have

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Tejun Heo
On Wed, May 22, 2013 at 08:35:54AM +0200, Paolo Bonzini wrote: I'm not sure what is more ridiculous, whether the seven pings or the lack of review... So, ummm, I don't know what Jens is thinking but at this point I'm basically waiting for someone else to pick it up as review to return ratio is

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 11:32, Tejun Heo ha scritto: On Wed, May 22, 2013 at 08:35:54AM +0200, Paolo Bonzini wrote: I'm not sure what is more ridiculous, whether the seven pings or the lack of review... So, ummm, I don't know what Jens is thinking but at this point I'm basically waiting for someone

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 12:02, Tejun Heo ha scritto: On Wed, May 22, 2013 at 11:53:30AM +0200, Paolo Bonzini wrote: Il 22/05/2013 11:32, Tejun Heo ha scritto: On Wed, May 22, 2013 at 08:35:54AM +0200, Paolo Bonzini wrote: I'm not sure what is more ridiculous, whether the seven pings or the lack of

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread James Bottomley
On Wed, 2013-05-22 at 12:23 +0200, Paolo Bonzini wrote: Il 22/05/2013 12:02, Tejun Heo ha scritto: On Wed, May 22, 2013 at 11:53:30AM +0200, Paolo Bonzini wrote: Il 22/05/2013 11:32, Tejun Heo ha scritto: On Wed, May 22, 2013 at 08:35:54AM +0200, Paolo Bonzini wrote: I'm not sure what is

[PATCH 00/12] megaraid_sas : Updates for scsi for-next

2013-05-22 Thread Sumit.Saxena
MegaRaid driver changes. Please consider this patch set for next kernel release. Signed-off-by: Sumit Saxena sumit.sax...@lsi.com Signed-off-by: Kashyap Desai kashyap.de...@lsi.com --- [PATCH 00/12] megaraid_sas : Updates for scsi for-next [PATCH 01/12] megaraid_sas : Return DID_ERROR for SCSI

[PATCH 01/12] megaraid_sas : Return DID_ERROR for SCSI IO, when controller is in critical h/w error

2013-05-22 Thread Sumit.Saxena
Do not return SCSI_MLQUEUE_HOST_BUSY, but send DID_ERROR to SCSI mid-layer, if adapter is in critical error state. SCSI_MLQUEUE_HOST_BUSY will keep same SCSI command in loop and it is not a right return value, if controller is hardware critical error. Signed-off-by: Sumit Saxena

[PATCH 02/12] megaraid_sas : Fix the interrupt mask for Gen2 controller

2013-05-22 Thread Sumit.Saxena
Fix the interrupt mask for Gen2 controller. Signed-off-by: Sumit Saxena sumit.sax...@lsi.com Signed-off-by: Kashyap Desai kashyap.de...@lsi.com --- diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 758ea2e..c79daf5 100644 ---

[PATCH 04/12] megaraid_sas : Free event detail memory without device ID check

2013-05-22 Thread Sumit.Saxena
Free event detail memory from more common place, instead of doing it for limited device types. Signed-off-by: Sumit Saxena sumit.sax...@lsi.com Signed-off-by: Adam Radford aradf...@gmail.com --- diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH 05/12] megaraid_sas : Set IO request timeout value provided by OS timeout for Tape devices

2013-05-22 Thread Sumit.Saxena
Set IO request timeout value provided by OS timeout for Tape devices. Signed-off-by: Sumit Saxena sumit.sax...@lsi.com Signed-off-by: Kashyap Desai kashyap.de...@lsi.com --- diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index

[PATCH 06/12] megaraid_sas : Add support for MegaRAID Fury (device ID-0x005f) 12Gb/s controllers

2013-05-22 Thread Sumit.Saxena
Add support for MegaRAID Fury (device ID-0x005f) 12Gb/s controllers. Signed-off-by: Sumit Saxena sumit.sax...@lsi.com Signed-off-by: Kashyap Desai kashyap.de...@lsi.com --- diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 408d254..64cc4d4 100644 ---

[PATCH 07/12] megaraid_sas : Add support to display Customer branding details in syslog

2013-05-22 Thread Sumit.Saxena
Add support to display Customer branding details in syslog. Signed-off-by: Sumit Saxena sumit.sax...@lsi.com Signed-off-by: Kashyap Desai kashyap.de...@lsi.com --- diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 64cc4d4..474f79f 100644 ---

[PATCH 09/12] megaraid_sas : Add support for Extended MSI-x vectors for 12Gb/s controller

2013-05-22 Thread Sumit.Saxena
Add support for Extended MSI-x vectors for Invader and Fury(12Gb/s HBA). This Driver will use more than 8 MSI-x support provided by Invader/Fury max upto 128 MSI-x. Signed-off-by: Sumit Saxena sumit.sax...@lsi.com Signed-off-by: Kashyap Desai kashyap.de...@lsi.com --- diff --git

[PATCH 10/12] megaraid_sas : Add support for Uneven Span PRL11

2013-05-22 Thread Sumit.Saxena
Add support for Uneven Span PRL11. MegaRAID older Firmware does not support uneven span configuration for PRL11. E.g User wants to create 34 Driver PRL11 config, it was not possible using old firmware, since it was not supported configuration in old firmware Old Firmware expect even number of

[PATCH 11/12] megaraid_sas : Add support to differentiate between iMR vs MR Firmware

2013-05-22 Thread Sumit.Saxena
Add support to differentiate between iMR(no external memory) and MR(with external memory) controllers. Signed-off-by: Sumit Saxena sumit.sax...@lsi.com Signed-off-by: Kashyap Desai kashyap.de...@lsi.com --- diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h

[PATCH 12/12] megaraid_sas : Changelog and driver version update

2013-05-22 Thread Sumit.Saxena
This patch updates the megaraid_sas driver version and updates Documentation/scsi/ChangeLog.megaraid_sas. Signed-off-by: Sumit Saxena sumit.sax...@lsi.com Signed-off-by: Kashyap Desai kashyap.de...@lsi.com --- diff --git a/Documentation/scsi/ChangeLog.megaraid_sas

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Tejun Heo
On Wed, May 22, 2013 at 12:23:56PM +0200, Paolo Bonzini wrote: Yes, because I have no idea what _your_ point is. Isolate the actual fixes and just submit them as it seems impossible for you to provide proper justifications for the things you want to add. -- tejun -- To unsubscribe from this

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
OK, let me try. I did draw straws with Jens at LSF to see who would look at this and he lost, but the complexity of the patch set probably makes it hard for him to find the time. Thanks. The first problem, which Tejun already pointed out is that you've combined a bug fix with a large

Re: SCSI testing/USB devices are amazing

2013-05-22 Thread Bart Van Assche
On 04/28/13 18:19, ronnie sahlberg wrote: Hi List, Interested in SCSI tests? I have a reasonable SCSI (mainly SBC) testsuite at https://github.com/sahlberg/libiscsi while I am mainly interested in testing of iSCSI targets, most of my tests so far are for the SCSI protocol so they work quite

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 15:41, Tejun Heo ha scritto: On Wed, May 22, 2013 at 12:23:56PM +0200, Paolo Bonzini wrote: Yes, because I have no idea what _your_ point is. Isolate the actual fixes and just submit them as it seems impossible for you to provide proper justifications for the things you want to

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Tejun Heo
On Wed, May 22, 2013 at 04:12:04PM +0200, Paolo Bonzini wrote: Il 22/05/2013 15:41, Tejun Heo ha scritto: On Wed, May 22, 2013 at 12:23:56PM +0200, Paolo Bonzini wrote: Yes, because I have no idea what _your_ point is. Isolate the actual fixes and just submit them as it seems impossible

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 16:30, Tejun Heo ha scritto: * Separate fixes from additions. Transform existing code so that the visible behavior doesn't change but the required fix can be implemented on top. Explicitly note what's going on in the commit messages. Been there, done that. Have you read

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Theodore Ts'o
Paolo, I'll probably regret butting my head into this, but it might be helpful if you talk about your particular use case which is driving your desire to make these changes. For example, what do you think the SG_IO whitelist _should_ be used, and why should it be made more general? What's the

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 17:03, Theodore Ts'o ha scritto: Paolo, I'll probably regret butting my head into this, but it might be helpful if you talk about your particular use case which is driving your desire to make these changes. Ted, thank you very much. I understand that my discussion with Tejun

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 16:07, Paolo Bonzini ha scritto: Finally, the patch for the feature I think you actually want, which is 13/14, could have been implemented fairly simply as a single patch and doesn't have to be part of this series. It was, and it was ignored. I sent it together because of the

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Martin K. Petersen
Paolo == Paolo Bonzini pbonz...@redhat.com writes: Paolo First of all, I'll note that SG_IO and block-device-specific Paolo ioctls both have their place. My usecase for SG_IO is Paolo virtualization, where I need to pass information from the LUN to Paolo the virtual machine with as much

Re: SCSI testing/USB devices are amazing

2013-05-22 Thread ronnie sahlberg
Hi Bart, Thanks for trying the test tool. You have a more detailed description furhter down at the definition of READ10. Look there instead. Looking at sbc3r35b.pdf 5.13 for READ16 it refers to READ10 for the bits in the CDB. Looking at 5.11 READ10 : Table 59 RDPROTECT field we have all

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 18:32, Martin K. Petersen ha scritto: Paolo == Paolo Bonzini pbonz...@redhat.com writes: Paolo First of all, I'll note that SG_IO and block-device-specific Paolo ioctls both have their place. My usecase for SG_IO is Paolo virtualization, where I need to pass information from

Re: [PATCH 0/5] scsi: Allow fast io fail without waiting through timeout

2013-05-22 Thread James Smart
yes - that was the session. Granted the posted notes were rather terse. More of the ideas were presented in this recent email thread: http://marc.info/?l=linux-scsim=136819142000596w=2 In general - we're going to create a LLD library for error handling, using paradigms in libsas, that: - no

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Theodore Ts'o
On Wed, May 22, 2013 at 07:00:14PM +0200, Paolo Bonzini wrote: You have hardware providers selling cloud services that want to run their own custom backup services from within a VM, which entails having vendor-specific commands run from within a VM. Or you have people that run clusters that

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Tejun Heo
On Wed, May 22, 2013 at 05:00:52PM +0200, Paolo Bonzini wrote: Il 22/05/2013 16:30, Tejun Heo ha scritto: * Separate fixes from additions. Transform existing code so that the visible behavior doesn't change but the required fix can be implemented on top. Explicitly note what's going

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 20:11, Theodore Ts'o ha scritto: On Wed, May 22, 2013 at 07:00:14PM +0200, Paolo Bonzini wrote: You have hardware providers selling cloud services that want to run their own custom backup services from within a VM, which entails having vendor-specific commands run from within a

[PATCH 1/2] SCSI: nsp32: replace large udelay by mdelay

2013-05-22 Thread Marc Dietrich
ARM has a maximum of 2000 usec delay. Use mdelay for larger delays. This affects distro kernels mostly. Cc: GOTO Masanori go...@debian.or.jp Cc: YOKOTA Hiroshi yok...@netlab.is.tsukuba.ac.jp Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Cc:

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Theodore Ts'o
On Wed, May 22, 2013 at 09:37:54PM +0200, Paolo Bonzini wrote: If it's not theoretical, how does the cloud service control who has access to the CD burner, and how are the disks loaded into the CD burner? CD burning would be used in a VM that runs on your local workstation, so the VM

Re: [PATCH 1/2] SCSI: nsp32: replace large udelay by mdelay

2013-05-22 Thread Marc Dietrich
Looks like Arndt already send a fix for this. Sorry for the noise. Am Mittwoch, 22. Mai 2013, 21:48:41 schrieb Marc Dietrich: ARM has a maximum of 2000 usec delay. Use mdelay for larger delays. This affects distro kernels mostly. Cc: GOTO Masanori go...@debian.or.jp Cc: YOKOTA Hiroshi

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 22:19, Theodore Ts'o ha scritto: On Wed, May 22, 2013 at 09:37:54PM +0200, Paolo Bonzini wrote: If it's not theoretical, how does the cloud service control who has access to the CD burner, and how are the disks loaded into the CD burner? CD burning would be used in a VM that

Re: [GIT PULL] target fixes for v3.10-rc2

2013-05-22 Thread Or Gerlitz
On Thu, May 16, 2013 at 7:53 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: Yes, that's the patch included in the PULL request here: http://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/commit/?h=queueid=52c07423a819091b0fe9abbf26977098b996f85b Cool! Btw, It still needs

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Tejun Heo
Hey, On Wed, May 22, 2013 at 05:53:34PM +0200, Paolo Bonzini wrote: I do listen to review feedback, but I also expect the other side to listen to me, ask me what is not clear, and possess some knowledge of the domain that he's reviewing patches for. All of which, quite frankly, I have not

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 22:39, Tejun Heo ha scritto: Hey, On Wed, May 22, 2013 at 05:53:34PM +0200, Paolo Bonzini wrote: I do listen to review feedback, but I also expect the other side to listen to me, ask me what is not clear, and possess some knowledge of the domain that he's reviewing patches

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 21:30, Tejun Heo ha scritto: The thing is that the behavior change is now implemented in an inactive form by #2 and then flipped on by #3. #2 both change the format and the content of the table. This should have been like the following. #2: Convert to the new table for mat

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Tejun Heo
On Wed, May 22, 2013 at 11:18:05PM +0200, Paolo Bonzini wrote: Ok, so I can split it in 10 patches one per command, but at some point I wonder if it is overkill. For example, for disks: - WRITE AND VERIFY(16) is needed to support 2TB disks, and the corresponding 12-byte CDB is whitelisted

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Tejun Heo
On Thu, May 23, 2013 at 07:17:37AM +0900, Tejun Heo wrote: No, it doesn't. You can use SCM_RIGHTS, and pass a file descriptor for the device node to an unprivileged program. You can choose the users/groups that are allowed to access the device. In either case, the privileged action is