Re: [PATCH V5] Save command pool address of Scsi_Host

2014-08-07 Thread Christoph Hellwig
Can I get another review for this one so I can queue it up for 3.17? (or v4 if you have a strong preference for it..) -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-07 Thread Christoph Hellwig
On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: I doubt either of them forces users to hack up flags for these cases. Why was this change needed in the first place? There's no explanation in the patch itself. Which chance? The one to not support SG_FLAG_LUN_INHIBIT? At

Re: [PATCH] bnx2fc: Set no_async_abort to 1 in SCSI host template.

2014-08-07 Thread Christoph Hellwig
On Wed, Aug 06, 2014 at 04:01:12PM -0400, Chad Dupuis wrote: This was on RHEL 7. Should we retry the test case with the latest mainline? Yes. Please always test your patches against latest mainline. If that is for some reason not possible please at least very prominently mention that the

Re: [PATCH 0/3] scsi_debug: review fixes for scsi-mq changes

2014-08-07 Thread Christoph Hellwig
Thanks Doug, all the patches look good to me. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1.3 1/18] arcmsr: Revised interrupt service routine relate function to fix bug

2014-08-07 Thread Tomas Henzl
On 08/01/2014 10:28 AM, Ching Huang wrote: This patch rewrite the interrupt service routine relate function to fix command timeout when controller has very heavy loading. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h

Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

2014-08-07 Thread Tomas Henzl
On 08/04/2014 06:00 AM, Ching Huang wrote: On Fri, 2014-08-01 at 05:35 -0700, Christoph Hellwig wrote: @@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru arcmsr_handle_virtual_command(acb, cmd); return 0; } - if (atomic_read(acb-ccboutstandingcount)

Re: [PATCH] scsi: Check if WSR already defined

2014-08-07 Thread Hannes Reinecke
On 08/07/2014 07:38 AM, Nick Krause wrote: On xtensa arch there is this warning drivers/scsi/sym53c8xx_2/sym_defs.h:109:0: warning: WSR redefined [enabled by default] arch/xtensa/include/asm/processor.h:188:0: note: this is the location of the previous definition I can remove WSR since it is

Re: [PATCH v1.3 3/18] arcmsr: Add code to support system hibernation

2014-08-07 Thread Tomas Henzl
On 08/01/2014 10:36 AM, Ching Huang wrote: This patch adds code to support system hibernation. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c2014-08-01

Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-07 Thread Alan Stern
On Wed, 6 Aug 2014, Christoph Hellwig wrote: On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: I doubt either of them forces users to hack up flags for these cases. Why was this change needed in the first place? There's no explanation in the patch itself. Which chance?

[Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=80711 --- Comment #8 from Alan Stern st...@rowland.harvard.edu --- On Wed, 6 Aug 2014, Christoph Hellwig wrote: On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: I doubt either of them forces users to hack up flags for these cases.

[Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN

2014-08-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=80711 --- Comment #9 from Tiziano Bacocco tiziano.baco...@gmail.com --- (In reply to Alan Stern from comment #8) On Wed, 6 Aug 2014, Christoph Hellwig wrote: On Wed, Aug 06, 2014 at 04:02:22PM -0400, Alan Stern wrote: I doubt either of them

[Bug 81861] New: mvsas.ko v0.8.16 error messages and kernel crashes attaching 4 SATA drives to specific HP SAS expander ports

2014-08-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 Bug ID: 81861 Summary: mvsas.ko v0.8.16 error messages and kernel crashes attaching 4 SATA drives to specific HP SAS expander ports Product: SCSI Drivers Version:

[Bug 81861] mvsas.ko v0.8.16 error messages and kernel crashes attaching 4 SATA drives to specific HP SAS expander ports

2014-08-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 linux-...@crashplan.pro changed: What|Removed |Added Kernel Version|3.16.0-031600rc6|3.16.0-031600rc6.x86_64 -- You

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-08-07 Thread Dan Williams
[ adding yuxia...@marvell.com ] On Tue, Jun 3, 2014 at 6:41 PM, Dan Williams dan.j.willi...@intel.com wrote: Hi, some notes below: On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu yxlr...@gmail.com wrote: Add support for SATA port softreset and port multiplier error handling. Some more

[PATCH 1/5] be2iscsi: Fix the sparse warning introduced in previous submission

2014-08-07 Thread Jay Kallickal
From: Jayamohan Kallickal jayamohan.kallic...@emulex.com commit 73af08e11c6638e2abd6b1fa13cdab58c2bbdbf8 Author: Jayamohan Kallickal jayamohan.kallic...@emulex.com Date: Mon May 5 21:41:26 2014 -0400 be2iscsi: Fix interrupt Coalescing mechanism. Signed-off-by: John Soni Jose

[PATCH 2/5] be2iscsi: Fix the copyright year

2014-08-07 Thread Jay Kallickal
From: Jayamohan Kallickal jayamohan.kallic...@emulex.com Change the copyright year to 2014 Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be.h | 2 +- drivers/scsi/be2iscsi/be_cmds.c | 2 +-

[PATCH 0/5] be2iscsi: Update to 10.4.74.0

2014-08-07 Thread Jay Kallickal
From: Jayamohan Kallickal jayamohan.kallic...@emulex.com This patchset updates be2iscsi driver to 10.4.74.0 These patches are based on for-next branch of scsi.git. 0001 - Fix the sparse warning 0002 - Update the copyright year 0003 - Fix updating the boot enteries in sysfs 0004 - Fix

[PATCH 5/5] be2iscsi: Bump the driver version

2014-08-07 Thread Jay Kallickal
From: Jayamohan Kallickal jayamohan.kallic...@emulex.com Bump the driver version Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 4/5] be2iscsi: Fix processing CQE before connection resources are freed

2014-08-07 Thread Jay Kallickal
From: Jayamohan Kallickal jayamohan.kallic...@emulex.com Driver should process the completion queue entries before a connection resources are freed. While running mixed traffic due to latency, driver processes the CQE after the connection resources are freed. This fix processes all the

[PATCH 3/5] be2iscsi: Fix updating the boot enteries in sysfs

2014-08-07 Thread Jay Kallickal
From: Jayamohan Kallickal jayamohan.kallic...@emulex.com During port async event driver should check if there is any boot target configured on the adapter. Update sysfs enteries with the boot target parameters. Signed-off-by: Minh Tran minhduc.t...@emulex.com Signed-off-by: John Soni Jose