Re: [PATCH for v3.19, v2] Avoid that sd_shutdown() triggers a kernel warning

2015-01-20 Thread Alan Stern
On Wed, 14 Jan 2015, Christoph Hellwig wrote: On Mon, Jan 12, 2015 at 11:29:15AM -0500, Alan Stern wrote: This seems like a good idea and the obvious (once it has been pointed out!) approach. Perhaps not directly related to the issue at hand is this question: In scsi_rescan_device()

Re: [PATCH v4 00/11] scsi: fix module reference mismatch for scsi host

2015-01-20 Thread Akinobu Mita
2015-01-19 23:22 GMT+09:00 Tejun Heo t...@kernel.org: On Mon, Jan 19, 2015 at 12:05:58AM +0900, Akinobu Mita wrote: While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through .module field of struct scsi_host_template.

Re: module: fix module_refcount() return when running in a module exit routine

2015-01-20 Thread James Bottomley
On Tue, 2015-01-20 at 11:15 +1030, Rusty Russell wrote: James Bottomley james.bottom...@hansenpartnership.com writes: On Mon, 2015-01-19 at 16:21 +1030, Rusty Russell wrote: Masami Hiramatsu masami.hiramatsu...@hitachi.com writes: (2015/01/19 1:55), James Bottomley wrote: From: James

Re: [PATCH v4 00/11] scsi: fix module reference mismatch for scsi host

2015-01-20 Thread Tejun Heo
Hello, Akinobu. On Tue, Jan 20, 2015 at 11:57:37PM +0900, Akinobu Mita wrote: The reason I didn't move sht from the core driver to the LLDDs for fixing ufs and ums-* in the first place is to avoid exporting many symbols for callbacks in sht. But I realized that we can do it without that many

Re: [PATCH v4 00/11] scsi: fix module reference mismatch for scsi host

2015-01-20 Thread Alan Stern
On Tue, 20 Jan 2015, Akinobu Mita wrote: 2015-01-19 23:22 GMT+09:00 Tejun Heo t...@kernel.org: On Mon, Jan 19, 2015 at 12:05:58AM +0900, Akinobu Mita wrote: While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through

tcmu-runner (target userspace passthrough daemon) development

2015-01-20 Thread Andy Grover
Hi all, tcmu-runner is a userspace daemon that simplifies the configuration and processing of SCSI commands from LIO to userspace handlers, via the new TCMU userspace passthrough backstore. https://github.com/agrover/tcmu-runner As a proof-of-concept, I've implemented a Gluster backend

Re: [PATCH] scsi: qla2xxx: print port name via %*phC

2015-01-20 Thread Nicholas A. Bellinger
On Thu, 2015-01-15 at 13:28 +0200, Andy Shevchenko wrote: Instead of pushing each byte via stack let's use custom specifier which allows to print small buffers as a hex string. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 +---

Re: tcmu-runner (target userspace passthrough daemon) development

2015-01-20 Thread Nicholas A. Bellinger
On Tue, 2015-01-20 at 15:27 -0800, Andy Grover wrote: Hi all, tcmu-runner is a userspace daemon that simplifies the configuration and processing of SCSI commands from LIO to userspace handlers, via the new TCMU userspace passthrough backstore. https://github.com/agrover/tcmu-runner

[PATCH] block: Add discard flag to blkdev_issue_zeroout() function

2015-01-20 Thread Martin K. Petersen
blkdev_issue_discard() will zero a given block range. This is done by way of explicit writing, thus provisioning or allocating the blocks on disk. There are use cases where the desired behavior is to zero the blocks but unprovision them if possible. The blocks must deterministically contain

[PATCH 3/3] scsi: Remove VPD quirk for Seagate drives

2015-01-20 Thread Martin K. Petersen
Now that we sanity check the optimal I/O size reported by the device we no longer need to blacklist the VPD pages on certain Seagate drives. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com Cc: sta...@vger.kernel.org --- drivers/scsi/scsi_devinfo.c | 1 - 1 file changed, 1

Re: [PATCH] iscsi-target: use '%*ph' specifier to dump hex buffer

2015-01-20 Thread Nicholas A. Bellinger
On Thu, 2015-01-15 at 13:40 +0200, Andy Shevchenko wrote: Instead of pushing each byte via stack the %*ph specifier allows to supply just a pointer and length of the buffer. The patch converts code to use the specifier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com ---

[PATCH 2/3] sd: Sanity check the optimal I/O size

2015-01-20 Thread Martin K. Petersen
We have come across a couple of devices that report crackpot values in the optimal I/O size in the Block Limits VPD page. Since this is a 32-bit entity that gets multiplied by the logical block size we can get disproportionately large values reported to the block layer. Cap io_opt at 256 MB.