Re: [patch] vhost/scsi: potential memory corruption

On Thu, 2015-02-05 at 10:37 +0300, Dan Carpenter wrote: This code in vhost_scsi_make_tpg() is confusing because we limit tpgt to UINT_MAX but the data type of tpg-tport_tpgt and that is a u16. I looked at the context and it turns out that in vhost_scsi_set_endpoint(), tpg-tport_tpgt is used

[PATCH 4/4] SCSI-QLA4...: Less function calls in qla4xxx_sysfs_ddb_logout() after error detection

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 22:44:23 +0100 The vfree() function was called in three cases by the qla4xxx_sysfs_ddb_logout() function during error handling even if the passed variables flash_tddb and tmp_tddb contained still a null pointer. * This

[PATCH 1/4] SCSI-QLA4...: Deletion of unnecessary checks before three function calls

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 20:38:23 +0100 The following functions perform also input parameter validation. * iscsi_boot_destroy_kset * kfree * vfree Thus the test around their calls is not needed. This issue was detected by using the Coccinelle

[PATCH 01/36] aha1542: Stop using scsi_module.c

Convert aha1542 to use scsi_add_host instead of scsi_module.c Use pnp_driver and isa_driver to manage cards. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 300 +++- drivers/scsi/aha1542.h |2 +- 2 files

[PATCH 09/36] aha1542: Use BIT() macro

Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.h | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/aha1542.h b/drivers/scsi/aha1542.h index f0b862b..1333a23 100644 --- a/drivers/scsi/aha1542.h

[PATCH 02/36] aha1542: remove dead code

Remove dead code. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 243 +--- drivers/scsi/aha1542.h |6 -- 2 files changed, 1 insertion(+), 248 deletions(-) diff --git a/drivers/scsi/aha1542.c

[PATCH 07/36] aha1542: Reorder functions to remove forward declarations

Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 51 +++- drivers/scsi/aha1542.h | 12 2 files changed, 24 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c

[PATCH 06/36] aha1542: Use u8 instead of unchar

Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 50 drivers/scsi/aha1542.h | 42 2 files changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers/scsi/aha1542.c

[PATCH 0/4] SCSI-QLA4...: Deletion of some unnecessary checks

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 23:03:41 +0100 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (4): Deletion of unnecessary checks before three function calls Less function

[PATCH 03/36] aha1542: Remove SCSI_BUF_PA, SCSI_SG_PA, AHA1542_SCATTER and AHA1542_CMDLUN

Remove SCSI_BUF_PA, SCSI_SG_PA, AHA1542_SCATTER and AHA1542_CMDLUN macros Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 23 ++- drivers/scsi/aha1542.h |2 -- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git

[PATCH 04/36] aha1542: Remove HOSTDATA macro

Remove HOSTDATA macro and use shost_priv instead Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 114 +++- 1 file changed, 55 insertions(+), 59 deletions(-) diff --git a/drivers/scsi/aha1542.c

[PATCH 08/36] aha1542: remove empty aha1542_stat

Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index af1e8fa..ebc5476 100644 --- a/drivers/scsi/aha1542.c +++

[PATCH 05/36] aha1542: Convert aha1542_intr_reset to function

Convert aha1542_intr_reset macro to inline function Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index ebf54b5..2a6308f 100644 ---

[PATCH 0/36] aha1542: Various improvements

Hello, this patch series updates aha1542 driver to not use deprecated initialization, removes dead code, ugly macros and simplifies the code. No major CodingStyle fixes yet. Tested on AHA-1542B. aha1542.c | 1687 +++--- aha1542.h | 136

[PATCH] hpsa: correct compiler warnings introduced by hpsa-add-local-workqueue patch

Correct compiler warning introduced by hpsa-add-local-workqueue patch 6636e7f455b33b957c5ee016daa6de46148026ab hpsa: Use local workqueues instead of system workqueues Suggested-by: Kees Cook keesc...@chromium.org Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Webb Scales web...@hp.com

[PATCH 2/4] SCSI-QLA4...: Less function calls in qla4xxx_is_session_exists() after error detection

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 21:14:40 +0100 The vfree() function was called in two cases by the qla4xxx_is_session_exists() function during error handling even if the passed variables fw_tddb and tmp_tddb contained still a null pointer. * This

[PATCH 21/36] aha1542: Simplify aha1542_biosparam

Simplify aha1542_biosparam, use sector_div, remove unused BIOS_TRANSLATION_1632. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/aha1542.c

[PATCH 14/36] aha1542: remove useless code from aha1542_test_port

Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index af2c69e..29ddcc9 100644 --- a/drivers/scsi/aha1542.c +++

[PATCH 3/4] SCSI-QLA4...: Less function calls in qla4xxx_is_flash_ddb_exists() after error detection

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 21:55:55 +0100 The vfree() function was called in two cases by the qla4xxx_is_flash_ddb_exists() function during error handling even if the passed variables fw_tddb and tmp_tddb contained still a null pointer. * This

[PATCH] xen-scsiback: some modifications about code comment

From: Tao Chen boby.c...@huawei.com Signed-off-by: Tao Chen boby.c...@huawei.com --- drivers/xen/xen-scsiback.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c index 3e32146..59f09fd 100644 ---

[PATCH 24/36] aha1542: Always name Scsi_Host variables sh

Make Scsi_Host variable names consistent - use sh everywhere. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 98 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/drivers/scsi/aha1542.c

[PATCH 31/36] aha1542: remove DEB macro and simplify debug code

Remove DEB macro and join ifdef DEBUG blocks Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 56 +++- 1 file changed, 22 insertions(+), 34 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c

[PATCH 17/36] aha1542: split out code from aha1542_hw_init

Split out bus times related block of aha1542_hw_init into separate function aha1542_set_bus_times. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 65 ++-- 1 file changed, 35 insertions(+), 30 deletions(-) diff

[PATCH 22/36] aha1542: clean up cmd variables

Make sure that there's no variable named cmd Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 53 ++-- 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c

[PATCH 11/36] aha1542: Unify aha1542_in and aha1542_in1

Unify aha1542_in and aha1542_in1 functions, they differ only in timeout and printk. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 33 +++-- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/aha1542.c

[PATCH 10/36] aha1542: Remove WAIT and WAITd macros

Convert the ugly WAIT and WAITd macros into wait_mask function. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 104 ++-- 1 file changed, 57 insertions(+), 47 deletions(-) diff --git a/drivers/scsi/aha1542.c

[PATCH 23/36] aha1524: Use struct scsi_cmnd

Use struct scsi_cmnd instead of Scsi_Cmnd and also rename the variables to get rid of SC prefix Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 150 1 file changed, 75 insertions(+), 75 deletions(-) diff --git

[PATCH 15/36] aha1542: Remove aha1542_restart

aha1542_restart does nothing (except useless printk), remove it Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c

[PATCH 30/36] aha1542: Use shost_printk instead of printk

Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 67 +++- 1 file changed, 32 insertions(+), 35 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 6e44a7f..d607f59 100644 ---

[PATCH 16/36] aha1542: Merge aha1542_host_reset and aha1542_bus_reset

aha1542_host_reset and aha1542_bus_reset are almost same, merge them into aha1542_reset Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 82 +--- 1 file changed, 14 insertions(+), 68 deletions(-) diff --git

[PATCH 18/36] aha1542: Call wait_mask from aha1542_out

aha1542_out call is always followed by wait_mask. Move the call into aha1542_out to simplify code. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/aha1542.c

[PATCH 34/36] aha1542: rework locking

Remove aha1542_lock and use host_lock instead. Remove interrupt and queuecommand function wrappers. Remove locking from lowlevel _out and _in functions, they now can onle be called (at runtime) with host_lock being held. Remove ssleep(4) in aha1542_reset as we can't sleep while holding a spinlock.

[PATCH 36/36] aha1542: remove loop from aha1542_outb

The loop in aha1542_outb with double-check is no longer needed, remove it. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index

[PATCH 13/36] aha1542: Remove unneeded gotos

Remove gotos that are no longer needed. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 58 1 file changed, 19 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index

[PATCH 32/36] aha1542: Use print_hex_dump_bytes in debug code

Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 34 -- 1 file changed, 8 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 6d4532c..87017fb 100644 --- a/drivers/scsi/aha1542.c

[PATCH 20/36] aha1542: rework configuration parameters

Remove __setup and introduce separate io, bus_on, bus_off and dma_speed module parameters. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 213 1 file changed, 54 insertions(+), 159 deletions(-) diff --git

[PATCH 25/36] aha1542: fix include guard and remove useless changelog

Fix include guard in header file and remove useless changelog Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.h | 36 +++- 1 file changed, 3 insertions(+), 33 deletions(-) diff --git a/drivers/scsi/aha1542.h

[PATCH 27/36] aha1542: cleanup includes

Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 214b9f4..16cb6f9 100644 --- a/drivers/scsi/aha1542.c +++

[PATCH 35/36] aha1542: Fix bus reset

Bus reset always fails because aha1542_reset waits for the controller to assert the INIT bit (Mailbox Initialization Required) which it never does. This bit is asserted only after host reset. Remove the requirement for INIT bit (we really need only the IDLE bit). Signed-off-by: Ondrej Zary

[PATCH 28/36] aha1542: Pass struct Scsi_Host * to functions

Pass struct Scsi_Host * to functions instead of base address. This reduces the number of parameters and is also required for printk conversion. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 125 1 file

[PATCH 26/36] aha1542: remove useless changelog

Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c index 7b06698..214b9f4 100644 --- a/drivers/scsi/aha1542.c +++

[PATCH 19/36] aha1542: rework hw_init

Cleanup hw_init, use goto for error handling. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 139 drivers/scsi/aha1542.h |1 + 2 files changed, 59 insertions(+), 81 deletions(-) diff --git

[PATCH 33/36] aha1542: Don't reduce functionality with DEBUG enabled

Enabling DEBUG disables write commands and devices with ID 1. Remove this feature to allow real debugging. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git

[PATCH 29/36] aha1542: Change aha1542_set_bus_times parameters

Pass struct Scsi_Host *sh and dma parameters instead of index to aha1542_set_bus_times. This is required for printk conversion. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/scsi/aha1542.c | 34 -- 1 file changed, 16 insertions(+), 18

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: There has been some ongoing discussion about the best way to implement tape statistics. The original method suggested a long time ago used a single file in sysfs similar to block statistics in sysfs. That lead to an impass about

[PATCH] scsi: megaraid_sas: Prevent future %p disaster

There is currently no %po format extension, so currently the letters on are simply skipped and the pointer is printed as expected (while missing the word on). However, it is probably only a matter of time before someone comes up with a %po extension, at which point this is likely to fail

[PATCH] scsi: 3w-xxxx: Drop duplicated function name

Mentioning the enclosing function twice doesn't add value. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/scsi/3w-.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/3w-.c b/drivers/scsi/3w-.c index c75f2048319f..67539e73fdad

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

On Fri, Feb 06, 2015 at 09:13:55AM +, Bryn M. Reeves wrote: The sysfs documentation says that files should contain one item per file (with some small exceptions): Attributes should be ASCII text files, preferably with only one value per file. It is noted that it may not be

[PATCH 0/3] SCSI-debug: Deletion of a few unnecessary checks

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 18:08:53 +0100 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (3): Deletion of unnecessary checks before the function call vfree Less

[PATCH 1/3] SCSI-debug: Deletion of unnecessary checks before the function call vfree

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 16:56:57 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 2/3] SCSI-debug: Less function calls in scsi_debug_init() after error detection

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 17:48:34 +0100 The vfree() function was called in two cases by the scsi_debug_init() function during error handling even if the passed variables dif_storep and map_storep contained null pointers eventually. This

[PATCH 3/3] SCSI-debug: Fix exception handling for an alignment/granularity mismatch in scsi_debug_init()

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 17:57:32 +0100 The scsi_debug_init() function returned directly if the data items alignment and granularity did not fit together. Let us improve the affected exception handling by replacing the return statement by a goto

Re: [PATCH 07/21] lpfc: Fix setting of EQ delay Multiplier

On 02/05/2015 08:24 PM, James Smart wrote: --- drivers/scsi/lpfc/lpfc_init.c | 8 drivers/scsi/lpfc/lpfc_sli.c | 9 +++-- drivers/scsi/lpfc/lpfc_sli4.h | 2 +- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c

Re: [PATCH 02/21] lpfc: Add Lancer Temperature Event support to the lpfc driver

On 02/05/2015 08:23 PM, James Smart wrote: --- drivers/scsi/lpfc/lpfc_hw4.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 179 +- 2 files changed, 125 insertions(+), 55 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hw4.h

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: Hello linux-api'ers There has been some ongoing discussion about the best way to implement tape statistics. The original method suggested a long time ago used a single file in sysfs similar to block statistics in sysfs. That

Re: [PATCH 10/21] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

On 02/05/2015 08:24 PM, James Smart wrote: --- drivers/scsi/lpfc/lpfc_ct.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c index 61a32cd..5091184 100644 --- a/drivers/scsi/lpfc/lpfc_ct.c

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

On Fri, Feb 06, 2015 at 04:59:16AM -0800, Greg KH wrote: On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: The current patch that implements tape statistics is here: http://marc.info/?l=linux-scsim=142112067313723w=2 Aside from the do we want to do this all in a single

Re: [PATCH] st: implement sysfs based tape statistics v2

On 1/26/2015 6:11 PM, Seymour, Shane M wrote: I was wondering if anyone had any feedback or had any chance to review the changes? Per the other discussion about having the same stat format forever. It seems to me that you might want to preemptively add a few additional counters.

[PATCH] SCSI-csiostor: Delete an unnecessary check before the function call release_firmware

From: Markus Elfring elfr...@users.sourceforge.net Date: Fri, 6 Feb 2015 19:10:25 +0100 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.