On Wed, 2015-06-03 at 12:37 +0300, Yaniv Gardi wrote:
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
EXPORT_SYMBOL(ufs_hba_qcom_vops);
Nothing uses this export. It's still a (static) symbol that is not
included in any header. I think this export serves no purpose. Am
Hi Yaniv,
2015-06-03 18:37 GMT+09:00 Yaniv Gardi yga...@codeaurora.org:
@@ -321,7 +313,22 @@ static int ufshcd_pltfrm_probe(struct
platform_device *pdev)
goto out;
}
- hba-vops = get_variant_ops(pdev-dev);
+ err = of_platform_populate(node, NULL, NULL,
This patch removes 21 casts between an __iomem pointer type and
another data type but also introduces five new casts (see also
the casts with __force). Although this patch does not change
any functionality, IMHO the code with __force casts needs further
review.
Signed-off-by: Bart Van Assche
Avoid that smatch reports the following warning:
drivers/scsi/qla2xxx/qla_attr.c:1081: qla2x00_model_desc_show() warn: this
array is probably non-NULL. 'vha-hw-model_desc'
Signed-off-by: Bart Van Assche bart.vanass...@sandisk.com
Acked-by: Himanshu Madhani himanshu.madh...@qlogic.com
Cc: Quinn
The return QLA_SUCCESS statement just above the fw_load_failed
label cannot be reached, hence remove it. Additionally remove the
else keyword since the code block below the if-statement ends
with a return statement.
Signed-off-by: Bart Van Assche bart.vanass...@sandisk.com
Acked-by: Himanshu
Signed-off-by: Bart Van Assche bart.vanass...@sandisk.com
Acked-by: Himanshu Madhani himanshu.madh...@qlogic.com
Cc: Quinn Tran quinn.t...@qlogic.com
Cc: Saurav Kashyap saurav.kash...@qlogic.com
---
drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
drivers/scsi/qla2xxx/qla_iocb.c | 4 ++--
Detected by smatch.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: Himanshu Madhani himanshu.madh...@qlogic.com
Cc: Quinn Tran quinn.t...@qlogic.com
Cc: Saurav Kashyap saurav.kash...@qlogic.com
---
drivers/scsi/qla2xxx/qla_init.c | 2 +-
drivers/scsi/qla2xxx/qla_iocb.c | 8
Comment out the code that is never reached in qla83xx_idc_unlock()
and also in qlt_set_data_offset() to avoid that static source code
analysis tools report warnings for this code.
Signed-off-by: Bart Van Assche bart.vanass...@sandisk.com
Cc: Himanshu Madhani himanshu.madh...@qlogic.com
Cc: Quinn
Hello James,
On Thu, Jun 4, 2015 at 1:27 PM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Thu, 2015-06-04 at 11:40 -0700, Rajat Jain wrote:
Each cmd timeout should result in scmd-retries++. Currently it happens
just only before a command is requeued back. However, if the LLD
Whether htonl() or __constant_htonl() is used, if the argument
is a constant the conversion happens at compile time. Hence leave
out the __constant_ prefix for this and other endianness
conversion functions. This improves source code readability.
Signed-off-by: Bart Van Assche
This patch avoids that sparse complains about duplicate [noderef]
attributes.
Signed-off-by: Bart Van Assche bart.vanass...@sandisk.com
Acked-by: Himanshu Madhani himanshu.madh...@qlogic.com
Cc: Quinn Tran quinn.t...@qlogic.com
Cc: Saurav Kashyap saurav.kash...@qlogic.com
---
This patch series addresses several warnings reported by static source
code analysis tools for the qla2xxx driver (gcc (W=1), sparse (C=2) and
smatch (C=2 CHECK=smatch -p=kernel)). The patches in this series are:
0001-qla2xxx-Declare-local-functions-static.patch
Each cmd timeout should result in scmd-retries++. Currently it happens
just only before a command is requeued back. However, if the LLD
eh_timed_out() handler asks to reset timer back again, then also it should
be incremented because effectively LLD will be given a full time period
(SD_TIMEOUT =
On Thu, Jun 04, 2015 at 10:20:23AM +0530, Sreekanth Reddy wrote:
Hi Luis,
Sorry for delay in response. Actually I was looking for the history of
this section of code but I couldn't find it. Anyway this is dead code
and we are fine with removing this dead code.
James,
Please consider
Hi folks,
Well, we made it! As of yesterday, the File Storage systems microconf has
been approved for Plumbers! If you're interested in attending, I highly
recommend that you register[0] immediately, as the earlybird deadline is
tomorrow, June 5th.
We have a solid list of discussion ideas on
On 6/4/2015 10:06 AM, Nicholas A. Bellinger wrote:
On Wed, 2015-06-03 at 14:57 +0200, Christoph Hellwig wrote:
This makes lockdep very unhappy, rightly so. If you execute
one end_io function inside another you basіcally nest every possible
lock taken in the I/O completion path. Also adding
On Wed, 2015-06-03 at 12:37 +0300, Yaniv Gardi wrote:
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
EXPORT_SYMBOL(ufs_hba_qcom_vops);
Nothing uses this export. It's still a (static) symbol that is not
included in any header. I think this export serves no purpose. Am I
Hi Yaniv,
2015-06-03 18:37 GMT+09:00 Yaniv Gardi yga...@codeaurora.org:
@@ -321,7 +313,22 @@ static int ufshcd_pltfrm_probe(struct platform_device
*pdev)
goto out;
}
- hba-vops = get_variant_ops(pdev-dev);
+ err = of_platform_populate(node, NULL, NULL,
The string cmd %d RESET FAILED, new lockup detected is not quite
large enough so the sprintf() will overflow. I have increased the size
of the buffer and also changed the sprintf calls to snprintf.
Fixes: 73153fe533bc ('hpsa: use block layer tag for command allocation')
Signed-off-by: Dan
Am 04.06.2015 16:47, schrieb Dan Carpenter:
The string cmd %d RESET FAILED, new lockup detected is not quite
large enough so the sprintf() will overflow. I have increased the size
of the buffer and also changed the sprintf calls to snprintf.
Fixes: 73153fe533bc ('hpsa: use block layer tag
On 06/02/2015 06:55 PM, Matthew R. Ochs wrote:
+/**
+ * send_tmf() - sends a Task Management Function (TMF)
+ * @afu: AFU to checkout from.
+ * @scp: SCSI command from stack.
+ * @tmfcmd: TMF command to send.
+ *
+ * Return:
+ * 0 on success
+ * SCSI_MLQUEUE_HOST_BUSY when
On Thu, 2015-06-04 at 16:07 +0200, Paul Bolle wrote:
On Wed, 2015-06-03 at 12:37 +0300, Yaniv Gardi wrote:
+static int ufs_qcom_probe(struct platform_device *pdev)
+{
+ dev_set_drvdata(pdev-dev, (void *)ufs_hba_qcom_vops);
(Cast to void * should not be needed.)
Only if
On Wed, 2015-06-03 at 14:57 +0200, Christoph Hellwig wrote:
This makes lockdep very unhappy, rightly so. If you execute
one end_io function inside another you basіcally nest every possible
lock taken in the I/O completion path. Also adding more work
to the hardirq path generally isn't a
James,
This patch looks good, please consider this patch as Acked-by:
Sreekanth Reddy sreekanth.re...@avagotech.com.
Regards,
Sreekanth
On Wed, Jun 3, 2015 at 9:07 PM, Tomas Henzl the...@redhat.com wrote:
v2: use debug log level to silence the unsurprising information
v1: A user of
On Thu, 2015-06-04 at 11:40 -0700, Rajat Jain wrote:
Each cmd timeout should result in scmd-retries++. Currently it happens
just only before a command is requeued back. However, if the LLD
eh_timed_out() handler asks to reset timer back again, then also it should
be incremented because
25 matches
Mail list logo
