On Tue, 2015-07-14 at 16:00 -0400, Himanshu Madhani wrote:
Hi James,
This series is applied on top of patch series sent on June 10
[PATCH 0/9] qla2xxx: Patches for scsi misc branch
(http://marc.info/?l=linux-scsim=143395156920505w=2)
These set of patches addresses issue with reuse of
On Thu, 2015-07-23 at 23:38 -0700, Nicholas A. Bellinger wrote:
Hi Himanshu Co,
(Adding target-devel CC')
On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote:
Hi James,
SNIP
This series contains a number of qla2xxx target mode related bug-fixes
that have not made it into
Hi Himanshu Co,
(Adding target-devel CC')
On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote:
Hi James,
Please apply the following patches to the scsi tree at your earliest
convenience for inclusion in the next mainline merge window.
Thanks,
Himanshu
Himanshu Madhani (3):
On Thu, Jul 23, 2015 at 03:19:32PM -0700, Spencer Baugh wrote:
From: Alexei Potashnik ale...@purestorage.com
If command didn't match a LUN and we're sending check condition, the
target_cmd_complete ftrace point will crash because it assumes that
cmd-t_task_cdb has been set.
The fix will
This seems to be a bit of a catchall. Can you split the logging changes
from actual error code logic changes and describe the latter in more detail?
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at
- rq-cmd[6] = (h-bufflen 24) 0xff;
- rq-cmd[7] = (h-bufflen 16) 0xff;
- rq-cmd[8] = (h-bufflen 8) 0xff;
- rq-cmd[9] = h-bufflen 0xff;
+ put_unaligned_be32(bufflen, rq-cmd[6]);
This is unrelated to the rest of the patch, can you split it out,
maybe together with
On Wed, Jul 08, 2015 at 11:06:09AM +0200, Hannes Reinecke wrote:
+ pg = kzalloc(sizeof(struct alua_port_group), GFP_KERNEL);
+ if (!pg) {
+ sdev_printk(KERN_WARNING, sdev,
+ %s: kzalloc port group failed\n,
+ ALUA_DH_NAME);
On Fri, Jul 24, 2015 at 04:40:42PM +0200, Hannes Reinecke wrote:
Yeah, possibly. After all, the variable isn't expected to change
under rcu_read_lock().
Actually it can and will change, that's the point. But if you use
a local variable you keep a single version of it, which won't be
freed
As per the comment on patch 3 I'd rather expose the ALUA state in the core
SCSI code. But having this alua_state attribute in core SCSI code sounds
fine to me.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 22 Jun 2015, James Bottomley wrote:
On Mon, 2015-06-22 at 13:48 -0400, Alan Stern wrote:
On Mon, 22 Jun 2015, James Bottomley wrote:
On Mon, 2015-06-22 at 13:30 -0400, Alan Stern wrote:
On Mon, 22 Jun 2015, James Bottomley wrote:
I'm not sure I entirely like this:
Seems like this should use scsi_execute_req_flags instead so that it doesn't
have to deal with the raw sense buffer.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at
- memset(h-buff, 0, stpg_len);
- h-buff[4] = TPGS_STATE_OPTIMIZED 0x0f;
- h-buff[6] = (h-group_id 8) 0xff;
- h-buff[7] = h-group_id 0xff;
+ memset(stpg_data, 0, stpg_len);
+ stpg_data[4] = TPGS_STATE_OPTIMIZED 0x0f;
+ put_unaligned_be16(group_id,
On Wed, Jul 08, 2015 at 01:09:44PM +0200, Hannes Reinecke wrote:
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -264,8 +264,11 @@ static int alua_check_vpd(struct scsi_device *sdev,
struct alua_dh_data *h)
int device_id_size, device_id_type = 0;
struct alua_port_group
+ charwork_q_name[264];
create_workqueue and friends now accept printf-like format
string, so there is no need for this temporary buffer.
+ int error;
+ struct completion init_complete;
Please rename error to init_error and only
+ /*
+ * Retry on ALUA state transition or if any
+ * UNIT ATTENTION occurred.
+ */
+ if (sense_hdr.sense_key == NOT_READY
+ sense_hdr.asc == 0x04 sense_hdr.ascq == 0x0a)
+ err =
On Wed, Jul 08, 2015 at 11:06:12AM +0200, Hannes Reinecke wrote:
Parse VPD descriptor to figure out the device identification.
As devices might implement several descriptors the order
of preference is:
- NAA IEE Registered Extended
- EUI-64 based 16-byte
- EUI-64 based 12-byte
- NAA IEEE
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph Can you move this to scsi_mod.ko? I'll need the same code
Christoph for the NFS SCSI layout driver soon.
Same here. Working on copy offload again.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this
On 07/16/2015 06:26 PM, Matthew R. Ochs wrote:
+
+/**
+ * ba_clone() - frees a block from the block allocator
+ * @ba_lun: Block allocator from which to allocate a block.
+ * @to_free: Block to free.
+ *
+ * Return: 0 on success, -1 on failure
+ */
+static int ba_clone(struct ba_lun
On Fri, 2015-07-24 at 12:52 +0200, Christoph Hellwig wrote:
On Thu, Jul 23, 2015 at 03:19:32PM -0700, Spencer Baugh wrote:
From: Alexei Potashnik ale...@purestorage.com
If command didn't match a LUN and we're sending check condition, the
target_cmd_complete ftrace point will crash
On Fri, 2015-07-24 at 07:51 -0700, James Bottomley wrote:
On Thu, 2015-07-23 at 23:38 -0700, Nicholas A. Bellinger wrote:
Hi Himanshu Co,
(Adding target-devel CC')
On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote:
Hi James,
Please apply the following patches to the
On Fri, 2015-07-24 at 18:32 +, Himanshu Madhani wrote:
Hi Nic,
On 7/23/15, 11:45 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote:
On Thu, 2015-07-23 at 23:38 -0700, Nicholas A. Bellinger wrote:
Hi Himanshu Co,
(Adding target-devel CC')
On Wed, 2015-06-10 at 11:05
Hi Nic,
On 7/23/15, 11:45 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote:
On Thu, 2015-07-23 at 23:38 -0700, Nicholas A. Bellinger wrote:
Hi Himanshu Co,
(Adding target-devel CC')
On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote:
Hi James,
SNIP
This series contains
Hi Nic, James,
On 7/24/15, 7:51 AM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Thu, 2015-07-23 at 23:38 -0700, Nicholas A. Bellinger wrote:
Hi Himanshu Co,
(Adding target-devel CC')
On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote:
Hi James,
Please
https://bugzilla.kernel.org/show_bug.cgi?id=101891
--- Comment #2 from Dāvis davis...@gmail.com ---
(In reply to Dāvis from comment #0)
Got this call trace, it caused any attempts to access those disks hang
(couldn't even kill those processes, eg. ls).
Using HighPoint RocketRAID 2760A
25 matches
Mail list logo
