[RFC v5 01/26] scsi/atari_scsi: Dont select CONFIG_NVRAM

2015-07-25 Thread Finn Thain
On powerpc, setting CONFIG_NVRAM=n builds a kernel with no NVRAM support. Setting CONFIG_NVRAM=m enables the /dev/nvram misc device module without enabling NVRAM support in drivers. Setting CONFIG_NVRAM=y enables the misc device (built-in) and also enables NVRAM support in drivers. m68k shares

Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-25 Thread Nicholas A. Bellinger
On Sat, 2015-07-25 at 08:48 +0200, Christoph Hellwig wrote: On Fri, Jul 24, 2015 at 01:32:14PM -0700, Nicholas A. Bellinger wrote: We've already been through this discussion a couple of years back when target_submit_cmd() first came into existence. The reason iscsi/iser-target continues

Re: [PATCH 14/20] scsi_dh_alua: parse target device id

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 05:28 PM, Martin K. Petersen wrote: Christoph == Christoph Hellwig h...@lst.de writes: Christoph Can you move this to scsi_mod.ko? I'll need the same code Christoph for the NFS SCSI layout driver soon. Same here. Working on copy offload again. Hehe. Thought that was needed

Re: [PATCH 16/20] scsi_dh_alua: Use workqueue for RTPG

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 05:21 PM, Christoph Hellwig wrote: +charwork_q_name[264]; create_workqueue and friends now accept printf-like format string, so there is no need for this temporary buffer. +int error; +struct completion init_complete;

Re: [PATCH 04/20] scsi_dh_alua: Improve error handling

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 04:48 PM, Christoph Hellwig wrote: This seems to be a bit of a catchall. Can you split the logging changes from actual error code logic changes and describe the latter in more detail? Ok. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de

Re: [PATCH 08/20] scsi_dh_alua: Make stpg synchronous

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 04:51 PM, Christoph Hellwig wrote: -memset(h-buff, 0, stpg_len); -h-buff[4] = TPGS_STATE_OPTIMIZED 0x0f; -h-buff[6] = (h-group_id 8) 0xff; -h-buff[7] = h-group_id 0xff; +memset(stpg_data, 0, stpg_len); +stpg_data[4] = TPGS_STATE_OPTIMIZED 0x0f; +

Re: [PATCH 09/20] scsi_dh_alua: switch to scsi_execute()

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 04:53 PM, Christoph Hellwig wrote: Seems like this should use scsi_execute_req_flags instead so that it doesn't have to deal with the raw sense buffer. Ok, I'll have a look here. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de

Re: [PATCH 14/20] scsi_dh_alua: parse target device id

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 05:07 PM, Christoph Hellwig wrote: On Wed, Jul 08, 2015 at 11:06:12AM +0200, Hannes Reinecke wrote: Parse VPD descriptor to figure out the device identification. As devices might implement several descriptors the order of preference is: - NAA IEE Registered Extended - EUI-64

Re: [PATCH 11/20] scsi_dh_alua: Use separate alua_port_group structure

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 04:58 PM, Christoph Hellwig wrote: On Wed, Jul 08, 2015 at 11:06:09AM +0200, Hannes Reinecke wrote: +pg = kzalloc(sizeof(struct alua_port_group), GFP_KERNEL); +if (!pg) { +sdev_printk(KERN_WARNING, sdev, +%s: kzalloc port group

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-25 Thread Christoph Hellwig
Which debug printk do you care about? I'd much prefer having a trace point inside the driver which could even pretty print it instead of the hack where a driver defined binary value is printed by the core. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-25 Thread Christoph Hellwig
On Fri, Jul 24, 2015 at 03:06:12AM +, Elliott, Robert (Server Storage) wrote: Note that the officially published versions of the ISO and ANSI standards don't carry that revision number r36; they just have the standard name and year. SBC-3 revision 36 became ANSI INCITS 514-2014

Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-25 Thread Christoph Hellwig
On Fri, Jul 24, 2015 at 01:32:14PM -0700, Nicholas A. Bellinger wrote: We've already been through this discussion a couple of years back when target_submit_cmd() first came into existence. The reason iscsi/iser-target continues to be a special case is due to immediate data vs. non immediate

Re: [PATCH 4/5] scsi_dh_alua: add 'state' callback function

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 04:42 PM, Christoph Hellwig wrote: As per the comment on patch 3 I'd rather expose the ALUA state in the core SCSI code. But having this alua_state attribute in core SCSI code sounds fine to me. Sure, we can have an attribute 'alua_state' in the core code; after all, ALUA is

Re: [PATCH 1/5] scsi: rescan VPD attributes

2015-07-25 Thread Hannes Reinecke
On 07/24/2015 04:43 PM, Christoph Hellwig wrote: On Fri, Jul 24, 2015 at 04:40:42PM +0200, Hannes Reinecke wrote: Yeah, possibly. After all, the variable isn't expected to change under rcu_read_lock(). Actually it can and will change, that's the point. But if you use a local variable you

Re: [PATCH v2 3/3] cxlflash: Virtual LUN support

2015-07-25 Thread Matthew R. Ochs
Hi Brian, Thanks for reviewing. Comments inline below. -matt On Jul 24, 2015, at 3:15 PM, Brian King wrote: On 07/16/2015 06:26 PM, Matthew R. Ochs wrote: + +/** + * ba_clone() - frees a block from the block allocator + * @ba_lun: Block allocator from which to allocate a block. + *