Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

On Fri, 4 Dec 2015, Ondrej Zary wrote: > Add I/O register mapping for DTC chips and enable PDMA mode. > > These chips have 16-bit wide HOST BUFFER register (counter register at > offset 0x0d increments by 2 on each HOST BUFFER read). > > Large PIO transfers crash at least the DTCT-436P chip

Re: [PATCH 08/10] aacraid: Disable device ID wildcard

On Thu, Dec 03, 2015 at 09:32:18PM +, Raghava Aditya Renukunta wrote: > This will enable us to prevent aacraid from loading for PCI devices that match > device ID wildcards. Enabling us to use say a new driver for future devices. This looks like a bogus reason. The same PCI ID should always

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

On Fri, 4 Dec 2015, Julian Calaby wrote: > > - if (overrides[current_override].board == BOARD_NCR53C400A) { > > + if (overrides[current_override].board == BOARD_NCR53C400A || > > + overrides[current_override].board == BOARD_DTC3181E) { > > These if

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

On Fri, 4 Dec 2015, Ondrej Zary wrote: > @@ -685,8 +684,10 @@ static inline int NCR5380_pwrite(struct Scsi_Host > *instance, unsigned char *src, > /* All documentation says to check for this. Maybe my hardware is too >* fast. Waiting for it seems to work fine! KLL >*/ > -

Re: [PATCH] storvsc: add more logging for error and warning messages

Long Li writes: > Introduce a logging level for storvsc to log certain error/warning > messages. Those messages are helpful in some environments, > e.g. Microsoft Azure, for customer support and troubleshooting > purposes. I have an alternative suggestion: let's use

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

On Friday 04 December 2015, Finn Thain wrote: > > On Fri, 4 Dec 2015, Ondrej Zary wrote: > > > Add I/O register mapping for DTC chips and enable PDMA mode. > > > > These chips have 16-bit wide HOST BUFFER register (counter register at > > offset 0x0d increments by 2 on each HOST BUFFER read).

[PATCH v2 2/8] aic7xxx: Avoid name collision with

Rename the local definition of LIST_HEAD to BSD_LIST_HEAD. This fixes a ctags error if we apply the C rules to header files as well: ctags: Warning: drivers/scsi/aic7xxx/aic79xx.h:1072: null expansion of name pattern "\3" ctags: Warning: drivers/scsi/aic7xxx/aic7xxx.h:919: null expansion of

Re: [PATCH 04/10] aacraid: Fix memory leak in aac_fib_map_free

On 1.12.2015 13:39, Raghava Aditya Renukunta wrote: > From: Raghava Aditya Renukunta > > aac_fib_map_free() calls pci_free_consistent() without checking that > dev->hw_fib_va is not NULL and dev->max_fib_size is not zero.If they > are indeed NULL/0, this will

Re: [PATCH 05/10] aacraid: Set correct msix count for EEH recovery

On 1.12.2015 13:39, Raghava Aditya Renukunta wrote: > From: Raghava Aditya Renukunta > > During EEH recovery number of online CPU's might change thereby changing > the number of MSIx vectors. Since each fib is allocated to a vector, > changes in the number of

Re: [PATCH 02/10] aacraid: Fix RRQ overload

On 1.12.2015 13:39, Raghava Aditya Renukunta wrote: > From: Raghava Aditya Renukunta > > The driver utilizes an array of atomic variables to keep track of > IO submissions to each vector. To submit an IO multiple threads > iterate through the array to find a

Re: [PATCH 03/10] aacraid: Added EEH support

On 1.12.2015 13:39, Raghava Aditya Renukunta wrote: > From: Raghava Aditya Renukunta > > Added support for PCI EEH(extended error handling). > > Signed-off-by: Raghava Aditya Renukunta Reviewed-by: Tomas Henzl

[PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS

CONFIG_SCSI_MPT2SAS was added as a backwards-compatibility helper that selects the replacement SCSI_MPT3SAS symbol, but lacks the dependencies: warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct dependencies (SCSI_LOWLEVEL && PCI && SCSI) 0x7E5F9A79 Fri Dec 4 12:36:08 CET 2015

Re: [PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS

On Friday 04 December 2015 08:28:51 James Bottomley wrote: > On Fri, 2015-12-04 at 15:27 +0100, Arnd Bergmann wrote: > > CONFIG_SCSI_MPT2SAS was added as a backwards-compatibility helper that > > selects the replacement SCSI_MPT3SAS symbol, but lacks the dependencies: > > > > warning:

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Fri, 04 Dec 2015 18:02:58 +0100, Jens Axboe wrote: > > On 12/04/2015 09:59 AM, Takashi Iwai wrote: > > On Wed, 25 Nov 2015 20:01:47 +0100, > > Hannes Reinecke wrote: > >> > >> On 11/25/2015 07:01 PM, Mike Snitzer wrote: > >>> On Wed, Nov 25 2015 at 4:04am -0500, > >>> Hannes Reinecke

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

On Thu, 2015-12-03 at 23:20 +0100, Andrea Gelmini wrote: > On Thu, Dec 03, 2015 at 12:59:06PM -0800, James Bottomley wrote: > > sg_map -i > > > > in your system, you should see something with an inquiry string like > > enclosure. It's the /dev/sg of that you need to run sg_ses on. > >

Re: [PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS

On Fri, 2015-12-04 at 15:27 +0100, Arnd Bergmann wrote: > CONFIG_SCSI_MPT2SAS was added as a backwards-compatibility helper that > selects the replacement SCSI_MPT3SAS symbol, but lacks the dependencies: > > warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct > dependencies

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On 12/04/2015 09:59 AM, Takashi Iwai wrote: On Wed, 25 Nov 2015 20:01:47 +0100, Hannes Reinecke wrote: On 11/25/2015 07:01 PM, Mike Snitzer wrote: On Wed, Nov 25 2015 at 4:04am -0500, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at

Re: [PATCH v2 0/3] Badblock tracking for gendisks

On Wed, 2015-11-25 at 11:43 -0700, Vishal Verma wrote: > v2: >   - In badblocks_free, make 'page' NULL (patch 1) >   - Move the core badblocks code to a new .c file (patch 1) (Jens) >   - Fix a sizeof usage in disk_alloc_badblocks (patch 2) (Dan) >   - Since disk_alloc_badblocks can fail, check

Re: [PATCH v2 1/3] badblocks: Add core badblock management code

On Wed, 2015-11-25 at 11:43 -0700, Vishal Verma wrote: > Take the core badblocks implementation from md, and make it generally > available. This follows the same style as kernel implementations of > linked lists, rb-trees etc, where you can have a structure that can be > embedded anywhere, and

RE: [PATCH] storvsc: add more logging for error and warning messages

> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, December 4, 2015 1:53 AM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; James E.J. Bottomley ; >

[PATCH 73/71] ncr5380: Use runtime register mapping

Convert compile-time C400_ register mapping to runtime mapping. This removes the weird negative register offsets and allows adding additional mappings. Signed-off-by: Ondrej Zary --- drivers/scsi/NCR5380.h | 13 +- drivers/scsi/g_NCR5380.c | 61

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

On Fri, 2015-12-04 at 11:16 -0800, James Bottomley wrote: > On Fri, 2015-12-04 at 11:58 -0500, Ewan Milne wrote: > > On Thu, 2015-12-03 at 23:20 +0100, Andrea Gelmini wrote: > > > On Thu, Dec 03, 2015 at 12:59:06PM -0800, James Bottomley wrote: > > > > sg_map -i > > > > > > > > in your system,

Re: [PATCH v2] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

Thanks Josh! The patch looks good to me. Thanks! Arvind From: Johannes Thumshirn Sent: Thursday, December 3, 2015 5:35 AM To: Josh Boyer; james.bottom...@hansenpartnership.com; Arvind Kumar; Thomas Hellstrom Cc:

Re: [PATCH v2 2/3] block: Add badblock management for gendisks

On Wed, 2015-11-25 at 11:43 -0700, Vishal Verma wrote: > NVDIMM devices, which can behave more like DRAM rather than block > devices, may develop bad cache lines, or 'poison'. A block device > exposed by the pmem driver can then consume poison via a read (or > write), and cause a machine check. On

[PATCH 76/71] ncr5380: Enable PDMA for DTC chips

Add I/O register mapping for DTC chips and enable PDMA mode. These chips have 16-bit wide HOST BUFFER register (counter register at offset 0x0d increments by 2 on each HOST BUFFER read). Detect it automatically. Large PIO transfers crash at least the DTCT-436P chip (all reads result in 0xFF) so

[PATCH 74/71] ncr5380: Enable PDMA for NCR53C400A

Add I/O register mapping for NCR53C400A and enable PDMA mode to improve performance and fix non-working IRQ. Tested with HP C2502 (and user-space enabler). Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [PATCH v2 1/3] badblocks: Add core badblock management code

On Fri, 2015-12-04 at 15:30 -0800, James Bottomley wrote: [...] > > + * We return > > + *  0 if there are no known bad blocks in the range > > + *  1 if there are known bad block which are all acknowledged > > + * -1 if there are bad blocks which have not yet been acknowledged > > in metadata. > >

Re: [PATCH v2 1/3] badblocks: Add core badblock management code

On Fri, 2015-12-04 at 23:58 +, Verma, Vishal L wrote: > On Fri, 2015-12-04 at 15:30 -0800, James Bottomley wrote: > [...] > > > + * We return > > > + * 0 if there are no known bad blocks in the range > > > + * 1 if there are known bad block which are all acknowledged > > > + * -1 if there

Re: [PATCH v2 1/3] badblocks: Add core badblock management code

On Fri, 2015-12-04 at 16:06 -0800, James Bottomley wrote: > On Fri, 2015-12-04 at 23:58 +, Verma, Vishal L wrote: > > On Fri, 2015-12-04 at 15:30 -0800, James Bottomley wrote: > > [...] > > > > + * We return > > > > + *  0 if there are no known bad blocks in the range > > > > + *  1 if there

Re: [PATCH v2 2/3] block: Add badblock management for gendisks

On Fri, 2015-12-04 at 15:33 -0800, James Bottomley wrote: [...] > >  static void register_disk(struct gendisk *disk) > >  { > >   struct device *ddev = disk_to_dev(disk); > > @@ -609,6 +624,7 @@ void add_disk(struct gendisk *disk) > >   disk->first_minor = MINOR(devt); > >   > >  

RE: [PATCH 05/10] aacraid: Set correct msix count for EEH recovery

Hello Tomas, > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Friday, December 4, 2015 6:10 AM > To: Raghava Aditya Renukunta; jbottom...@parallels.com; linux- > s...@vger.kernel.org > Cc: Mahesh Rajashekhara; Murthy Bhat; Santosh Akula; Gana Sridaran; >

RE: [PATCH 04/10] aacraid: Fix memory leak in aac_fib_map_free

Hello Tomas, > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Friday, December 4, 2015 6:35 AM > To: Raghava Aditya Renukunta; jbottom...@parallels.com; linux- > s...@vger.kernel.org > Cc: Mahesh Rajashekhara; Murthy Bhat; Santosh Akula; Gana Sridaran; >

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

Hi Finn, On Sat, Dec 5, 2015 at 1:12 PM, Finn Thain wrote: > > On Sat, 5 Dec 2015, Julian Calaby wrote: > >> Hi Finn, >> >> On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain >> wrote: >> > >> > On Fri, 4 Dec 2015, Julian Calaby wrote: >> > >> >>

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

Hi Finn, On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain wrote: > > On Fri, 4 Dec 2015, Julian Calaby wrote: > >> > - if (overrides[current_override].board == BOARD_NCR53C400A) >> > { >> > + if (overrides[current_override].board ==

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

On Sat, 5 Dec 2015, Julian Calaby wrote: > Hi Finn, > > On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain wrote: > > > > On Fri, 4 Dec 2015, Julian Calaby wrote: > > > >> > - if (overrides[current_override].board == > >> > BOARD_NCR53C400A) { > >> > +

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

On Fri, 2015-12-04 at 18:46 +0100, Andrea Gelmini wrote: > On Fri, Dec 04, 2015 at 09:09:32AM -0800, James Bottomley wrote: > > Actually, that would be really helpful, since I only have access to one, > > very old, enclosure device. My ssh key is > > Ok. > Do you need same PC/Kernel of the