Re: [Bug 111441] New: iscsi fails to attach to targets

2016-02-08 Thread Nicholas A. Bellinger
On Tue, 2016-02-02 at 14:56 -0800, Nicholas A. Bellinger wrote: > On Mon, 2016-02-01 at 10:55 -0600, Mike Christie wrote: > > On 01/30/2016 01:38 AM, Nicholas A. Bellinger wrote: > > > On Fri, 2016-01-29 at 17:32 -0600, Mike Christie wrote: > > >> On 01/29/2016 04:21 PM, Serguei Bezverkhi

[Bug 111441] iscsi fails to attach to targets

2016-02-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=111441 --- Comment #15 from nab --- On Tue, 2016-02-02 at 14:56 -0800, Nicholas A. Bellinger wrote: > On Mon, 2016-02-01 at 10:55 -0600, Mike Christie wrote: > > On 01/30/2016 01:38 AM, Nicholas A. Bellinger wrote: > > > On Fri,

[Bug 111341] Firmware loader

2016-02-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=111341 --- Comment #2 from walter59 --- some new information : driver used is not c600 intel controller is intel c600 id 1d02 --- so it uses ahci driver. The probleme is the changes in achi.c to mulipile irq for each

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Keith Busch
On Mon, Feb 08, 2016 at 04:19:13PM +0100, Hannes Reinecke wrote: > Ok, so what about having a 'wwid' attribute which provides combined > information (like scsi has)? That looks like the sensible thing to do. Thanks for pointer. Going forward, I will solicite more feedback from scsi developers so

Re: [PATCH 3/3] add support for DWC UFS Host Controller

2016-02-08 Thread Joao Pinto
On 2/8/2016 4:15 PM, Mark Rutland wrote: > On Mon, Feb 08, 2016 at 03:36:52PM +, Joao Pinto wrote: >> Hi Mark, >> >> On 2/8/2016 3:30 PM, Mark Rutland wrote: >>> On Mon, Feb 08, 2016 at 03:17:11PM +, Joao Pinto wrote: Hi Mark and Arnd, Are you saying that a user that puts

[mpt3sas driver V1 6/10] mpt3sas: Added smp_affinity_enable module parameter.

2016-02-08 Thread Suganath prabu Subramani
Module parameter to enable/disable configuring affinity hint for msix vector. SMP affinity feature can be enabled/disabled by setting module parameter "smp_affinity_enable" to 1/0. By default this feature is enabled. (smp_affinity_enable = 1 enabled). Signed-off-by: Suganath prabu Subramani

Re: [PATCH 3/3] add support for DWC UFS Host Controller

2016-02-08 Thread Mark Rutland
On Mon, Feb 08, 2016 at 03:36:52PM +, Joao Pinto wrote: > Hi Mark, > > On 2/8/2016 3:30 PM, Mark Rutland wrote: > > On Mon, Feb 08, 2016 at 03:17:11PM +, Joao Pinto wrote: > >> Hi Mark and Arnd, > >> Are you saying that a user that puts "snps,ufshcd-1.1" > >> in the DT compatibility

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Christoph Hellwig
On Mon, Feb 08, 2016 at 12:01:16PM +0200, Sagi Grimberg wrote: > >> Do we have defined sysfs attributes for NVMe devices nowadays? > > /sys/block/nvme0n1/uuid That's only supported for NVMe 1.1 and higher devices, and optional. For older or stupid devices we need to support the algorithm based on

Re: [PATCH 1/2] megaraid_sas: Fix for IO failing post OCR in SRIOV environment

2016-02-08 Thread Tomas Henzl
On 5.2.2016 13:24, Sumit Saxena wrote: >> -Original Message- >> From: Tomas Henzl [mailto:the...@redhat.com] >> Sent: Friday, January 29, 2016 9:47 PM >> To: Sumit Saxena; jbottom...@parallels.com; h...@infradead.org; >> martin.peter...@oracle.com >> Cc: linux-scsi@vger.kernel.org;

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Sagi Grimberg
Do we have defined sysfs attributes for NVMe devices nowadays? /sys/block/nvme0n1/uuid If so I'd be willing to create/send some sysfs rules for them. That'd be great! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [mpt3sas driver 06/10] mpt3sas: Added smp_affinity_enable module parameter.

2016-02-08 Thread Tomas Henzl
On 8.2.2016 07:01, Suganath Prabu Subramani wrote: > Hi Tomas, > Initially, we posted this patch with "zalloc_cpumassk_var" and Robert > has suggested to use "alloc_cpumask_var". Please check the below link. >

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

2016-02-08 Thread Nicholas A. Bellinger
On Mon, 2016-02-08 at 17:43 +, Himanshu Madhani wrote: > > > >So looking at this patch beyond the debugfs part, it does change where > >->check_initiator_node_acl() gets call during qlt_create_sess(). > > > >I assume this is related to new debugfs attribute, and these changes > >(plus others

Re: [PATCH-v4 0/5] Fix LUN_RESET active I/O + TMR handling

2016-02-08 Thread Nicholas A. Bellinger
Hi Himanshu, On Mon, 2016-02-08 at 23:27 +, Himanshu Madhani wrote: > > I am testing this series with with 4.5.0-rc2+ kernel and I am seeing issue > where trying to trigger > sg_reset with option of host/device/bus in loop at 120second interval > causes call stack. At this point > removing

[PATCH 13/23] scsi_dh_alua: Use workqueue for RTPG

2016-02-08 Thread Hannes Reinecke
The current ALUA device_handler has two drawbacks: - We're sending a 'SET TARGET PORT GROUP' command to every LUN, disregarding the fact that several LUNs might be in a port group and will be automatically switched whenever _any_ LUN within that port group receives the command. - Whenever a

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Keith Busch
On Mon, Feb 08, 2016 at 11:13:50AM +0100, Christoph Hellwig wrote: > On Mon, Feb 08, 2016 at 12:01:16PM +0200, Sagi Grimberg wrote: > > > >> Do we have defined sysfs attributes for NVMe devices nowadays? > > > > /sys/block/nvme0n1/uuid > > That's only supported for NVMe 1.1 and higher devices,

Re: [PATCH 3/3] add support for DWC UFS Host Controller

2016-02-08 Thread Joao Pinto
Hi Mark, On 2/8/2016 3:30 PM, Mark Rutland wrote: > On Mon, Feb 08, 2016 at 03:17:11PM +, Joao Pinto wrote: >> Hi Mark and Arnd, >> >> I am planning the v2 of this patch set. I have a doubt in the version >> compatibility strings... The core driver must support the UFS 2.0 controller >> and

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread James Bottomley
On Mon, 2016-02-08 at 08:32 +0100, Hannes Reinecke wrote: > On 02/08/2016 12:07 AM, James Bottomley wrote: > > On Sun, 2016-02-07 at 15:28 -0700, Jens Axboe wrote: > > > On 02/07/2016 09:04 AM, James Bottomley wrote: > > > > On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote: > > > > >

[PATCH 18/23] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning

2016-02-08 Thread Hannes Reinecke
Sending a 'REPORT TARGET PORT GROUP' command is a costly operation, as the array has to gather information about all ports. So instead of using RTPG to poll for a status update when a port is in transitioning we should be sending a TEST UNIT READY, and wait for the sense code to report success.

[PATCH 08/23] scsi_dh_alua: use unique device id

2016-02-08 Thread Hannes Reinecke
Use scsi_vpd_lun_id() to assign a unique device identification to the alua port group structure. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 55 +++--- 1 file changed, 50

[PATCH 02/23] scsi_dh_alua: separate out alua_stpg()

2016-02-08 Thread Hannes Reinecke
Separate out SET TARGET PORT GROUP functionality into a separate function alua_stpg(). Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 95 +++--- 1 file changed, 61 insertions(+),

[PATCH 12/23] scsi_dh_alua: remove 'rel_port' from alua_dh_data structure

2016-02-08 Thread Hannes Reinecke
The 'relative port' field is not used, and might get stale when the port group changes. So remove the field altogether. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 6 +- 1 file changed, 1

[PATCH 11/23] scsi_dh_alua: move optimize_stpg evaluation

2016-02-08 Thread Hannes Reinecke
When the optimize_stpg module option is set we should just set it once during port_group allocation. Doing so allows us to override it later with device specific settings. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke ---

[PATCH 06/23] scsi_dh_alua: allocate RTPG buffer separately

2016-02-08 Thread Hannes Reinecke
The RTPG buffer will only evaluated within alua_rtpg(), so we can allocate it locally there and avoid having to put it into the global structure. Reviewed-by: Ewan Milne Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke ---

[PATCH 07/23] scsi_dh_alua: Use separate alua_port_group structure

2016-02-08 Thread Hannes Reinecke
The port group needs to be a separate structure as several LUNs might belong to the same group. Reviewed-by: Christoph Hellwig Reviewed-by: Ewan Milne Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 181

[PATCH 03/23] scsi_dh_alua: Make stpg synchronous

2016-02-08 Thread Hannes Reinecke
The 'activate_complete' function needs to be executed after stpg has finished, so we can as well execute stpg synchronously and call the function directly. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c |

[PATCH 19/23] scsi_dh: add 'rescan' callback

2016-02-08 Thread Hannes Reinecke
If a device needs to be rescanned the device_handler might need to be rechecked, too. So add a 'rescan' callback to the device handler and call it upon scsi_rescan_device(). Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke ---

[PATCH 20/23] scsi: Add 'access_state' attribute

2016-02-08 Thread Hannes Reinecke
Add an 'access_state' attribute to struct scsi_device to display the asymmetric LUN access state. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_scan.c | 1 + drivers/scsi/scsi_sysfs.c | 49

[PATCH 05/23] scsi_dh_alua: switch to scsi_execute_req_flags()

2016-02-08 Thread Hannes Reinecke
All commands are issued synchronously, so no need to open-code scsi_execute_req_flags() anymore. And we can get rid of the static sense code structure element. scsi_execute_req_flags() will be setting REQ_QUIET and REQ_PREEMPT, but that is perfectly fine as we're evaluating and logging any errors

[PATCH 23/23] scsi_dh_alua: Update version to 2.0

2016-02-08 Thread Hannes Reinecke
Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c

[PATCH 16/23] scsi_dh_alua: Recheck state on unit attention

2016-02-08 Thread Hannes Reinecke
When we receive a unit attention code of 'ALUA state changed' we should recheck the state, as it might be due to an implicit ALUA state transition. This allows us to return NEEDS_RETRY instead of ADD_TO_MLQUEUE, allowing to terminate the retries after a certain time. At the same time a workqueue

Re: [PATCH 3/3] add support for DWC UFS Host Controller

2016-02-08 Thread Joao Pinto
Hi Mark and Arnd, I am planning the v2 of this patch set. I have a doubt in the version compatibility strings... The core driver must support the UFS 2.0 controller and this patch set includes a patch that adds 2.0 capabilities to it. The core driver can get from the controller's version and with

[PATCH 17/23] scsi_dh_alua: update all port states

2016-02-08 Thread Hannes Reinecke
When we read in the target port group state we should be updating all affected port groups, otherwise we risk running out of sync. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 36

[PATCH 21/23] scsi_dh_alua: use common definitions for ALUA state

2016-02-08 Thread Hannes Reinecke
scsi_proto.h now contains definitions for the ALUA state, so we don't have to carry them in the device handler. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 58 +- 1 file

[PATCH 01/23] scsi_dh_alua: Pass buffer as function argument

2016-02-08 Thread Hannes Reinecke
Pass in the buffer as a function argument for submit_rtpg(). Reviewed-by: Martin K. Petersen Reviewed-by: Christoph Hellwig Reviewed-by: Bart Van Assche Signed-off-by: Hannes Reinecke ---

[PATCH 09/23] scsi_dh_alua: simplify alua_initialize()

2016-02-08 Thread Hannes Reinecke
Rework alua_check_vpd() to use scsi_vpd_get_tpg() and move the port group selection into the function, too. With that we can simplify alua_initialize() to just call alua_check_tpgs() and alua_check_vpd(); Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke

[PATCH 00/23] ALUA device handler update, part II

2016-02-08 Thread Hannes Reinecke
as promised here is now the second part of my ALUA device handler update. This contains a major rework of the ALUA device handler as execution is moved onto a workqueue. This has the advantage that we avoid having to do multiple calls to the same LUN (as happens frequently when failing over a LUN

Re: [PATCH 3/3] add support for DWC UFS Host Controller

2016-02-08 Thread Mark Rutland
On Mon, Feb 08, 2016 at 03:17:11PM +, Joao Pinto wrote: > Hi Mark and Arnd, > > I am planning the v2 of this patch set. I have a doubt in the version > compatibility strings... The core driver must support the UFS 2.0 controller > and > this patch set includes a patch that adds 2.0

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Hannes Reinecke
On 02/08/2016 04:12 PM, Keith Busch wrote: > On Mon, Feb 08, 2016 at 11:13:50AM +0100, Christoph Hellwig wrote: >> On Mon, Feb 08, 2016 at 12:01:16PM +0200, Sagi Grimberg wrote: >>> Do we have defined sysfs attributes for NVMe devices nowadays? >>> >>> /sys/block/nvme0n1/uuid >> >> That's

Re: Question for Patch"libsas: fix "sysfs group not found" warnings at port teardown time"

2016-02-08 Thread John Garry
On 05/02/2016 21:33, Praveen Murali wrote: Hi Yijing, The fix was deemed inappropriate and I think the explanation provided by James was kind similar to what your observation is. Also, as far as I remember the consensus was that these error messages (sysfs group not found) are harmless at

[Bug 111381] mvsas 0.8.16 on Marvell 88SE9485 reports timeouts on load

2016-02-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=111381 --- Comment #4 from Gabriel A. Devenyi --- After much more research and reading, I believe I've found the root issue causing the communication timeouts to the disks. I have not changed any cables (other than reseating

T10 adds locally assigned UUID designation descriptor

2016-02-08 Thread Douglas Gilbert
Recently, in draft spc5r08, T10 added a locally assigned RFC 4122 UUID *** designation descriptor. That descriptor can now be returned for VPD page 0x83 (device identification) amongst others. It can be used anywhere SCSI needs a unique identifier expanding the previous set of preferred

Re: [PATCH 3/4] qla2xxx: Add DebugFS node for target sess list.

2016-02-08 Thread Himanshu Madhani
Hi Nic, On 2/6/16, 8:40 PM, "Nicholas A. Bellinger" wrote: >Hi Himanshu & Quinn, > >On Thu, 2016-02-04 at 11:45 -0500, Himanshu Madhani wrote: >> From: Quinn Tran >> >> #cat /sys/kernel/debug/qla2xxx/qla2xxx_31/tgt_sess >> qla2xxx_31 >> Port

re: megaraid_sas: Task management support

2016-02-08 Thread Dan Carpenter
Hello Sumit Saxena, The patch 31796fa184ee: "megaraid_sas: Task management support" from Jan 28, 2016, leads to the following static checker warning: drivers/scsi/megaraid/megaraid_sas_base.c:1788 megasas_update_sdev_properties() warn: if statement not indented

[PATCH 2/2] add support for DWC UFS Host Controller

2016-02-08 Thread Joao Pinto
This patch has the goal to add support for DesignWare UFS Controller specific operations and to add specific platform and pci drivers. Signed-off-by: Joao Pinto --- Changes v3->v4 (Arnd Bergmann and Mark Rutland): - SCSI_UFS_DWC_HOOKS is now silent and selected by the

Re: [v4 01/14] scsi: ufs-qcom: add number of lanes per direction

2016-02-08 Thread Rob Herring
On Thu, Feb 04, 2016 at 12:36:07PM +0200, Yaniv Gardi wrote: > Different platform may have different number of lanes > for the UFS link. > Add parameter to device tree specifying how many lanes > should be configured for the UFS link. > > Signed-off-by: Gilad Broner >

Re: T10 adds locally assigned UUID designation descriptor

2016-02-08 Thread James Bottomley
On Mon, 2016-02-08 at 12:33 -0500, Douglas Gilbert wrote: > Recently, in draft spc5r08, T10 added a locally assigned RFC 4122 > UUID *** designation descriptor. That descriptor can now be > returned for VPD page 0x83 (device identification) amongst others. > It can be used anywhere SCSI needs a

Re: [PATCH 00/23] ALUA device handler update, part II

2016-02-08 Thread Bart Van Assche
On 02/08/2016 06:37 AM, Hannes Reinecke wrote: And for the impatient I've pushed the entire patchset to my kernel repository at kernel.org: kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git alua-2.v5 Hello Hannes, I will try to free up some time to help with reviewing and testing this

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Christoph Hellwig
On Sun, Feb 07, 2016 at 03:07:21PM -0800, James Bottomley wrote: > > I run root-on-nvme on my laptop, and I haven't observed any problems. > > Me too apparently. It looks like this problem may be SUSE specific > unless another distro has enabled this. I can see why they would: you > do need

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Hannes Reinecke
On 02/08/2016 12:07 AM, James Bottomley wrote: > On Sun, 2016-02-07 at 15:28 -0700, Jens Axboe wrote: >> On 02/07/2016 09:04 AM, James Bottomley wrote: >>> On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote: Keith said it should be on by default, and I promised him to change

[PATCH v4 1/2] fixed typo in ufshcd-pltfrm

2016-02-08 Thread Joao Pinto
Fixed typo in ufshcd-pltfrm. Signed-off-by: Joao Pinto --- Changes v0->v4: - Nothing changed (just to keep up with patch set version). drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c

[PATCH v4 0/2] add support for DWC UFS Controller

2016-02-08 Thread Joao Pinto
The work consisted of: - Fixed typo in ufshcd-pltfrm.c - Tweak ufshcd.c for UFS 2.0 support - Implement ufshcd-dwc which contains all DWC HW specific code - Unipro attributes were added and new registers were added to the driver - Implement a ufs-dwc glue platform driver - Implement a ufs-dwc-pci

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Jens Axboe
On 02/07/2016 09:04 AM, James Bottomley wrote: On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote: Keith said it should be on by default, and I promised him to change it once we run into problems, which I guess this counts as. But just curious: what distro are you using? Upstream

Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

2016-02-08 Thread Hannes Reinecke
On 02/07/2016 05:04 PM, James Bottomley wrote: > On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote: >> Keith said it should be on by default, and I promised him to change >> it once we run into problems, which I guess this counts as. >> >> But just curious: what distro are you using?

Re: T10 adds locally assigned UUID designation descriptor

2016-02-08 Thread Douglas Gilbert
On 16-02-08 02:00 PM, James Bottomley wrote: On Mon, 2016-02-08 at 12:33 -0500, Douglas Gilbert wrote: Recently, in draft spc5r08, T10 added a locally assigned RFC 4122 UUID *** designation descriptor. That descriptor can now be returned for VPD page 0x83 (device identification) amongst others.

[Bug 111381] mvsas 0.8.16 on Marvell 88SE9485 reports timeouts on load with SMART commands

2016-02-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=111381 Gabriel A. Devenyi changed: What|Removed |Added Summary|mvsas 0.8.16 on Marvell |mvsas 0.8.16 on

RE: T10 adds locally assigned UUID designation descriptor

2016-02-08 Thread Knight, Frederick
To add a little more information, the reason for the "NO" votes was as follows: If a storage device implements this TODAY - and the only unique identifier in VPD page 0x83 is the UUID identifier, then, any existing shipping host will not find any unique identifier that it recognizes. That host