Re: QoS for iSCSI target?

On Thu, 2016-03-10 at 23:30 -0800, Christoph Hellwig wrote: > On Thu, Mar 10, 2016 at 04:24:25PM -0600, Chris Friesen wrote: > > Hi, > > > > I'm looking for information on whether the iSCSI target in the kernel offers > > any way to do QoS between traffic driven by different initiators. > > > >

Re: QoS for iSCSI target?

On Thu, Mar 10, 2016 at 04:24:25PM -0600, Chris Friesen wrote: > Hi, > > I'm looking for information on whether the iSCSI target in the kernel offers > any way to do QoS between traffic driven by different initiators. > > I'm trying to make sure that one initiator can't do a denial-of-service >

[PATCH-v4 04/14] tcm_qla2xxx: Convert to target_alloc_session usage

From: Nicholas Bellinger This patch converts existing qla2xxx target mode assignment of struct qla_tgt_sess related sid + loop_id values to use a callback via the new target_alloc_session API caller. Cc: Himanshu Madhani Cc: Quinn Tran

[PATCH-v4 13/14] tcm_fc: Convert to TARGET_SCF_ACK_KREF I/O + TMR krefs

From: Nicholas Bellinger This patch converts tcm_fc to modern TARGET_SCF_ACK_KREF usage for ft_queue_status(), and fixes ft_check_stop_free() to return transport_generic_free_cmd() for ->cmd_kref. It also converts TM request -> ft_send_tm() to use ACK_KREF, and update

[PATCH-v4 14/14] ib_srpt: Convert to percpu_ida tag allocation

From: Nicholas Bellinger This patch converts ib_srpt to use existing percpu_ida tag pre-allocation for struct srpt_send_ioctx. This allows ib_srpt to drop it's internal pre-allocation mechanisms with the extra spin_lock_irqsave, and use percpu_ida common code for doing

[PATCH-v4 05/14] tcm_fc: Convert to target_alloc_session usage

From: Nicholas Bellinger This patch converts tcm_fc target mode addition of tf_sess->hash to port_id hlist_head using the new alloc_session callback(). Cc: Vasu Dev Cc: Mark Rustad Cc: Robert Love

[PATCH-v4 12/14] xen-scsiback: Convert to TARGET_SCF_ACK_KREF I/O krefs

From: Nicholas Bellinger This patch converts xen-scsiback to modern TARGET_SCF_ACK_KREF usage for scsiback_cmd_done() callback path. It also also converts TMR -> scsiback_device_action() to use modern target_submit_tmr() code. Acked-by: Juergen Gross

[PATCH-v4 10/14] usb-gadget/tcm: Convert to TARGET_SCF_ACK_KREF I/O krefs

From: Nicholas Bellinger This patch drops struct usbg_cmd->kref internal kref-erence usage, for proper TARGET_SCF_ACK_KREF conversion. Tested-by: Andrzej Pietrasiewicz Cc: Sebastian Andrzej Siewior Cc: Felipe Balbi

[PATCH-v4 07/14] sbp-target: Conversion to percpu_ida tag pre-allocation

From: Nicholas Bellinger This patch converts sbp-target to use struct sbp_target_request descriptor tag pre-allocation using percpu_ida. (Fix sbp_mgt_get_req() IS_ERR failure checking - Dan Carpenter) (Add missing sbp_target_request tag memset - Chris Boot) Acked-by:

[PATCH-v4 08/14] sbp-target: Convert to TARGET_SCF_ACK_KREF I/O krefs

From: Nicholas Bellinger This patch converts sbp-target to modern TARGET_SCF_ACK_KREF usage for sbp_send_status() callback path, and drops the now obsolete sbp_free_request() failure path calls. Acked-by: Chris Boot Tested-by: Chris Boot

[PATCH-v4 09/14] usb-gadget/tcm: Conversion to percpu_ida tag pre-allocation

From: Nicholas Bellinger This patch converts usb-gadget target to use percpu_ida tag pre-allocation for struct usbg_cmd descriptor, in order to avoid fast-path struct usbg_cmd memory allocations. Note by default this is currently hardcoded to 128. Tested-by: Andrzej

[PATCH-v4 11/14] xen-scsiback: Convert to percpu_ida tag allocation

From: Nicholas Bellinger This patch converts xen-scsiback to use percpu_ida tag pre-allocation for struct vscsibk_pend descriptor, in order to avoid fast-path struct vscsibk_pend memory allocations. Note by default this is currently hardcoded to 128. (Add wrapper for

[PATCH-v4 06/14] ib_srpt: Convert to target_alloc_session usage

From: Nicholas Bellinger This patch converts ib_srpt internal assignments of se_node_acl and transport_register_session() to use the new alloc_session method. Cc: Vu Pham Cc: Sagi Grimberg Cc: Bart Van Assche

[PATCH-v4 00/14] target: alloc_session w/ percpu_ida+ACK_KREF conversions

From: Nicholas Bellinger Here is -v4 series code to add target_alloc_session() helper support using existing percpu-ida tag pre-allocation logic, along with a new (*callback)() for allowing fabric driver code to finish setup ahead of transport_register_session() I_T nexus

[PATCH-v4 02/14] target: Convert demo-mode only drivers to target_alloc_session

From: Christoph Hellwig This patch converts existing loopback, usb-gadget, and xen-scsiback demo-mode only fabric drivers to use the new target_alloc_session API caller. This includes adding a new alloc_session callback for fabric driver internal nexus pointer assignments. (Fixes

[PATCH-v4 01/14] target: Add target_alloc_session() helper function

From: Nicholas Bellinger Based on HCH's original patch, this adds a full version to support percpu-ida tag pre-allocation and callback function pointer into fabric driver code to complete session setup. Reported-by: Christoph Hellwig Cc: Sagi Grimberg

[PATCH-v4 03/14] vhost/scsi: Convert to target_alloc_session usage

From: Nicholas Bellinger This patch converts vhost/scsi pre-allocation of vhost_scsi_cmd descriptors to use the new alloc_session callback(). Acked-by: Michael S. Tsirkin Signed-off-by: Nicholas Bellinger --- drivers/vhost/scsi.c |

Re: [PATCH 1/1] sd: fix lbprz discard granularity as expected

On 11 March 2016 at 10:16, Martin K. Petersen wrote: > > Discard is advisory, the command will not get rejected. > In that case, if the granularity only act as some sort of "reference" but has no real "binding" to the actual behaviour, why would the kernel even "make

Re: [PATCH v8 00/17] add fixes, device quirks, error recovery,

> "Yaniv" == Yaniv Gardi writes: Yaniv> V8: fixed cyclic dependency by removing ufs_quirk.c that was Yaniv> previously added in V7 06/17, and moving its code into ufshcd.c Patch 6 is now different yet it retains Reviewed-by: tags from the previous version. These

Re: [PATCH 1/1] sd: fix lbprz discard granularity as expected

> "Tom" == Tom Yan writes: Tom> Nevertheless, I don't really quite get the sense of the original Tom> commit anyway. Isn't discard granularity the minimum size we can Tom> discard? In that case why would it have anything to do with "read Tom> zeroes"? On devices that

Re: [PATCH 1/1] sd: fix lbprz discard granularity as expected

> "Tom" == tom ty89 writes: Tom> According to its own comment, the discard granularity should fixed Tom> to the logical block size. However, the actual code has it Tom> hardcoded as 1 byte. Changing it to logical_block_size. Already fixed. -- Martin K. Petersen

Re: Fwd: [PATCH 1/1] sd: do not let LBPME bit stop the VPDs speak

> "Tom" == Tom Yan writes: Tom> Hmm, is it originated from: (2^32-1) - (2^32-1)%512 = 4294966784 Tom> bytes = 8388607 (512-byte) blocks = 0x7f Yes. Tom> What about SD_MAX_XFER_BLOCKS then? It is merely there to provide a theoretical upper max for the 16 and 32-byte

Re: Fwd: [PATCH 1/1] sd: do not let LBPME bit stop the VPDs speak

> "Tom" == Tom Yan writes: Tom, Tom> I just couldn't think of a case that the LBPME bit would actually Tom> indicates that the VPDs should not be used. It's merely bad Tom> implementation of Read Capacity (16), which doesn't practically Tom> stops the device from

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

> "Arnd" == Arnd Bergmann writes: Arnd> Looking through what other drivers do, I've found a couple of Arnd> patterns now. n particular, most use the SG_IO ioctl to pass down Arnd> commands from user space into a device specific command Arnd> queue. Have you looked at that

Re: [PATCH] scsi_sysfs: Fix typo in is_bin_visible()

> "Hannes" == Hannes Reinecke writes: Hannes> The test for the existence vpd_pg83 is inverted. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH] megaraid_sas: Don't issue kill adapter for MFI controllers in case of PD list DCMD failure

> "Sumit" == Sumit Saxena writes: Sumit> There are few MFI adapters which do not support Sumit> MR_DCMD_PD_LIST_QUERY so if MFI adapters fail this DCMD, it Sumit> should not be considered as FATAL and driver should not issue Sumit> kill adapter and set per

QoS for iSCSI target?

Hi, I'm looking for information on whether the iSCSI target in the kernel offers any way to do QoS between traffic driven by different initiators. I'm trying to make sure that one initiator can't do a denial-of-service attack against others. Does the kernel target have this sort of thing

Re: [PATCH] megaraid_sas: Don't issue kill adapter for MFI controllers in case of PD list DCMD failure

On 10.3.2016 11:14, Sumit Saxena wrote: > There are few MFI adapters which do not support MR_DCMD_PD_LIST_QUERY so > if MFI adapters fail this DCMD, it should not be considered as FATAL and > driver should not issue kill adapter and set per controller's instance > variable- pd_list_not_supported

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

On Thursday 10 March 2016, Arnd Bergmann wrote: > On Wednesday 09 March 2016, yga...@codeaurora.org wrote: > > Any userspace application can be a tool. > > We already implemented and used a user space application, that sent > > queries to the UFS devices in order to get information and

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

On Thu, Mar 10, 2016 at 06:48:54PM -, yga...@codeaurora.org wrote: > > On Thu, Mar 10, 2016 at 04:29:55PM -, yga...@codeaurora.org wrote: > >> > On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: > >> >> > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

> On Thu, Mar 10, 2016 at 04:29:55PM -, yga...@codeaurora.org wrote: >> > On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: >> >> > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org >> wrote: >> >> >> > On Wed, Mar 09, 2016 at 07:09:49PM -,

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

On Wednesday 09 March 2016, yga...@codeaurora.org wrote: > Any userspace application can be a tool. > We already implemented and used a user space application, that sent > queries to the UFS devices in order to get information and descriptors. > Not only ioctl interface is a useful way to interact

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

On Thu, Mar 10, 2016 at 04:29:55PM -, yga...@codeaurora.org wrote: > > On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: > >> > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: > >> >> > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

> On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: >> > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: >> >> > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org >> wrote: >> >> >> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: > >> > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: > >> >> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: >

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

> On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: >> > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: >> >> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: >> >> >> This patch exposes the ioctl interface for UFS driver via SCSI >>

[PATCH v8 05/17] scsi: ufs: add support to read device and string descriptors

This change adds support to read device descriptor and string descriptor from a UFS device Reviewed-by: Gilad Broner Reviewed-by: Hannes Reinecke Signed-off-by: Raviv Shvili Signed-off-by: Yaniv Gardi ---

[PATCH v8 06/17] scsi: ufs: separate device and host quirks

Currently we use the host quirks mechanism in order to handle both device and host controller quirks. In order to support various of UFS devices we should separate handling the device quirks from the host controller's. Reviewed-by: Gilad Broner Reviewed-by: Hannes

[PATCH v8 14/17] scsi: ufs: add device quirk delay before putting UFS rails in LPM

We put the UFS device in sleep state & UFS link in hibern8 state during runtime suspend. After this we put all the UFS rails in low power modes immediately but it seems some devices may still draw more than sleep current from UFS rails (especially from VCCQ rail) at-least for 500us. To avoid this

[PATCH v8 09/17] scsi: ufs: add error recovery after DL NAC error

Some vendor's UFS device sends back to back NACs for the DL data frames causing the host controller to raise the DFES error status. Sometimes such UFS devices send back to back NAC without waiting for new retransmitted DL frame from the host and in such cases it might be possible the Host UniPro

[PATCH v8 04/17] scsi: ufs: verify hba controller hce reg value

Sometimes due to hw issues it takes some time to the host controller register to update. In order to verify the register has updated, a polling is done until its value is set. In addition the functions ufshcd_hba_stop() and ufshcd_wait_for_register() was updated with an additional input

[PATCH v8 12/17] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time

Optimal values of local UniPro parameters like PA_Hibern8Time & PA_TActivate can help reduce the hibern8 exit latency. If both host and device supports UniPro ver1.6 or later, these parameters will be automatically tuned during link startup itself. But if either host or device doesn't support

[PATCH v8 00/17] add fixes, device quirks, error recovery,

V8: fixed cyclic dependency by removing ufs_quirk.c that was previously added in V7 06/17, and moving its code into ufshcd.c V7: updated patches with "Reviewed-by" and "Acked-by" tags V6: as per comment, patch 15/15 in V5 was divided into 3 patches in V6 V5: as per comment, patch 05/14 in V4,

[PATCH v8 17/17] scsi: ufs-qcom: add printouts of testbus debug registers

This change adds printouts of testbus and debug registers. Reviewed-by: Gilad Broner Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 77 + drivers/scsi/ufs/ufs-qcom.h | 9 ++ 2 files

[PATCH v8 07/17] scsi: ufs: disable vccq if it's not needed by UFS device

Some UFS devices don't require VCCQ rail for device operations hence this change adds support to recognize such devices and remove vote for the unused VCCQ rail. Reviewed-by: Hannes Reinecke Signed-off-by: Subhash Jadavani Signed-off-by: Yaniv Gardi

[PATCH v8 13/17] scsi: ufs: fix leakage during link off state

Currently when we try to put the link in off/disabled state during suspend, it seems link is not being kept in low power mode. This patch fixes the issue by putting the link in hibern8 first (so device also puts the link in low power mode) and then stop the host controller. Reviewed-by: Hannes

[PATCH v8 15/17] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup

Some UFS devices (and may be host) have issues if LCC is enabled. So we are setting PA_Local_TX_LCC_Enable to 0 before link startup which will make sure that both host and device TX LCC are disabled once link startup is completed. Reviewed-by: Gilad Broner Signed-off-by:

[PATCH v8 03/17] scsi: ufs: implement scsi host timeout handler

A race condition exists between request requeueing and scsi layer error handling: When UFS driver queuecommand returns a busy status for a request, it will be requeued and its tag will be freed and set to -1. At the same time it is possible that the request will timeout and scsi layer will start

Re: [PATCH v7 06/17] scsi: ufs: separate device and host quirks

Martin, the only way i can avoid the circular dependency is to move the routines from ufs_quirks.c into ufshcd.c. i will upload V8 soon thanks, Yaniv >> "Yaniv" == Yaniv Gardi writes: > > Yaniv> Currently we use the host quirks mechanism in order to handle > Yaniv>

[PATCH v8 08/17] scsi: ufs: make error handling bit faster

UFS driver's error handler forcefully tries to clear all the pending requests. For each pending request in the queue, it waits 1 sec for it to get cleared. If we have multiple requests in the queue then it's possible that we might end up waiting for those many seconds before resetting the host.

[PATCH v8 16/17] scsi: ufs-qcom: enable/disable the device ref clock

This change enables the device ref clock before changing to HS mode and disables it if entered to PWM mode. Reviewed-by: Gilad Broner Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 12 drivers/scsi/ufs/ufshcd.h | 9

[PATCH v8 01/17] scsi: ufs-qcom: add number of lanes per direction

Different platform may have different number of lanes for the UFS link. Add parameter to device tree specifying how many lanes should be configured for the UFS link. Reviewed-by: Hannes Reinecke Acked-by: Rob Herring Signed-off-by: Gilad Broner

[PATCH v8 10/17] scsi: ufs: add retry for query descriptors

Query commands have 100ms timeout and it may timeout if they are issued in parallel to ongoing read/write SCSI commands, this change adds the retry (max: 10) in case command timeouts. Reviewed-by: Hannes Reinecke Signed-off-by: Subhash Jadavani

[PATCH v8 11/17] scsi: ufs: handle non spec compliant bkops behaviour by device

We are seeing that some devices are raising the urgent bkops exception events even when BKOPS status doesn't indicate performace impacted or critical. Handle these device by determining their urgent bkops status at runtime. Reviewed-by: Hannes Reinecke Signed-off-by: Subhash

[PATCH v8 02/17] scsi: ufs: avoid spurious UFS host controller interrupts

When control reaches to Linux UFS driver during UFS boot mode, UFS host controller interrupt status/enable registers may have left over settings. In order to avoid any spurious interrupts due to these left overs, it's important to clear these interrupt status/enable registers before enabling UFS

Re: [PATCH] scsi_sysfs: Fix typo in is_bin_visible()

Reviewed-by:Laurence Oberman lober...@redhat.com> Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Ewan Milne" To: "Hannes Reinecke" Cc: "Martin K. Petersen"

Re: [PATCH] megaraid_sas: Don't issue kill adapter for MFI controllers in case of PD list DCMD failure

On Thu, 2016-03-10 at 02:14 -0800, Sumit Saxena wrote: > There are few MFI adapters which do not support MR_DCMD_PD_LIST_QUERY so > if MFI adapters fail this DCMD, it should not be considered as FATAL and > driver should not issue kill adapter and set per controller's instance > variable-

Re: [PATCH] scsi_sysfs: Fix typo in is_bin_visible()

On Thu, 2016-03-10 at 11:25 +0100, Hannes Reinecke wrote: > The test for the existence vpd_pg83 is inverted. > > Fixes: 7e47976bcff ("scsi_sysfs: add 'is_bin_visible' callback") > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_sysfs.c | 2 +- > 1 file changed, 1

Re: [PATCH] megaraid_sas: Don't issue kill adapter for MFI controllers in case of PD list DCMD failure

On 03/10/2016 11:14 AM, Sumit Saxena wrote: > There are few MFI adapters which do not support MR_DCMD_PD_LIST_QUERY so > if MFI adapters fail this DCMD, it should not be considered as FATAL and > driver should not issue kill adapter and set per controller's instance > variable-

Lainatarjous

Gloucestershire Credit Union on luotonanto yritys, joka tekee lainat ja rahoituspalveluja yrityksille, yhteistyöhön yhteisöjä, sijoittajat, liiketoiminta miehet ja naiset, velallisten myös rahasto projekti e.t.c Tarvitsetko lainaa 2% korolla? Alkaen € 10,000.00 sen € 500,000.000.00 min Max.

Re: [PATCH] scsi_sysfs: Fix typo in is_bin_visible()

On Thu, Mar 10, 2016 at 11:25:26AM +0100, Hannes Reinecke wrote: > The test for the existence vpd_pg83 is inverted. > > Fixes: 7e47976bcff ("scsi_sysfs: add 'is_bin_visible' callback") > Signed-off-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --

Re: [PATCH 1/1] sd: do not let LBPME bit stop the VPDs speak

On 10 March 2016 at 12:36, Tom Yan wrote: > > Both `blkdiscard` with a patched kernel and `sg_unmap` appeared to > have gone well (checked with `hexdump`). > Actually, `blkdiscard` didn't quite actually go well. It seems last time it just ended quickly with only error on

[PATCH] scsi_sysfs: Fix typo in is_bin_visible()

The test for the existence vpd_pg83 is inverted. Fixes: 7e47976bcff ("scsi_sysfs: add 'is_bin_visible' callback") Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_sysfs.c

[PATCH] megaraid_sas: Don't issue kill adapter for MFI controllers in case of PD list DCMD failure

There are few MFI adapters which do not support MR_DCMD_PD_LIST_QUERY so if MFI adapters fail this DCMD, it should not be considered as FATAL and driver should not issue kill adapter and set per controller's instance variable- pd_list_not_supported so that same variable can be used inside

Re: [PATCH 1/1] sd: fix lbprz discard granularity as expected

Nevertheless, I don't really quite get the sense of the original commit anyway. Isn't discard granularity the minimum size we can discard? In that case why would it have anything to do with "read zeroes"? Suppose we are handling a device reports a discard granularity of 4096 bytes, while logical

[PATCH 1/1] sd: fix lbprz discard granularity as expected

From: Tom Yan According to its own comment, the discard granularity should fixed to the logical block size. However, the actual code has it hardcoded as 1 byte. Changing it to logical_block_size. Signed-off-by: Tom Yan diff --git a/drivers/scsi/sd.c

Fwd: [PATCH 1/1] sd: do not let LBPME bit stop the VPDs speak

Hmm, is it originated from: (2^32-1) - (2^32-1)%512 = 4294966784 bytes = 8388607 (512-byte) blocks = 0x7f for the byte count (of a bio?) is limited by a 32-bit representation (2^32-1) as well just like the block count in the two scsi commands? What about SD_MAX_XFER_BLOCKS then? On 10

Fwd: [PATCH 1/1] sd: do not let LBPME bit stop the VPDs speak

The outputs were made with an SSD that supports TRIM plugged in: [tom@localhost ~]$ sudo smartctl --identify=wb /dev/sdc | grep -i trim 69 14 1 Deterministic data after trim supported 69 5 1 Trimmed LBA range(s) returning zeroed data supported 169 0