Re: [PATCHv2 09/14] libata: fixup ZAC device disabling

On 04/13/2016 08:09 PM, Tejun Heo wrote: > On Tue, Apr 12, 2016 at 08:47:53AM +0200, Hannes Reinecke wrote: >> libata device disabling is ... curious. So add the correct >> definitions that we can disable ZAC devices properly. > > Fold into an earlier patch? > That earlier patch would be commit

Re: [PATCHv2 06/14] libata: Check log page directory before accessing pages

On 04/13/2016 08:08 PM, Tejun Heo wrote: > On Tue, Apr 12, 2016 at 08:47:50AM +0200, Hannes Reinecke wrote: >> +log_pages = get_unaligned_le16(>sector_buf[log_index]); >> +if (!log_pages) { >> +ata_dev_warn(dev, >> + "NCQ Send/Recv Log not supported\n");

Re: [PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT

On 04/13/2016 08:07 PM, Tejun Heo wrote: > On Tue, Apr 12, 2016 at 08:47:49AM +0200, Hannes Reinecke wrote: >> Recent devices can use NCQ encapsulation for READ LOG DMA EXT, >> so we should be using it if available. > > Does this have any actual benefits than being new and shiny? It's > being

[PATCH V3 00/29] bitops: add parity functions

From: Zhaoxiu Zeng When I do "grep parity -r linux", I found many parity calculations distributed in many drivers. This patch series does: 1. provide generic and architecture-specific parity calculations 2. remove drivers' local parity calculations, use bitops'

[PATCH V3 18/29] scsi: use parity32 in isci's phy

From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- drivers/scsi/isci/phy.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c index cb87b2e..a06aff6 100644 ---

Re: [-next] BUG_ON in scsi_target_destroy()

Hello, On (04/13/16 08:14), James Bottomley wrote: [..] > How about good grief no! A device with multiple targets will get it's > lists screwed with this > > The STARGET_REMOVE state you added only applies to the case we're > trying to kill a target. In the natural operation case, which is

Re: [Lsf] LSF/MM Schedule and improving discard support

On 16-04-13 01:30 PM, Darrick J. Wong wrote: On Wed, Apr 13, 2016 at 09:51:04AM -0700, James Bottomley wrote: On Wed, 2016-04-13 at 09:29 -0700, Bart Van Assche wrote: On 04/13/2016 09:21 AM, Martin K. Petersen wrote: From a filesystem/ioctl perspective, BLKDISCARD is a hint. We should not

Gratulace vítìz.

Gratulace vítìz. Vᚠemailem adresa právì vyhrál € 150,000.00 (sto padesát tisíc eur). V Uplift mezinárodní charitativní program. Ref No: Sp / 229/ 0-01 / 07/5 - 02 / ES. Lucky No: 9/11/13/24/40. Pro více informací a pohledávky postupu kontaktem; CAPITAL CLAIM AGENCY Mr. John Carlos. Email:

[PATCH] pm80xx: Remove bogus address masking in pm8001_ioremap()

From: David Daney It is unclear what the original intent of the masking was, but it is clearly incorrect to truncate a physical address before calling ioremap(). On systems where there are valid physical address bits above bit-31 (arm64 for example) the result is an

Re: [PATCHv2 13/14] libata: support device-managed ZAC devices

On Tue, Apr 12, 2016 at 1:47 PM, Hannes Reinecke wrote: > Device-managed ZAC devices just set the zoned capabilities field > in INQUIRY byte 69 (cf ACS-4). This corresponds to the 'zoned' > field in the block device characteristics VPD page. > As this is only defined in SPC-5/SBC-4

[PATCHv2 1/2] target: make target db location configurable

This commit adds the read-write attribute "dbroot", in the top-level CONFIGFS (core) target directory, normally /sys/kernel/config/target. This attribute defaults to "/var/target" but can be changed by writing a new pathname string to it. Changing this attribute is only allowed when no fabric

[PATCHv2 0/2] target: make location of /var/targets configurable

These patches make the location of "/var/target" configurable, though it still defauls to "/var/target". This "target database directory" can only be changed after the target_core_mod loads but before any fabric drivers are loaded, and must be the pathname of an existing directory. This

[PATCH 2/2] target: use new "dbroot" target attribute

This commit updates the target core ALUA and PR modules to use the new "dbroot" attribute instead of assuming the target database is in "/var/target". Signed-off-by: Lee Duncan --- drivers/target/target_core_alua.c | 6 +++--- drivers/target/target_core_pr.c | 2 +- 2 files

[PATCH 01/42] block/fs/drivers: remove rw argument from submit_bio

From: Mike Christie This has callers of submit_bio/submit_bio_wait set the bio->bi_rw instead of passing it in. This makes that use the same as generic_make_request and how we set the other bio fields. v5: 1. Missed crypto fs submit_bio_wait call. v2: 1. Set bi_rw instead

[PATCH 04/42] fs: have submit_bh users pass in op and flags separately

From: Mike Christie This has submit_bh users pass in the operation and flags separately, so submit_bh_wbc can setup bio->bi_op and bio-bi_rw on the bio that is submitted. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig ---

[PATCH 06/42] direct-io: set bi_op to REQ_OP

From: Mike Christie This patch has the dio code set the bio bi_op to a REQ_OP and bio op_flags to rq_flag_bits. It also begins to convert btrfs's dio_submit_t because of the dio submit_io callout use. In the btrfs_submit_direct change, I OR'd the op and flag back together.

[PATCH 00/42] v5: separate operations from flags in the bio/request structs

point, we abused them so much we just made cmd_flags 64 bits, so we could add more. The following patches seperate the operation (read, write discard, flush, etc) from cmd_flags/bi_rw. This patchset was made against linux-next from today April 13 (git tag next-20160413). I put a git tree here:

[PATCH 05/42] fs: have ll_rw_block users pass in op and flags separately

From: Mike Christie This has ll_rw_block users pass in the operation and flags separately, so ll_rw_block can setup bio->bi_op and bio-bi_rw on the bio that is submitted. v2: 1. Fix for kbuild error in ll_rw_block comments. Signed-off-by: Mike Christie

[PATCH 09/42] btrfs: update __btrfs_map_block for bi_op transition

From: Mike Christie We no longer pass in a bitmap of rq_flag_bits bits to __btrfs_map_block. It will always be a REQ_OP, or the btrfs specific REQ_GET_READ_MIRRORS, so this drops the bit tests. Signed-off-by: Mike Christie Reviewed-by: Christoph

[PATCH 02/42] block: add REQ_OP definitions and bi_op/op fields

From: Mike Christie The following patches separate the operation (write, read, discard, etc) from the rq_flag_bits flags. This patch adds definitions for request/bio operations, adds fields to the request/bio to set them, and some temporary compat code so the kernel/modules

[PATCH 07/42] btrfs: have submit_one_bio users setup bio bi_op

From: Mike Christie This patch has btrfs's submit_one_bio callers set the bio->bi_op to a REQ_OP and the bi_rw to rq_flag_bits. The next patches will continue to convert btrfs, so submit_bio_hook and merge_bio_hook related code will be modified to take only the bio. I did

[PATCH 15/42] mpage: set bi_op to REQ_OP

From: Mike Christie This patch has mpage.c use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- fs/mpage.c | 41 + 1 file

[PATCH 08/42] btrfs: set bi_op tp REQ_OP

From: Mike Christie This patch has btrfs use the bio bi_op for REQ_OP and bi_rw for rq_flag_bits. v5: - Misset bi_rw to REQ_OP_WRITE in finish_parity_scrub Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig ---

[PATCH 14/42] hfsplus: set bi_op to REQ_OP

From: Mike Christie This patch has hfsplus use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- fs/hfsplus/hfsplus_fs.h | 2 +- fs/hfsplus/part_tbl.c | 5 +++--

[PATCH 16/42] nilfs: set bi_op to REQ_OP

From: Mike Christie This patch has nilfs use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- fs/nilfs2/segbuf.c | 18 ++ 1 file changed, 10

[PATCH 17/42] ocfs2: set bi_op to REQ_OP

From: Mike Christie This patch has ocfs2 use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- fs/ocfs2/cluster/heartbeat.c | 11 +++ 1 file changed, 7

[PATCH 19/42] dm: set bi_op to REQ_OP

From: Mike Christie This patch has dm use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- drivers/md/dm-bufio.c | 8 +++--- drivers/md/dm-crypt.c

[PATCH 21/42] bcache: set bi_op to REQ_OP

From: Mike Christie This patch has bcache use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- drivers/md/bcache/btree.c | 2 ++ drivers/md/bcache/debug.c |

[PATCH 23/42] md/raid: set bi_op to REQ_OP

From: Mike Christie This patch has md use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- drivers/md/bitmap.c | 2 +- drivers/md/dm-raid.c | 5 +++--

[PATCH 22/42] drbd: set bi_op to REQ_OP

From: Mike Christie This patch has drbd use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Lars and Philip, I might have split this patch up a little weird. The block layer has compat so you can set either bi_rw or bi_op. This patch handles setting up the bio in

[PATCH 13/42] xfs: set bi_op to REQ_OP

From: Mike Christie This patch has xfs use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig Acked-by: Dave Chinner --- fs/xfs/xfs_aops.c | 3 +--

[PATCH 24/42] xen: set bi_op to REQ_OP

From: Mike Christie This patch has the xen block driver use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- drivers/block/xen-blkback/blkback.c | 29

[PATCH 18/42] pm: set bi_op to REQ_OP

From: Mike Christie This patch has the pm code use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- kernel/power/swap.c | 31 +++ 1 file

[PATCH 10/42] btrfs: use bio fields for op and flags

From: Mike Christie The bio bi_op and bi_rw is now setup, so there is no need to pass around the rq_flag_bits bits too. btrfs users should should access the bio. v2: 1. Fix merge_bio issue where instead of removing rw/op argument I passed it in again to the merge_bio

[PATCH 11/42] f2fs: set bi_op to REQ_OP

From: Mike Christie This patch has f2fs use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- fs/f2fs/checkpoint.c| 10 ++ fs/f2fs/data.c |

[PATCH 20/42] dm: pass dm stats data dir instead of bi_rw

From: Mike Christie It looks like dm stats cares about the data direction (READ vs WRITE) and does not need the bio/request flags. Commands like REQ_FLUSH, REQ_DISCARD and REQ_WRITE_SAME are currently always set with REQ_WRITE, so the extra check for REQ_DISCARD in

[PATCH 12/42] gfs2: set bi_op to REQ_OP

From: Mike Christie This patch has gfs2 use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- fs/gfs2/log.c| 8 fs/gfs2/lops.c | 12 +++-

[PATCH 27/42] block: prepare request creation/destruction code to use REQ_OPs

From: Mike Christie This patch prepares *_get_request/*_put_request and freed_request, to use separate variables for the operation and flags. In the next patches the struct request users will be converted like was done for bios. request->op will be used for the REQ_OP and

[PATCH 28/42] block: prepare mq request creation to use REQ_OPs

From: Mike Christie This patch modifies the blk mq request creation code to use separate variables for the operation and flags, because in the the next patches the struct request users will be converted like was done for bios. request->op will be used for the REQ_OP and

[PATCH 35/42] blktrace: get op from req->op/bio->bi_op

From: Mike Christie The bio and request structs now store the operation in bio->bi_op/request->op. This patch has blktrace use that field instead of bi_rw/cmd_flags. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig ---

[PATCH 34/42] drivers: set request op to REQ_OP

From: Mike Christie This patch has the block drivers use the request->op for REQ_OP operations and cmd_flags for rq_flag_bits. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- drivers/block/loop.c | 6 +++---

[PATCH 25/42] target: set bi_op to REQ_OP

From: Mike Christie This patch has the target modules use bio->bi_op for REQ_OPs and rq_flag_bits to bio->bi_rw. Signed-off-by: Mike Christie Acked-by: Nicholas Bellinger Reviewed-by: Christoph Hellwig ---

[PATCH 32/42] block: convert is_sync helpers to use REQ_OPs.

From: Mike Christie This patch converts the is_sync helpers to use separate variables for the operation and flags. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- block/blk-core.c | 6 +++--- block/blk-mq.c

[PATCH 33/42] block: convert rq_data_dir helper to use REQ_OPs

From: Mike Christie The request->op field is now always setup up with a REQ_OP. This patch has the rq_data_dir helper convert the operation to a WRITE or READ direction based on that. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig

[PATCH 30/42] blkg_rwstat: separate op from flags

From: Mike Christie The bio and request operation and flags are going to be separate definitions, so we cannot pass them in as a bitmap. This patch converts the blkg_rwstat code and its caller, cfq, to pass in the values separately. Signed-off-by: Mike Christie

[PATCH 29/42] block: prepare elevator to use REQ_OPs.

From: Mike Christie This patch converts the elevator code to use separate variables for the operation and flags, and to check request->op for the REQ_OP. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- block/blk-core.c

[PATCH 31/42] block: convert merge/insert code to check for REQ_OPs.

From: Mike Christie This patch converts the block layer merging code to use separate variables for the operation and flags, and to check request->op for the REQ_OP. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig ---

[PATCH 37/42] block, fs, drivers: do use bi_rw/cmd_flags for REQ_OPs.

From: Mike Christie We no longer use the bio->bi_rw and request->cmd_flags field for REQ_OPs: REQ_WRITE, REQ_DISCARD, REQ_WRITE_SAME, so this patch stops checking for them in bi_rw/cmd_flags and also removes the related compat code. v2: 1. Remove compat code in

[PATCH 26/42] block: copy bio op to request op

From: Mike Christie The bio users should now always be setting up the bio->bi_op. This patch has us copy that to the struct request op field. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- block/blk-core.c | 2 ++ 1 file

[PATCH 38/42] block, fs: remove old REQ definitions.

From: Mike Christie We no longer use REQ_WRITE. REQ_WRITE_SAME and REQ_DISCARD, so this patch removes them. Signed-off-by: Mike Christie Reviewed-by: Christoph Hellwig --- include/linux/blk_types.h | 21 ++---

[PATCH 42/42] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH

From: Mike Christie To avoid confusion between REQ_OP_FLUSH, which is handled by request_fn drivers, and upper layers requesting the block layer perform a flush sequence along with possibly a WRITE, this patch renames REQ_FLUSH to REQ_PREFLUSH. Signed-off-by: Mike Christie

[PATCH 40/42] block, drivers: add REQ_OP_FLUSH operation

From: Mike Christie This adds a REQ_OP_FLUSH operation that is sent to request_fn based drivers by the block layer's flush code, instead of sending requests with the request->cmd_flags REQ_FLUSH bit set. For the following 3 flush related patches, I have not tested every

[PATCH 39/42] block: shrink bio/request fields

From: Mike Christie bi_op only needed to be a int for temp compat reasons, so this patch shrinks it to u8. There is no need for bi_rw to be so large now, so that is reduced to a unsigned int and bi_ioprio is just put in its own field. Signed-off-by: Mike Christie

[PATCH 41/42] block: use QUEUE flags instead of flush_flags to test for flush support

From: Mike Christie The last patch added a REQ_OP_FLUSH for request_fn drivers and the next patch renames REQ_FLUSH to REQ_PREFLUSH which will be used by file systems and make_request_fn drivers so they can send a write/flush combo. Jens's cleanup in: block: add ability to

[PATCH 36/42] ide cd: do not set REQ_WRITE on requests.

From: Mike Christie The block layer will set the correct READ/WRITE operation flags/fields when creating a request, so there is not need for drivers to set the REQ_WRITE flag. This patch is compile tested only. Signed-off-by: Mike Christie

[PATCH 03/42] block, fs, mm, drivers: set bi_op to REQ_OP

From: Mike Christie This patch converts the simple bi_rw use cases in the block, drivers, mm and fs code to set the bio->bi_op to a REQ_OP. These should be simple one liner cases, so I just did them in one patch. The next patches handle the more complicated cases in a

Re: [PATCHv2 06/14] libata: Check log page directory before accessing pages

On Tue, Apr 12, 2016 at 08:47:50AM +0200, Hannes Reinecke wrote: > + log_pages = get_unaligned_le16(>sector_buf[log_index]); > + if (!log_pages) { > + ata_dev_warn(dev, > + "NCQ Send/Recv Log not supported\n"); Shouldn't this be an info message?

Re: [PATCHv2 09/14] libata: fixup ZAC device disabling

On Tue, Apr 12, 2016 at 08:47:53AM +0200, Hannes Reinecke wrote: > libata device disabling is ... curious. So add the correct > definitions that we can disable ZAC devices properly. Fold into an earlier patch? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCHv2 05/14] libata: NCQ Encapsulation for READ LOG DMA EXT

On Tue, Apr 12, 2016 at 08:47:49AM +0200, Hannes Reinecke wrote: > Recent devices can use NCQ encapsulation for READ LOG DMA EXT, > so we should be using it if available. Does this have any actual benefits than being new and shiny? It's being called from EH path where we know that no other

Re: [Lsf] LSF/MM Schedule and improving discard support

On Wed, Apr 13, 2016 at 09:51:04AM -0700, James Bottomley wrote: > On Wed, 2016-04-13 at 09:29 -0700, Bart Van Assche wrote: > > On 04/13/2016 09:21 AM, Martin K. Petersen wrote: > > > From a filesystem/ioctl perspective, BLKDISCARD is a hint. We > > > should not be > > > rounding off or aligning

Re: [Lsf] LSF/MM Schedule and improving discard support

> "Bart" == Bart Van Assche writes: Bart> And if so, how should this code behave and if sector and/or Bart> nr_sectors is not a multiple of sdp->sector_size? As one can see Bart> the above code rounds down sector and nr_sectors while converting Bart> from sectors

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

On Wed, Apr 13, 2016 at 09:55:09AM -0700, James Bottomley wrote: > On Wed, 2016-04-13 at 10:15 -0500, Josh Poimboeuf wrote: > > On Wed, Apr 13, 2016 at 07:36:07AM -0500, Josh Poimboeuf wrote: > > > On Wed, Apr 13, 2016 at 02:12:25PM +0200, Denys Vlasenko wrote: > > > > On 04/13/2016 05:36 AM, Josh

Re: [Lsf] LSF/MM Schedule and improving discard support

On 04/13/2016 09:43 AM, Martin K. Petersen wrote: "Bart" == Bart Van Assche writes: Bart> Today if a BLKDISCARD ioctl passes a non-aligned start and/or end Bart> sector to the kernel then the block layer will submit invalid Bart> (non-aligned) REQ_DISCARD requests

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

On Wed, 2016-04-13 at 10:15 -0500, Josh Poimboeuf wrote: > On Wed, Apr 13, 2016 at 07:36:07AM -0500, Josh Poimboeuf wrote: > > On Wed, Apr 13, 2016 at 02:12:25PM +0200, Denys Vlasenko wrote: > > > On 04/13/2016 05:36 AM, Josh Poimboeuf wrote: > > > > On Thu, Feb 04, 2016 at 08:45:35PM +0100, Denys

Re: [Lsf] LSF/MM Schedule and improving discard support

On Wed, 2016-04-13 at 09:29 -0700, Bart Van Assche wrote: > On 04/13/2016 09:21 AM, Martin K. Petersen wrote: > > From a filesystem/ioctl perspective, BLKDISCARD is a hint. We > > should not be > > rounding off or aligning anything. > > Hello Martin, > > Today if a BLKDISCARD ioctl passes a

Re: [Lsf] LSF/MM Schedule and improving discard support

> "Bart" == Bart Van Assche writes: Bart> Today if a BLKDISCARD ioctl passes a non-aligned start and/or end Bart> sector to the kernel then the block layer will submit invalid Bart> (non-aligned) REQ_DISCARD requests to the block driver the ioctl Bart> applies to.

Re: LSF/MM Schedule and improving discard support

On 04/13/2016 09:21 AM, Martin K. Petersen wrote: From a filesystem/ioctl perspective, BLKDISCARD is a hint. We should not be rounding off or aligning anything. Hello Martin, Today if a BLKDISCARD ioctl passes a non-aligned start and/or end sector to the kernel then the block layer will

Re: libiscsi: Use scsi helper to set information descriptor

On Wed, Apr 13, 2016 at 05:53:08PM +0300, Sagi Grimberg wrote: > Hey Dan, > > >Hello Sagi Grimberg, > > > >The patch a73c2a2f9123: "libiscsi: Use scsi helper to set information > >descriptor" from Jul 15, 2015, leads to the following static checker > >warning: > > > >

Re: [PATCH v2 01/16] iscsi-target: add callback to alloc and free PDU

On Wed, Apr 13, 2016 at 12:56:25PM +0300, Sagi Grimberg wrote: > > >>On 09/04/16 16:11, Varun Prakash wrote: > >>>Add two callbacks to struct iscsit_transport - > >>> > >>>1. void *(*iscsit_alloc_pdu)() > >>>iscsi-target uses this callback for > >>>iSCSI PDU allocation. > >>> > >>>2. void

Re: LSF/MM Schedule and improving discard support

> "Bart" == Bart Van Assche writes: Bart, Bart> There is something that should be discussed further, namely what Bart> the behavior of the BLKDISCARD and BLKSECDISCARD ioctls should be Bart> if the start and/or end sectors are not aligned on a discard Bart>

Re: LSF/MM Schedule and improving discard support

(+ LSF mailing list) On 04/07/2016 08:51 AM, James Bottomley wrote: On Thu, 2016-04-07 at 08:39 -0700, Bart Van Assche wrote: Some time ago I proposed to discuss how to improve discard support during the LSF/MM (http://thread.gmane.org/gmane.linux.scsi/110048). I would appreciate it if this

Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

On Wed, Apr 13, 2016 at 10:48:42AM -0400, William Breathitt Gray wrote: > On Wed, Apr 13, 2016 at 04:38:38PM +0200, Ingo Molnar wrote: > >Ah, ok, so it's for enabling real hardware, not just a cleanup, right? You > >might > >want to put that info into the boilerplate mail or so. > > > >I'm

Re: [-next] BUG_ON in scsi_target_destroy()

On Wed, 2016-04-13 at 10:41 +0200, Johannes Thumshirn wrote: > Hi Sergey, Xiong, > > Can you try below patch? > > On Montag, 11. April 2016 18:01:47 CEST Sergey Senozhatsky wrote: > > Hello, > > > > commit 7b106f2de6938c31ce5e9c86bc70ad3904666b96 > > Author: Johannes Thumshirn

Re: libiscsi: Use scsi helper to set information descriptor

Hey Dan, Hello Sagi Grimberg, The patch a73c2a2f9123: "libiscsi: Use scsi helper to set information descriptor" from Jul 15, 2015, leads to the following static checker warning: drivers/scsi/libiscsi.c:858 iscsi_scsi_cmd_rsp() error: XXX uninitialized symbol 'sector'.

Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

On Wed, Apr 13, 2016 at 04:38:38PM +0200, Ingo Molnar wrote: >Ah, ok, so it's for enabling real hardware, not just a cleanup, right? You >might >want to put that info into the boilerplate mail or so. > >I'm perfectly fine with all the patches that touch x86 code: > > Acked-by: Ingo Molnar

Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

* William Breathitt Gray wrote: > On Wed, Apr 13, 2016 at 09:26:02AM +0200, Ingo Molnar wrote: > >What's the practical motivation of this? What exact hardware is this for? > > > >Thanks, > > > > Ingo > > The PC/104 bus is equivalent to the ISA bus regarding software

Zajimam?

Jsem zastupujicí investicní zajem ze strany Dubaji, pro ktere hledáme vasi ucast. Odpoved na e-mailu nize v pripade zajmu. E-mail: philp...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 2/2] IB/iser: set max_segment_size

On Tue, Apr 12, 2016 at 11:43:09AM -0700, Christoph Hellwig wrote: > > I think this means that there is a mismatch between the current block layer > > limits and what NVMe / RDMA drivers need ... > > If we tell the block layer that we can only handle page sized comments > using max_segent_size it

Re: [-next] BUG_ON in scsi_target_destroy()

On Mittwoch, 13. April 2016 23:47:04 CEST Sergey Senozhatsky wrote: > Hi, > > On (04/13/16 10:41), Johannes Thumshirn wrote: > > Hi Sergey, Xiong, > > > > Can you try below patch? > > it panics my system. > first it warn_on-s in lib/kobject.c:244 > > then NULL dereferences > do_scan_async >

Re: [-next] BUG_ON in scsi_target_destroy()

Hi, On (04/13/16 10:41), Johannes Thumshirn wrote: > Hi Sergey, Xiong, > > Can you try below patch? it panics my system. first it warn_on-s in lib/kobject.c:244 then NULL dereferences do_scan_async __scsi_remove_device scsi_target_reap device_del dpm_sysfs_remove

Re: [PATCH v14 6/9] added support for DesignWare Controller

Hi Joao, 2016-04-13 21:57 GMT+09:00 Joao Pinto : > > Hi Akinobu, > > On 4/13/2016 1:19 PM, Akinobu Mita wrote: >> Hi Joao, >> >> 2016-04-13 18:04 GMT+09:00 Joao Pinto : >> >>> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h >>>

re: libiscsi: Use scsi helper to set information descriptor

Hello Sagi Grimberg, The patch a73c2a2f9123: "libiscsi: Use scsi helper to set information descriptor" from Jul 15, 2015, leads to the following static checker warning: drivers/scsi/libiscsi.c:858 iscsi_scsi_cmd_rsp() error: XXX uninitialized symbol 'sector'.

Re: [PATCH v2 08/16] iscsi-target: add void (*iscsit_get_r2t_ttt)()

On Wed, Apr 13, 2016 at 12:52:11PM +0300, Sagi Grimberg wrote: > > >>>Add void (*iscsit_get_r2t_ttt)() to > >>>struct iscsit_transport, iscsi-target > >>>uses this callback to get > >>>r2t->targ_xfer_tag. > >> > >>Your driver allocates ttt's? That looks like bad > >>layering to me. This

Re: [PATCH v14 6/9] added support for DesignWare Controller

Hi Akinobu, On 4/13/2016 1:19 PM, Akinobu Mita wrote: > Hi Joao, > > 2016-04-13 18:04 GMT+09:00 Joao Pinto : > >> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h >> index e3931d0..c780d14 100644 >> --- a/drivers/scsi/ufs/ufshcd.h >> +++

re: [SCSI] qla2xxx: Enhancements to support ISPFx00.

Hello Giridhar Malavali, The patch 8ae6d9c7eb10: "[SCSI] qla2xxx: Enhancements to support ISPFx00." from Mar 28, 2013, leads to the following static checker warning: drivers/scsi/qla2xxx/qla_mr.c:2264 qlafx00_ioctl_iosb_entry() error: uninitialized symbol 'res'.

Re: [PATCH v14 6/9] added support for DesignWare Controller

Hi Joao, 2016-04-13 18:04 GMT+09:00 Joao Pinto : > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index e3931d0..c780d14 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -263,6 +263,7 @@ struct ufs_pwr_mode_info { >

Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

On Wed, Apr 13, 2016 at 09:26:02AM +0200, Ingo Molnar wrote: >What's the practical motivation of this? What exact hardware is this for? > >Thanks, > > Ingo The PC/104 bus is equivalent to the ISA bus regarding software communication. Many small form factor systems have a PC/104 bus where

re: [SCSI] pm80xx: Phy settings support for motherboard controller.

Hello Anand Kumar Santhanam, The patch 279094079a44: "[SCSI] pm80xx: Phy settings support for motherboard controller." from Sep 18, 2013, leads to the following static checker warning: drivers/scsi/pm8001/pm80xx_hwi.c:4554 mpi_set_phy_profile_req() error: uninitialized symbol

[PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling

The caller assumes that "itnim" is NULL on error and non-NULL on success but really "itnim" is uninitialized on error. This function should just use normal error handling where it returns zero on success and negative on failure. Signed-off-by: Dan Carpenter --- v2: fix

Re: [PATCH v2 01/16] iscsi-target: add callback to alloc and free PDU

On 09/04/16 16:11, Varun Prakash wrote: Add two callbacks to struct iscsit_transport - 1. void *(*iscsit_alloc_pdu)() iscsi-target uses this callback for iSCSI PDU allocation. 2. void (*iscsit_free_pdu) iscsi-target uses this callback to free an iSCSI PDU which was

Re: [PATCH v2 08/16] iscsi-target: add void (*iscsit_get_r2t_ttt)()

Add void (*iscsit_get_r2t_ttt)() to struct iscsit_transport, iscsi-target uses this callback to get r2t->targ_xfer_tag. Your driver allocates ttt's? That looks like bad layering to me. This definitely deserves an explanation... cxgbit.ko allocates ttt only for r2t pdus to do Direct Data

Re: [PATCH 1/2] scsi: add a max_segment_size limitation to struct Scsi_Host

Reviewed-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] IB/iser: set max_segment_size

Acked-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'

> > Applied to 4.6/scsi-queue. Hi Martin, I am not seeing this patch in v4.6-rc3 in Linus's tree. Should I resend this? Thanks, Tina -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 0/5] hisi_sas: v2 hw SATA fixes

On Fri, Apr 8, 2016 at 5:23 PM, John Garry wrote: > This patchset introduces SATA support fixes for > the HiSilicon v2 hw SAS controller. > > Fixes include: > - attach issue for SATA disk attached through expander > - intermittent issue for directly attaching multiple >

[PATCH] mpt3sas: Remove usage of 'struct timeval'

'struct timeval' will have its tv_sec value overflow on 32-bit systems in year 2038 and beyond. This patch replaces the use of struct timeval for computing mpi_request.TimeStamp, and instead uses ktime_t which provides 64-bit seconds value. The timestamp computed remains unaffected (milliseconds

Re: [-next] BUG_ON in scsi_target_destroy()

Hi Sergey, Xiong, Can you try below patch? On Montag, 11. April 2016 18:01:47 CEST Sergey Senozhatsky wrote: > Hello, > > commit 7b106f2de6938c31ce5e9c86bc70ad3904666b96 > Author: Johannes Thumshirn > Date: Tue Apr 5 11:50:44 2016 +0200 > > scsi: Add intermediate

Re: [PATCH v4 1/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

Hi Xiong Sorry for the late reply On Dienstag, 12. April 2016 21:01:53 CEST Xiong Zhou wrote: > How about this? > > drivers/scsi/scsi_scan: mark STARGET_REMOVE state before destroy > > Signed-off-by: Xiong Zhou > --- > drivers/scsi/scsi_scan.c | 3 +++ > 1 file

Re: [PATCH 2/2] IB/iser: set max_segment_size

In iser we sorta rely on 4k pages so we avoid PAGE_SIZE but rather set SIZE_4K for these sort of things (like we did in the virt_boundary). So you still want only 4k segments even on PPC where the PAGE_SIZE is 16k? Yes, iSER has the "no-gaps" constraint (like nvme) and some applications in

Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

* William Breathitt Gray wrote: > This patchset is based on top of commit 3a3a5fece6f2 ("fs: kernfs: Replace > CURRENT_TIME by current_fs_time()") of the driver-core-testing branch of > the driver-core repository. > > The introduction of the ISA_BUS option in commit

  1   2   >