Re: UBSAN: Undefined behaviour in drivers/scsi/aic7xxx/aic7xxx_core.c:2831:31

2016-05-12 Thread James Bottomley
On Thu, 2016-05-12 at 17:56 -0400, Ilia Mirkin wrote: > On Thu, May 12, 2016 at 4:08 PM, James Bottomley > wrote: > > On Thu, 2016-05-12 at 19:02 +0300, Meelis Roos wrote: > > > This is from a dual-AthlonMP 32-bit x86 system with onboard > > > Adaptec > > > SCSI > > >

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-05-12 Thread Martin K. Petersen
> "Fam" == Fam Zheng writes: Fam, Fam> This looks wrong to me, maybe I'm missing the obvious? Here sdkp-> Fam> opt_xfer_blocks is in block size unit, and rw_max is in byte sdkp-> Fam> unit. Oh, joy. It's the commit that keeps on giving! Back when the I/O topology was

Re: UBSAN: Undefined behaviour in drivers/scsi/aic7xxx/aic7xxx_core.c:2831:31

2016-05-12 Thread Ilia Mirkin
On Thu, May 12, 2016 at 4:08 PM, James Bottomley wrote: > On Thu, 2016-05-12 at 19:02 +0300, Meelis Roos wrote: >> This is from a dual-AthlonMP 32-bit x86 system with onboard Adaptec >> SCSI >> controller, once during bootup. >> >> [4.896307] >>

obchod +

2016-05-12 Thread Fni
odpovezte mi na tento e-mail nize na dulezitou transakci. email: fg.ni...@yandex.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 2/2] mpt3sas: clean up indenting a bit

2016-05-12 Thread Dan Carpenter
The indenting is slightly off in parts of this file so I have tidied it. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 6bff13e..34d6f996 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++

[patch 1/2] mpt3sas: add missing curly braces

2016-05-12 Thread Dan Carpenter
There are some missing curly braces on this if statement, so we end up printing when we shouldn't. Fixes: a470a51cd648 ('mpt3sas: Handle active cable exception event') Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c

Re: UBSAN: Undefined behaviour in drivers/scsi/aic7xxx/aic7xxx_core.c:2831:31

2016-05-12 Thread James Bottomley
On Thu, 2016-05-12 at 19:02 +0300, Meelis Roos wrote: > This is from a dual-AthlonMP 32-bit x86 system with onboard Adaptec > SCSI > controller, once during bootup. > > [4.896307] > = > === > [4.896471] UBSAN:

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-12 Thread Doug Ledford
On 05/03/2016 10:33 AM, Florian Westphal wrote: > Replace all trans_start updates with netif_trans_update helper. > change was done via spatch: > > struct net_device *d; > @@ > - d->trans_start = jiffies > + netif_trans_update(d) > > Compile tested only. > > Cc:

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-05-12 Thread Tom Yan
On 12 May 2016 at 12:04, Fam Zheng wrote: > > Following is: > > else > rw_max = BLK_DEF_MAX_SECTORS; > > Which seems in sector unit, and is already making above change suspicious, and Yes BLK_DEF_MAX_SECTORS is in sector unit. It has been bumped from 1024

UBSAN: Undefined behaviour in drivers/scsi/aic7xxx/aic7xxx_core.c:2831:31

2016-05-12 Thread Meelis Roos
This is from a dual-AthlonMP 32-bit x86 system with onboard Adaptec SCSI controller, once during bootup. [4.896307] [4.896471] UBSAN: Undefined behaviour in drivers/scsi/aic7xxx/aic7xxx_core.c:2831:31 [

Behavior for hot-plugging SD card in USB SD card reader

2016-05-12 Thread Frkuska, Joshua
Hello, I have two questions regarding the behavior for hot-plugging SD card in USB SD card reader relating to the scsi sub system. Before the questions, the background and my understanding: On the 3.14.y branch and later (not sure about 4.2+), when using a USB SD card reader with sd card

RE: [PATCH] megaraid: add scsi_cmnd NULL check before use

2016-05-12 Thread Sumit Saxena
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, May 12, 2016 12:05 PM > To: Petros Koutoupis > Cc: Sumit Saxena; Finn Thain; kashyap.de...@avagotech.com; > sumit.sax...@avagotech.com; uday.ling...@avagotech.com; >

Re: [PATCH] megaraid: add scsi_cmnd NULL check before use

2016-05-12 Thread Dan Carpenter
On Wed, May 11, 2016 at 08:49:51PM -0500, Petros Koutoupis wrote: > Sumit, > > I will resubmit the patch with all the recommendations. Thank you. In case > you are interested, I have a crash file showcasing the error. I can always > provide this outside of this mailing thread. > Please send it