iscsi_ttx kernel issues on 3.10.0-327.28.3.el7.x86_64

2016-09-15 Thread Bruce Coulter
linux-scsi, target-devel, We're noticing consistent kernel lock-up issues with RH 3.10 kernels, esp. while dm targets are under concurrent load from iscsi and local disk access. Issue is reproducible with load on disks over time. Sample call trace below; what additional information can I

Re: [PATCH] scsi: replace broken specification URL

2016-09-15 Thread Laurence Oberman
- Original Message - > From: "Martin K. Petersen" > To: "Michael Opdenacker" > Cc: cor...@lwn.net, j...@linux.vnet.ibm.com, "martin petersen" > , > linux-...@vger.kernel.org,

Re: [PATCH] scsi: replace broken specification URL

2016-09-15 Thread Laurence Oberman
- Original Message - > From: "Michael Opdenacker" > To: cor...@lwn.net, j...@linux.vnet.ibm.com, "martin petersen" > > Cc: linux-...@vger.kernel.org, linux-ker...@vger.kernel.org, > linux-scsi@vger.kernel.org,

Re: TRIM/UNMAP/DISCARD via ATA Passthrough

2016-09-15 Thread Jason A. Donenfeld
Hi Martin, On Thu, Sep 15, 2016 at 6:07 PM, Martin K. Petersen > But how do they signal that ATA passthrough is possible? Is there an ATA > Information VPD page? Is REPORT SUPPORTED OPERATION CODES supported? > > We need really solid discovery data before we can entertain enabling > something

Re: TRIM/UNMAP/DISCARD via ATA Passthrough

2016-09-15 Thread Martin K. Petersen
> "Jason" == Jason A Donenfeld writes: Jason, >> How do they signal that they support the passthrough? Jason> Through the usual SCSI ATA-passthrough interface, "SAT" (SCSI-ATA Jason> Command Translation) -- ATA PASS THROUGH SCSI (16) and ATA PASS Jason> THROUGH SCSI (12).

Re: TRIM/UNMAP/DISCARD via ATA Passthrough

2016-09-15 Thread Jason A. Donenfeld
On Wed, Sep 14, 2016 at 8:37 PM, Martin K. Petersen > How do they signal that they support the passthrough? Through the usual SCSI ATA-passthrough interface, "SAT" (SCSI-ATA Command Translation) -- ATA PASS THROUGH SCSI (16) and ATA PASS THROUGH SCSI (12). I can use hdparm to treat /dev/sdb

Re: [PATCH] [SCSI] wd719x: Avoid calling request_firmware under spinlock

2016-09-15 Thread John Garry
On 15/09/2016 15:08, John Garry wrote: On 15/09/2016 14:48, Vaishali Thakkar wrote: It is preferrable to use request_firmware where sleeping is allowed. Using it under spinlock can cause blocking. Here, the function wd719x_chip_init calls request_firmware while holding a spinlock. So, let's

Re: [PATCH] [SCSI] wd719x: Avoid calling request_firmware under spinlock

2016-09-15 Thread John Garry
On 15/09/2016 14:48, Vaishali Thakkar wrote: It is preferrable to use request_firmware where sleeping is allowed. Using it under spinlock can cause blocking. Here, the function wd719x_chip_init calls request_firmware while holding a spinlock. So, let's access it outside the spinlock. Coccinelle

Re: [PATCH] scsi: replace broken specification URL

2016-09-15 Thread Martin K. Petersen
> "Michael" == Michael Opdenacker > writes: Michael> + * 'cam-r12b.pdf' document on http://www.t10.org/t10docs.htm Michael> + * (registration required) That link really should be http://www.t10.org/drafts.htm. You can't look up draft

Re: [patch v2] arcmsr: buffer overflow in arcmsr_iop_message_xfer()

2016-09-15 Thread Martin K. Petersen
> "Dan" == Dan Carpenter writes: Dan> We need to put an upper bound on "user_len" so the memcpy() doesn't Dan> overflow. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH -next] scsi: ibmvscsis: Fix error return code in ibmvscsis_probe()

2016-09-15 Thread Martin K. Petersen
> "Wei" == Wei Yongjun writes: Wei> From: Wei Yongjun Fix to return error code Wei> -ENOMEM from the dma mapping error handling case instead of 0, as Wei> done elsewhere in this function. Applied to 4.9/scsi-queue. -- Martin K. Petersen

Re: [PATCH 3/3] sd: move DIF protection types to t10-pi.h

2016-09-15 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: >> I don't mind fixing that up when I apply. Any objections? Christoph> Sure, go ahead! Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

[PATCH] [SCSI] wd719x: Avoid calling request_firmware under spinlock

2016-09-15 Thread Vaishali Thakkar
It is preferrable to use request_firmware where sleeping is allowed. Using it under spinlock can cause blocking. Here, the function wd719x_chip_init calls request_firmware while holding a spinlock. So, let's access it outside the spinlock. Coccinelle is used to detect the issue. Signed-off-by:

[patch v2] arcmsr: buffer overflow in arcmsr_iop_message_xfer()

2016-09-15 Thread Dan Carpenter
We need to put an upper bound on "user_len" so the memcpy() doesn't overflow. Reported-by: Marco Grassi Signed-off-by: Dan Carpenter Reviewed-by: Tomas Henzl diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c

Re: [patch] arcmsr: buffer overflow in arcmsr_iop_message_xfer()

2016-09-15 Thread Dan Carpenter
On Thu, Sep 15, 2016 at 03:19:12PM +0200, Tomas Henzl wrote: > > @@ -2397,6 +2398,10 @@ static int arcmsr_iop_message_xfer(struct > > AdapterControlBlock *acb, > > } > > ptmpuserbuffer = ver_addr; > > user_len = pcmdmessagefld->cmdmessage.Length; > > +

Re: [patch] arcmsr: buffer overflow in arcmsr_iop_message_xfer()

2016-09-15 Thread Tomas Henzl
On 15.9.2016 14:01, Dan Carpenter wrote: > We need to put an upper bound on "user_len" so the memcpy() doesn't > overflow. > > Reported-by: Marco Grassi > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c >

[PATCH] scsi: replace broken specification URL

2016-09-15 Thread Michael Opdenacker
The t10.org website containing SCSI-2 draft specifications now requires to be from a member company to access the documents. Signed-off-by: Michael Opdenacker --- Documentation/DocBook/scsi.tmpl | 6 +++--- drivers/scsi/scsicam.c | 3 ++- 2 files

Re: [PATCH] scsi: replace broken specification URL

2016-09-15 Thread Michael Opdenacker
Hi Martin, On 14/09/2016 19:00, Martin K. Petersen wrote: Michael> So, should we only that the cam-r12b document can be found from Michael> http://www.t10.org/t10docs.htm (registration required)?, and Michael> tell that a copy can be found on Michael>

[patch] arcmsr: buffer overflow in arcmsr_iop_message_xfer()

2016-09-15 Thread Dan Carpenter
We need to put an upper bound on "user_len" so the memcpy() doesn't overflow. Reported-by: Marco Grassi Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 7640498..73ddd45 100644 ---

Re: [PATCH] Remove the unnecessary semicolons

2016-09-15 Thread Paolo Bonzini
On 19/08/2016 04:03, Zhou Jie wrote: > At the end of funcions, semicolons are unnecessary. So drop them. > > Signed-off-by: Chao Fan > --- > drivers/scsi/virtio_scsi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH -next] scsi: ibmvscsis: Fix error return code in ibmvscsis_probe()

2016-09-15 Thread Johannes Thumshirn
On Thu, Sep 15, 2016 at 03:25:23AM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return error code -ENOMEM from the dma mapping error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun >