linux-scsi, target-devel,
We're noticing consistent kernel lock-up issues with RH 3.10 kernels, esp.
while dm targets are under concurrent load from iscsi and local disk
access. Issue is reproducible with load on disks over time. Sample call
trace below; what additional information can I
- Original Message -
> From: "Martin K. Petersen"
> To: "Michael Opdenacker"
> Cc: cor...@lwn.net, j...@linux.vnet.ibm.com, "martin petersen"
> ,
> linux-...@vger.kernel.org,
- Original Message -
> From: "Michael Opdenacker"
> To: cor...@lwn.net, j...@linux.vnet.ibm.com, "martin petersen"
>
> Cc: linux-...@vger.kernel.org, linux-ker...@vger.kernel.org,
> linux-scsi@vger.kernel.org,
Hi Martin,
On Thu, Sep 15, 2016 at 6:07 PM, Martin K. Petersen
> But how do they signal that ATA passthrough is possible? Is there an ATA
> Information VPD page? Is REPORT SUPPORTED OPERATION CODES supported?
>
> We need really solid discovery data before we can entertain enabling
> something
> "Jason" == Jason A Donenfeld writes:
Jason,
>> How do they signal that they support the passthrough?
Jason> Through the usual SCSI ATA-passthrough interface, "SAT" (SCSI-ATA
Jason> Command Translation) -- ATA PASS THROUGH SCSI (16) and ATA PASS
Jason> THROUGH SCSI (12).
On Wed, Sep 14, 2016 at 8:37 PM, Martin K. Petersen
> How do they signal that they support the passthrough?
Through the usual SCSI ATA-passthrough interface, "SAT" (SCSI-ATA
Command Translation) -- ATA PASS THROUGH SCSI (16) and ATA PASS
THROUGH SCSI (12).
I can use hdparm to treat /dev/sdb
On 15/09/2016 15:08, John Garry wrote:
On 15/09/2016 14:48, Vaishali Thakkar wrote:
It is preferrable to use request_firmware where sleeping is
allowed. Using it under spinlock can cause blocking. Here,
the function wd719x_chip_init calls request_firmware while
holding a spinlock. So, let's
On 15/09/2016 14:48, Vaishali Thakkar wrote:
It is preferrable to use request_firmware where sleeping is
allowed. Using it under spinlock can cause blocking. Here,
the function wd719x_chip_init calls request_firmware while
holding a spinlock. So, let's access it outside the spinlock.
Coccinelle
> "Michael" == Michael Opdenacker
> writes:
Michael> + * 'cam-r12b.pdf' document on http://www.t10.org/t10docs.htm
Michael> + * (registration required)
That link really should be http://www.t10.org/drafts.htm. You can't look
up draft
> "Dan" == Dan Carpenter writes:
Dan> We need to put an upper bound on "user_len" so the memcpy() doesn't
Dan> overflow.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe
> "Wei" == Wei Yongjun writes:
Wei> From: Wei Yongjun Fix to return error code
Wei> -ENOMEM from the dma mapping error handling case instead of 0, as
Wei> done elsewhere in this function.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen
> "Christoph" == Christoph Hellwig writes:
>> I don't mind fixing that up when I apply. Any objections?
Christoph> Sure, go ahead!
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe
It is preferrable to use request_firmware where sleeping is
allowed. Using it under spinlock can cause blocking. Here,
the function wd719x_chip_init calls request_firmware while
holding a spinlock. So, let's access it outside the spinlock.
Coccinelle is used to detect the issue.
Signed-off-by:
We need to put an upper bound on "user_len" so the memcpy() doesn't
overflow.
Reported-by: Marco Grassi
Signed-off-by: Dan Carpenter
Reviewed-by: Tomas Henzl
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c
On Thu, Sep 15, 2016 at 03:19:12PM +0200, Tomas Henzl wrote:
> > @@ -2397,6 +2398,10 @@ static int arcmsr_iop_message_xfer(struct
> > AdapterControlBlock *acb,
> > }
> > ptmpuserbuffer = ver_addr;
> > user_len = pcmdmessagefld->cmdmessage.Length;
> > +
On 15.9.2016 14:01, Dan Carpenter wrote:
> We need to put an upper bound on "user_len" so the memcpy() doesn't
> overflow.
>
> Reported-by: Marco Grassi
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c
>
The t10.org website containing SCSI-2 draft specifications now requires
to be from a member company to access the documents.
Signed-off-by: Michael Opdenacker
---
Documentation/DocBook/scsi.tmpl | 6 +++---
drivers/scsi/scsicam.c | 3 ++-
2 files
Hi Martin,
On 14/09/2016 19:00, Martin K. Petersen wrote:
Michael> So, should we only that the cam-r12b document can be found from
Michael> http://www.t10.org/t10docs.htm (registration required)?, and
Michael> tell that a copy can be found on
Michael>
We need to put an upper bound on "user_len" so the memcpy() doesn't
overflow.
Reported-by: Marco Grassi
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index 7640498..73ddd45 100644
---
On 19/08/2016 04:03, Zhou Jie wrote:
> At the end of funcions, semicolons are unnecessary. So drop them.
>
> Signed-off-by: Chao Fan
> ---
> drivers/scsi/virtio_scsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
On Thu, Sep 15, 2016 at 03:25:23AM +, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return error code -ENOMEM from the dma mapping error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun
>
21 matches
Mail list logo