Re: [Open-FCoE] [PATCH RFC 5/5] qedf: Add FIP request handling

On 01/09/2017 05:47 PM, Chad Dupuis wrote: > > On Wed, 28 Dec 2016, 9:11am -, Hannes Reinecke wrote: > >> On 12/23/2016 08:17 PM, Dupuis, Chad wrote: >>> From: "Dupuis, Chad" >>> >>> This patch adds handling for FIP requests and responses that are handled by >>> the

Re: [Open-FCoE] [PATCH RFC 2/5] qedf: Add QLogic FastLinQ offload FCoE driver framework.

On 01/09/2017 05:45 PM, Chad Dupuis wrote: > > On Wed, 28 Dec 2016, 9:00am -, Hannes Reinecke wrote: > >> On 12/23/2016 08:17 PM, Dupuis, Chad wrote: >>> From: "Dupuis, Chad" >>> >>> The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific module >>> for 41000

Re: [PATCH 0/4] cxlflash: Enhancements, cleanup and fixes

On 10/01/17 16:00, Martin K. Petersen wrote: The first three patches in the series were submitted by you but do not carry your Signed-off-by:... hmm, over in linuxppc-land I don't think we particularly enforce this. Thanks for the reminder! -- Andrew Donnellan OzLabs, ADL

Re: [PATCH 0/4] cxlflash: Enhancements, cleanup and fixes

> "Uma" == Uma Krishnan writes: Uma, Uma> This patch series includes an enhancement to support a new command Uma> queuing model and also cleans up prints throughout the driver. The Uma> last patch in the series fixes a racing issue. Uma> The series is based upon

Re: [PATCH v2] scsi: esas2r: Fix format string type mistakes

> "Kees" == Kees Cook writes: Kees> From: Emese Revfy This adds the missing Kees> __printf attribute which allows compile time format string Kees> checking (and will be used by the coming initify gcc Kees> plugin). Additionally, this fixes the

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

> "Sreekanth" == Sreekanth Reddy writes: Sreekanth> We are fine with this patch. Can we rename function Sreekanth> 'set_satl_pending()' name to '_scsih_set_satl_pending()' and Sreekanth> can add headers to this function. Sreekanth> other wise I am OK.

Re: [PATCH] pmcraid: switch to pci_alloc_irq_vectors

> "Christoph" == Christoph Hellwig writes: Christoph> On Tue, Nov 29, 2016 at 11:42:35AM -0500, Martin K. Petersen wrote: >> > "Christoph" == Christoph Hellwig writes: >> >> Somebody please review. Christoph> review ping^2 Applied to 4.11/scsi-queue.

Re: [PATCH] bfa: remove bfa_fcs_mod_s

> "Christoph" == Christoph Hellwig writes: Christoph> Just call the functions directly instead of obsfucating the Christoph> call chain. This was in reply to a patch from Kees Cook to Christoph> constify the function pointer struct bfa_fcs_mod_s, but it Christoph> turns out

Re: [PATCH] qla2xxx: rename {vendor|hba}_indentifer to {vendor|hba}_identifer

> "Colin" == Colin King writes: Colin> Rename the Colin> vendor_indentifer and hba_indentifer fields to correct spelling. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

Re: scsi: qla2xxx: Fix apparent cut-n-paste error.

> "Dave" == Dave Jones writes: Dave> commit 093df73771bac8a37d607c0e705d157a8cef4c5c introduces two Dave> bodies of code that look similar but with s/req/rsp/ in the second Dave> instance. But in one case, it looks like this conversion was Dave> missed. Applied to

Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

> "Nicolas" == Nicolas Iooss writes: Nicolas> qla24xx_enable_msix() calls scnprintf() with a non-literal Nicolas> format string. This makes clang report -Wformat-security Nicolas> warnings when compiling this function: Applied 1+2 to 4.11/scsi-queue. -- Martin

Re: [PATCH] qla2xxx: Get mutex lock before checking optrom_state

> "Milan" == Milan P Gandhi writes: Milan> There is a race condition with qla2xxx optrom functions where one Milan> thread might modify optrom buffer, optrom_state while other Milan> thread is still reading from it. Applied to 4.10/scsi-fixes. -- Martin K. Petersen

Re: [PATCH] qla2xxx: rename {vendor|hba}_indentifer to {vendor|hba}_identifer

On 12/29/16, 2:20 PM, "Colin King" wrote: >From: Colin Ian King > >Rename the vendor_indentifer and hba_indentifer fields to correct spelling. > >Signed-off-by: Colin Ian King >--- > drivers/scsi/qla2xxx/qla_def.h |

[PATCH] ses: Fix SAS device detection in enclosure

From: "Ewan D. Milne" The call to scsi_is_sas_rphy() needs to be made on the SAS end_device, not on the SCSI device. Fixes: 835831c57e9b ("ses: use scsi_is_sas_rphy instead of is_sas_attached") Reviewed-by: Johannes Thumshirn Signed-off-by: Ewan D. Milne

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Mon, Jan 09, 2017 at 09:30:05PM +0100, Jan Kara wrote: > On Sat 07-01-17 21:02:00, Johannes Weiner wrote: > > On Tue, Jan 03, 2017 at 01:28:25PM +0100, Jan Kara wrote: > > > On Mon 02-01-17 16:11:36, Johannes Weiner wrote: > > > > On Fri, Dec 23, 2016 at 03:33:29AM -0500, Johannes Weiner wrote:

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Sat 07-01-17 21:02:00, Johannes Weiner wrote: > On Tue, Jan 03, 2017 at 01:28:25PM +0100, Jan Kara wrote: > > On Mon 02-01-17 16:11:36, Johannes Weiner wrote: > > > On Fri, Dec 23, 2016 at 03:33:29AM -0500, Johannes Weiner wrote: > > > > On Fri, Dec 23, 2016 at 02:32:41AM -0500, Johannes Weiner

Re: scsi: qla2xxx: Fix apparent cut-n-paste error.

-Original Message- From: "Martin K. Petersen" Organization: Oracle Corporation Date: Thursday, January 5, 2017 at 5:52 PM To: Dave Jones Cc: "linux-scsi@vger.kernel.org" , "Tran, Quinn"

Re: [PATCH 03/11] qla2xxx: Make trace flags more readable.

On 1/9/17, 5:11 AM, "Christoph Hellwig" wrote: >On Fri, Dec 23, 2016 at 08:23:31PM -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> This patch does not change any functionality. > >... >> +++ b/drivers/scsi/qla2xxx/qla_target.c >> @@ -3294,7

Re: [PATCH 05/11] qla2xxx: Fix wrong argument in sp done callback.

On 1/9/17, 5:17 AM, "Christoph Hellwig" wrote: >On Fri, Dec 23, 2016 at 08:23:33PM -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> Callback for sp->done expects scsi_qla_host is passed in as argument, >> Instead qla_hw_data is passed in. >

Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

On Mon, Jan 09, 2017 at 11:23:23AM -0600, Bryant G. Ly wrote: > On 1/9/17 10:47 AM, Greg KH wrote: > > > On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote: > > > From: "Bryant G. Ly" > > > > > > If srp_transfer_data fails within ibmvscsis_write_pending, then > > >

Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

On 1/9/17 10:47 AM, Greg KH wrote: On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote: From: "Bryant G. Ly" If srp_transfer_data fails within ibmvscsis_write_pending, then the most likely scenario is that the client timed out the op and removed the TCE mapping.

Re: [Open-FCoE] [PATCH RFC 5/5] qedf: Add FIP request handling

On Wed, 28 Dec 2016, 9:11am -, Hannes Reinecke wrote: > On 12/23/2016 08:17 PM, Dupuis, Chad wrote: > > From: "Dupuis, Chad" > > > > This patch adds handling for FIP requests and responses that are handled by > > the driver itself and not by libfcoe. > > > >

Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote: > From: "Bryant G. Ly" > > If srp_transfer_data fails within ibmvscsis_write_pending, then > the most likely scenario is that the client timed out the op and > removed the TCE mapping. Thus it will loop forever

Re: [Open-FCoE] [PATCH RFC 3/5] qedf: Add offloaded I/O request functions.

On Wed, 28 Dec 2016, 9:08am -, Hannes Reinecke wrote: > On 12/23/2016 08:17 PM, Dupuis, Chad wrote: > > From: "Dupuis, Chad" > > > > This patch adds various I/O requests types that are handled in firmware: > > > > - Normal I/O requests > > - ABTS requests > > -

Re: [Open-FCoE] [PATCH RFC 2/5] qedf: Add QLogic FastLinQ offload FCoE driver framework.

On Wed, 28 Dec 2016, 9:00am -, Hannes Reinecke wrote: > On 12/23/2016 08:17 PM, Dupuis, Chad wrote: > > From: "Dupuis, Chad" > > > > The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific module > > for 41000 Series Converged Network Adapters by QLogic. > >

[PATCH] ibmvscsis: Fix srp_transfer_data fail return code

From: "Bryant G. Ly" If srp_transfer_data fails within ibmvscsis_write_pending, then the most likely scenario is that the client timed out the op and removed the TCE mapping. Thus it will loop forever retrying the op that is pretty much guaranteed to fail forever. A better

LSF/MM 2017: Call for Proposals closes January 15th

We initially sent this pretty early this year, so this is a resend in case anyone missed the first posting. The call for topics and attendance requests is open until January 15th, 2017. The original message follows: --8< The annual

Re: [PATCH 07/11] qla2xxx: Track I-T nexus as single fc_port struct.

> +typedef struct { > + struct list_headlist; > + u8 iocb[64]; /* imm_ntfy_from_isp */ Please keep it as struct imm_ntfy_from_isp so that all the crazy casts in the new code can be removed. > + qlt_plogi_ack_t* plogi_link[QLT_PLOGI_LINK_MAX];

Re: [PATCH 06/11] qla2xxx: Use d_id instead of s_id for more clarity.

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/11] qla2xxx: Fix wrong argument in sp done callback.

On Fri, Dec 23, 2016 at 08:23:33PM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > Callback for sp->done expects scsi_qla_host is passed in as argument, > Instead qla_hw_data is passed in. Please also fix the prototype of the done and free callbacks to use the

Re: [PATCH 03/11] qla2xxx: Make trace flags more readable.

On Fri, Dec 23, 2016 at 08:23:31PM -0800, Himanshu Madhani wrote: > From: Quinn Tran > > This patch does not change any functionality. ... > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -3294,7 +3294,6 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd) > return

Re: [PATCH 04/11] qla2xxx: Cleanup SRR code.

s/Cleanup/Remove/ ? Maybe add a little blurb on why we even had this huge pile of dead code despite not using selective retransmissions, and why you don't plan to use it any time soon. Otherwise looks fine: Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the

[no subject]

Bitte tut mir leid, dass ich Sie stören kann, können Sie mich auf E-Mail-Adresse, so dass ich in der Lage, Ihnen meine Bilder -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] pmcraid: switch to pci_alloc_irq_vectors

On 11/18/2016 07:28 AM, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig --- drivers/scsi/pmcraid.c | 92 ++ drivers/scsi/pmcraid.h | 1 - 2 files changed, 41 insertions(+), 52 deletions(-) Reviewed-by: Hannes Reinecke

Re: [PATCH] bfa: remove bfa_fcs_mod_s

On 01/08/2017 10:41 AM, Christoph Hellwig wrote: Just call the functions directly instead of obsfucating the call chain. This was in reply to a patch from Kees Cook to constify the function pointer struct bfa_fcs_mod_s, but it turns out there is no reason to have this indirection at all.

Re: Uninitialized variable in bfad_im_bsg_els_ct_request

On Sun, Dec 18, 2016 at 09:44:27PM +0100, Nicolas Iooss wrote: > Hello, > > Currently on Linus master tree and in linux-next [1], > bfad_im_bsg_els_ct_request() code starts with the following code: > > int > bfad_im_bsg_els_ct_request(struct bsg_job *job) > { > /*...*/ > struct