Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-20 Thread Damien Le Moal
Bart, On 2/21/17 13:21, Bart Van Assche wrote: > On 02/20/2017 06:35 PM, Martin K. Petersen wrote: >> I'm still not keen on having two orthogonal sanity checks wrt. figuring >> out how much of a request has been completed. >> >> Also, I find your approach hard to follow in the case where >>

[PATCH] scsi: ufs: Factor out ufshcd_read_desc_param

2017-02-20 Thread Potomski, MichalX
Since in UFS 2.1 specification some of the descriptor lengths differs from 2.0 specification and some devices, which are reporting spec version 2.0 have different descriptor lengths we can not rely on hardcoded values taken from 2.0 specification. This patch introduces reading these lengths per

Re: [PATCH] scsi: zero per-cmd driver data before each I/O

2017-02-20 Thread Hannes Reinecke
On 02/20/2017 05:52 PM, Christoph Hellwig wrote: > Without this drivers that don't clear the state themselves can see off > effects. For example Hyper-V VMs using the storvsc driver will often > hang during boot due to uncleared Test Unit Ready failures. > > Fixes: e9c787e6 ("scsi: allocate

Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-20 Thread Bart Van Assche
On 02/20/2017 06:35 PM, Martin K. Petersen wrote: > I'm still not keen on having two orthogonal sanity checks wrt. figuring > out how much of a request has been completed. > > Also, I find your approach hard to follow in the case where > sd_completed_bytes() is called after the resid has been

Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-20 Thread Martin K. Petersen
> "Damien" == Damien Le Moal writes: Damien, Damien> Initially, I didn't want to change more than I did so that the Damien> patch quickly make it to 4.10 and we get ZBC working with LSI Damien> HBAs. Since this did not happen and we have more time ahead, I Damien> can

Re: [PATCH v3 00/16] lpfc: Add NVME Fabrics support

2017-02-20 Thread Martin K. Petersen
> "James" == James Smart writes: James> This patch set adds support for NVME over Fabrics FC transport to James> lpfc Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-20 Thread Damien Le Moal
Martin, On 2/21/17 11:35, Martin K. Petersen wrote: >> "Damien" == Damien Le Moal writes: > > Hi Damien, > > Damien> Move the partial completion alignement check of mpt3sas to a > Damien> generic implementation in sd_done so that the check ignores > Damien>

Re: [PATCH] cxlflash: Enable PCI device ID for future IBM CXL Flash AFU

2017-02-20 Thread Martin K. Petersen
> "Uma" == Uma Krishnan writes: Uma> From: "Matthew R. Ochs" Add support for Uma> a future IBM Coherent Accelerator (CXL) flash AFU with an ID of Uma> 0x0624. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCHv3] scsi: use 'scsi_device_from_queue()' for scsi_dh

2017-02-20 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> The device handler needs to check if a given queue belongs to a Hannes> scsi device; only then does it make sense to attach a device Hannes> handler. Fixed kbuild warning and applied to 4.11/scsi-queue. -- Martin K. Petersen

Re: [PATCH 0/3] qla2xxx: Bug fixes and cleanup for the driver.

2017-02-20 Thread Martin K. Petersen
> "Himanshu" == Himanshu Madhani writes: Hi Himanshu, Himanshu> This series contains small cleanup + fix for regression that Himanshu> was introduced by pci_alloc_irq_vectors_affinity() call in Himanshu> driver. Himanshu> Please apply this series to

Re: [PATCH v1 1/1] scsi: ufs-qcom: remove redundant condition check

2017-02-20 Thread Martin K. Petersen
> "Subhash" == Subhash Jadavani writes: Subhash, Subhash> Dan Carpenter reported this: --- The Subhash> patch 9c46b8676271: "scsi: ufs-qcom: dump additional testbus Subhash> registers" from Feb 3, 2017, leads to the following static

Re: [PATCH] smartpqi: fix time handling

2017-02-20 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> When we have turned off RTC support, the smartpqi driver fails to Arnd> build: ERROR: "rtc_time64_to_tm" Arnd> [drivers/scsi/smartpqi/smartpqi.ko] undefined! Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCH V2 00/15] aacraid: Fixes and enhancements for arc family

2017-02-20 Thread Martin K. Petersen
> "Raghava" == Raghava Aditya Renukunta > writes: Raghava> This patch set contains issue fixes, enhancements and other Raghava> misc changes. The majority of the fixes are a direct outcome Raghava> of testing and work done on the adapter reset

Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-20 Thread Martin K. Petersen
> "Damien" == Damien Le Moal writes: Hi Damien, Damien> Move the partial completion alignement check of mpt3sas to a Damien> generic implementation in sd_done so that the check ignores Damien> REQ_TYPE_FS requests with special payload size handling Damien>

Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-20 Thread Damien Le Moal
Bart, On 2/21/17 02:34, Bart Van Assche wrote: > On 02/16/2017 04:20 PM, Damien Le Moal wrote: >> Move the partial completion alignement check of mpt3sas to a generic >> implementation in sd_done so that the check ignores REQ_TYPE_FS >> requests with special payload size handling (REQ_OP_DISCARD,

[GIT PULL] first round of SCSI updates for the 4.10+ merge window

2017-02-20 Thread James Bottomley
This update includes the usual round of major driver updates (ncr5380, ufs, lpfc, be2iscsi, hisi_sas, storvsc, cxlflash, aacraid, megaraid_sas, ). There's also an assortment of minor fixes and the major update of switching another bunch of drivers to pci_alloc_irq_vectors from Christoph. The

RE

2017-02-20 Thread Viet Xuan Luong
I am Viet Xuan Luong. I am an American soldier presently on active service with 4th Squadron battalion here in Afghanistan. I served with the third Infantry Division in Iraq before thousand of my lucky colleagues were pulled out in August Last year, leaving me among the unlucky ones drafted

RE

2017-02-20 Thread Viet Xuan Luong
I am Viet Xuan Luong. I am an American soldier presently on active service with 4th Squadron battalion here in Afghanistan. I served with the third Infantry Division in Iraq before thousand of my lucky colleagues were pulled out in August Last year, leaving me among the unlucky ones drafted

Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-20 Thread Bart Van Assche
On 02/16/2017 04:20 PM, Damien Le Moal wrote: > Move the partial completion alignement check of mpt3sas to a generic > implementation in sd_done so that the check ignores REQ_TYPE_FS > requests with special payload size handling (REQ_OP_DISCARD, > REQ_OP_WRITE_SAME, REQ_OP_ZONE_REPORT and

Re: [PATCH 0/5] block subsystem refcounter conversions

2017-02-20 Thread James Bottomley
On Mon, 2017-02-20 at 17:56 +0100, Peter Zijlstra wrote: > On Mon, Feb 20, 2017 at 07:41:01AM -0800, James Bottomley wrote: > > On Mon, 2017-02-20 at 08:15 -0700, Jens Axboe wrote: > > > On 02/20/2017 04:16 AM, Elena Reshetova wrote: > > > > Now when new refcount_t type and API are finally merged

Re: [PATCH] scsi: zero per-cmd driver data before each I/O

2017-02-20 Thread Bart Van Assche
On 02/20/2017 08:52 AM, Christoph Hellwig wrote: > Without this drivers that don't clear the state themselves can see off > effects. For example Hyper-V VMs using the storvsc driver will often > hang during boot due to uncleared Test Unit Ready failures. > > Fixes: e9c787e6 ("scsi: allocate

Re: [PATCH 0/5] block subsystem refcounter conversions

2017-02-20 Thread Peter Zijlstra
On Mon, Feb 20, 2017 at 07:41:01AM -0800, James Bottomley wrote: > On Mon, 2017-02-20 at 08:15 -0700, Jens Axboe wrote: > > On 02/20/2017 04:16 AM, Elena Reshetova wrote: > > > Now when new refcount_t type and API are finally merged > > > (see include/linux/refcount.h), the following > > > patches

[PATCH] scsi: zero per-cmd driver data before each I/O

2017-02-20 Thread Christoph Hellwig
Without this drivers that don't clear the state themselves can see off effects. For example Hyper-V VMs using the storvsc driver will often hang during boot due to uncleared Test Unit Ready failures. Fixes: e9c787e6 ("scsi: allocate scsi_cmnd structures as part of struct request")

Re: [PATCH 0/5] block subsystem refcounter conversions

2017-02-20 Thread Jens Axboe
On 02/20/2017 08:41 AM, James Bottomley wrote: > On Mon, 2017-02-20 at 08:15 -0700, Jens Axboe wrote: >> On 02/20/2017 04:16 AM, Elena Reshetova wrote: >>> Now when new refcount_t type and API are finally merged >>> (see include/linux/refcount.h), the following >>> patches convert various

Re: [PATCH 0/5] block subsystem refcounter conversions

2017-02-20 Thread James Bottomley
On Mon, 2017-02-20 at 08:15 -0700, Jens Axboe wrote: > On 02/20/2017 04:16 AM, Elena Reshetova wrote: > > Now when new refcount_t type and API are finally merged > > (see include/linux/refcount.h), the following > > patches convert various refcounters in the block susystem from > > atomic_t to

Re: [PATCH 0/5] block subsystem refcounter conversions

2017-02-20 Thread Jens Axboe
On 02/20/2017 04:16 AM, Elena Reshetova wrote: > Now when new refcount_t type and API are finally merged > (see include/linux/refcount.h), the following > patches convert various refcounters in the block susystem from atomic_t > to refcount_t. By doing this we prevent intentional or accidental >

[PATCH 0/5] block subsystem refcounter conversions

2017-02-20 Thread Elena Reshetova
Now when new refcount_t type and API are finally merged (see include/linux/refcount.h), the following patches convert various refcounters in the block susystem from atomic_t to refcount_t. By doing this we prevent intentional or accidental underflows or overflows that can led to use-after-free

[PATCH 2/5] block: convert blk_queue_tag.refcnt from atomic_t to refcount_t

2017-02-20 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

[PATCH 1/5] block: convert bio.__bi_cnt from atomic_t to refcount_t

2017-02-20 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

[PATCH 3/5] block: convert blkcg_gq.refcnt from atomic_t to refcount_t

2017-02-20 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

[PATCH 5/5] block: convert bsg_device.ref_count from atomic_t to refcount_t

2017-02-20 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

[PATCH 4/5] block: convert io_context.active_ref from atomic_t to refcount_t

2017-02-20 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: