[Bug 188061] On quad port QLE2564 can't add in target only 2 ports

2017-03-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=188061 --- Comment #5 from Anthony (anthony.blood...@gmail.com) --- I've installed another 4-port card and got same issue - port names have variable part at highest bits. On 2-port card port names have variable part at lower bits: port_name

[PATCH] qla2xxx: Fix ql_dump_buffer

2017-03-02 Thread Joe Perches
Recent printk changes for KERN_CONT cause this logging to be defectively emitted on multiple lines. Fix it. Also reduces object size a trivial amount. $ size drivers/scsi/qla2xxx/qla_dbg.o* textdata bss dec hex filename 39125 0 0 3912598d5

[PATCH] aacraid: Fix typo in blink status

2017-03-02 Thread Raghava Aditya Renukunta
The return status of the adapter check on KERNEL_PANIC is supposed to be the upper 16 bits of the OMR status register. Fixes: c421530bf848604e (scsi: aacraid: Reorder Adpater status check) Reported-by: Dan Carpenter Signed-off-by: Raghava Aditya Renukunta

Re: SCSI regression in 4.11

2017-03-02 Thread James Bottomley
On March 2, 2017 10:23:24 AM PST, Stephen Hemminger wrote: >On Thu, 2 Mar 2017 14:25:14 +0100 >Hannes Reinecke wrote: > >> On 03/02/2017 02:40 AM, Stephen Hemminger wrote: >> > On Thu, 2 Mar 2017 01:56:15 +0100 >> > Christoph Hellwig

RE: [bug report] scsi: aacraid: Reorder Adapter status check

2017-03-02 Thread Dave Carroll
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Monday, February 27, 2017 8:32 AM > To: Raghava Aditya Renukunta > Cc: linux-scsi@vger.kernel.org > Subject: [bug report] scsi: aacraid: Reorder

[GIT PULL] target updates for v4.11-rc1

2017-03-02 Thread Nicholas A. Bellinger
Hello Linus, Here are the outstanding target pending changes for v4.11-rc1. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next The highlights this round include: - Enable dual mode (initiator + target) qla2xxx operation. (Quinn +

[bug report] scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-03-02 Thread Dan Carpenter
Hello Dupuis, Chad, The patch 61d8658b4a43: "scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework." from Feb 15, 2017, leads to the following static checker warning: drivers/scsi/qedf/qedf_main.c:1168 qedf_rport_event_handler() warn: 'rval' can be either negative or

Re: [PATCHv3 1/6] scsi_error: count medium access timeout only once per EH run

2017-03-02 Thread Benjamin Block
Hej Hannes, On Wed, Mar 01, 2017 at 10:15:15AM +0100, Hannes Reinecke wrote: > The current medium access timeout counter will be increased for > each command, so if there are enough failed commands we'll hit > the medium access timeout for even a single failure. > Fix this by making the timeout

Re: [ANNOUNCE]: Broadcom (Emulex) FC Target driver - efct

2017-03-02 Thread Nicholas A. Bellinger
Hi James & Co, Adding target-devel and Sebastian CC' On Mon, 2017-02-27 at 15:28 -0800, James Smart wrote: > I'd like to announce the availability of the Broadcom (Emulex) FC Target > driver - efct. > This driver has been part of the Emulex OneCore Storage SDK tool kit for > Emulex > SLI-4

Re: SCSI regression in 4.11

2017-03-02 Thread James Bottomley
On March 2, 2017 11:05:05 AM PST, Stephen Hemminger wrote: >On Thu, 02 Mar 2017 10:36:17 -0800 >James Bottomley wrote: > >> On March 2, 2017 10:23:24 AM PST, Stephen Hemminger > wrote: >> >On Thu, 2

Re: [regression] vmw_pvscsi probe fails on 4.11

2017-03-02 Thread Loïc Yhuel
Le 02/03/2017 à 17:05, Christoph Hellwig a écrit : Please try this patch: diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c index ef474a748744..c374e3b5c678 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi/vmw_pvscsi.c @@ -1487,7 +1487,7 @@ static int

Re: SCSI regression in 4.11

2017-03-02 Thread Stephen Hemminger
On Thu, 02 Mar 2017 10:36:17 -0800 James Bottomley wrote: > On March 2, 2017 10:23:24 AM PST, Stephen Hemminger > wrote: > >On Thu, 2 Mar 2017 14:25:14 +0100 > >Hannes Reinecke wrote: > > > >> On 03/02/2017

Re: SCSI regression in 4.11

2017-03-02 Thread Stephen Hemminger
On Thu, 2 Mar 2017 14:25:14 +0100 Hannes Reinecke wrote: > On 03/02/2017 02:40 AM, Stephen Hemminger wrote: > > On Thu, 2 Mar 2017 01:56:15 +0100 > > Christoph Hellwig wrote: > > > >> On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote: > >>> On Wed,

Re: SCSI regression in 4.11

2017-03-02 Thread Stephen Hemminger
On Thu, 2 Mar 2017 14:25:14 +0100 Hannes Reinecke wrote: > On 03/02/2017 02:40 AM, Stephen Hemminger wrote: > > On Thu, 2 Mar 2017 01:56:15 +0100 > > Christoph Hellwig wrote: > > > >> On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote: > >>> On Wed,

Re: [regression] vmw_pvscsi probe fails on 4.11

2017-03-02 Thread Christoph Hellwig
Please try this patch: diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c index ef474a748744..c374e3b5c678 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi/vmw_pvscsi.c @@ -1487,7 +1487,7 @@ static int pvscsi_probe(struct pci_dev *pdev, const struct pci_device_id *id)

Re: [PATCH] scsi_sysfs: fix hang when removing scsi device

2017-03-02 Thread Bart Van Assche
On Thu, 2017-03-02 at 16:45 +0200, Israel Rukshin wrote: > The bug reproduce when unloading srp module with one port down. > device_del() hangs when __scsi_remove_device() get scsi_device with > state SDEV_OFFLINE or SDEV_TRANSPORT_OFFLINE. > It hangs because device_del() is trying to send sync

Re: [PATCH] scsi: qedi: fix build error without DEBUG_FS

2017-03-02 Thread Arnd Bergmann
On Thu, Mar 2, 2017 at 1:10 PM, Arnd Bergmann wrote: > > - QEDI_INFO(qedi_dbg, QEDI_LOG_DEBUGFS, "do_not_recover=%d\n", > - do_not_recover); > + QEDI_INFO(qedi_dbg, QEDI_LOG_DEBUGFS, "qedi_do_not_recover=%d\n", > + qedi_do_not_recover);

[PATCH] scsi_sysfs: fix hang when removing scsi device

2017-03-02 Thread Israel Rukshin
The bug reproduce when unloading srp module with one port down. device_del() hangs when __scsi_remove_device() get scsi_device with state SDEV_OFFLINE or SDEV_TRANSPORT_OFFLINE. It hangs because device_del() is trying to send sync cache command when the device is offline but with SDEV_CANCEL

Re: [PATCH] scsi: qedi: fix build error without DEBUG_FS

2017-03-02 Thread Johannes Thumshirn
On 03/02/2017 01:10 PM, Arnd Bergmann wrote: > Without CONFIG_DEBUG_FS, we run into a link error: > > drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_poll': > qedi_iscsi.c:(.text.qedi_ep_poll+0x134): undefined reference to > `do_not_recover' > drivers/scsi/qedi/qedi_iscsi.o: In function

[PATCH] [v2] scsi: qedi: fix build error without DEBUG_FS

2017-03-02 Thread Arnd Bergmann
Without CONFIG_DEBUG_FS, we run into a link error: drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_poll': qedi_iscsi.c:(.text.qedi_ep_poll+0x134): undefined reference to `do_not_recover' drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_disconnect':

Re: [PATCHv3 1/6] scsi_error: count medium access timeout only once per EH run

2017-03-02 Thread Hannes Reinecke
On 03/02/2017 12:24 AM, Bart Van Assche wrote: On Wed, 2017-03-01 at 10:15 +0100, Hannes Reinecke wrote: The current medium access timeout counter will be increased for each command, so if there are enough failed commands we'll hit the medium access timeout for even a single failure. This

Re: SCSI regression in 4.11

2017-03-02 Thread Hannes Reinecke
On 03/02/2017 02:40 AM, Stephen Hemminger wrote: On Thu, 2 Mar 2017 01:56:15 +0100 Christoph Hellwig wrote: On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote: On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote:

[PATCH] scsi: qedi: fix build error without DEBUG_FS

2017-03-02 Thread Arnd Bergmann
Without CONFIG_DEBUG_FS, we run into a link error: drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_poll': qedi_iscsi.c:(.text.qedi_ep_poll+0x134): undefined reference to `do_not_recover' drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_disconnect':

[PATCH] megaraid_sas: enable intx only if msix request fails

2017-03-02 Thread Kashyap Desai
Without this fix, driver will enable INTx Interrupt pin even though MSI-x vectors are enabled. See below lspci output. DisINTx is unset for MSIx setup. lspci -s 85:00.0 -vvv |grep INT |grep Control Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+

[PATCH] enclosure: fix sysfs symlinks creation when using multipath

2017-03-02 Thread Maurizio Lombardi
With multipath, it may happen that the same device is passed to enclosure_add_device() multiple times and that the enclosure_add_links() function fails to create the symlinks because the device's sysfs directory entry is still NULL. In this case, the links will never be created because all the

Re: sg driver, sg_io and sg tablesize

2017-03-02 Thread Fam Zheng
On Wed, 03/01 17:11, Laurence Oberman wrote: > This was suggested by Ewan and is the best way to know what the actual max I/O > size for sg_io would be for the LPFC driver. This sounds silly, why is there a "lame" max I/O size as in max_sectors_kb, that is unusable because of a more limiting

[regression] vmw_pvscsi probe fails on 4.11

2017-03-02 Thread Loïc Yhuel
Hi, On Fedora Rawhide (reproduced on git master), vmw_pvscsi probe fails. It also calls free_irq during cleanup, which produces a warning since it didn't call request_irq in this case. Reverting commit 2e48e34 (scsi: vmw_pvscsi: switch to pci_alloc_irq_vectors) fixes the issue (I get

Re: [PATCH] mpt3sas: Avoid sleeping in interrupt context

2017-03-02 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Bart> Commit 669f044170d8 ("scsi: srp_transport: Move queuecommand() Bart> wait code to SCSI core") can make scsi_internal_device_block() Bart> sleep. However, the mpt3sas driver can call this function from an Bart> interrupt

Re: [PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target.

2017-03-02 Thread Nicholas A. Bellinger
Hi Himanshu & Co, On Fri, 2017-02-24 at 13:37 -0800, Himanshu Madhani wrote: > Hi Nic, > > Please consider this series for inclusion in target-pending. > This is a little late to include for v4.11-rc1, but considering the number of bug-fixes I'm OK to merge it post -rc1. > This series