[PATCH resend] scsi: fc: drop residual tsk_mgmt_response and it_nexus_response

[Kefeng Wang]

After commit 556e26a70b64 ("scsi: remove tsk_mgmt_response and
it_nexus_response transport methods"), the target driver support
was removed totally. Drop the residua.

Signed-off-by: Kefeng Wang 
---
 include/scsi/scsi_transport_fc.h | 4 
 1 file changed, 4 deletions(-)

diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h
index 6e208bb..e308cd5 100644
--- a/include/scsi/scsi_transport_fc.h
+++ b/include/scsi/scsi_transport_fc.h
@@ -658,10 +658,6 @@ struct fc_function_template {
int (*vport_disable)(struct fc_vport *, bool);
int (*vport_delete)(struct fc_vport *);
 
-   /* target-mode drivers' functions */
-   int (* tsk_mgmt_response)(struct Scsi_Host *, u64, u64, int);
-   int (* it_nexus_response)(struct Scsi_Host *, u64, int);
-
/* bsg support */
int (*bsg_request)(struct bsg_job *);
int (*bsg_timeout)(struct bsg_job *);
-- 
1.7.12.4

Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server

[Madhani, Himanshu]

Hi Johannes, 

> On Jun 19, 2017, at 3:06 AM, Johannes Thumshirn  wrote:
> 
> On Fri, Jun 16, 2017 at 03:47:42PM -0700, Himanshu Madhani wrote:
>> From: Duane Grigsby 
>> 
>> This patch adds switch command support for FC-4 type of FC-NVMe (0x28)
>> for resgistering HBA port to the management server. RFT_ID command is
>> used to register FC-4 type of 0x28 and RFF_ID is used to register
>> FC-4 features bits for FC-NVMe port.
>> 
>> Signed-off-by: Darren Trapp 
>> Signed-off-by: Duane Grigsby 
>> Signed-off-by: Anil Gurumurthy 
>> Signed-off-by: Giridhar Malavali 
>> Signed-off-by: Himanshu Madhani 
>> ---
> 
> [...]
> 
>> +   ct_rsp = >ct_desc.ct_sns->p.rsp;
>> +   /*
>> +* FC-GS-7, 5.2.3.12 FC-4 Features - format
>> +* The format of the FC-4 Features object, as defined by the FC-4,
>> +* Shall be an array of 4-bit values, one for each type code value
>> +*/
> 
> Indentation looks a bit odd here. Did you run checkpatch.pl on the series?
> 

forgot to reply to this earlier. Yes. I ran checkpatch.pl on this series.

Somehow in the actual code this does not look like issue. (i.e. correct 
indentation is seen) 
i am not sure why in patch view its showing one space off.
 
>> @@ -4634,6 +4637,12 @@ qla2x00_configure_fabric(scsi_qla_host_t *vha)
>>  >dpc_flags))
>>  break;
>>  }
>> +if (vha->flags.nvme_enabled) {
>> +if (qla2x00_rff_id(vha, FC4_TYPE_NVME)) {
> 
>   if (vha->flags.nvme_enabled && 
>   qla2x00_rff_id(vha, FC4_TYPE_NVME)) 
>   ql_dbg(ql_dbg_disc, vha, 0x2049, )
> 
>> +ql_dbg(ql_dbg_disc, vha, 0x2049,
>> +"Register NVME FC Type Features 
>> failed.\n");
>> +}
>> +}
> 
> -- 
> Johannes Thumshirn  Storage
> jthumsh...@suse.de+49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Thanks,
- Himanshu

[PATCH] scsi: csiostor: update module version

[Varun Prakash]

Add -ko to the module version similar to module version of
other Chelsio drivers.

Signed-off-by: Varun Prakash 
---
 drivers/scsi/csiostor/csio_init.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/csiostor/csio_init.h 
b/drivers/scsi/csiostor/csio_init.h
index 5cc5d31..96b31e5 100644
--- a/drivers/scsi/csiostor/csio_init.h
+++ b/drivers/scsi/csiostor/csio_init.h
@@ -50,7 +50,7 @@
 #define CSIO_DRV_AUTHOR"Chelsio Communications"
 #define CSIO_DRV_LICENSE   "Dual BSD/GPL"
 #define CSIO_DRV_DESC  "Chelsio FCoE driver"
-#define CSIO_DRV_VERSION   "1.0.0"
+#define CSIO_DRV_VERSION   "1.0.0-ko"
 
 extern struct fc_function_template csio_fc_transport_funcs;
 extern struct fc_function_template csio_fc_transport_vport_funcs;
-- 
2.0.2

RE: remove dma_alloc_noncoherent

[David Laight]

From: Christoph Hellwig
> Sent: 16 June 2017 08:17
>
> For many years we've had the dma_alloc_attrs API that is more flexible
> than dma_alloc_noncoherent.  This series moves the remaining users over
> to the attrs API.

And most of the callers probably only want to specify 'noncoherent'.
Grepping the source for other uses is easier if the wrapper is left.

David

Re: enclosure: fix sysfs symlinks creation when using multipath

[Maurizio Lombardi]

Dne 16.6.2017 v 18:08 Douglas Miller napsal(a):
> Just to respond to James' question on the cause. What I observed was a race 
> condition between udevd (ses_init()) and a worker thread (do_scan_async()),
> where the worker thread is creating the directories that are the target of 
> the symlinks being created by udevd.
> Something was happening when udevd caught up with the worker thread (so the 
> target directory did not exist) and it seemed the worker thread either got 
> preempted or
> else just could not stay ahead of udevd. This means that udevd started 
> failing to create symlinks even though the worker thread eventually got them 
> all created.
> I did observe what appeared to be preemption, as the creation of directories 
> stopped until udevd finished failing all the (rest of the) symlinks.
> Although there may have been other explanations for what I saw.
> 

> I am able to pass my testing with this patch. I don't see an official submit 
> of this patch, but will respond to it when I see one.

Thanks Douglas for testing it, I will resubmit the patch if no one has any 
objections.

Maurizio.

Re: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

[Bartlomiej Zolnierkiewicz]

On Tuesday, June 20, 2017 11:10:45 AM Christoph Hellwig wrote:
> On Mon, Jun 19, 2017 at 01:15:04PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Friday, June 16, 2017 09:17:08 AM Christoph Hellwig wrote:
> > > au1100fb is using managed dma allocations, so it doesn't need to
> > > explicitly free the dma memory in the error path (and if it did
> > > it would have to use the managed version).
> > > 
> > > Signed-off-by: Christoph Hellwig 
> > 
> > Acked-by: Bartlomiej Zolnierkiewicz 
> 
> Are you fine with picking this up through the new dma-mapping tree?

Yes, this is why Ack-ed it.

If you prefer me to merge it through fbdev for 4.13 please let me know.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

Re: mptsas crash on expander hot-remove

[John Garry]

On 19/06/2017 09:23, Johannes Thumshirn wrote:

On Fri, Jun 16, 2017 at 07:57:08PM -0400, Will Simoneau wrote:

Is this is a known / obvious issue, or should I try to bisect it?




Out of curiousity, does this issue also occur when only the disk is 
hot-removed from the expander?



This is a known issue with SAS (and FC) drivers, although no soulution exists
to this point.

Johannes

Re: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

[Christoph Hellwig]

On Mon, Jun 19, 2017 at 01:15:04PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Friday, June 16, 2017 09:17:08 AM Christoph Hellwig wrote:
> > au1100fb is using managed dma allocations, so it doesn't need to
> > explicitly free the dma memory in the error path (and if it did
> > it would have to use the managed version).
> > 
> > Signed-off-by: Christoph Hellwig 
> 
> Acked-by: Bartlomiej Zolnierkiewicz 

Are you fine with picking this up through the new dma-mapping tree?

RE: [PATCH v6 00/22] hisi_sas: hip08 support

[John Garry]

Thanks!

-Original Message-
From: Martin K. Petersen [mailto:martin.peter...@oracle.com] 
Sent: 20 June 2017 02:42
To: John Garry
Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; Linuxarm; 
linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; a...@arndb.de; 
h...@infradead.org
Subject: Re: [PATCH v6 00/22] hisi_sas: hip08 support


John,

> This patchset adds support for the HiSilicon SAS controller in the
> hip08 chipset.

Applied to 4.13/scsi-queue. Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [lkp-robot] [scsi] ebc76736f2: fio.write_bw_MBps -4% regression

[Christoph Hellwig]

On Tue, Jun 20, 2017 at 10:16:36AM +0800, Ye Xiaolong wrote:
> Hi, Christoph
> 
> On 06/19, Christoph Hellwig wrote:
> >On Mon, Jun 19, 2017 at 04:52:36PM +0800, Ye Xiaolong wrote:
> >> >I've not seen a compile-time option for the MQ I/O scheduler (unlike
> >> >the legacy one), so the way to change it would be to echo the name to
> >> >/sys/block//queue/scheduler 
> >> 
> >> echo mq-deadline > /sys/block//queue/scheduler ?
> >> 
> >> I'll try and post the results once I get it.
> >
> >Thanks!
> 
> I've re-run the test and cat /sys/block/sda/queue/scheduler and
> /sys/block/sda/queue/scheduler, and both showed "[mq-deadline] kyber none",
> Does it mean they have already set as 'mq-deadline'?

Yes, it seems like you're already using mq-deadline, but bfq isn't even
available.