Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-16 Thread Martin Wilck
On Wed, 2018-01-17 at 01:15 -0500, Martin K. Petersen wrote: > Martin, > > > + if (!strncmp(scmd->device->vendor, "FUJITSU", 7) > > && > > + !strncmp(scmd->device->model, > > "ETERNUS_DXM", 11) && > > Blacklist, please. > To make sure I understand correctly:

Re: [PATCH] scsi: devinfo: fix format of the device list

2018-01-16 Thread Martin K. Petersen
Xose, > Replace "" with NULL for product revision level, and > merge TEXEL duplicate entries. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/8] qla2xxx: Minor fixes for the driver

2018-01-16 Thread Martin K. Petersen
Himanshu, > This series has fixes for smatch warnings. Patch 3 addresses smatch > warning reported by Dan Carpenter. We've also added a patch for async > abort handling for initiator multiqueue in the driver along with a > patch for NULL pointer access during probe failure. Applied to

Re: [PATCH] scsi: mptsas: remove duplicated assignment to pointer head

2018-01-16 Thread Martin K. Petersen
Colin, > The pointer head is re-assigned the same value twice, so remove the > second redundant assignment. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

2018-01-16 Thread Martin K. Petersen
Dan, > We should set the error code if fc_remote_port_add() fails. Applied to 4.16/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-16 Thread Martin K. Petersen
Martin, > + if (!strncmp(scmd->device->vendor, "FUJITSU", 7) && > +!strncmp(scmd->device->model, "ETERNUS_DXM", 11) && Blacklist, please. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v1] mptfusion: Use snprintf() instead of open coded divisions

2018-01-16 Thread Martin K. Petersen
Andy, > Numbers up to 100 snprintf() prints without using a division. > Besides that the code looks more readable. Applied to 4.16/scsi-queue (despite not really being a fan of cleaning up dead code). Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: how to enlarge value of max_sectors_kb

2018-01-16 Thread Martin K. Petersen
Tang, > There is a machine with very little max_sectors_kb size: > [root@ceph151 queue]# pwd > /sys/block/sdd/queue > [root@ceph151 queue]# cat max_hw_sectors_kb > 256 > [root@ceph151 queue]# cat max_sectors_kb > 256 > > The performance is very low when I run big I/Os. > I can not modify it

Re: [PATCH][scsi-next] scsi: mpt3sas: make function _get_st_from_smid static

2018-01-16 Thread Martin K. Petersen
Colin, > The function _get_st_from_smid is local to the source and does > not need to be in global scope, so make it static. Applied to 4.16/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: hisi_sas: make local symbol host_attrs static

2018-01-16 Thread Martin K. Petersen
Wei, > Fixes the following sparse warning: > > drivers/scsi/hisi_sas/hisi_sas_main.c:1691:25: warning: > symbol 'host_attrs' was not declared. Should it be static? Applied to 4.16/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi_debug: delay stress fix

2018-01-16 Thread Martin K. Petersen
Doug, > Introduce a state enum into sdebug_defer objects to indicate which, if > any, defer method has been used with the associated command. Also add > 2 bools to indicate which of the defer methods has been > initialized. Those objects are re-used but the initialization only > needs to be

Re: [PATCH] scsi: fnic: use kzalloc in fnic_fcoe_process_vlan_resp

2018-01-16 Thread Martin K. Petersen
Rasmus, > This saves a little .text and gets rid of the unmotivated line break and > the sizeof(...) style inconsistency. Applied to 4.16/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2018-01-16 Thread Martin K. Petersen
Bart, >> Applied to 4.15/scsi-fixes. Thanks! > > Since that patch fixes an issue that was introduced in kernel v4.14 > but did not have a "Cc: stable" tag, should this patch be sent to Greg > for inclusion in the kernel v4.14.x series? Yes. Hannes? -- Martin K. Petersen Oracle Linux

Re: [PATCH 1/1] scsi_debug: delay stress fix

2018-01-16 Thread Bart Van Assche
On Wed, 2018-01-10 at 16:57 -0500, Douglas Gilbert wrote: > Introduce a state enum into sdebug_defer objects to indicate which, > if any, defer method has been used with the associated command. > Also add 2 bools to indicate which of the defer methods has been > initialized. Those objects are

Re: HP ProLiant DL360p Gen8 hangs with Linux 4.13+.

2018-01-16 Thread Vinson Lee
On Wed, Jan 10, 2018 at 4:52 PM, Vinson Lee wrote: > On Fri, Jan 5, 2018 at 8:32 AM, Bart Van Assche > wrote: >> On Thu, 2018-01-04 at 14:32 -0800, Vinson Lee wrote: >>> HP ProLiant DL360p Gen8 with Smart Array P420i boots to the login >>> prompt

Re: [Lsf-pc] [LSF/MM TOPIC] A high-performance userspace block driver

2018-01-16 Thread Bart Van Assche
On Tue, 2018-01-16 at 15:28 -0800, James Bottomley wrote: > On Tue, 2018-01-16 at 18:23 -0500, Theodore Ts'o wrote: > > On Tue, Jan 16, 2018 at 06:52:40AM -0800, Matthew Wilcox wrote: > > > > > > > > > I see the improvements that Facebook have been making to the nbd > > > driver, and I think

Re: [Lsf-pc] [LSF/MM TOPIC] A high-performance userspace block driver

2018-01-16 Thread James Bottomley
On Tue, 2018-01-16 at 18:23 -0500, Theodore Ts'o wrote: > On Tue, Jan 16, 2018 at 06:52:40AM -0800, Matthew Wilcox wrote: > > > > > > I see the improvements that Facebook have been making to the nbd > > driver, and I think that's a wonderful thing.  Maybe the outcome of > > this topic is simply:

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-16 Thread Tony Luck
On Sat, Jan 13, 2018 at 10:51 AM, Linus Torvalds wrote: > On Fri, Jan 12, 2018 at 4:15 PM, Tony Luck wrote: > So your argument depends on "the uarch will actually run the code in > order if there are no events that block the pipeline". And

[PATCH] scsi: mptsas: remove duplicated assignment to pointer head

2018-01-16 Thread Colin King
From: Colin Ian King The pointer head is re-assigned the same value twice, so remove the second redundant assignment. Cleans up clang warning: drivers/message/fusion/mptsas.c:1161:20: warning: Value stored to 'head' during its initialization is never read

Re: [PATCH] tcmu: Fix trailing semicolon

2018-01-16 Thread Michael Christie
On 01/16/2018 09:34 AM, Luis de Bethencourt wrote: > The trailing semicolon is an empty statement that does no operation. > It is completely stripped out by the compiler. Removing it since it doesn't do > anything. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > >

Re: [PATCH] scsi: check for device state in __scsi_remove_target()

2018-01-16 Thread Bart Van Assche
On Mon, 2017-12-18 at 22:37 -0500, Martin K. Petersen wrote: > Hannes, > > > As it turned out device_get() doesn't use kref_get_unless_zero(), > > so we will be always getting a device pointer. > > So we need to check for the device state in __scsi_remove_target() > > to avoid tripping over

Re: [PATCH] scsi_sysfs: fix list entry double-deletion

2018-01-16 Thread Bart Van Assche
On Tue, 2018-01-16 at 14:10 +0800, zhenwei.pi wrote: > CPU: 15 PID: 23529 Comm: lvm Tainted: G D W E 4.14.11 #1 Please retest with kernel v4.15-rc6 or later. That kernel includes commit 81b6c9998979 ("scsi: core: check for device state in __scsi_remove_target()"). Thanks, Bart.

[PATCH] tcmu: Fix trailing semicolon

2018-01-16 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. It is completely stripped out by the compiler. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches

RE: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

2018-01-16 Thread KY Srinivasan
> -Original Message- > From: Cathy Avery [mailto:cav...@redhat.com] > Sent: Tuesday, January 16, 2018 6:36 AM > To: Dan Carpenter ; KY Srinivasan > > Cc: Haiyang Zhang ; Stephen Hemminger > ;

Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

2018-01-16 Thread Cathy Avery
On 01/16/2018 05:40 AM, Dan Carpenter wrote: We should set the error code if fc_remote_port_add() fails. Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c

Re: [PATCH 0/2] genirq/affinity: try to make sure online CPU is assgined to irq vector

2018-01-16 Thread Ming Lei
On Tue, Jan 16, 2018 at 12:25:19PM +0100, Thomas Gleixner wrote: > On Tue, 16 Jan 2018, Ming Lei wrote: > > > On Mon, Jan 15, 2018 at 09:40:36AM -0800, Christoph Hellwig wrote: > > > On Tue, Jan 16, 2018 at 12:03:43AM +0800, Ming Lei wrote: > > > > Hi, > > > > > > > > These two patches fixes IO

Re: [PATCH] mptfusion: use strlcpy() instead of strncpy()

2018-01-16 Thread Xiongfeng Wang
On 2018/1/16 3:34, Andy Shevchenko wrote: > On Fri, Jan 12, 2018 at 5:09 PM, Bart Van Assche > wrote: >> On Fri, 2018-01-12 at 15:45 +0200, Andy Shevchenko wrote: >>> On Fri, Jan 12, 2018 at 1:46 PM, Wang wrote: > >>> This one is false

[PATCH] scsi: storvsc: missing error code in storvsc_probe()

2018-01-16 Thread Dan Carpenter
We should set the error code if fc_remote_port_add() fails. Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.") Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 3b3d1d050cac..40fc7a590e81 100644 ---

Assalamu`Alaikum.

2018-01-16 Thread Mohammad Ouattara
Greetings from Dr. mohammad ouattara. Assalamu`Alaikum. My Name is Dr. mohammad ouattara, I am a banker by profession. I'm from Ouagadougou, Burkina Faso, West Africa. My reason for contacting you is to transfer an abandoned $14.6M to your account. The owner of this fund died since 2004

Re: [Drbd-dev] [PATCH 23/27] drbd: make intelligent use of blkdev_issue_zeroout

2018-01-16 Thread Lars Ellenberg
On Mon, Jan 15, 2018 at 10:07:38AM -0500, Mike Snitzer wrote: > > See also: > > https://www.redhat.com/archives/dm-devel/2017-March/msg00213.html > > https://www.redhat.com/archives/dm-devel/2017-March/msg00226.html > > Right, now that you mention it it is starting to ring a bell (especially >