On Wed, 2018-01-17 at 01:15 -0500, Martin K. Petersen wrote:
> Martin,
>
> > + if (!strncmp(scmd->device->vendor, "FUJITSU", 7)
> > &&
> > + !strncmp(scmd->device->model,
> > "ETERNUS_DXM", 11) &&
>
> Blacklist, please.
>
To make sure I understand correctly:
Xose,
> Replace "" with NULL for product revision level, and
> merge TEXEL duplicate entries.
Applied to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This series has fixes for smatch warnings. Patch 3 addresses smatch
> warning reported by Dan Carpenter. We've also added a patch for async
> abort handling for initiator multiqueue in the driver along with a
> patch for NULL pointer access during probe failure.
Applied to
Colin,
> The pointer head is re-assigned the same value twice, so remove the
> second redundant assignment.
Applied to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> We should set the error code if fc_remote_port_add() fails.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Martin,
> + if (!strncmp(scmd->device->vendor, "FUJITSU", 7) &&
> +!strncmp(scmd->device->model, "ETERNUS_DXM", 11) &&
Blacklist, please.
--
Martin K. Petersen Oracle Linux Engineering
Andy,
> Numbers up to 100 snprintf() prints without using a division.
> Besides that the code looks more readable.
Applied to 4.16/scsi-queue (despite not really being a fan of cleaning
up dead code). Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tang,
> There is a machine with very little max_sectors_kb size:
> [root@ceph151 queue]# pwd
> /sys/block/sdd/queue
> [root@ceph151 queue]# cat max_hw_sectors_kb
> 256
> [root@ceph151 queue]# cat max_sectors_kb
> 256
>
> The performance is very low when I run big I/Os.
> I can not modify it
Colin,
> The function _get_st_from_smid is local to the source and does
> not need to be in global scope, so make it static.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Wei,
> Fixes the following sparse warning:
>
> drivers/scsi/hisi_sas/hisi_sas_main.c:1691:25: warning:
> symbol 'host_attrs' was not declared. Should it be static?
Applied to 4.16/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Doug,
> Introduce a state enum into sdebug_defer objects to indicate which, if
> any, defer method has been used with the associated command. Also add
> 2 bools to indicate which of the defer methods has been
> initialized. Those objects are re-used but the initialization only
> needs to be
Rasmus,
> This saves a little .text and gets rid of the unmotivated line break and
> the sizeof(...) style inconsistency.
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Bart,
>> Applied to 4.15/scsi-fixes. Thanks!
>
> Since that patch fixes an issue that was introduced in kernel v4.14
> but did not have a "Cc: stable" tag, should this patch be sent to Greg
> for inclusion in the kernel v4.14.x series?
Yes. Hannes?
--
Martin K. Petersen Oracle Linux
On Wed, 2018-01-10 at 16:57 -0500, Douglas Gilbert wrote:
> Introduce a state enum into sdebug_defer objects to indicate which,
> if any, defer method has been used with the associated command.
> Also add 2 bools to indicate which of the defer methods has been
> initialized. Those objects are
On Wed, Jan 10, 2018 at 4:52 PM, Vinson Lee wrote:
> On Fri, Jan 5, 2018 at 8:32 AM, Bart Van Assche
> wrote:
>> On Thu, 2018-01-04 at 14:32 -0800, Vinson Lee wrote:
>>> HP ProLiant DL360p Gen8 with Smart Array P420i boots to the login
>>> prompt
On Tue, 2018-01-16 at 15:28 -0800, James Bottomley wrote:
> On Tue, 2018-01-16 at 18:23 -0500, Theodore Ts'o wrote:
> > On Tue, Jan 16, 2018 at 06:52:40AM -0800, Matthew Wilcox wrote:
> > >
> > >
> > > I see the improvements that Facebook have been making to the nbd
> > > driver, and I think
On Tue, 2018-01-16 at 18:23 -0500, Theodore Ts'o wrote:
> On Tue, Jan 16, 2018 at 06:52:40AM -0800, Matthew Wilcox wrote:
> >
> >
> > I see the improvements that Facebook have been making to the nbd
> > driver, and I think that's a wonderful thing. Maybe the outcome of
> > this topic is simply:
On Sat, Jan 13, 2018 at 10:51 AM, Linus Torvalds
wrote:
> On Fri, Jan 12, 2018 at 4:15 PM, Tony Luck wrote:
> So your argument depends on "the uarch will actually run the code in
> order if there are no events that block the pipeline".
And
From: Colin Ian King
The pointer head is re-assigned the same value twice, so remove the
second redundant assignment.
Cleans up clang warning:
drivers/message/fusion/mptsas.c:1161:20: warning: Value stored to 'head'
during its initialization is never read
On 01/16/2018 09:34 AM, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> It is completely stripped out by the compiler. Removing it since it doesn't do
> anything.
>
> Signed-off-by: Luis de Bethencourt
> ---
>
> Hi,
>
>
On Mon, 2017-12-18 at 22:37 -0500, Martin K. Petersen wrote:
> Hannes,
>
> > As it turned out device_get() doesn't use kref_get_unless_zero(),
> > so we will be always getting a device pointer.
> > So we need to check for the device state in __scsi_remove_target()
> > to avoid tripping over
On Tue, 2018-01-16 at 14:10 +0800, zhenwei.pi wrote:
> CPU: 15 PID: 23529 Comm: lvm Tainted: G D W E 4.14.11 #1
Please retest with kernel v4.15-rc6 or later. That kernel includes commit
81b6c9998979 ("scsi: core: check for device state in __scsi_remove_target()").
Thanks,
Bart.
The trailing semicolon is an empty statement that does no operation.
It is completely stripped out by the compiler. Removing it since it doesn't do
anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> -Original Message-
> From: Cathy Avery [mailto:cav...@redhat.com]
> Sent: Tuesday, January 16, 2018 6:36 AM
> To: Dan Carpenter ; KY Srinivasan
>
> Cc: Haiyang Zhang ; Stephen Hemminger
> ;
On 01/16/2018 05:40 AM, Dan Carpenter wrote:
We should set the error code if fc_remote_port_add() fails.
Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.")
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
On Tue, Jan 16, 2018 at 12:25:19PM +0100, Thomas Gleixner wrote:
> On Tue, 16 Jan 2018, Ming Lei wrote:
>
> > On Mon, Jan 15, 2018 at 09:40:36AM -0800, Christoph Hellwig wrote:
> > > On Tue, Jan 16, 2018 at 12:03:43AM +0800, Ming Lei wrote:
> > > > Hi,
> > > >
> > > > These two patches fixes IO
On 2018/1/16 3:34, Andy Shevchenko wrote:
> On Fri, Jan 12, 2018 at 5:09 PM, Bart Van Assche
> wrote:
>> On Fri, 2018-01-12 at 15:45 +0200, Andy Shevchenko wrote:
>>> On Fri, Jan 12, 2018 at 1:46 PM, Wang wrote:
>
>>> This one is false
We should set the error code if fc_remote_port_add() fails.
Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.")
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 3b3d1d050cac..40fc7a590e81 100644
---
Greetings from Dr. mohammad ouattara.
Assalamu`Alaikum.
My Name is Dr. mohammad ouattara, I am a banker by profession. I'm from
Ouagadougou, Burkina Faso, West Africa. My reason for contacting you is to
transfer an abandoned $14.6M to your account.
The owner of this fund died since 2004
On Mon, Jan 15, 2018 at 10:07:38AM -0500, Mike Snitzer wrote:
> > See also:
> > https://www.redhat.com/archives/dm-devel/2017-March/msg00213.html
> > https://www.redhat.com/archives/dm-devel/2017-March/msg00226.html
>
> Right, now that you mention it it is starting to ring a bell (especially
>
30 matches
Mail list logo