Re: [V1] mpt3sas: Do not use 32-bit atomic request descriptor for Ventura controllers.

On Wed, 14 Feb 2018 02:16:37 -0800 Suganath Prabu S wrote: > Problem Statement: Sending I/O through 32 bit descriptors to > Ventura series of controller results in IO timeout on certain > conditions. > > This error only occurs on systems with high I/O

RE: [PATCH v2] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

Mauricio, During the shutdown time, I don't want the outstanding IOs to timeout due to disabling of interrupts and go the TM path. So I wanted to clear out all the Outstanding IOs in the shutdown path itself instead of clearing them in TM path. But if there are already some TMs are outstanding

[PATCH] scsi: scsi_transport_spi make two const arrays static, shrinks object size

From: Colin Ian King Don't populate the const read-only arrays spi_test_unit_ready and spi_test_unit_ready on the stack but instead make them static. Makes the object code smaller by over 100 bytes: Before: textdata bss dec hex filename 40171

RE: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

The writeq is defined to ensure both the registers are written without any interleaved access in between the two writels in 32 bit systems. Also we want to retain the order of writing the registers. If needed I can dig out the issue we have faced using writeq in 32 bit systems (happened five/six

Re: [GIT PULL] SCSI fixes for 4.16-rc1

On Wed, Feb 14, 2018 at 12:28 PM, James Bottomley wrote: > > Actually, can I cancel this. We've had a tree rebase between mine and > Martin's which means I need to do a reset. I'll do that now and submit > a new pull request next week. Ok, dropped.

Re: [GIT PULL] SCSI fixes for 4.16-rc1

James, > These are mostly fixes for problems with merge window code.  In > addition we have one doc update (alua) and two dead code removals > (aiclib and octogon) a spurious assignment removal (csiostor) and a > performance improvement for storvsc involving better interrupt > spreading and

Re: [GIT PULL] SCSI fixes for 4.16-rc1

On Wed, 2018-02-14 at 12:19 -0800, James Bottomley wrote: > These are mostly fixes for problems with merge window code.  In > addition we have one doc update (alua) and two dead code removals > (aiclib and octogon) a spurious assignment removal (csiostor) and a > performance improvement for

[GIT PULL] SCSI fixes for 4.16-rc1

These are mostly fixes for problems with merge window code.  In addition we have one doc update (alua) and two dead code removals (aiclib and octogon) a spurious assignment removal (csiostor) and a performance improvement for storvsc involving better interrupt spreading and increasing the command

[PATCH v2] scsi: qla2xxx: Use dma_pool_zalloc()

Use dma_pool_zalloc() instead of dma_pool_alloc + memset Signed-off-by: Souptick Joarder --- v2: Remove extra line and comment drivers/scsi/qla2xxx/qla_bsg.c| 3 +-- drivers/scsi/qla2xxx/qla_iocb.c | 10 ++ drivers/scsi/qla2xxx/qla_target.c | 7 +-- 3

Re: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

On Wed, 2018-02-14 at 21:48 +0200, Andy Shevchenko wrote: > On Wed, 2018-02-14 at 11:40 -0800, James Bottomley wrote: > > > > On Wed, 2018-02-14 at 20:10 +0200, Andy Shevchenko wrote: > > > > > > Since we have a writeq() for 32-bit architectures as provided by > > > IO > > > non-atomic helpers,

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

Hi John, > On Feb 13, 2018, at 2:54 AM, John Garry wrote: > > On 12/02/2018 18:28, Himanshu Madhani wrote: >> This patch fixes NULL pointer crash due to active timer running >> for abort IOCB. >> >>> From crash dump analysis it was discoverd that

[PATCH] scsi: qla2xxx: Use dma_pool_zalloc()

Use dma_pool_zalloc() instead of dma_pool_alloc + memset Signed-off-by: Souptick Joarder --- drivers/scsi/qla2xxx/qla_bsg.c| 3 +-- drivers/scsi/qla2xxx/qla_iocb.c | 10 ++ drivers/scsi/qla2xxx/qla_target.c | 5 + 3 files changed, 4 insertions(+), 14

Re: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

On Wed, 2018-02-14 at 11:40 -0800, James Bottomley wrote: > On Wed, 2018-02-14 at 20:10 +0200, Andy Shevchenko wrote: > > Since we have a writeq() for 32-bit architectures as provided by IO > > non-atomic helpers, there is no need to open code it. > > > > Moreover sparse complains about this: > >

Re: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

On Wed, 2018-02-14 at 20:10 +0200, Andy Shevchenko wrote: > Since we have a writeq() for 32-bit architectures as provided by IO > non-atomic helpers, there is no need to open code it. > > Moreover sparse complains about this: > > drivers/scsi/mpt3sas/mpt3sas_base.c:2975:16: expected unsigned

[PATCH] scsi: qla4xxx: Use dma_pool_zalloc()

Use dma_pool_zalloc() instead of dma_pool_alloc + memset Signed-off-by: Souptick Joarder --- drivers/scsi/qla4xxx/ql4_mbx.c | 6 ++ drivers/scsi/qla4xxx/ql4_os.c | 4 +--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c

Re: Fwd: All scsi_debug devices in the scsi_debug driver share the same RAM space

On Tue, 2018-02-13 at 21:14 -0500, Martin K. Petersen wrote: > Lukas, > > > I like the idea to have an option to separate the memory area for > > different LUNs, while keeping the current behavior as default. > > As the name implies, scsi_debug is mostly a tool for debugging the > SCSI > stack.

[PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

Since we have a writeq() for 32-bit architectures as provided by IO non-atomic helpers, there is no need to open code it. Moreover sparse complains about this: drivers/scsi/mpt3sas/mpt3sas_base.c:2975:16: expected unsigned long long val drivers/scsi/mpt3sas/mpt3sas_base.c:2975:16: got restricted

Re: [V1] mpt3sas: Do not use 32-bit atomic request descriptor for Ventura controllers.

On 02/14/2018 11:16 AM, Suganath Prabu S wrote: > Problem Statement: Sending I/O through 32 bit descriptors to > Ventura series of controller results in IO timeout on certain conditions. > > This error only occurs on systems with high I/O activity on > Ventura series controllers. > > Changes in

Re: [PATCH] libsas: Fix kernel-doc headers

On 13/02/2018 17:49, Bart Van Assche wrote: On 02/13/18 02:17, John Garry wrote: On 12/02/2018 18:45, Bart Van Assche wrote: [ ... ] -/** +/* * sas_init_disc -- initialize the discovery struct in the port * @port: pointer to struct port I wonder why you get no complaint that @disc

[PATCH][scsi-next] scsi: myrb: remove shadowed and unassigned variable ldev_num

From: Colin Ian King A lower-scoped variable ldev_num is never assigned and is shadowing the higher scoped iterator ldev_num and should be removed to avoid using garbage ldev_num values. Detected by CoverityScan, CID#1465226 ("Uninitialized scalar variable") Fixes:

[PATCH][scsi-next] scsi: myrs: ensure sge_count is set correctly

From: Colin Ian King The DMA size is not being assigned to sge_count, instead sge_addr is being assigned this value, which is incorrected. Detected by CoverityScan, CID#1465233 ("Unused value") Fixes: 8a8606895947 ("scsi: myrs: Add Mylex RAID controller (SCSI

Re: [PATCH v2] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

Hi Sreenkanth, Thanks for reviewing. On 02/12/2018 04:28 AM, Sreekanth Reddy wrote: Instead of returning the scmd with DID_NO_CONNECT in TM path, can we wait for some time (10 seconds) in shutdown/unload path for the outstanding commands to complete and even then [if] the scmds are outstanding

[patch RESEND] atp870u: 64 bit bug in atp885_init()

On 64 bit CPUs there is a memory corruption bug on probe(). It should be a u32 pointer instead of an unsigned long pointer or we write past the end of the setupdata[] array. Signed-off-by: Dan Carpenter Reviewed-by: Hannes Reinecke --- I was reviewing

[PATCH][scsi-next] scsi: myrs: Fix spelling mistake: "Cashe"-> "Cache"

From: Colin Ian King Trivial fix to spelling mistake in info message text. Signed-off-by: Colin Ian King --- drivers/scsi/myrs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c

[V1] mpt3sas: Do not use 32-bit atomic request descriptor for Ventura controllers.

Problem Statement: Sending I/O through 32 bit descriptors to Ventura series of controller results in IO timeout on certain conditions. This error only occurs on systems with high I/O activity on Ventura series controllers. Changes in this patch will prevent driver from using 32 bit descriptor

[PATCH v2] scsi_debug: call resp_*() function after setting host_scribble

Error injection in scsi_debug (e.g. opts=16, SDEBUG_OPT_TRANSPORT_ERR) currently doesn't work correctly because the test for sqcp in resp_read_dt0() and similar resp_*() functions always fails. sqcp is set from cmnd->host_scribble, which is set in schedule_resp(), which is called from

Re: [PATCH v3 09/13] lpfc: Add embedded data pointers for enhanced performance

Thanks James, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v3 11/13] lpfc: Work around NVME cmd iu SGL type

Thanks, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v3 06/13] lpfc: Add 64G link speed support

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v3 05/13] lpfc: Add PCI Ids for if_type=6 hardware

Thanks, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

On Tue, Feb 13, 2018 at 11:34:48AM -0800, James Smart wrote: [...] > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c > index 3bff1f9c5df7..5e03b2c969e5 100644 > --- a/drivers/scsi/lpfc/lpfc_sli.c > +++ b/drivers/scsi/lpfc/lpfc_sli.c > @@ -35,6 +35,9 @@ > #include >

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

On Tue, 2018-02-13 at 18:13 +, Madhani, Himanshu wrote: > Thanks for asking (I did not add fixes commit ID because it was pre > 4.x kernel)  > > Here’s commit id 4440e46d5db7b445a961a8849b2a31fa7fd1 which is > fixed by this patch. Thanks for the info. In general having a  Fixes:

[PATCH v2] megaraid_sas: Do not use 32-bit atomic request descriptor for Ventura controllers

Problem Statement: Sending I/O through 32 bit descriptors to Ventura series of controller results in IO timeout on certain conditions. This error only occurs on systems with high I/O activity on Ventura series controllers. Changes in this patch will prevent driver from using 32 bit descriptor