Sebastian,
> Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock
> management duties from lldds") the sas_ata_qc_issue() function unlocks
> the ata_port.lock and disables interrupts before doing so. That lock
> is always taken with disabled interrupts so at this point, the
>
> Compiler output:
> drivers/scsi/qla2xxx/qla_target.c: In function
> 'qlt_schedule_sess_for_deletion':
> drivers/scsi/qla2xxx/qla_target.c:1227:22: warning: unused variable 'ha'
> [-Wunused-variable]
> struct qla_hw_data *ha = sess->vha->hw;
Applied to 4.18/scsi-fixes. Thanks!
--
Martin
On 06/14/2018 09:49 AM, Bart Van Assche wrote:
> This patch avoids that warnings about the kernel headers appear when
> building with W=1.
>
> Signed-off-by: Bart Van Assche
> Cc: Sathya Prakash
> Cc: Chaitra P B
> Cc: Suganath Prabu Subramani
> ---
> drivers/scsi/mpt3sas/mpt3sas_base.c
This patch does not change any functionality.
Signed-off-by: Bart Van Assche
Cc: Sathya Prakash
Cc: Chaitra P B
Cc: Suganath Prabu Subramani
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 10 --
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 -
2 files changed, 15 deletions(-)
diff --git
Make _base_build_nvme_prp() easier to read by introducing a structure
to access NVMe command fields.
Signed-off-by: Bart Van Assche
Cc: Sathya Prakash
Cc: Chaitra P B
Cc: Suganath Prabu Subramani
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 13 -
drivers/scsi/mpt3sas/mpt3sas_base.h
Since ioc->shost_recovery is set after ioc->reset_in_progress_mutex
is obtained, if concurrent resets are issued there is a short time
during which ioc->reset_in_progress_mutex is locked and
ioc->shost_recovery == 0. Avoid that this can cause trouble by
unconditionally locking ioc->shost_recovery.
This patch avoids that warnings about the kernel headers appear when
building with W=1.
Signed-off-by: Bart Van Assche
Cc: Sathya Prakash
Cc: Chaitra P B
Cc: Suganath Prabu Subramani
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 16 +-
drivers/scsi/mpt3sas/mpt3sas_ctl.c | 251
Split each of these functions in three functions - one function
per reset phase. This patch does not change any functionality but
makes the code easier to read.
Signed-off-by: Bart Van Assche
Cc: Sathya Prakash
Cc: Chaitra P B
Cc: Suganath Prabu Subramani
---
This patch avoids that smatch complains about a double unlock on
ioc->transport_cmds.mutex.
Fixes: 651a01364994 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP
passthrough")
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Sathya Prakash
Cc: Chaitra P B
Cc: Suganath Prabu
This patch avoids that gcc complains about switch/case fall-through
when building with W=1.
Signed-off-by: Bart Van Assche
Cc: Sathya Prakash
Cc: Chaitra P B
Cc: Suganath Prabu Subramani
---
drivers/scsi/mpt3sas/mpt3sas_ctl.c | 1 +
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +++
2 files
Hello Martin,
This patch series addresses the complaints reported by multiple static
source code analysis tools about the mpt3sas source code. Please consider
these patches for kernel v4.19.
Thanks,
Bart.
Bart Van Assche (8):
mpt3sas: Fix indentation
mpt3sas: Remove set-but-not-used
Modify the indentation such that smatch no longer complains about
inconsistent indenting.
Signed-off-by: Bart Van Assche
Cc: Sathya Prakash
Cc: Chaitra P B
Cc: Suganath Prabu Subramani
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 40
nit:
scsi: libsas: remove irq save in sas_ata_qc_issue()
On 14/06/2018 17:18, Sebastian Andrzej Siewior wrote:
Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock
management duties from lldds") the sas_ata_qc_issue() function unlocks
the ata_port.lock and disables interrupts before
On Thu, Jun 14, 2018 at 9:18 AM, Sebastian Andrzej Siewior
wrote:
> Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock
> management duties from lldds") the sas_ata_qc_issue() function unlocks
> the ata_port.lock and disables interrupts before doing so.
> That lock is always taken
Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock
management duties from lldds") the sas_ata_qc_issue() function unlocks
the ata_port.lock and disables interrupts before doing so.
That lock is always taken with disabled interrupts so at this point, the
interrupts are already
On Thu, 2018-06-14 at 15:56 +0530, Chaitra Basappa wrote:
> Bart,
> Please see my replies inline.
Hello Chaitra,
Please don't use inline replies. That makes it very hard to follow the
conversation. BTW, in the headers of your e-mail I found the following:
"X-Mailer: Microsoft Outlook 14.0".
On Thu, 2018-06-14 at 06:25 -0400, Chaitra P B wrote:
> As a part of host reset operation, driver will flushout all IOs
> outstanding at driver level with "DID_RESET" result.
> To find which are all commands outstanding at the driver level,
> driver loops with smid starting from one to HBA queue
On Thu, Jun 14, 2018 at 7:30 AM, Sebastian Andrzej Siewior
wrote:
> On 2018-06-12 08:46:38 [-0700], Dan Williams wrote:
>> On Tue, Jun 12, 2018 at 8:04 AM, John Garry wrote:
>> >> We had this comment for 6 years or so and nothing happend. What makes
>> >> you think that an updated version of
On 2018-06-12 08:46:38 [-0700], Dan Williams wrote:
> On Tue, Jun 12, 2018 at 8:04 AM, John Garry wrote:
> >> We had this comment for 6 years or so and nothing happend. What makes
> >> you think that an updated version of that comment will motivate someone
> >> to make change here in the near
Good Morning,
Although, I am not comfortable discussing the content of my mail on
the Internet owing to lots of unsolicited/Spam mails on the net
nowadays. However, I have made up my mind to will my late Husband's
funds to you so you can use it for charity duties and good work to
humanity. The
This change adds a new API ufshcd_do_config_device() to
write configuration descriptor with the provisioning data.
Configfs support is added in driver to trigger ufs provisioning at
runtime. Provisioning data is parsed from vendor specific provisioning
file. This parsed data is passed as a buffer
Dear James, dear all!
Am 11.06.2018 um 17:06 schrieb James Bottomley
:
> This means that somehow, something sent a non 4k aligned 4k sized
> request. SCSI here is just the messenger. However, if you apply this
> patch, it will capture the stack trace of what above it triggered this,
> which may
From: Mikhail Malygin
Compiler output:
drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_schedule_sess_for_deletion':
drivers/scsi/qla2xxx/qla_target.c:1227:22: warning: unused variable 'ha'
[-Wunused-variable]
struct qla_hw_data *ha = sess->vha->hw;
Signed-off-by: Mikhail Malygin
Bart,
Please see my replies inline.
Thanks,
Chaitra
-Original Message-
From: Bart Van Assche [mailto:bart.vanass...@wdc.com]
Sent: Wednesday, June 13, 2018 9:22 PM
To: chaitra.basa...@broadcom.com; linux-scsi@vger.kernel.org
Cc: sathya.prak...@broadcom.com;
Below kernel BUG was observed while running IOs with host reset
(issued from application),
mpt3sas_cm0: diag reset: SUCCESS
[ cut here ]
WARNING: CPU: 12 PID: 4336 at drivers/scsi/mpt3sas/mpt3sas_base.c:3282
mpt3sas_base_clear_st+0x3d/0x40 [mpt3sas]
Modules linked in:
25 matches
Mail list logo
