Re: [PATCH] scsi: ibmvscsi: Improve strings handling

On 06/26/2018 01:35 PM, Breno Leitao wrote: The subject line should have been updated to [PATCH v2] to clue recipients to the fact that this is an updated version and not a resend or accidental duplicate send. > Currently an open firmware property is copied into partition_name variable >

[PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

This patch avoids that self-removal triggers the following deadlock: == WARNING: possible circular locking dependency detected 4.18.0-rc2-dbg+ #5 Not tainted -- modprobe/6539 is trying to

[PATCH] scsi: ibmvscsi: Improve strings handling

Currently an open firmware property is copied into partition_name variable without keeping a room for \0. Later one, this variable (partition_name), which is 97 bytes long, is strncpyed into ibmvcsci_host_data->madapter_info->partition_name, which is 96 bytes long, possibly truncating it 'again'

Re: [PATCH] scsi: ibmvscsi: Improve strings handling

On 06/26/18 12:10, Breno Leitao wrote: if (ppartition_name) strncpy(partition_name, ppartition_name, - sizeof(partition_name)); + sizeof(partition_name) - 1); Please use strlcpy() instead of trying to emulate

[PATCH] scsi: ibmvscsi: Improve strings handling

Currently an open firmware property is copied into partition_name variable without keeping a room for \0. Later one, this variable (partition_name), which is 97 bytes long, is strncpyed into ibmvcsci_host_data->madapter_info->partition_name, which is 96 bytes long, possibly truncating it 'again'

Re: [PATCH 1/1] tcmu: Don't pass KERN_ERR to pr_err

Mike, > Fix warning: > > smatch warnings: > drivers/target/target_core_user.c:301 tcmu_genl_cmd_done() warn: KERN_* > level not at start of string Applied to 4.19/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

[PATCH 1/1] tcmu: Don't pass KERN_ERR to pr_err

Fix warning: smatch warnings: drivers/target/target_core_user.c:301 tcmu_genl_cmd_done() warn: KERN_* level not at start of string Signed-off-by: Mike Christie --- drivers/target/target_core_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host

John, >> Took a while for all the prerequisites to materialize. I just rebased >> 4.19/scsi-queue to v4.18-rc1 and applied your patch. Thanks! > > Is it possible to add this patch to the 4.18 fixes? I was on the fence on this but felt it was an intricate enough change to warrant a bit of soak

Re: [PATCH] sd: Remove a superfluous assignment

Bart, > Since blk_rq_bytes(req) returns req->__data_len, assigning that value > to req->__data_len is superfluous. Hence remove that assignment. Applied to 4.19/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qedi: Fix misleading indentation

Bart, > This patch avoids that smatch reports the following warnings: > > drivers/scsi/qedi/qedi_fw_api.c:129: init_sqe() warn: inconsistent indenting > drivers/scsi/qedi/qedi_fw_api.c:137: init_sqe() warn: inconsistent indenting Applied to 4.19/scsi-queue, thank you! -- Martin K. Petersen

Re: [PATCH v6 0/7] scsi_io_completion cleanup

Douglas, > This patch refactors scsi_io_completion() by taking the bulk of its > error processing code into three static helper functions, leaving only > the 20 or so code lines that constitute the fastpath. In this process > comments were added and tweaked, plus variables renamed. The last two

Re: tcmu: fix hung netlink requests and nl related cleanup V2

Mike, > The following patches fix the issues where the userspace daemon has > crashed and left netlink requests dangling. The daemon can now block > the interface, kill outstanding requests, reopen the netlink socket > and then unblock and execute new requests. Applied to 4.19/scsi-queue,

Re: [PATCH] scsi: aacraid: Fix PD performance regression over incorrect qd being set

Raghava, > The driver fails to set the correct queue depth for native devices, > due to failing to set the device type prior to calling > aac_set_safw_target_qd(). This results in slave configure setting the > queue depth to 1. > > This causes around 30% performance degradation. Fixed by

[PATCH 07/10] lpfc: Fix NVME Target crash in defer rcv logic

Kernel occasionally crashed with the following ops on NVME Target: BUG: unable to handle kernel NULL pointer dereference at 0058 IP: [] lpfc_nvmet_defer_rcv+0x50/0x70 [lpfc] Callback routine was called for deferred rcv when it should be treated as a normal rcv. Added code in

[PATCH 09/10] lpfc: update driver version to 12.0.0.5

Update the driver version to 12.0.0.5 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index

[PATCH 08/10] lpfc: devloss timeout race condition caused null pointer reference

A race condition between the context of devloss timeout handler and I/O completion caused devloss timeout handler de-referencing pointer that had been released. Added the check in lpfc_sli_validate_fcp_iocb() on LPFC_IO_ON_TXCMPLQ to capture the race condition of I/O completion and devloss

[PATCH 10/10] lpfc: Revise copyright for new company language

Change references from "Broadcom Limited" to "Broadcom Inc." in the copyright message. Update copyright duration if not yet updated for 2018. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/Makefile | 4 ++-- drivers/scsi/lpfc/lpfc.h | 2 +-

[PATCH 06/10] lpfc: Support duration field in Link Cable Beacon V1 command

Current implementation missed setting the duration field. Correct the code to set the field. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 64 +++ drivers/scsi/lpfc/lpfc_hw.h | 18 +++-

[PATCH 05/10] lpfc: Make PBDE optimizations configurable

the PBDE optimizations aren't supported in all firmware revs. Make to optimizations configurable in case there's a side effect on old firmware. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 3 +-- drivers/scsi/lpfc/lpfc_attr.c | 10 ++

[PATCH 00/10] lpfc updates for 12.0.0.5

This patch contains lpfc bug fixes and some minor functional additions. The patches were cut against the Martin's 4.18/scsi-queue tree James Smart (10): lpfc: Add Buffer overflow check, when nvme_info larger than PAGE_SIZE lpfc: Fix driver not setting dpp bits correctly in doorbell word

[PATCH 04/10] lpfc: Fix abort error path for NVMET

rmmod of driver hangs As driver instances were being unloaded, the NVME target port was unloaded first. During the unload, the NVME initiator port sent a heartbeat IO. Because of the target port state, that IO was scheduled for an Abort; however, that abort subseqentially failed. The failure was

[PATCH 02/10] lpfc: Fix driver not setting dpp bits correctly in doorbell word

Driver is incorrectly formatting a register on new hardware, using a format for an older chip. This can result in non-deterministic behavior. Ensure driver is not setting "workqueue index" in the WQ doorbell when making a non-dpp doorbell write. The field must be zero when non-dpp.

[PATCH 03/10] lpfc: Fix panic if driver unloaded when port is offline

System crashes when the lpfc module is unloaded after making the port offline The nvme queue pointers were freed during port offline, but were later accessed in pci remove path. Validate the pointers in pci remove path before accessing them. Signed-off-by: Dick Kennedy Signed-off-by: James

[PATCH 01/10] lpfc: Add Buffer overflow check, when nvme_info larger than PAGE_SIZE

Kernel crashes during fill_read_buffer when nvme_info sysfs file read. With multiple NVME targets, approx 40, nvme_info may grow larger than PAGE_SIZE bytes. snprintf(buf + len, PAGE_SIZE - len, ...) logic is flawed as PAGE_SIZE - len can be < 0 and is accepted by snprintf. This results in

RE: mpt3sas regression...

Hi David, Sorry for the inconvenience caused. Yes, "scsi: mpt3sas: Bug fix for big endian systems." patch was posted to fix sparse warnings. I missed the testing. Currently we are testing on sparc64 system and soon I will be reposting the patch based on the findings. Thanks, Chaitra

[PATCH V2 2/2] ata: Fix ZBC_OUT all bit handling

If the ALL bit is set in the ZBC_OUT command, the command zone ID field (block) should be ignored. Reported-by: David Butterfield Signed-off-by: Damien Le Moal Cc: sta...@vger.kernel.org --- drivers/ata/libata-scsi.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH V2 1/2] ata: Fix ZBC_OUT command block check

The block (LBA) specified must not exceed the last addressable LBA, which is dev->nr_sectors - 1. So fix the correct check is "if (block >= dev->n_sectors)" and not "if (block > dev->n_sectords)". Additionally, the asc/ascq to return for an LBA that is not a zone start LBA should be ILLEGAL

[PATCH V2 0/2] ZBC_OUT command translation fixes

Tejun, These two patches fix problems with the checks of the ZBC_OUT command fields prior to its translation to ZAC MANAGEMENT OUT. The first patch fixes an incorrect out-of-range check and changes the returned asc/ascq to the ZBC defined INVALID FIELD IN CDB instead of (the more natural but

[PATCH V2 0/2] ZBC_OUT command translation fixes

Tejun, These two patches fix problems with the checks of the ZBC_OUT command fields prior to its translation to ZAC MANAGEMENT OUT. The first patch fixes an incorrect out-of-range check and changes the returned asc/ascq to the ZBC defined INVALID FIELD IN CDB instead of (the more natural but

Re: [PATCH 2/2] ata: Fix ZBC_OUT all bit handling

On Tue, Jun 26, 2018 at 04:18:38PM +0900, Damien Le Moal wrote: > If the ALL bit is set in the ZBC_OUT command, the command zone ID field > (block) should be ignored. > > Reported-by: David Butterfield > Signed-off-by: Damien Le Moal > --- > drivers/ata/libata-scsi.c | 11 --- > 1 file

Re: [PATCH 1/2] ata: Fix ZBC_OUT command block check

On Tue, Jun 26, 2018 at 04:18:37PM +0900, Damien Le Moal wrote: > The block (LBA) specified must not exceed the last addressable LBA, > which is dev->nr_sectors - 1. So fix the correct check is > "if (block >= dev->n_sectors)" and not "if (block > dev->n_sectords)". > > Additionally, the asc/ascq

[Bug 199703] HPSA blocking boot on HP smart Array P400

https://bugzilla.kernel.org/show_bug.cgi?id=199703 --- Comment #15 from Roberto M. (roby_program...@fastwebnet.it) --- Hi, my answer below (In reply to Don from comment #14) > I'm wondering how you updated. It is a prolian ML350 G5 with Ubuntu 16.04 LTS, I upgraded to 18.04 LTS, after upgrade

Re: [PATCH v6 7/7] scsi_io_completion convert BUGs to WARNs

On Tue, Jun 26, 2018 at 12:53:32PM +0200, Douglas Gilbert wrote: > The SCSI subsystem may not be the primary storage medium on a system, so > bringing down the system because the SCSI mid-level has an unrecoverable > error may be overkill. Think an embedded system with the rootfs on a >

Re: [PATCH v6 7/7] scsi_io_completion convert BUGs to WARNs

On 2018-06-26 07:28 AM, Hannes Reinecke wrote: On 06/23/2018 12:22 PM, Douglas Gilbert wrote: The scsi_io_completion function contains three BUG() and BUG_ON() calls. Replace them with WARN variants. Signed-off-by: Douglas Gilbert Reviewed-by: Johannes Thumshirn Reviewed-by: Bart Van Assche

PROCUREMENT DEPARTMENT

Thanks for your mail. please follow our page below to confirm details   http://pronotioncn.com/draftoffer/po/ We wish to get the delivery date on all as listed and your payment details in regards.  Thanks Jendrics Anikó JEMOLIMPEX Kft. 1089 Bp. Orczy út 46 - 48

Re: [PATCH] qedi: Fix static checker warning

On 6/25/18, 8:31 PM, "Bart Van Assche" wrote: >External Email > >On 06/25/18 05:32, Nilesh Javali wrote: >> This patch fixes the static checker warning, >> >> drivers/scsi/qedi/qedi_main.c:891 qedi_get_boot_tgt_info() >> error: snprintf() is printing too much 256 vs 255 > >Which

Re: [PATCH] qedi: Fix misleading indentation

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

[PATCH 1/2] ata: Fix ZBC_OUT command block check

The block (LBA) specified must not exceed the last addressable LBA, which is dev->nr_sectors - 1. So fix the correct check is "if (block >= dev->n_sectors)" and not "if (block > dev->n_sectords)". Additionally, the asc/ascq to return for an LBA that is not a zone start LBA should be ILLEGAL

[PATCH 2/2] ata: Fix ZBC_OUT all bit handling

If the ALL bit is set in the ZBC_OUT command, the command zone ID field (block) should be ignored. Reported-by: David Butterfield Signed-off-by: Damien Le Moal --- drivers/ata/libata-scsi.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH 0/2] ZBC_OUT command translation fixes

Tejun, These two patches fix problems with the checks of the ZBC_OUT command fields prior to its translation to ZAC MANAGEMENT OUT. The first patch fixes an incorrect out-of-range check and changes the returned asc/ascq to the ZBC defined INVALID FIELD IN CDB instead of (the more natural but