RE: [PATCH v2 0/8] scsi: scsi transport for ufs devices

2018-08-07 Thread Avri Altman
> On Sun, Aug 05, 2018 at 02:39:48PM +0300, Avri Altman wrote: > > Here is a proposal to use the scsi transport subsystem to manage > > ufs devices. > > This should superceed previous patches to provide provisioning > support through sysfs or configfs, right? Yes. Thanks, Avri

[PATCH] qla2xxx: Fix issue reported by static checker for qla2x00_els_dcmd2_sp_done()

2018-08-07 Thread Himanshu Madhani
From: Quinn Tran This patch fixes following Smatch complaint: drivers/scsi/qla2xxx/qla_iocb.c:2647 qla2x00_els_dcmd2_sp_done() error: we previously assumed 'e' could be null (see line 2631) Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine") Reported-by: Dan

Re: [PATCH RESEND v2] target: move the rx hdr buffer out of the stack

2018-08-07 Thread Mike Christie
On 08/03/2018 03:48 AM, Maurizio Lombardi wrote: > When HeaderDigest is enabled on aarch64 machines, target triggers > a lot of failed crc checksum errors: > > example of output in dmesg: > [ 154.495031] HeaderDigest CRC32C failed, received 0x60571c8d, computed > 0x288c3ab9 > [ 154.583821] Got

Re: [PATCH v3] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-07 Thread Bart Van Assche
On Tue, 2018-08-07 at 21:46 +0530, Sreekanth Reddy wrote: > [Sreekanth] In the patch description I mentioned that I have done a > manual mistake and I am correcting with this patch. > > Hope I have answered all of your quires. Not yet unfortunately. Why do you consider the current implementation

Re: [PATCH] aha1542: convert to DMA mapping API

2018-08-07 Thread Ondrej Zary
On Tuesday 07 August 2018 09:29:59 Christoph Hellwig wrote: > Looks like the dma allocation is too late. Updated version below: > > ... Crashes a bit later now: [ 89.270529] scsi host2: Adaptec AHA-1542 (SCSI-ID 7) at IO 0x330, IRQ 11, DMA 7 [ 89.346535] scsi host2: Adaptec 1542 [

Re: [PATCH v3] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-07 Thread Sreekanth Reddy
On Tue, Aug 7, 2018 at 8:27 PM, Bart Van Assche wrote: > On Tue, 2018-08-07 at 20:03 +0530, Sreekanth Reddy wrote: >> The main intention of this patch to reset the smid to zero after >> resetting the corresponding smid entry's chain_offset to zero. While >> posting "mpt3sas: Fix calltrace

Re: [PATCH v3] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-07 Thread Bart Van Assche
On Tue, 2018-08-07 at 20:03 +0530, Sreekanth Reddy wrote: > The main intention of this patch to reset the smid to zero after > resetting the corresponding smid entry's chain_offset to zero. While > posting "mpt3sas: Fix calltrace observed while running IO & reset" > patch I have done manual

Re: [PATCH v3] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-07 Thread Sreekanth Reddy
On Tue, Aug 7, 2018 at 7:29 PM, Bart Van Assche wrote: > On Tue, 2018-08-07 at 12:10 +0530, Sreekanth Reddy wrote: >> This function _base_get_chain_buffer_tracker() is called only during >> the IO submission time and mpt3sas_base_clear_st() is called during IO >> completion time and hence I don't

Re: [PATCH v3] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-07 Thread Bart Van Assche
On Tue, 2018-08-07 at 12:10 +0530, Sreekanth Reddy wrote: > This function _base_get_chain_buffer_tracker() is called only during > the IO submission time and mpt3sas_base_clear_st() is called during IO > completion time and hence I don't see any race condition here. > > Currently this patch is

Re: [PATCH v2 0/8] scsi: scsi transport for ufs devices

2018-08-07 Thread Christoph Hellwig
On Sun, Aug 05, 2018 at 02:39:48PM +0300, Avri Altman wrote: > Here is a proposal to use the scsi transport subsystem to manage > ufs devices. This should superceed previous patches to provide provisioning support through sysfs or configfs, right?

[bug report] scsi: qla2xxx: Migrate NVME N2N handling into state machine

2018-08-07 Thread Dan Carpenter
Hello Quinn Tran, This is a semi-automatic email about new static checker warnings. The patch 8777e4314d39: "scsi: qla2xxx: Migrate NVME N2N handling into state machine" from Aug 2, 2018, leads to the following Smatch complaint: drivers/scsi/qla2xxx/qla_iocb.c:2647

Re: [PATCH] aha1542: convert to DMA mapping API

2018-08-07 Thread Christoph Hellwig
Looks like the dma allocation is too late. Updated version below: --- >From 9dd7a3eb89d1cc72c001daeb80e44de7c5fb5b00 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Thu, 2 Aug 2018 14:22:46 +0200 Subject: aha1542: convert to DMA mapping API aha1542 is one of the last users of the legacy

Re: [PATCH v3] mpt3sas: correct reset of smid while clearing scsi tracker

2018-08-07 Thread Sreekanth Reddy
On Mon, Aug 6, 2018 at 11:41 PM, Bart Van Assche wrote: > On Sat, 2018-08-04 at 18:56 +0530, Sreekanth Reddy wrote: >> No Bart, their is no race condition here. Since chain lookup table >> entry is uniquely accessed using smid value. And this smid (which is >> scmd->request->tag +1) is unique for