On Wed, Sep 05, 2018 at 07:08:50PM +0200, Christoph Hellwig wrote:
> On Wed, Sep 05, 2018 at 03:53:41PM +, Avri Altman wrote:
> > But on the other hand, task management request and response UPIUs
> > are honorable members of the ufs spec (JEDEC 220C paragraphs 10.7.6 &
> > 10.7.7).
> > and
On Wed, Sep 05, 2018 at 03:53:41PM +, Avri Altman wrote:
> But on the other hand, task management request and response UPIUs
> are honorable members of the ufs spec (JEDEC 220C paragraphs 10.7.6 & 10.7.7).
> and indeed they lives in ufs.h, where they should.
There is no other use anywhere.
> On Wed, Sep 05, 2018 at 07:30:03AM +, Avri Altman wrote:
> > Looking into the UFSHCI spec (JESD223C March 2016) paragraph 6.2,
> > It doesn't specify any inner structure of the task management
> > request or response, just a bunch of 8 DW each.
> > I guess this is why it is defined as a
On Wed, Sep 05, 2018 at 09:38:16AM +0200, Lukas Wunner wrote:
> On Wed, Sep 05, 2018 at 11:45:45AM +0530, Sreekanth Reddy wrote:
> > On Tue, Sep 4, 2018 at 3:12 PM, Lukas Wunner wrote:
> > > Many scsi drivers call pci_channel_offline() to detect inaccessibility
> > > of the device due to a PCI
On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote:
> test_bit() is atomic, test_bit() || test_bit() is not.
> So protect consecutive bit tests with a lock to avoid races.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/qedf/qedf_els.c | 9 +++--
>
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_main.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 3407a05e898b..2bedad13f3f4 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++
Hi all,
occasionally the qedf driver will crash in fc_lookup_rport() due to missing
locking and incorrect reference counting of the fc_rport_priv() structure
from libfc. This patchset fixes up the reference counting and ensures that
the locking rules of libfc are followed.
As usual, comments and
qedf_xmit() calls fc_rport_lookup(), but discards the returned
rdata structure almost immediately without decreasing the refcount.
This leads to a refcount leak and the rdata never to be freed.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_main.c | 4 +++-
1 file changed, 3
The fc_rport_priv structure is reference counted, so we need to
ensure that the reference is increased before accessing the structure.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_els.c | 12 ++--
drivers/scsi/qedf/qedf_io.c | 32 ++--
test_bit() is atomic, test_bit() || test_bit() is not.
So protect consecutive bit tests with a lock to avoid races.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_els.c | 9 +++--
drivers/scsi/qedf/qedf_main.c | 5 -
2 files changed, 11 insertions(+), 3 deletions(-)
diff
fc_rport_create() needs to be called with disc_mutex held.
And we should re-assign the 'rdata' pointer in case it got changed.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/qedf/qedf_els.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qedf/qedf_els.c
On Wed, Sep 05, 2018 at 07:30:03AM +, Avri Altman wrote:
> Looking into the UFSHCI spec (JESD223C March 2016) paragraph 6.2,
> It doesn't specify any inner structure of the task management
> request or response, just a bunch of 8 DW each.
> I guess this is why it is defined as a __le32 array.
On Wed, Sep 5, 2018 at 7:47 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> Updated the driver version from 0.1.38 to 0.1.39.
>
> Signed-off-by: Deepak Ukey
> Signed-off-by: Viswas G
> ---
> drivers/scsi/pm8001/pm8001_sas.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Wed, Sep 5, 2018 at 7:47 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> When the firmware is not responding, execution of kexec boot
> causes a system hang. When firmware assertion happened, driver
> get notified with interrupt vector updated in MPI configuration
> table. Then, the driver will
> > ---
> > drivers/scsi/ufs/ufshcd.c | 35 ++-
> > 1 file changed, 26 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index d18832a..15be103 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++
On Wed, Sep 5, 2018 at 7:47 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> For the function dma_unmap_sg(), the parameter should be
> number of elements in the scatter list prior to the mapping, not
> after the mapping.
>
> Signed-off-by: Deepak Ukey
> Signed-off-by: Viswas G
> ---
>
On Wed, Sep 5, 2018 at 7:47 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> Added proper mask for phy id in mpi_phy_stop_resp().
>
> Signed-off-by: Deepak Ukey
> Signed-off-by: Viswas G
> ---
> drivers/scsi/pm8001/pm8001_defs.h | 7 +++
> drivers/scsi/pm8001/pm8001_hwi.c | 4 ++--
>
On Wed, Sep 05, 2018 at 11:45:45AM +0530, Sreekanth Reddy wrote:
> On Tue, Sep 4, 2018 at 3:12 PM, Lukas Wunner wrote:
> > Many scsi drivers call pci_channel_offline() to detect inaccessibility
> > of the device due to a PCI error:
> >
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org
> On Behalf Of Christoph Hellwig
> Sent: Tuesday, September 04, 2018 10:12 PM
> To: Avri Altman
> Cc: Christoph Hellwig ; Johannes Thumshirn
> ; Hannes Reinecke ; Bart Van Assche
> ; James E.J. Bottomley
> ; Martin K.
> > + */
> > +#ifndef SCSI_BSG_UFS_H
> > +#define SCSI_BSG_UFS_H
> > +
> > +/*
> > + * This file intended to be included by both kernel and user space
> > + */
> > +
> > +
> > +/**
> > + * struct ufs_bsg_upiu - upiu transaction structure
> > + *
> > + * @header: upiu header
> > + * @tsf:
l
On Tue, Sep 4, 2018 at 3:12 PM, Lukas Wunner wrote:
> On Tue, Sep 04, 2018 at 11:19:04AM +0530, Sreekanth Reddy wrote:
>> On Fri, Aug 31, 2018 at 2:25 PM, Lukas Wunner wrote:
>> > * Just reading the vendor ID may not be sufficient to detect unplug,
>> > it may also read as "all ones" if
> -Original Message-
> From: Christoph Hellwig
> Sent: Tuesday, September 04, 2018 10:20 PM
> To: Avri Altman
> Cc: Christoph Hellwig ; Johannes Thumshirn
> ; Hannes Reinecke ; Bart Van Assche
> ; James E.J. Bottomley
> ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; Stanislav
> -Original Message-
> From: Christoph Hellwig
> Sent: Tuesday, September 04, 2018 10:16 PM
> To: Avri Altman
> Cc: Christoph Hellwig ; Johannes Thumshirn
> ; Hannes Reinecke ; Bart Van Assche
> ; James E.J. Bottomley
> ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; Stanislav
23 matches
Mail list logo
